Observations re Unapproved Attachments ...

[GL700Wing]

I created a new SMF 2.1 RC3 forum using a release I downloaded from GitHub yesterday so that I could update my Image Attachment Thumbnail View mod to support SMF 2.1 RC3.

In the process of working out what changes I need for my mod to support SMF 2.1 RC3 I discovered the following:

• There is no indication that attachments are awaiting approval in 'Profile of User > Show posts > Attachments'.
  In SMF 2.0.17 unapproved attachments are displayed in a row with a different coloured background and the attachment name is followed by the text '(Awaiting Approval)'.
• If the 'Administration Center > Attachments and Avatars > Attachment Settings > Do not show attachments under the post if they are already embedded in it.' option is enabled:
  
  
  • Attachments that have been inserted inline and are awaiting approval are shown as the text 'Not a valid attachment ID.' for non-administrators and non-moderators; and
  • Attachments that have been inserted inline are not shown in the 'Attachments awaiting approval' block with the following consequences:
    
    
    • If all attachments have been inserted inline the 'Attachments awaiting approval' block is not displayed; and
    • If some attachments have been inserted inline the 'approve all' action applies to attachments that are not shown in the 'Attachments awaiting approval' block (this may result in admins/moderators unintentionally approving attachments).
• If a member clicks on the link for an unapproved attachment in another member's profile via 'Profile of User > Show posts > Attachments' they get a '403 Forbidden' error.
  In SMF 2.0.17 the error message 'You do not have permission to approve items.' is displayed.