2.0.18 Subs.php custom tag adaptation

[spiros]

I am using this extra tag, I am not sure how exactly these should be edited for php 7.4/SMF 2.0.18 compatibility

Code Select Expand

array(
'tag' => 'google',
'type' => 'unparsed_content',
'content' => '<a href="https://www.google.com/search?q=&quot;$1&quot;" target="_blank" rel="nofollow noreferrer noopener">$1</a>',
'validate' => create_function('&$tag, &$data, $disabled', '$data = strtr($data, array(\'<br />\' => \'\'));'),
                'disallow_children' => array('email', 'ftp', 'url', 'iurl'),
'disabled_content' => '<span style="color: red;">Google Search: $1</span>',
),
array(
'tag' => 'google',
'type' => 'unparsed_equals',
'before' => '<a href="https://www.google.com/search?q=&quot;$1&quot;" target="_blank" rel="nofollow noreferrer noopener">',
                'after' => '</a>',
                'disallow_children' => array('email', 'ftp', 'url', 'iurl'),
'disabled_before' => '<span style="color: red;">',
                'disabled_after' => ' ($1)</span>',
),

I can see in the operations for the upgrade

Find

Code Select Expand

'validate' => create_function('&$tag, &$data, $disabled', '$data = strtr($data, array(\'<br />\' => \'\'));'),
),
array(

Replace

Code Select Expand

'validate' => function(&$tag, &$data, $disabled)
{
$data = strtr($data, array('<br>' => ''));
},
),
array(


Not sure whether this change should be applied to that tag or whether anything else needs to change.

[vbgamer45]

Just the 'validate' part needs to change

Code Select Expand


'validate' => create_function('&$tag, &$data, $disabled', '$data = strtr($data, array(\'<br />\' => \'\'));'),

To

Code Select Expand


'validate' => function(&$tag, &$data, $disabled)
{
$data = strtr($data, array('<br>' => ''));
},


[spiros]

Thanks, that's what I had done -:)