News:

Join the Facebook Fan Page.

Main Menu

Code Select not working

Started by Shades., February 20, 2021, 08:23:21 PM

Previous topic - Next topic

Shades.

When installing a mod and I try to click on the "Code Select" button, it does not select. Ive tried on different installs and several different browsers.
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

vbgamer45

Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Kindred

What browser and version of browser are you using?
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

live627


Kindred

well, it was not working in FF earlier... but 78.7.1esr works fine...
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

live627

Are you taking about code blocks in topics?

Shades.

No its in admin when your upload a mod thru package manager and click the manual edits and it show you the code to select.

Ive tried it in FF, Chrome and edge and get the same thing. I can highlight and copy manually but the "Select" link does not work for me.
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

Kindred

Works for me with the most recent versions of every browser
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Shades.

I just tried again with updated browsers and still not working for me on 2.1 but works fine on 2.0.18 :o
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

Shades.

Also just now tried to select copy code in a topic and it worked fine just not in admin!
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean


Shades.

Quote from: live627 on March 06, 2021, 07:38:13 PM
Oh I should  probably share the fix lol

https://github.com/SimpleMachines/SMF2.1/commit/8cc9caaa6a15eefac08d468847a2e2eec1bb71e6
Thanks but I have no idea how to use that page lol!
Can someone break it down for me lol! :o ;D

Its really not that big of a deal though I can wait for the patch or update. Should this be moved to the Bug section then?
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

Speed King

Quote from: live627 on March 06, 2021, 07:38:13 PM
Oh I should  probably share the fix lol

https://github.com/SimpleMachines/SMF2.1/commit/8cc9caaa6a15eefac08d468847a2e2eec1bb71e6

This fix is already applied in recent Github builds, but 'Code select' in Package Manager still not working :(

Aleksi "Lex" Kilpinen

Quote from: Shades. on March 06, 2021, 09:14:42 PM
Quote from: live627 on March 06, 2021, 07:38:13 PM
Oh I should  probably share the fix lol

https://github.com/SimpleMachines/SMF2.1/commit/8cc9caaa6a15eefac08d468847a2e2eec1bb71e6
Thanks but I have no idea how to use that page lol!
Can someone break it down for me lol! :o ;D
That's so easy even I can answer that! Remove the lines marked with a - and red colour. Add the lines marked with + and green colour. :D
Slava
Ukraini!
"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Shades.

ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

ozp


Speed King

Quote from: ozp on May 03, 2021, 02:15:25 AM
Found the problem.
PR submitted https://github.com/SimpleMachines/SMF2.1/pull/6723

Thanks for the fix, now code select in package manager is working properly :)

Shades.

Quote from: ozp on May 03, 2021, 02:15:25 AM
Found the problem.
PR submitted https://github.com/SimpleMachines/SMF2.1/pull/6723

This fix was not added to RC4 because the code select in admin is not working from the SMF download but the manual edits above and at https://github.com/SimpleMachines/SMF2.1/pull/6723/files fixed the problem.
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

Advertisement: