News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

Centered Backtrace Info

Started by Shades., July 30, 2021, 05:38:26 PM

Previous topic - Next topic

Shades.

Is the backtrace information supposed to be centered? (See attachment) I'm using default theme I just changed the background to black.
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

Kindred

hmmm.... is not so for me, on my test site...
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Shades.

Here's another site fullscreen:
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

Mick.

Um, your site has a mod or any edits you did in css file is doing this. Why? Vbgamer's downloads mod does the same thing on my site. That tells me some line was edited or a new class or id was made that is currently clashing with the mod. That being said, you may have some line in css clashing with your page. Did i fix it? No. I am not chasing for something no one sees.  If it ain't broke, don't fix it.

Shades.

Yeah it's not a big deal cause it doesn't effect the way the forum works!

I'll just have to uninstall some mods and see which one is causing it...I was just checking if anyone else had this b4 I start tearing things down lol! ;) 8)
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

Mick.

I'm not saying you shouldn't fix it. I'm a bit experienced and know my issue is not affecting anyone so decided not to chase it. But, yes, by all means, start with removing mods one at a time and look back and forth.

Shades.

Well I uninstalled all the mods and still getting the same.

So i figured maybe one of the files was corrupt so I uploaded all new files accept for Settings.php of course and still the same.

So then I just deleted everything and reinstalled a fresh downloaded copy, uploaded one mod cause I new it would give me an error to look at, then deleted the mod, did a full refresh and still centered so I don't know!
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

Mick.

I should have actually look look the image. Its right there, that avatar mod seem to be the culprit.  If you did a new install,  it may be cache thing

lurkalot

I have a couple of sites with a couple of old errors sitting in the log so just checked this.  It's centered for me too.  ;)

Not sure, but it appears to be this causing it,  in index.css around line 290

.centertext, .centercol {
margin: 0 auto;
text-align: center;
}







Shades.

Quote from: lurkalot on July 31, 2021, 05:23:25 AM
I have a couple of sites with a couple of old errors sitting in the log so just checked this.  It's centered for me too.  ;)

Not sure, but it appears to be this causing it,  in index.css around line 290

.centertext, .centercol {
margin: 0 auto;
text-align: center;
}


That worked, I changed it to:
Quote.centertext, .centercol {
   margin: 0 auto;
   text-align: left;
}

But I wonder what other areas that will effect?
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

lurkalot

Quote from: Shades. on July 31, 2021, 05:43:35 AM

That worked, I changed it to:

But I wonder what other areas that will effect?

I haven't a clue what else it might interfere with.  I only quickly disabled that line in my browsers inspect tool.  I did say I wasn't sure though. ;)

wintstar

.centertext, .centercol {
   margin: 0 auto;
   text-align: left;
}


It makes no sense to change a CSS class centering value to left or right. It is best to remove it in the template centertext or centercol. You have created another problem for yourself with your solution.
Regards Stephan

,,In order for the possible to come into being, the impossible must be attempted again and again."
Hermann Hesse (1877-1962)

My HomepageMy Board - My Atelier

lurkalot

Quote from: wintstar on July 31, 2021, 06:17:29 AM
.centertext, .centercol {
   margin: 0 auto;
   text-align: left;
}


It makes no sense to change a CSS class centering value to left or right. It is best to remove it in the template centertext or centercol. You have created another problem for yourself with your solution.

That might well be the case.  But what we need to ascertain here, is,

1: Is the backtrace info supposed to be centered ?
2: If no, then why it is for some and not others?
3: Is this a minor bug, or not?

Personally I can take it or leave it for the same reason Mick mentioned above, no one else will see it.

wintstar

Standard it is not centered

https://github.com/SimpleMachines/SMF2.1/blob/release-2.1/Themes/default/Errors.template.php#L360-L375

.padding
https://github.com/SimpleMachines/SMF2.1/blob/release-2.1/Themes/default/css/index.css#L314

.backtrace:not(:last-child)
https://github.com/SimpleMachines/SMF2.1/blob/release-2.1/Themes/default/css/index.css#L4082

i think the problem is selfmade. If I so look at his solution, who knows where he still applies such or a mod overwrites a value for backtrace,  padding or ul
Regards Stephan

,,In order for the possible to come into being, the impossible must be attempted again and again."
Hermann Hesse (1877-1962)

My HomepageMy Board - My Atelier

lurkalot

Quote from: wintstar on July 31, 2021, 07:58:42 AM
Standard it is not centered

i think the problem is selfmade. If I so look at his solution, who knows where he still applies such or a mod overwrites a value for backtrace,  padding or ul

Well had to try it.  Just done a fresh install of RC4 on my local, no mods.  And it's the same.

wintstar

Quote from: lurkalot on July 31, 2021, 11:51:31 AM
Quote from: wintstar on July 31, 2021, 07:58:42 AM
Standard it is not centered

i think the problem is selfmade. If I so look at his solution, who knows where he still applies such or a mod overwrites a value for backtrace,  padding or ul

Well had to try it.  Just done a fresh install of RC4 on my local, no mods.  And it's the same.

What I can see on your screen capture, that's the way it is. As for the lower part of the backtrace. Title of the theme here "Centered Backtrace Info".


If the upper table area should be meant, the class in the template centertext must be removed
https://github.com/SimpleMachines/SMF2.1/blob/release-2.1/Themes/default/Errors.template.php#L297

Errors.template  function template_show_backtrace()
change from
<table class="table_grid centertext">


to
<table class="table_grid">

That the upper area is centered, is so wanted by the development team and no bug.
Regards Stephan

,,In order for the possible to come into being, the impossible must be attempted again and again."
Hermann Hesse (1877-1962)

My HomepageMy Board - My Atelier

Shades.

ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

Sesquipedalian

I agree that it looks weird. The centertext class has been removed from the table in #6896.
I promise you nothing.

Sesqu... Sesqui... what?
Sesquipedalian, the best word in the English language.

Advertisement: