SMF 2.1 RC4: Hard-coded height restriction on SCE Editor textarea.

Started by Antechinus, August 30, 2021, 08:43:14 PM

Previous topic - Next topic

Antechinus

It's my thread, so you don't get to use the button. Only the OP or mods get to use it. ;)

Diego Andrés

Quote from: Antechinus on May 08, 2022, 06:06:01 PMSo...
Code (jquery.sceditor.bbcode.min.js - Find) Select
resizeMaxHeight:null,
Code (jquery.sceditor.bbcode.min.js - Replace) Select
resizeMaxHeight:-1,
There you go. Sorted, using officially approved SCE options. Post this to Tips and Tricks if the devs don't want to touch it. ;)

Actually, you'd have to edit Subs-Editor.php since that's how SMF implemented it and that's how I also added it.  ;)
$sce_options['resizeMaxHeight'] = -1;

And I guess I should move it to Feature Requests since the dev team stated is not a bug?

SMF Tricks - Free & Premium Responsive Themes for SMF.

Shades.

Quote from: Antechinus on May 08, 2022, 06:28:12 PMIt's my thread, so you don't get to use the button. Only the OP or mods get to use it. ;)
Yea I know... was just kidding! ;)  ;D
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

Antechinus

No, I would not have to edit Subs-Editor.php. I have tested the change live on local. It works perfectly, So, anyone can do it the way I indicated. It comes down to: do you want to hack Sources, or do you prefer to edit a js file?

The devs can say it is "not a bug" because it is "intended behaviour", but it is still dumb behaviour, and it is easy to fix, so it should be fixed. You can move it to Feature Requests if you like, or to Tips and Tricks. I'm not fussed.

Diego Andrés

Could also just use the mod and you know, no file edits :P
I might even add a per member option just to make you reasonably happy.

SMF Tricks - Free & Premium Responsive Themes for SMF.

Antechinus

Could even just fix it in core and, y'know, no mod required then. :P

Steve

I've installed Diego's mod and it works perfectly, however, I have to agree with Ant's main point, that there should be no height restriction hard-coded in.
My pet rock is not feeling well. I think it's stoned.

Advertisement: