Quote feature no longer working 2.0.15

[Finn_958]

Website: www.coscienzamaschile.com

Hi, the quote feature no longer works on my forum. You can try it without registering, please help:
1. What are the source code files involved?
2. Does it also involve the database?
It appears that the quote button "inserisci citazione" does not generate a correct link
All other features seem OK
Thanks

[shadav]

any errors in your admin logs
any errors in your server logs
are you using a custom theme? if so does this do this with the default theme?
what's the last modifications you did to your forum since last time the quote worked? try undoing them

also (the obligatory) please update to the latest stable version of smf (2.0.18)

[Finn_958]

Only one error on admin log on October 20 made by a visitor:

https://www.coscienzamaschile.com/index.php?topic=2263.0Applica filtro: Mostra solo gli errori con lo stesso messaggio8192: Array and string offset access syntax with curly braces is deprecatedApplica filtro: Mostra solo gli errori relativi a questo fileFile: /home/coscienz/public_html/Sources/Subs-Editor.php
Riga: 900

No modifications made since the issue occurred
No custom themes
Cannot update to 2.0.18 without losing many MODs. Another 2.0.1.5 forum on another server performs well
1-2 days ago I partially restored php files (not the database), so it's possible that some files are missing/corrupt.

The inserto quote buttton should generate a link like this:

index.php?action=post;quote=201754;topic=17858.0

Instead, it generates links like this:

index.php?action=post;topic=2727.0;last_msg=10710#postmodify

What are the files involved in the insert quote function?
Thanks

[Finn_958]

It has to do with Tapatalk plugin, which worked so far. I am now trying to update the mod but it gives the following errors:

[shadav]

uggg tapatalk....can't help there
never used that mod and yes I've heard it causes all sorts of issues
in my opinion it's not worth the hassle for all the issues that it creates, would be better to just uninstall the mod
but to update it or install it would need to know what each error is (it's looking for code that has already been altered by something else) and what it's looking for and what is actually there in that file

as for updating smf you can use the patches, one by one until you are up to date
https://custom.simplemachines.org/index.php?action=patches
download them and upload them to your packages folder and install them like a mod

depending on how heavily modified your forum is you may run into errors which you can post them and we can help you work them out so you can get updated

[Finn_958]

Thanks, If I update SMF I lose many MODS compatibilityso I stick to 2.0.15 for now.
Apparently I succeeded in updating Tapatalk but the tapatalk app no longer loads the forum. I submitted a ticket to them too

[shadav]

using the patches to update you won't lose any mods

[Finn_958]

Some mods are incompatible with the latest version

[shadav]

any mod that works on any version of 2.0.x should work with 2.0.18 (not saying that some changes may be needed)
which mods in question do you think are incompatible?

[Illori]

also you are at risk of your forum being hacked and it will not work with all the latest php versions we support and you may have issues if your host upgrades your php version.

[Finn_958]

I understand. This mod for example works only with 2.0.1.5:
https://custom.simplemachines.org/index.php?mod=2322

[Diego Andrés]

If it works on 2.0, it probably works for any 2.0.x smf version, sometimes it just means the author/s haven't updated certain mod in a while.
You can always head to the support topic for any of the mods.

As for updating, when you install the patches you'd see if there are any errors during installation like any mod and you could ask for help in case you need it

[Finn_958]

The 2.0.16 patch gives many errors although I did not uninstall any mods before installing the patch

[Diego Andrés]

You're not supposed to uninstall mods anyways.
You could share the errors that you're getting and perhaps the list of mods so we can take a look at it

[Finn_958]

Here are the 2.0.16 patch failures:

Sostituisci   ./Sources/Subs.php   Test fallito

[Diego Andrés]

That's only for your custom theme? If that's the one from vbgamer you could ask for support on the web for that one.
Although I'd assume the latest version of that theme is already up to date assuming you installed it recently so wouldn't need to update it with the patches.

[Finn_958]

This custom theme is paid and works as an app on smartphones. For updating, I should buy the new version but for now I would like Tapatalk to work and update only when obliged by php or similar.

[shadav]

as mentioned all the errors shown above were only for a specific theme

you could install either the Responsive Curve or the Hilbert mods on the default theme to make the default theme mobile friendly instead of using the theme in question

I mean it obviously is your choice not to update however that said, due note that you are using an outdated version with security issues

and as mentioned if your host decides to update php your forum will stop working
most hosts are dropping php 5.x, even php 7.2 is now obsolete

at some point you will inevitably have to update

as for the tapatalk mod, you will need to contact them for help, I don't believe they have a support thread here anymore due to too many security issues and they weren't keeping the mod or support for it here up to date.

[Finn_958]

I reinstalled the Tapatalk app on my phone and the issue was solved!
Thank you for your suggestions,I will use them when I will update the forum.
Just a quick suggestion about the new SMF grahpics: the new version has great functionalitites and design but too much grey, it's a bit dull. More blue like in the previous version would be better. I choose SMF mainly for its graphics, much more relaxing and pleasing than that of other forums

[Finn_958]

The problem occurred again even after uninstallin Tapatalk.
To fix it, please let me know which files are involved in the use of the quote buttons and i will try replacing them with backed up versions

[Finn_958]

Any help?

[Kindred]

I would really just suggest uploading a clean set of 2.0.18 files and then reinstalling any mods that you feel that you need, one by one and check to see where the failure happens.

This serves 2 purposes...   1- it gets you on 2.0.18 and 2- it probably corrects your error.

[Finn_958]

Thank you. I see that other suggestions are:
1. Checking with file_check.php but I don't know how to perform this check
2. Checking errors with browser, I did it ("Inspect2 on Chrome) but apparently it detected no errors
Also, I did not install any mod recently, the issue just happened

[Kindred]

Well, errors like that don't "just happen". Computers do the same thing, every time, until something changes.

So -- SOMETHING changed.
We don't know exactly what...  but it did.

As I said, your best bet at this point is to load a clean set of files for your forum and your custom theme. (remove any hooks using repair_settings.php, as well) - then install mods one by one.


Because you REALLY need to be on 2.0.18, not the least of reasons which, there are known security holes in previous versions which have been patched.

[Finn_958]

I updated to 2.0.18 but the problem persists

[Finn_958]

I removed hooks but the problem persists

[shadav]

how did you update to 2.0.18?
might need to clear your browsers cache (Doubt it but it can't hurt)
any errors in your admin logs
any errors in your server logs

you mentioned before about using phone, does this only occur on your phone?

[Finn_958]

I updated using patches
I removed all mods (except 2.0.16->2.018 updates patches)
Cache cleaned
I use Win 10 PC not phone
The problem persists, where are the logs?

[Finn_958]

One error on error log:

Visitatore [error caused by unregistered visitor]
Applica filtro: Mostra solo i messaggi di errore relativi a questo indirizzo IP 66.249.74.80 
    Inverti l'ordine cronologico della lista Ottobre 20, 2021, 02:13:12 am
a7c28b6fb43960440a4e69877a66fd8c
URLhttps://www.coscienzamaschile.com/index.php?topic=2263.0Applica filtro: Mostra solo gli errori con lo stesso messaggio8192: Array and string offset access syntax with curly braces is deprecatedApplica filtro: Mostra solo gli errori relativi a questo fileFile: /home/coscienz/public_html/Sources/Subs-Editor.php
Line: 900

No errors shown in admin activity

[shadav]

Well, errors like that don't "just happen". Computers do the same thing, every time, until something changes.

So -- SOMETHING changed.
We don't know exactly what...  but it did.

As I said, your best bet at this point is to load a clean set of files for your forum and your custom theme. (remove any hooks using repair_settings.php, as well) - then install mods one by one.


Because you REALLY need to be on 2.0.18, not the least of reasons which, there are known security holes in previous versions which have been patched.

you should do as kindred said here, install clean files, not patches
use the 2.0.18 Large upgrade

and then after doing that use the repair settings to remove any hooks

make sure that everything is working correctly, then make sure you have the latest versions of the mods that you were using and install them one by one checking for the issue

what version of php are you using?
server logs should be found somewhere in your hosting account (depends on your host where they place them)

[Finn_958]

7.4 php since a long time

[Finn_958]

I just uploaded the large upgrade unzipped files and the quote problem seems already solved at least for now.
Now proceeding with the other upgrade steps+mods

[Finn_958]

I reinstalled all mods including Tapatalk and for now everything works. Mods have now to be configured, I leave the topic open for some time

[Finn_958]

Some images are missing from the settings page:

[Kindred]

Refresh your cache

If that doesn't fix it, make  Sure the files are actually are actually in the location that the system is looking for them at. If not get the files from the SMF distribution archive and put them there

[Finn_958]

Many system images are decidedly missing since a long time. What are the files involved?

[Finn_958]

I added all the admin images (which were already there) but the problem persists. I also tried to login from another browser so it's not a refresh cache issue

[Kindred]

Right click the missing image.  See if it is pointing to the correct location

[Finn_958]

Yes it does. Also, the images exist but if accessed directly the server gives a timeout error or just does not open the page

[Kindred]

Seems like a server problem.

[Finn_958]

It may also be Cloudflare config

[Kindred]

You didn't mention that you were using cloudflare.   

Yes, it could be.  Either way, it's not an issue in smf.

[Finn_958]

I pointed to other nameservers which propagated immediately but the problem persists: forum system images (admin interface) do not load

[Kindred]

as I said:   
if the code is pointing to the correct location and file... 
and the file is actually present in that location, then the issue is not with SMF...
 -- the issue is with your servers. (Probably permissions for file access)

Since you say that the file is NOT accessible by direct URL
-- that would seem to be indicative of your problem.
If you can't access the file directly - neither can the SMF code when it calls the file for display.


except for the fact that *I* can apparently get to those files
https://coscienzamaschile.com/Themes/default/images/admin/support_and_credits.png
and
https://www.coscienzamaschile.com/Themes/default/images/admin/feature_cd.png
this works just fine for me...


which suggests that the problem is on YOUR browser.

[Finn_958]

I set all images folder file permissions to 755 and the problem was solved, so it was most likely a permissions issue. I now re-enabled Cloudflare+Cloudflare nameservers and for now everything works but only on Chrome, most likely it is a local, SMF or Cloudflare cache issue. I will now see what happens within some minutes

[Finn_958]

Everything works, thank you for your help