Very strange smiley performance following upgrade

Started by Roger2, December 25, 2021, 11:25:12 AM

Previous topic - Next topic

Roger2

Hi folks

Been using SMF successfully for many years. I did a clean V2.08 install about 2015 and have nominally kept it up-to-date since - although I was on 2.0.17 for longer than I perhaps should have been.

Last night I upgrade to 2.0.19 in the recommended manner - went to 2.0.18 first. All tests successful at both upgrades and all seemed well. However, since this upgrade, only some of the smiley words parse to smileys when posting. All existing posts seem to have all smileys ok - but if I quote a post with smileys in, some parse and others don't (leaving just the words).

Is this a known issue? All Smileys are in the default group (and others for that matter) and all appear in the edit screen.
Nil illigitimis el carborundum

Roger2

A possible clue - not checked them all. Some smiley texts are plain such as ThumbUp , others are enclosed between colons :smiley: - and others are inside single speech marks 'LikeThis'. I think the ones in speech marks are the ones that don't parse.

Edit: No wrong. Some of the PlainText smileys aren't parsing wither - but I think all those between colons are. Sample size may be too small for this to be significant.

Curiouser and curriouser.
Nil illigitimis el carborundum

Sir Osis of Liver

Which theme are you using?  Same problem in Curve?
"The best laid schemes o' mice an' men / Gang aft a-gley." - Robert Burns

Roger2

Quote from: Sir Osis of Liver on December 25, 2021, 04:26:31 PMWhich theme are you using?  Same problem in Curve?

Standard - Curve. I briefly experimented with themes but reverted to standard at least 4 years ago.

The board is a support forum for oil technicians [nofollow] I have created a user profile - smftest, password testsmf1, that can see the sandbox. Would be grateful for any pointers - feel free to play with anything in that
Test Bed - or start a new topic if you prefer within the sandbox.

Most grateful for any assistance.

Apologies - can't seem to subvert the inactive link. Hopefully it's obvious...
Nil illigitimis el carborundum

Sir Osis of Liver

Will be offline til late tomorrow, if no one else gets to it will take a look.  Have you tried uninstalling 2.0.19 patch?
"The best laid schemes o' mice an' men / Gang aft a-gley." - Robert Burns

Roger2

Quote from: Sir Osis of Liver on December 25, 2021, 10:49:46 PMWill be offline til late tomorrow, if no one else gets to it will take a look.  Have you tried uninstalling 2.0.19 patch?
Thanks for your continued help. No - didn't realise one could go backwards - I'll do that now if I can see how.......  Right, did that - it now says 2.0.18 at the bottom - and I think it's better.  I'll see if I can now uninstall 2.0.18..... Yes I can :-)  And it is definitely better in both 2.0.18 and 2.0.17.

Reinstalling just 2.0.18 - all seems to work fine.

Reinstalling 2.0.19 - and the problem recurs.

I'll leave it at 2.0.19 for a day or so lest it help you with diagnosis of something esoteric for the greater good. However, I can revert to 2.0.18 to restore full emoticon functionality which I will do in a day or so unless there's a compelling reason not to.

Two consecutive posts on my forum - infuriatingly by fluke one at the bottom of a page and the next at the top of the following page. The first - http://www.oiltechs.org/forum/index.php?topic=2317.msg29300#msg29300 [nofollow] - was made at 2.0.18, all required icons present and correct (it is simply a text copy of a chunk of the admin emoticon edit page).  The second - https://www.oiltechs.org/forum/index.php?topic=2317.msg29301#msg29301 [nofollow] - identical at composition stage - was made at 2.0.19. If you "quote" either, apart from the date credentials in the quote link, the text to parse is identical.

Nil illigitimis el carborundum

Dave J

The way I see it you need to remove all the inverted commas from the either the 'filename' or 'tooltip description' by modifying the smiley and see if that works. See the screenshot below you'll see none of them have any commas


You cannot view this attachment.

Roger2

Quote from: Dave J on December 26, 2021, 06:02:04 AMThe way I see it you need to remove all the inverted commas from the either the 'filename' or 'tooltip description' by modifying the smiley and see if that works. See the screenshot below you'll see none of them have any commas


You cannot view this attachment.
Will that render smileys in existing posts fugitive? If so I'd prefer to stick at 2.0.18 and log as a bug.
Nil illigitimis el carborundum

Steve

What are inverted commas? Apostrophes?

@Roger2 - yes it would
Please do not PM me for support.

Roger2

Quote from: Steve on December 26, 2021, 08:57:57 AMWhat are inverted commas? Apostrophes?

@Roger2 - yes it would

Could I duplicate but hide the ones in speech marks to cover all bases? Still seems like a bug to me.
Nil illigitimis el carborundum

shawnb61

Can you share some examples of which smileys work & which don't?  Screenshots of examples that work & ones that don't would help identify a pattern.

I am also wondering about the 'enclosed in quotes' - where are you seeing that?  A screenshot there would help, too.  I don't see smiley codes enclosed in quotes anywhere...

Sounds like you have a lot of custom smileys?  Are the standard ones working?

No, this is not a known issue.  (However, I do see an issue with the cry smiley atm...)
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

Dave J

Quote from: Steve on December 26, 2021, 08:57:57 AMWhat are inverted commas? Apostrophes?

@Roger2 - yes it would


 Inverted commas are punctuation marks that are used in writing to show where speech or a quotation begins and ends. They are usually written or printed as ' ' or " ". Inverted commas are also sometimes used around the titles of books, plays, or songs, or around a word or phrase that is being discussed.

Steve

I know what they are. I was being a little facetious. Apostrophes and inverted commas are the same thing. :)
Please do not PM me for support.

Dave J

Quote from: shawnb61 on December 26, 2021, 01:04:27 PMCan you share some examples of which smileys work & which don't?  Screenshots of examples that work & ones that don't would help identify a pattern.

I am also wondering about the 'enclosed in quotes' - where are you seeing that?  A screenshot there would help, too.  I don't see smiley codes enclosed in quotes anywhere...

Sounds like you have a lot of custom smileys?  Are the standard ones working?

No, this is not a known issue.  (However, I do see an issue with the cry smiley atm...)

Shawn, in one of the OP's posts there is a link to his site and a temp log in which is what I used to see the post with the smileys in 'inverted commas'.

It should be noted that as per my previous post to Steve they are called many things, I just know sinlge marks like '' as inverted commas and "" are speech marks, sorry if that was confusing anyone.

Dave J

Quote from: Steve on December 26, 2021, 05:16:16 PMI know what they are. I was being a little facetious. Apostrophes and inverted commas are the same thing. :)

 ;D  ;)

Roger2

Quote from: shawnb61 on December 26, 2021, 01:04:27 PMCan you share some examples of which smileys work & which don't?  Screenshots of examples that work & ones that don't would help identify a pattern.
I endeavoured to do that in the posts I (attempted to) link to in my earlier message. However, with the help of clipboard and a bit of cloud space I cam likely show more explicitly.

Firstly, a screenshot from the admin "edit smileys" page. That shows a large number of personalised smileys, all of which work as expected in 2.0.18 and earlier. Two images at different scroll points in a long list.

Can't seem to make the IMG tag work - so including the image links in code quotes to easr copy/paste.

[img]https://drive.google.com/file/d/1QaZazdRNdTOUrj3P_5VpQXpxHSTXz15M/view?usp=sharing[/img]
[img]https://drive.google.com/file/d/1jsMV5buLYuK8ctkimPM8T888AmInVrVG/view?usp=sharing[/img]

You will see that many of these smiley texts are bookended by colons, eg:
:spoon:
:tongue:
:undecided:
These all seem to work in 2.0.19 as well.

Some are bookended by inverted commas/single speech marks/apostrophes (sorry for confusion - all mean the same character - the one to the right of the semicolon on the keyboard, eg:
'Applause'
'Confused'
'Cool shades'
'Cuppa'
'thank you'
'Think'
None of these parse when posted in 2.0.19 - although if posted in 2.0.18 or earlier, they parse and appear - and continue to show in these posts after upgrading to 2.0.19 - although if "quoted", they no longer render.

Still other smileys are not bookended at all, eg:
Thumbs Up
Bang Head
Head Spin
Laughing
These all seem to work in 2.0.19

I thus conclude that Smileys whose post token is bookended with apostrophes do not parse when posting in 2.0.19, though legacy posts continue to display them correctly (even after clearing cache)

Quote from: shawnb61 on December 26, 2021, 01:04:27 PMI am also wondering about the 'enclosed in quotes' - where are you seeing that?  A screenshot there would help, too.  I don't see smiley codes enclosed in quotes anywhere...
Sorry I must've explained myself badly, hopefully the above clears this up?

Quote from: shawnb61 on December 26, 2021, 01:04:27 PMSounds like you have a lot of custom smileys?  Are the standard ones working?

No, this is not a known issue.  (However, I do see an issue with the cry smiley atm...)

Yes there are a lot of custom smileys - created at various times by co-administrators. Yes they all should be colon bookeneded for consistency, but they aren't - and I am loathe to modify them as it will leave legacy posts with unconvolved smileys.

It would be good if this were fixable, but for now I think I have to wind back to 2.0.18 (but will leave matters in abeyance for a few more hours).

Edit: While I composed the above I see Dave has explained things better than I did.
Nil illigitimis el carborundum

shawnb61

So, in a word, the problem is apostrophies:
 - All smilies with apostrophies in the code fail.
 - All smilies without apostrophies work.

Is this correct?

(For most folks, this just means the cry smiley fails.)
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

Roger2

Quote from: shawnb61 on December 26, 2021, 05:52:26 PMSo, in a word, the problem is apostrophies:
 - All smilies with apostrophies in the code fail.
 - All smilies without apostrophies work.

Is this correct?

(For most folks, this just means the cry smiley fails.)
Yes - but the fail is not complete (hence the title "very strange"). Previously posted apostrophe-clad smileys continue to render correctly, but no longer do so when quoted.

Edit: Wasn't there a change to a translation table in this upgrade - could they have "translated" Ascii character 039 to something else that looks the same, like Word does to giver it a slope - eg Ascii 239? ´ '
Nil illigitimis el carborundum

shawnb61

Yep, perfect.  And yep, it's a bug.

Appears to only impact smilies, and specifically smilies that use apostrophies in the code.  For most of us, that's just the cry smiley.

Logged internally, #254
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

Roger2

Brilliant - feel free to mark this as closed. I'm going to revert to 2.0.18 - perhaps one of you would be kind enough to drop something in my Sandbox when it's safe to upgrade?

Not sure if I need to earn trust, but the ability to drop in hyperlinks or img references would have been helpful to both you and me here. If there is a flag you can set in my profile, I'd appreciate it. At least I'm no longer plagued with increasingly difficult-to-read Captchas!
Nil illigitimis el carborundum

Advertisement: