News:

Wondering if this will always be free?  See why free is better.

Main Menu

Cry Icon stopped working

Started by IamTheBoy, June 06, 2022, 03:52:34 PM

Previous topic - Next topic

IamTheBoy

Not quite sure when, but the cry icon on our forum stopped working.  Possibly with the 2.0.19 update?

The code is the forum default of : ' ( (without spaces), but this does not get converted to a smiley.

Smiley appears in the Post dialogue fine, no other smilies are using that code.  Creating a new identical Cry smiley with a different code does work fine.

Any ideas?

IamTheBoy

Actually, if I try to create a duplicate smiley with a ' in the code, the same happens.  Given the potential meaning of ' in php code, could it be its not being parsed properly?

Doug Heffernan

Quote from: IamTheBoy on June 06, 2022, 03:52:34 PMNot quite sure when, but the cry icon on our forum stopped working.  Possibly with the 2.0.19 update?

An update should not make it stop working. What was the latest change that you did to your forum, besides the 2.0.19 upgrade, prior to this happening?


Arantor

My understanding was that 2.0.18 introduced a bug in the smiley parsing but that 2.0.19 was supposed to fix it. Maybe @shawnb61 has a better memory for it than I do though.

Steve

Flagging for him to look at when he has time ... @shawnb61
Please do not PM me for support.

shawnb61

A quick search came up with this:
https://www.simplemachines.org/community/index.php?topic=580033.0

A 2.0.19 bug.  Not sure if anyone posted a temp fix or not; I don't recall seeing one.
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

IamTheBoy

Quote from: shawnb61 on June 07, 2022, 09:32:45 AMA quick search came up with this:
https://www.simplemachines.org/community/index.php?topic=580033.0

A 2.0.19 bug.  Not sure if anyone posted a temp fix or not; I don't recall seeing one.
The later comments on that thread match my symptoms, but no fix put forward on that thread, except to change the code for the smiley, which will then impact the rendering of all existing posts...

Steve

Quote from: IamTheBoy on June 07, 2022, 04:18:17 PMwhich will then impact the rendering of all existing posts
Which are all already impacted ... just saying.

Maybe one of our coding wizards can come up with a solution (*glances at Arantor*   :P ).
Please do not PM me for support.

Arantor

Before I look at that I'd need to dig back through why it was changed in the first place since it provably wasn't broken before.

Steve

I was kind of kidding that you should be the one to look at it.  ;D

Hopefully any of you coding wizards can come up with a solution.  :)
Please do not PM me for support.

Arantor

I'm not against the idea, just I don't have full access to the reports/discussions where it was changed in previous versions to understand why the parsing was changed - and that fixing it might break whatever was patched last time.

Advertisement: