Setting custom menu button active

[DeadMan...]

Okay, I'm setting up a board to be called from the menu.
I edited Subs.php and got the menu button as I want.
However, I'm having trouble getting it to be "active" when viewing that particular board.

Menu button:

Code Select Expand

            'gallery' => array(
                'title' => $txt['gallery'],
                'href' => $scripturl . '?board=8.0',
                'show' => true,
                'sub_buttons' => array(
                ),
            ),
Below, where states for doing active, I tried:

Code Select Expand

    elseif ($context['current_action'] == 'gallery')
        $current_action = 'gallery';
Also tried:

Code Select Expand

    elseif ($context['current_action'] == 'index.php?board=8.0')
        $current_action = 'gallery';
Still does the main forum button as active. (Using a portal)

[Arantor]

Try:

Code Select Expand

    elseif (empty($context['current_action']) && !empty($context['current_board']) && $context['current_board'] == 8)
        $current_action = 'gallery';
As for removing the category, find this in Load.php (your portal may have changed it, it's in loadBoard():

Code Select Expand

// Build up the linktree.
$context['linktree'] = array_merge(
$context['linktree'],
array(array(
'url' => $scripturl . '#c' . $board_info['cat']['id'],
'name' => $board_info['cat']['name']
)),
array_reverse($board_info['parent_boards']),
array(array(
'url' => $scripturl . '?board=' . $board . '.0',
'name' => $board_info['name']
))
);

Take out the:

Code Select Expand

array(array(
'url' => $scripturl . '#c' . $board_info['cat']['id'],
'name' => $board_info['cat']['name']
)),

This whole structure takes the existing linktree (home), adds category, adds board hierarchy then the current board all in one go, so you just need to remove the little bit of it that is the category name.

[DeadMan...]

Try:

Code Select Expand

Code Select Expand

    elseif (empty($context['current_action']) && !empty($context['current_board']) && $context['current_board'] == 8)
        $current_action = 'gallery';

Didn't work. Still shows Forum as active.

[DeadMan...]

Anyone have another idea how to accomplish this?

[Arantor]

Well it might have helped if you'd mentioned you had a portal messing with things...

[DeadMan...]

Well it might have helped if you'd mentioned you had a portal messing with things...

Umm... I did. And you even commented on it afterwards. 

Still does the main forum button as active. (Using a portal)

As for removing the category, find this in Load.php (your portal may have changed it, it's in loadBoard():

[Arantor]

That was a subtle hint that it would be nice to not try to read your mind further than necessary... as in, all the useful details up front?

[DeadMan...]

That was a subtle hint that it would be nice to not try to read your mind further than necessary... as in, all the useful details up front?

Good point...

SMF 2.1.3 - TinyPortal 2.3.0
NameX theme

I had tried this, but it didn't work:

Try:

Code Select Expand

    elseif (empty($context['current_action']) && !empty($context['current_board']) && $context['current_board'] == 8)
        $current_action = 'gallery';

[Arantor]

OK so I see how TinyPortal is doing this.

Give this a go instead.

Code Select Expand

    elseif ($context['current_action'] == 'forum' && !empty($context['current_board']) && $context['current_board'] == 8)
        $current_action = 'gallery';
Gets a bit different if you want to change it up based on whether they're actually in the board or not or in a topic in that board or not but in general this should work.

[DeadMan...]

Give this a go instead.

Still not doing it.

https://www.deadmanknows.site/

[Arantor]

Oh, I'm an idiot.

Make that an if rather than an elseif.

[DeadMan...]

Make that an if rather than an elseif.

That did it. Thanks, my friend!

[Sesquipedalian]

Oh, I'm an idiot.

Not in my experience.

[Arantor]

I should have seen it earlier to be honest, it's kind of a rookie mistake on my part - of course it would never trigger, because the first link in the chain (action being forum is a known action in the menu) would always have fired first and skipped all the branches.

Though I will be honest, I spend time over in Laravel land these days and I miss code like this, it has a certain fundamental honesty that Laravel doesn't.

[DeadMan...]

I should have seen it earlier to be honest

Does that mean the first code you gave may have worked if we did if instead of elseif?

[Arantor]

Nah, it would still have failed because I didn't at that point realise that action=forum already was directly in play since not all portals do it that way. $context['current_action'] was never empty in that scenario.