Can't install update due to Theme incompatibility

[Sono]

My forum is running with SMF4Mobile theme for mobile devices. When I try to install the 2.0.10 update, these codes are shown as Test Failed. Are these essential, or can I skip them for the mobile theme?

/Themes/SMF4Mobile/scripts/script.js

Code Select Expand

var is_ff = (ua.indexOf('firefox') != -1 || ua.indexOf('iceweasel') != -1 || ua.indexOf('icecat') != -1 || ua.indexOf('shiretoko') != -1 || ua.indexOf('minefield') != -1 || ua.indexOf('PaleMoon') != -1) && !is_opera;

Code Select Expand

if (!bInit && 'oThemeOptions' in this.opt && this.opt.oThemeOptions.bUseThemeSettings)
./Themes/SMF4Mobile/Search.template.php

Code Select Expand

<li class="board">
<label for="brd', $board['id'], '" style="margin-', $context['right_to_left'] ? 'right' : 'left', ': ', $board['child_level'], 'em;"><input type="checkbox" id="brd', $board['id'], '" name="brd[', $board['id'], ']" value="', $board['id'], '"', $board['selected'] ? ' checked="checked"' : '', ' class="input_check" /> ', $board['name'], '</label>
</li>';
./Themes/SMF4Mobile/Post.template.php

Code Select Expand

\'question\', \'topic\', ', JavaScriptEscape($context['session_var']), '

[Kindred]

Best asked in the support thread for that theme...

[Steve]

You're on 2.0.10 or is that a typo? 

[Kindred]

I would guess that the OP is on 2.0.9 and is trying to upgrade to 2.0.10 via the patch update.

thing is, the SMfmobile theme is actually pretty outdated, so there is a good chance that there will be more failed tests as the OP applies patches up to 2.0.19

[Diego Andrés]

This one? https://smfmobile.com/
I did some light work on it but don't recall the SMF version, must've been at least 2.0.15 and it worked just fine.
I wouldn't know about the js or jquery, didn't check that at the time. In any case if the files weren't supposed to be customized (or included in the theme), could be skipped for the patching, and maybe removed from the theme.

[Steve]

I would guess that the OP is on 2.0.9 and is trying to upgrade to 2.0.10 via the patch update.

Oh yea, I see now. I guess I jumped too quickly on the fact he's so far behind on all the security improvements.

[Sono]

This one? https://smfmobile.com/
I did some light work on it but don't recall the SMF version, must've been at least 2.0.15 and it worked just fine.
I wouldn't know about the js or jquery, didn't check that at the time. In any case if the files weren't supposed to be customized (or included in the theme), could be skipped for the patching, and maybe removed from the theme.

Yes, this is it.

[Sono]

I would guess that the OP is on 2.0.9 and is trying to upgrade to 2.0.10 via the patch update.

Oh yea, I see now. I guess I jumped too quickly on the fact he's so far behind on all the security improvements.

Because of this mobile theme. There are always Test failures for it reported on every update.

[Kindred]

Which is a problem with the theme...

As with any custom mod or theme,  given a failure with a patch or mod, you - the admin - need to use human logic to determine if the auto-searched code exists in some form, and if so, interpret what needs to be done

[Sono]

Which is a problem with the theme...

As with any custom mod or theme,  given a failure with a patch or mod, you - the admin - need to use human logic to determine if the auto-searched code exists in some form, and if so, interpret what needs to be done

It works like that provided you know PHP coding. Unfortunately I don't belong to that group so it is always a mystery for me in most cases what type of codes are concerned.