2.1.4 Issue with TR, TD, Table in Signature

[Aleksi "Lex" Kilpinen]

Ping @Sesquipedalian @SleePy

You cannot view this attachment.

[Kindred]

hmmm..... maybe the assumption was, if table is enabled, tr and td would also HAVE to be enabled ---   which informed the activationdisplay, but someone forgot the logic in the backend?

but, why would it work HERE if that was the case?
How can it work on one site and not on another?

[shawnb61]

I think this issue is specific to using hr tags within the table.

Without the hr tags, it works fine on my test sites.  But it does break when hr tags are used.  (The exact sig example provided earlier in reply #8.)

I think I do recall table/tr/td were grouped a long time ago due to confusing & erroneous bug reports where folks didn't know they had to select all.  Couldn't find it on gh though.

[Kindred]

ok...  so, it is what I assumed (you can't have tr/td without table, so selecting table includes everything)

I don't think an hr within a table is fully kosher when it comes to html anyway... is it?

(searches ---   nope...  alot of people complain within basic html that it doesn't work right and they should use a td or tr border rather than an hr)

[shawnb61]

I don't believe SMF tables support borders.  It'd be nice if they did.

[live627]

I don't think an hr within a table is fully kosher when it comes to html anyway... is it?

it is within <td> https://developer.mozilla.org/en-US/docs/Web/HTML/Element/td#technical_summary

The OP is building the table right. Keep on fishing for red herring.

[shawnb61]

Is this a bug?  If so, what would be an acceptable fix?

My thinking is to leave it as-is.  The whole point of an hr tag, to split the page, is kinda incompatible with a table.

We could strip such tags from inside a table.  To me, that solution feels overengineered.

Report an error?  We normally don't preparse & provide bbc warnings.  We DO provide a preview function instead, though.  Which in this case very clearly shows the problem.

My take : Don't do that....

[Aleksi "Lex" Kilpinen]

I don't think an hr within a table is fully kosher when it comes to html anyway... is it?

it is within <td> https://developer.mozilla.org/en-US/docs/Web/HTML/Element/td#technical_summary

The OP is building the table right. Keep on fishing for red herring.

The OP did also say they tried without the HR tags, unless they made a mistake somewhere and didn't notice.

Like I said, just making sure. To continue with that, if you remove the [hr] tags, what happens? Is it still broken?

Yes, it's broken 

GL700Wing also tested with my current signature, and couldn't get it to work right, and no hr tags there.
https://www.simplemachines.org/community/index.php?msg=4172467

[shawnb61]

Likely a mistake.

Easily confirmed - try it yourself.

Pix of your example attached, with & without a hr tag.

You & live627 are both correct that hr is valid within an html table and will only do the width of the cell.  So, yes, another solution is to better mimic the raw html behavior.

[shawnb61]

Note this is not limited to the signature - same problem exists in the message body.

I did find that it works ok under some circumstances (empty cell?).  Hard to tell I'm out of town trying this all on my phone.... 😅

Code Select Expand

[table][tr][td][b][color=#0066cc]Slava[/color]
[color=#ffcc00][hr]Ukraini![/color][/b][/td][/tr]
[tr][td][/td][/tr]
[tr][td][sub]"Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas[/sub][/td][/tr][/table]

[Alex98]

So how can I allow them? Forum options are already allowed.

[Kindred]

So how can I allow them? Forum options are already allowed.

you don't need to allow anything.  The tr and td are automatically included or excluded based on the table BBC.

[Kindred]

ok...   this is really weird...  I *SWEAR* that it worked right before.   I had tables in my signature for several forums.

Code Select Expand

[table][tr][td][b][color=#0066cc]Slava[/color][/b][/td]
[td][b]Peace for[/b][/td][/tr]
[tr][td][b][color=#ffcc00]Ukraini![/color][/b][hr][/td]
[td][b]Gaza[/b][/td][/tr]
[tr][td][sub]This is my signature![/sub][/td]
[td][sup]view it and despair[/sup][/td][/tr][/table]

https://test2.turtleshellprod.com/index.php?msg=64

it works in the post body, but not in the signature... even with the hr

[Alex98]

I hope you now understand what I'm talking about.
Because it worked for me until recently, it suddenly stopped working and stopped loading the tr td board, which is even worse, I didn't touch anything on the forum during that period.
This also happens with quick edit, suddenly it doesn't want to save a post that can be edited via quick.

[Kindred]

I can't replicate the quick edit thing.   The post i linked above has been edited 15 times with quick edit

[needhelpsff]

I have the same problem.




You can see my setting

3. On the signature the table tag does not work. So does the the Glow tag.
Code Select Expand

Code Select Expand

[table]
[tr]
[td][size=18pt][color=red][b]ভাই পানি লাগবে, পানি?[/b][/color][/size][/td]
[/tr]
[tr]
[td][size=18pt][color=green][b]বাবা তোমার বুকে অনেক ভাল্লাগে।[/b][/color][/size][/td]
[/tr]
[/table]

My setting

[Kindred]

Yes, that's what known (and confirmed) issue means...  everyone has this problem

[shawnb61]

Logged the hr within a table issue:
https://github.com/SimpleMachines/SMF/issues/8299

[Aleksi "Lex" Kilpinen]

It might not be strictly related to the hr tag though, this topic has examples where table fails without the hr tag.
The latest post by needhelpsff being one, and the test by GL700Wing earlier being another.

[shawnb61]

It might not be strictly related to the hr tag though, this topic has examples where table fails without the hr tag.
The latest post by needhelpsff being one, and the test by GL700Wing earlier being another.

I only log what I can reproduce.  If you can reproduce it, please share how.

I believe in both examples you cited, the bbc was entered or copied & pasted incorrectly, specifically, missing the opening table tag.