Glossary for SMF 2.1

[GL700Wing]

I loaded your test glossary and ran your version of the mod to end up with a 14 second load time! Also "credit" had a different tooltip than the rest of the line A credit for your thoughts'

on test2.turtleshellprod.com, I have an extensive glossary added...    and it performs a really quick load for me on the glossary page.

I don't think the issue is with the time it takes a large main Glossary list to load for a Glossary administrator but rather the time it takes to display topics (particularly those with more than a few messages) containing multiple keywords in every message when a large Glossary list has to be processed.

Note: This is not a noticeable issue when only keywords enclosed in the Glossary BBcode are processed.

That said, the Glossary list I use for testing has a combination of almost 1,300 keywords/synonyms and if a Glossary this size was required in a production environment and the impact it had on the time it takes to display messages was unacceptable my recommendation would be to start with enabling the option 'Only show tooltip for each keyword once per message' and then, if necessary, enable the option 'Only show tooltips for keywords inside a Glossary BBCode tag'.

[live627]

I loaded your test glossary and ran your version of the mod to end up with a 14 second load time! Also "credit" had a different tooltip than the rest of the line A credit for your thoughts'

on test2.turtleshellprod.com, I have an extensive glossary added...    and it performs a really quick load for me on the glossary page.

6 seconds on your test topic

[GL700Wing]

6 seconds on your test topic

FYI: The Glossary on that forum contains almost 1,100 keywords.

Also, another SMF user with whom I worked extensively when updating this mod has a Glossary of ~100 keywords and when I use that Glossary list on my test forum there is no noticeable delay in the page load times.  Users of this mod may have to decide from the outset whether or not to enforce the use of the Glossary BBCode tag depending on their server configuration/capability, the size of their Glossary and/or the activity level of their forum.  In addition, the requirement to use the Glossary BBCode tag may need to enabled at a later time if the message processing/load times become unacceptable.

Finally, and if the use of the use of the Glossary BBCode tag is not required, enabling the 'Only show tooltip for each keyword once per message' and/or disabling the 'Show keyword and synonyms below definition in tooltip will reduce message processing/load times.

[Kindred]

I consistently get 2.7-2.9 seconds for that topic....

[live627]

ok...? Fighting over numbers gets us nowhere. The fact is that there is a performance issue
that MUST be addressed.

@GL700Wing here is another draft of my parsing algorithm. Thanks to your test data, I discovered that many of the matching failures were due to the word boundary. I also reorganized the code into classes/modules so that I wouldn't get lost.

[GL700Wing]

ok...? Fighting over numbers gets us nowhere. The fact is that there is a performance issue
that MUST be addressed.

@GL700Wing here is another draft of my parsing algorithm. Thanks to your test data, I discovered that many of the matching failures were due to the word boundary. I also reorganized the code into classes/modules so that I wouldn't get lost.

WOW!! All I can say is wow!! and many, many thanks!

You certainly a very knowledgeable and skilled programmer!

If it's okay with you I would like to add you as an additional author for this mod to acknowledge your amazing contribution.

[live627]

Sure thing. Go ahead.