Modifying post count group

[Sir Osis of Liver]

In response to this post, post count group can be modified to Private, this adds it to newsletter membergroups.  If you try to change it back to Post Based it fails with this error -

Fatal error: Uncaught TypeError: abs(): Argument #1 ($num) must be of type int|float, string given in /home/thekrash/domains/thekrashsite.com/public_html/smf21core/Sources/ManageMembergroups.php:740 Stack trace: #0 /home/thekrash/domains/thekrashsite.com/public_html/smf21core/Sources/ManageMembergroups.php(740): abs() #1 /home/thekrash/domains/thekrashsite.com/public_html/smf21core/Sources/Subs.php(6030): EditMembergroup() #2 /home/thekrash/domains/thekrashsite.com/public_html/smf21core/Sources/ManageMembergroups.php(66): call_helper() #3 /home/thekrash/domains/thekrashsite.com/public_html/smf21core/Sources/Admin.php(499): ModifyMembergroups() #4 /home/thekrash/domains/thekrashsite.com/public_html/smf21core/index.php(184): AdminMain() #5 {main} thrown in /home/thekrash/domains/thekrashsite.com/public_html/smf21core/Sources/ManageMembergroups.php on line 740

Steps to replicate -

Admin > Members > Membergroups.  Modify post count group to Private - works.  Modify back to Post Based, fails.

[Kindred]

It's not actually a bug..    well, the error is,  but you should not be able to change it back,  since post count based groups are special and have a variable membership

[Sir Osis of Liver]

Maybe shouldn't have an option to change it at all.

[Aleksi "Lex" Kilpinen]

I'd agree, if it works one way it should work the other way too. Or if for some reason that wouldn't be possible, then it shouldn't be an option at all.

#8324

[Arantor]

The reason it fails trying to put it back is that it no longer knows how many posts are the new baseline, from what I can tell.

But it shouldn't let you change it because post type groups aren't hidden anywhere in the system (the hidden logic literally can't apply to them)

[KittyGalore]

I'd agree, if it works one way it should work the other way too. Or if for some reason that wouldn't be possible, then it shouldn't be an option at all.

#8324

Also get the error strange you can select all the other options Protected and Requestable and so on but won't go to post count.

[Kindred]

Not strange  at all..   because it would break the system

It should not even allow you to change it in the first place.

The bug here is not the failure to change back,  or even the error...  the bug is allowing the first change at all.

I guess we never thought anyone would do that,  so it never even occurred to us to test it.

You should never be able to change a group from Post count based to assigned or from assigned to post count based

[KittyGalore]

Not strange  at all..  because it would break the system

It should not even allow you to change it in the first place.

The bug here is not the failure to change back,  or even the error...  the bug is allowing the first change at all.

I guess we never thought anyone would do that,  so it never even occurred to us to test it.

You should never be able to change a group from Post count based to assigned or from assigned to post count based

Clearly the post count group should have been made separate to the others so the option to change it isn't there and not having it in that list so avoiding the error.

[Kindred]

That's what I just said.

We never tested it because it never even occurred to us that someone would try that,  since it's illogical (imnsho)

[Arantor]

It's not even illogical: it's a literal achieve-nothing operation because there is literally no handling anywhere for the concept of a private post count group, because post-count groups don't have the same visibility as regular groups.

Serious question: what would you as an admin envisage the concept of a 'private post count' group even mean? It's not like you can be in multiple post count groups at once.

[Sir Osis of Liver]

If you look at the referenced topic you'll see there was a legitimate reason to try it.  It can't be reversed, once you modify the post count group it can't be restored as such.  The option should be removed.

[Arantor]

No, there wasn't a legitimate reason to try it, when there was already the functionality you wanted.

But again, what does a "private post group" look like?

[Sir Osis of Liver]

No, there wasn't a legitimate reason to try it, when there was already the functionality you wanted.

Yeah, well, if I knew that ..........

[Arantor]

Funnily enough it's been the same for 20 years - 1.1 and 2.0 both behave this way as well...

[Sir Osis of Liver]

Well, either it never came up before, or I don't remember it (there's much I don't remember ).

Hey, we're at 2.1.5. 

[Jeff Lewis]

(there's much I don't remember ).

Story of my life 

[Arantor]

2.1.5 has been on this site for a while, while some bugs are ironed out on it.