SMF, Joomla, The Bridge and UTF-8, XHTML compliance?

spiros · December 31, 2005, 12:28:26 PM

I noticed that when accessing directly a bridged forum xhtml is valid; when this is done through mambo (.../com_smf/...) plenty of xhtml errors appear (I also use an xhtml mambo template).

I guess it might be worth the trouble making the bridge xhtml compliant...

Orstio · December 31, 2005, 02:35:00 PM

The biggest part of making your bridge XHTML compliant is making the <head> area of your SMF theme conditional, by putting in something like this:

if (!defined(_VALID_MOS)){

[SMF Header, up to the <body> tag]

}

That should eliminate most of your XHTML errors. There is, of course, more you can do. I know I spent a lot of time getting all my components/modules to use & instead of &, etc.

spiros · December 31, 2005, 04:06:40 PM

Thanks Orstio.

The funny thing is that many xhtml errors also appear in the mambo home page, indicating the the login mod has problems.

I tried your suggestion but all I got was

if (!defined(_VALID_MOS)){ }

which was not parsed. Maybe I put it in the wrong place (index.template.php)

<html xmlns="http://www.w3.org/1999/xhtml"', $context['right_to_left'] ? ' dir="rtl"' : '', '>
[b]if (!defined(_VALID_MOS)){[/b]
<head>
        <meta http-equiv="Content-Type" content="text/html; charset=', $context['character_set'], '" />
        <meta name="description" content="', $context['page_title'], '" />
        <meta name="keywords" content="PHP, MySQL, bulletin, board, free, open, source, smf, simple, machines, forum" />

// The ?rc1 part of this link is just here to make sure browsers don't cache it wrongly.

echo '

Orstio · December 31, 2005, 04:13:19 PM

No, it will need to go before the echo statement that contains the html tags. You can't drop php into your html that way.

spiros · December 31, 2005, 04:32:36 PM

Thanks Orstio,

Which echo statement? There are so many of those I am lost...

Orstio · December 31, 2005, 04:39:36 PM

It's impossible to give terribly detailed instructions with this. Every theme is different -- there is no way to give out instructions that would encompass every theme, and also give detailed code.

This is the best I can do to help:

http://www.simplemachines.org/community/index.php?topic=38051.msg279445#msg279445

spiros · December 31, 2005, 07:33:20 PM

No problem Orstio,

It is not important as I am currently checking RC2. I reinstalled forum (as upgrade came up with unicode problems) just to realize that there are major unicode problems in this release (which is quite sad given that joomla is moving to a core UTF-8 approach in 1.1). Indeed, I feel that SMF people should try a bit harder to provide UTF-8 compliance in SMF.

More details here
http://www.simplemachines.org/community/index.php?topic=63235.0

spiros · December 31, 2005, 07:39:26 PM

Some minor UTF problems of the previous releases have been solved by a Greek guy (!!!) despite the fact that I mentioned them in this forum.

If anybody wants to know the solution here are the posts (with the code which has to be replaced)

http://www.mamboclub.net/forum/showthread.php?t=1467

For the problem of corrupting characters in topic subject (i.e. �):

/Sources/Post.php

Code Select

// Make sure the subject isn't too long - taking into account special characters.
		$strlen_subject = preg_replace('~&(#\d{4,5}|#[3-9]\d{2,4}|#2[6-9]\d|quot|#039|amp|lt|gt);~', '_', $form_subject);
		// Clip off the excess characters (100 - 104 is negative) - hopefully roughly making it as long as need be.
		if (strlen($strlen_subject) > 100)
			$form_subject = substr($form_subject, 0, 100 - strlen($strlen_subject));

As well as

Code Select

// At this point, we want to make sure the subject isn't too long.
	$strlen_subject = preg_replace('~&(#\d{4,5}|#[3-9]\d{2,4}|#2[6-9]\d|quot|#039|amp|lt|gt);~', '_', stripslashes($_POST['subject']));
	// We're stripping and adding the slashes to correctly trim it, and we're only taking off what's needed to make $strlen_subject 100.
	if (strlen($strlen_subject) > 100)
		$_POST['subject'] = addslashes(substr(stripslashes($_POST['subject']), 0, 100 - strlen($strlen_subject)));

	// Hack to make it so &#324324... can't happen.
	$_POST['subject'] = preg_replace('~&(#\d*)?$~', '', $_POST['subject']);

And replace all 100 with 150

For the problem of corrupting characters in latest post / last post find in

In /Sources/BoardIndex.php Find

Code Select

censorText($row_board['subject']);
$row_board['short_subject'] = shorten_subject($row_board['subject'], 24);
$this_last_post = array(

and change 24 to 25.

chadness · January 04, 2006, 02:31:34 AM

Quote from: Orstio on December 31, 2005, 02:35:00 PM
The biggest part of making your bridge XHTML compliant is making the <head> area of your SMF theme conditional, by putting in something like this:

if (!defined(_VALID_MOS)){

[SMF Header, up to the <body> tag]

}

That should eliminate most of your XHTML errors. There is, of course, more you can do. I know I spent a lot of time getting all my components/modules to use & instead of &, etc.

Nice idea! That's cleaner than the

Code Select

if (empty($_REQUEST['option'])){way of doing that I'm used to.

News:

SMF, Joomla, The Bridge and UTF-8, XHTML compliance?

spiros

Orstio

spiros

Orstio

spiros

Orstio

spiros

spiros

chadness