News:

SMF 2.1.4 has been released! Take it for a spin! Read more.

Main Menu

Topic Solved Mod

Started by Grudge, March 07, 2004, 07:51:18 AM

Previous topic - Next topic

MkC

Quote from: damacguy on January 15, 2006, 06:34:49 PM
I've downloaded v2, and it installed fine. I've also downloaded and installed the english file.

But I don't have a Topic Solved section as in the screenshot.

I'm running 1.1RC2.

Dans section il faut choisir la section designée comme celle devant etre gérée par le topic solved  ;)
Pour rc1 la gestion du packet est trop problematique donc pas de version
*********************************************************************************

In section it is necessary to choose the section designée like that having to be managed by the topic solved;)
For RC1 Bug with gestion of packet, not version for smf 1.1RC1

Menni

#82
edit: no bro anymore.

I installed tihis mod to my testboard(1.1 RC 2) and it works fine. I also translated it to finnish.
But when I try to install topicsolved to my chatboard(exactly samekind like testboard) I get several " Duplicate column name 'topicSolved' errors.
I had this mod installed to my previus smf version and there is something left in my database. I tried to remove the duplicate files, but there is always something left and the installation fails.
Can someone tell me exactly how and what should I remove(duplicate tables and keys) from my database?

EDIT:

I managed succesfully delete these tables:
db_query("
ALTER TABLE {$db_prefix}messages
ADD `topicSolved` TINYINT(4) DEFAULT '0' NOT NULL", __FILE__, __LINE__);

db_query("
ALTER TABLE {$db_prefix}boards
ADD `topicSolved` TINYINT(4) DEFAULT '0' NOT NULL", __FILE__, __LINE__);

db_query("
ALTER TABLE {$db_prefix}topics
ADD `topicSolved` TINYINT(1) DEFAULT '0' NOT NULL", __FILE__, __LINE__);


But this is what I'm not able to find:
Duplicate entry 'topicsolvedLockSolved' for key 1
Tiedosto: /home/myspace/public_html/myboard/Packages/temp/TopicSolvedPdb.php
Rivi: 53
// The infamous modSettings
foreach ($toSet as $key => $value)
$result =db_query("
INSERT INTO
{$db_prefix}settings
(`variable`, `value`)
VALUES
('$key', '$value')", __FILE__, __LINE__);


I'm a kind a nOOb and can't find it :-[


MkC

In phpmyadmin
Quote
DELETE FROM smf_settings WHERE variable = topicsolvedLockSolved LIMIT 1

damacguy

Quote from: damacguy on January 15, 2006, 06:34:49 PM
I've downloaded v2, and it installed fine. I've also downloaded and installed the english file.

But I don't have a Topic Solved section as in the screenshot.

I'm running 1.1RC2.

I finally got back to this issue. The install runs normally and says its successful, but nothing has been touched! I've manually installed it and it works! Hurrah!

It doesn't seem like the english file is being read though. I've installed it in /Themes/default/languages/ but it's not being read. I've changed the permissions on the file to 0777. And I've verified that Display.php has this line in it...
// Everything's gonna need this.
loadLanguage('ManageTopicSolved');
.

Suggestions?

MkC

#85
the file english is this:
http://smf-fr.org/forum/index.php/topic,274.msg1496.html#msg1496

The English file is placed before the installation of the MOD

Only version 1.1RC1 install not mods correctly.


V2 was tested on a basic smf 1.1RC2 with the theme default core. It is necessary to make the modifications in the other topics with the hand!

damacguy

I have the english file, and it's installed in /Themes/default/languages/. I didn't install it before I installed the mod, but I wouldn't think that would matter.

What fixed this for me was to copy the contents of the english file and add them to the end of my ManageBoards.english.php file.

damacguy

Where can I change the green color used for the background on solved posts? My users are saying its a bit too... bright. :)

MkC

In admin
       Topic solved

damacguy

AH! Silly me... looked everywhere but in the GUI. :-)

Thanks!

ArkServer

It requires me to fill in some ftp info.. but we dont use ftp, its installed locally

MkC

verify chmod 777  of all files ;)

damacguy

Saw "Undefined index: topicsolved" error from two lines in my Post.php file.

Specifically 112 if ($board_info['topicsolved'])

and 665 if ($board_info['topicsolved'])

The user was posting a Calendar event. I don't have any mods effecting my calendar installed.

I don't know enough about php, but where should 'topicsolved' be defined/indexed?

MkC


basys

#94
Hi Folks

Nice upgrade MkC & Grudge.     8)
Much appreciated.



Couple of suggestions for improving, (items 1 & 2 are relatively important).

If I've missed the logic behind this method, please explain.      :D




On Topic Solved Boards

1)
Message icon on all messages should remain selectable.
The stored smf_messages->icon should remain as the user's chosen icon.

The displayed icon should be conditionally selected dependent on smf_messages->topicSolved .

Icons should only change when accept/reject applied to that message, (and topic starter).
If accept/reject removed, icon should revert to display original selected.



2)
Related icon issue.
This mod amending the stored smf_messages->icon, rather than conditional display an indicator,
means that if you change the icon selected in Control Panel - Topic Solved Options,
the new icon is not propogated through the board.



3)
Message background colour
Conditionally display as per smf_messages->topicSolved.

Currently displays -
ok for status of initial question
ok for multiple wrong/reject answers.
ok for single correct answer

Doesn't allow accepting multiple correct answers



In message header

3)
To prevent accidentally clicking message deletion icon, (both are Xs)
Move the Accept Reject icons to before the Quote icon, (and away from the Remove icon).

4)
In default theme,
to display as other options,
display both icon and text, format to match.




In Control Panel - Topic Solved Options

5)
Message icon on OPTION
For admins other than person who installed the package.
Text descriptions for the four icon options
require instructions to indicate the filename is required, (without .ext),
and is not the icon's title/description.



Thanks again.

HTH
ATB
Paul

MkC

@damacguy: That comes from a bug in smf1.1RC2 of origin. The MOD does not have nothing to do there... Afflicted

damacguy


MkC

Quote from: damacguy on March 29, 2006, 05:13:39 PM
Thanks MkC.

Quote from: MkC on March 28, 2006, 04:22:49 PM
Il est possible que certains d'entre vous remarquent dans leur log cette erreur:
Quote
8: Undefined index: calendar_shortedit
Fichier: xxxxxxxxxxx/Themes/default/languages/ManageTopicSolved.french.php (eval?)
Ligne: 158

Il ne s'agit absolument pas d'un bug sur le topicsolved, mais un enorme oublis dans les fichiers smf sur la version officielle  ;)

Editer le fichier /Themes/default/languages/index.french.php

Rechercher
Quote
$txt['calendar_linked_events'] = 'Événements liés';

Ajouter apres
Quote
$txt['calendar_shortedit'] = 'Editer';

Vous pouvez supprimer ces erreurs  ;)

*********************************************************************************
Quote from: MkC on March 28, 2006, 04:22:49 PM
It is possible that some among you notice in their log this error:
Quote
8: Undefined index: calendar_shortedit
Fichier: xxxxxxxxxxx/Themes/default/languages/ManageTopicSolved.french.php (eval?)
Ligne: 158

They are not absolutely a bug on the topicsolved, but enormous lapses of memory in the files smf on the official version;)

Edit the file /Themes/default/languages/index.french.php

search
Quote
$txt['calendar_linked_events'] = 'Événements liés';

add after
Quote
$txt['calendar_shortedit'] = 'Edit';


URPG

so, how do i get this MOD to work in RC2?


Advertisement: