Advertisement:

Author Topic: Ad Management mod  (Read 1960140 times)

Offline Douglas

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,165
  • Gender: Male
  • Non sibi sed patriae
    • @BearlyDoug on Twitter
    • TheFan.net
Re: Ad Management mod
« Reply #7980 on: June 05, 2021, 06:04:05 AM »
Just an FYI, because you're using valign="top" and align and even width="100%" for your <td> calls, HTML validators are failing on those.

You need to switch this to use CSS, instead. Inline CSS is not the best way to handle this; you might want to consider including a separate CSS file for this.

I would also recommend starting to move away from tables and use pure CSS and divs... just my thoughts.

(Love this mod, do NOT get me wrong!)
« Last Edit: June 05, 2021, 06:14:40 AM by Douglas »
Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* Sports Photographer and Media Personality
* CFB Historian
* Tech Admin for one 1M+ post, one 2M+ post and one 10M+ post sites (last two are powered by multiple servers)
* WordPress Developer (Junkie)

Offline vbgamer45

  • Customizer
  • SMF Super Hero
  • *
  • Posts: 23,608
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: Ad Management mod
« Reply #7981 on: June 05, 2021, 08:02:51 AM »
It would be nice to move away from tables for the main columns.  I would need to hire someone for that part for the CSS to make that happen, as I am not that good with CSS layouts.
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline smartmouse

  • Full Member
  • ***
  • Posts: 610
Re: Ad Management mod
« Reply #7982 on: June 24, 2021, 04:13:49 AM »
Hello, is possible to avoid mod to add attachments to it ads post?
I see that if the post before ads have files attached the sponsored post has the same file attached as well.
How to fix it?

Offline vbgamer45

  • Customizer
  • SMF Super Hero
  • *
  • Posts: 23,608
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: Ad Management mod
« Reply #7983 on: June 24, 2021, 07:05:47 AM »
Are you using the option display ads a s posts.
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline smartmouse

  • Full Member
  • ***
  • Posts: 610
Re: Ad Management mod
« Reply #7984 on: June 24, 2021, 09:45:14 AM »
Yes, I removed it and I solved, thank you!

Offline vbgamer45

  • Customizer
  • SMF Super Hero
  • *
  • Posts: 23,608
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: Ad Management mod
« Reply #7985 on: June 24, 2021, 09:53:14 AM »
Glad that helped
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline Dave J

  • Full Member
  • ***
  • Posts: 466
    • The Hobby Workshop
Re: Ad Management mod
« Reply #7986 on: June 27, 2021, 05:49:35 AM »
Hi VB,

I'm trying to get a wordsearch page (which the files for it are stored on my site) to work via your ads mod. I've managed to get a crossword added but I cannot get the html code to open the full wordsearch in the ad.
I can link to the wordsearch which then opens on another page but I wanted it embedded into the site rather than members having to go to an external page.

This is the code I'm using, which is basically the wordsearch html page.

Code: [Select]
<div style="text-align:center">
<head>
<meta charset="utf-8">
<title>Testing</title>
</head>
<body>
<h6>Testing</h6>
<h7 id = "instructions"></h7>
<h8 id = "themeIntro">The theme is: <span id = "wordTheme"></span></h8>

<button id = "newGameButton" type = "button">New Game</button>
<div id = "wordboard"></div>
<div id = "wordlist"></div>
<button id = "solveButton" type = "button">Release the sacred answers!</button>

<link rel = "stylesheet" type="text/css" href = "css/wordsearch.css">

<script src = https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js></script>

<script src = "js/wordpaths.js"></script>
<script src = "js/wordsearchcontroller.js"></script>
<script src = "js/wordsearchlogic.js"></script>
<script src = "js/wordsearchview.js"></script>

<script>
$(document).ready( function() {
new WordSearchController("#wordboard", "#wordlist", "#solveButton", "#newGameButton", "#instructions",
"#wordTheme");
})
</script>
</body>
</div>

You can see what I've got on my test site here
Code: [Select]
https://www.davejohnson.co.uk/testing/index.php?action=forum

Any help is much appreciated

Dave
All the Quiz info is here

Offline vbgamer45

  • Customizer
  • SMF Super Hero
  • *
  • Posts: 23,608
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: Ad Management mod
« Reply #7987 on: June 27, 2021, 09:03:15 AM »
I am getting these files don't exist checking javascript console in browser
https://www.davejohnson.co.uk/testing/js/wordsearchlogic.js

Loading failed for the <script> with source “https://www.davejohnson.co.uk/testing/js/wordpaths.js”. index.php:197:1
Loading failed for the <script> with source “https://www.davejohnson.co.uk/testing/js/wordsearchcontroller.js”. index.php:198:1
Loading failed for the <script> with source “https://www.davejohnson.co.uk/testing/js/wordsearchlogic.js”. index.php:199:1
Loading failed for the <script> with source “https://www.davejohnson.co.uk/testing/js/wordsearchview.js”.
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline Dave J

  • Full Member
  • ***
  • Posts: 466
    • The Hobby Workshop
Re: Ad Management mod
« Reply #7988 on: June 27, 2021, 09:15:09 AM »
Hi VB,

It should have shown

Code: [Select]
https://www.davejohnson.co.uk/testing/wordsearch/js/wordsearchlogic.js
Not sure why it gave that link

Thanks for looking at it but I have solved it now. All I needed to do was put the link in an <iframe>.

If you go to the test site now you'll see it working. All I need to do now is some cosmetic touches.

Thanks again VB

All the Quiz info is here

Offline Douglas

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,165
  • Gender: Male
  • Non sibi sed patriae
    • @BearlyDoug on Twitter
    • TheFan.net
Re: Ad Management mod
« Reply #7989 on: July 05, 2021, 10:12:06 AM »
Interesting error here... out of the box install...

Code: [Select]
Incorrect string value: '\xE2\x80\x83\x0D\x0A<...' for column 'CONTENT' at row 1
File: /home/[url=https://www.simplemachines.org/community/index.php?action=profile;u=360106]snip[/url]/Sources/Ads.php
Line: 273

Ads.php attached (as Ads.txt)

I was trying to change the positioning of this between certain posts.
Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* Sports Photographer and Media Personality
* CFB Historian
* Tech Admin for one 1M+ post, one 2M+ post and one 10M+ post sites (last two are powered by multiple servers)
* WordPress Developer (Junkie)

Offline vbgamer45

  • Customizer
  • SMF Super Hero
  • *
  • Posts: 23,608
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: Ad Management mod
« Reply #7990 on: July 05, 2021, 10:26:13 AM »
Probably due the fact the table is not in utf8 format for ads
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline Douglas

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,165
  • Gender: Male
  • Non sibi sed patriae
    • @BearlyDoug on Twitter
    • TheFan.net
Re: Ad Management mod
« Reply #7991 on: July 06, 2021, 07:11:37 PM »
Quote from: vbgamer45
Probably due the fact the table is not in utf8 format for ads
Good catch... this should probably be changed for those of us running 2.1. ;)

Code: [Select]
yabbse_admin_info_files utf8_general_ci
yabbse_ads   latin1_swedish_ci
yabbse_ads_settings   latin1_swedish_ci
yabbse_approval_queue   utf8_general_ci
yabbse_attachments   utf8_general_ci
yabbse_background_tasks utf8_general_ci
yabbse_ban_groups   utf8_general_ci

EDIT: I ended up manually putting the code into the DB. Would like to see this resolved, though. :)
« Last Edit: July 06, 2021, 07:27:19 PM by Douglas »
Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* Sports Photographer and Media Personality
* CFB Historian
* Tech Admin for one 1M+ post, one 2M+ post and one 10M+ post sites (last two are powered by multiple servers)
* WordPress Developer (Junkie)

Offline vbgamer45

  • Customizer
  • SMF Super Hero
  • *
  • Posts: 23,608
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: Ad Management mod
« Reply #7992 on: July 06, 2021, 10:12:50 PM »
Yeah I probably should make it standard for all mods now
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro