IPB -> SMF converter

[didou]

Hi

I use the converter IPB 1.3 -> SMF 1.0.6, (then conversion 1.0.6 -> 1.1rc2)

1) I think I have found some bugs if converter IPB1.3 : is it the good place to post proposition of patch ?

2) Will a converter IPB1.3 -> future SMF 1.1 be disponible at the same time of SMF 1.1 or it will arrive later or a double conversion IPB 1.3 -> SMF 1.0.6 then SMF 1.0.6 -> SMF 1.1 will be the solution for me

[Aaron]

1) I think I have found some bugs if converter IPB1.3 : is it the good place to post proposition of patch ?

Yes it is.

2) Will a converter IPB1.3 -> future SMF 1.1 be disponible at the same time of SMF 1.1 or it will arrive later or a double conversion IPB 1.3 -> SMF 1.0.6 then SMF 1.0.6 -> SMF 1.1 will be the solution for me

Actually, it already is. Have a look at this topic.

[didou]

patch I have to do on "invision_to_smf.php"

1) the converter add space in some field that is used as set in SMF, correction ', ' => ',' twice

Code Select Expand


***************
*** 1817,1823 ****
                                        // update the board with allowed groups - appears twice in case board is hidden...
makes sense to me :)
                                        mysql_query("
                                                UPDATE {$to_prefix}boards
!                                               SET memberGroups = '" . implode(', ', $affectedGroups) . "'
                                                WHERE ID_BOARD = $row[ID_BOARD]");
                                }
                        }
--- 1824,1830 ----
                                        // update the board with allowed groups - appears twice in case board is hidden...
makes sense to me :)
                                        mysql_query("
                                                UPDATE {$to_prefix}boards
!                                               SET memberGroups = '" . implode(',', $affectedGroups) . "'
                                                WHERE ID_BOARD = $row[ID_BOARD]");
                                }
                        }
****************
*** 1834,1840 ****
                                        // update the board with allowed groups - appears twice in case board is hidden...
makes sense to me :)
                                        mysql_query("
                                                UPDATE {$to_prefix}boards
!                                               SET memberGroups = '" . implode(', ', $affectedGroups) . "'
                                                WHERE ID_BOARD = $row[ID_BOARD]");
                                }
                                else
--- 1841,1847 ----
                                        // update the board with allowed groups - appears twice in case board is hidden...
makes sense to me :)
                                        mysql_query("
                                                UPDATE {$to_prefix}boards
!                                               SET memberGroups = '" . implode(',', $affectedGroups) . "'
                                                WHERE ID_BOARD = $row[ID_BOARD]");
                                }
                                else
*


2) Size conversion is incorrect : in IPB the size "3pt" is converted as "size=3"

=> three times I replace  '[size=$1]$2[/size]' by "$2" in the code (I prefer have no resize than bad resize )

3) to find the first message of a topic the procedure use the "ibf_new_topic" field. But in some case the first topic has not this flag setted ! (I suppose that's a large topic that has been splitted in the past ).

My solution is to not use this flag and to search first topic :

Code Select Expand


***************
*** 686,696 ****
                FROM {$from_prefix}topics");
        while ($row = mysql_fetch_assoc($result))
        {
                $result2 = mysql_query("
                        SELECT pid
                        FROM {$from_prefix}posts
                        WHERE topic_id = $row[tid]
!                               AND new_topic = 1
                        LIMIT 1");
                list ($first_msg) = mysql_fetch_row($result2);
 
--- 686,702 ----
                FROM {$from_prefix}topics");
        while ($row = mysql_fetch_assoc($result))
        {
                $result2 = mysql_query("
                        SELECT pid
                        FROM {$from_prefix}posts
                        WHERE topic_id = $row[tid]
!                       ORDER BY pid
                        LIMIT 1");
                list ($first_msg) = mysql_fetch_row($result2);



4) that's all => now I will try the converter to SMF 1.1, thanks for the link

[didou]

The points (1) and (2) are also in the converter IPB -> 1.1rc2