News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

Email notifications bug?

Started by Douglas, March 23, 2004, 10:33:44 AM

Previous topic - Next topic

Douglas

Okay, I've done EVERYTHING that I can for troubleshooting this one... and it almost always seems to happen when a forum software upgrade happens...

Folks aren't able to receive email notification of replies to threads.

http://frugalfriends.fractured.net/forums/index.php/topic,26899.0
Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* Sports Photographer and Media Personality
* CFB Historian
* Tech Admin for one 1M+ post, one 2M+ post and one 10M+ post sites (last two are powered by multiple servers)
* WordPress Developer (Junkie / Guru / Maven / whatever)

Owdy

Former Lead Support Specialist

Tarvitsetko apua SMF foorumisi kanssa? Otan työtehtäviä vastaan, lue:http://www.simplemachines.org/community/index.php?topic=375918.0

Douglas

Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* Sports Photographer and Media Personality
* CFB Historian
* Tech Admin for one 1M+ post, one 2M+ post and one 10M+ post sites (last two are powered by multiple servers)
* WordPress Developer (Junkie / Guru / Maven / whatever)

Owdy

Former Lead Support Specialist

Tarvitsetko apua SMF foorumisi kanssa? Otan työtehtäviä vastaan, lue:http://www.simplemachines.org/community/index.php?topic=375918.0

[Unknown]

Sources/Post.php, find:
// Find all the members who have notify on.

Replace:
log_error('Sending an announcement. ' . $board);
// Find all the members who have notify on.


Find:
// Find the members with notification on for this topic.

Replace:
log_error('Sending topic notifications. ' . $topic);
// Find the members with notification on for this topic.


Find: (in notifyUsersTopic()...)
if (!in_array(0, $allowed) && !in_array($rowmember['ID_GROUP'], $allowed) && count(array_intersect($allowed, explode(',', $rowmember['additionalGroups']))) == 0)
continue;


Replace:
if (!in_array(0, $allowed) && !in_array($rowmember['ID_GROUP'], $allowed) && count(array_intersect($allowed, explode(',', $rowmember['additionalGroups']))) == 0)
{
log_error('Skipping notification on ' . $topic . ' for ' . $rowmember['emailAddress'] . ' due to no access.');
continue;
}


Find:
// Find the members with notification on for this board.

Replace:
log_error('Sending board notifications. ' . $board);
// Find the members with notification on for this board.


And see what shows in the error log...

-[Unknown]

indio

error log     

http://www.../index.php?action=post2 
   Sending topic notifications. 708 

[Unknown]

So it skipped no one... try finding:
// Censor...

Replace:
log_error('Sending ' . $topic . ' to ' . $rowmember['emailAddress']);
// Censor...


-[Unknown]

indio

what¿

// Censor...
      censorText($_POST['subject']);
      $send_subject = $txt[127] . ': ' . $_POST['subject'];


or


// Censor...
      censorText($_POST['subject']);
      $send_subject = sprintf($txt['notify_boards_subject'], $_POST['subject']);


[Unknown]


indio

error log:

http://www..../index.php?action=post2;start=24;board=14 
   Sending topic notifications. 708 

http://www..../index.php?action=post2;start=24;board=14 
   Sending 708 to [email protected] 

http://www..../index.php?action=post2;start=24;board=14 
   Sending 708 to [email protected] 


[Unknown]

So, then, I assume it's working properly?

-[Unknown]

indio

i think yes, i recived email, but...

it leaves a message error.
it will leave whenever an email is sent?



[Unknown]

Quote from: indio on March 23, 2004, 05:11:02 PM
i think yes, i recived email, but...

it leaves a message error.
it will leave whenever an email is sent?

Well, Douglas was having problems with people receiving notifications.  I have no idea what you're talking about.

-[Unknown]

indio

sorry, I understood bad, my English is very bad.
:(

Douglas

Nope, not working properly here...

Douglas    Today at 09:01:41pm 
24.XXX.XXX.XXX      05a4a1f87643e8aab4f6981e1aeed8cd 
http://frugalfriends.fractured.net/forums/index.php?action=post2 
Skipping notification on 26899 for conure@******.net due to no access. 

Here's the thing.  Permissions shows that they do have access.  Admins are not having any problems, however, every one else is.
Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* Sports Photographer and Media Personality
* CFB Historian
* Tech Admin for one 1M+ post, one 2M+ post and one 10M+ post sites (last two are powered by multiple servers)
* WordPress Developer (Junkie / Guru / Maven / whatever)

[Unknown]

Sources/Post.php, find: (in notifyUsersTopic()...)
if (!in_array(0, $allowed) && !in_array($rowmember['ID_GROUP'], $allowed) && count(array_intersect($allowed, explode(',', $rowmember['additionalGroups']))) == 0)
{
log_error('Skipping notification on ' . $topic . ' for ' . $rowmember['emailAddress'] . ' due to no access.');
continue;
}


Replace:
if (!in_array(0, $allowed) && !in_array($rowmember['ID_GROUP'], $allowed) && count(array_intersect($allowed, explode(',', $rowmember['additionalGroups']))) == 0)
{
log_error('Skipping notification on ' . $topic . ' for ' . $rowmember['emailAddress'] . ' because they have access with ' . $rowmember['ID_GROUP'] . ' and ' . $rowmember['additionalGroups'] . ' but not to ' . implode(', ', $allowed) . '.');
continue;
}


And see what shows in the error log...

-[Unknown]

[Unknown]

 ! Notifications can now be sent by post group access too...

-[Unknown]

Martje

Hi :)
Quote! Notifications can now be sent by post group access too...

-[Unknown]
doe this mean it will be in the next beta?

I have similar problems. I changed all the code as described above. admins can post and everyone is getting a notification, but if one of my members post it  no one is getting a notification.

I have turned
QuoteNotify on Announcements
Sends an email to members when new topics are posted.
on on my boards.
and my members have

Quote
x Receive forum announcements and important notifications by email.
  Receive topics email notification ONLY in 1st unread reply.
x Turn notification on when you post or reply to a topic.
turned on in their profile

I thought this would be all but perhaps i am missing some ?

:) Would it be an idea to assign notification to a membergroup so that everyone you put in that membergroup gets a notification when someone of that membergroup post in whatever thread or board? or that you can add a member to a list in your profile so that if that member posts you get a notification... or do I make it much more complicated that it is? :P

thanks
maime

[Unknown]

It should be solved in the next beta.

-[Unknown]

Martje


Martje

Quote! Notifications can now be sent by post group access too...
where can I find this?

I installed beta 5 but I still have the same issues, should the email notification bug be gone?

thanks

[Unknown]

There may or may not still be problems, but now post group permissions take affect.

-[Unknown]

Martje

okay.... I guess  ;) but where can i find the post group permission?

thanks

[Unknown]

Meaning, if you don't allow all members, put say only "Hero" members to view the board, it wasn't working before - now it does.

-[Unknown]

Martje

 :) ahh now i understand it, sorry I am a bit slow on this sometimes :P, But I think I have still problems. but I install a fresh version to see if it does make the difference before I bug you again with questions  ;D

thanks

Advertisement: