Topic: SMF Trader System

[Xarcell]

Just ingore the error, it's because nothing is there yet I reckon.

Anyways, I got this working on SMF 1.1.

I need some help with some coding. In the display template, I only want the trader info to show up if it's in a certain board. Can you post a snippet for me so I can do this? I couldn't figure it out.

EX: the board ID is 43.

[Xarcell]

BTW, is there any chance you'll create an index for the trader system? That shows most feedback, most reviews, latest, that sorta thing?

Or post the code and I'll try to do it.

[klaus3]

How about some importers? A lot of people are changing from punBB and phpBB forums but all importers don't care about the trade rating mods date.

[vbgamer45]

I would need to get a database dump of the other trader mods and see if I could convert. That is some work though.

[Ben_S]

Regarding the division by zero errors, you want to do something like

Code: [Select]

<tr><td><b>' . $txt['smftrader_positivefeedbackpercent']  . '</b></td><td><b>' , $tradecount != 0 ? round(($pcount / $tradecount) * 100, 2) : 0 , '%</b></td></tr>
instead of

Code: [Select]

<tr><td><b>' . $txt['smftrader_positivefeedbackpercent']  . '</b></td><td><b>' .  round(($pcount / $tradecount) * 100, 2) . '%</b></td></tr>
Also not sure if there was a reason for using memberName in places, I personally think it's better to use realName.

[vbgamer45]

Regarding the division by zero errors, you want to do something like

Code: [Select]

<tr><td><b>' . $txt['smftrader_positivefeedbackpercent']  . '</b></td><td><b>' , $tradecount != 0 ? round(($pcount / $tradecount) * 100, 2) : 0 , '%</b></td></tr>
instead of

Code: [Select]

<tr><td><b>' . $txt['smftrader_positivefeedbackpercent']  . '</b></td><td><b>' .  round(($pcount / $tradecount) * 100, 2) . '%</b></td></tr>
Also not sure if there was a reason for using memberName in places, I personally think it's better to use realName.

SMF Trader updated with the above fixes.

[nay27uk]

SMF Trader System 1.1   mod, wher exactly do you sell or buy i cant find it, i am asuming you can because when you try to leave feedback for someone it askes wher you the SELLER, BUYER so wher do you put your advertisment

[vbgamer45]

You would sell a product/service/ or goods in a forum.

Buyers and sellers then rate each other via their profiles.
Under each post it lists a users trading count.

[Greek]

Good idea, but I think that this system is quite poor. It's more "cosmetic".
At this moment it looks more like karma.
I believe that it should be more "official". What I mean?
A tab in main index, with some categories like "For sale" and "Wanted", "Top sallers" and "Top buyers" and more...
Stronger control on feedbacks and generally in whole system, and some restrictions to who can post in this table (perhaps based on minimum number post in forum, or on various options)
Less important, but it doesn't seems good to appears the trade label right after the member's legend in mini profile. If a member doesn't have any relation with trades, doesn't need the label and it should have the option to deactivate it from his mini profile.
Just my opinion.
I want to believe that my poor english is understood 

[Kidsphoenixx]

I have just read through all 4 pages of this thread, and don't see anyone with my problem.
I installed this mod ( and a few others) before I fully understood SMF ( I still don't fully understand it, but I'm learning ).
I wanted to uninstall this mod until such time as I really need it....however, when I go to "Installed Pakcages", and click on uninstall it, I get this message:

This package cannot be uninstalled, because there is no uninstaller!

Please contact the mod author for more information.

Can anyone help me with this please? I don't want to just delete it cos I've read how doing that often causes problems.
Is there a "general" way to uninstall mods that come with NO uninstaller?
Thanks in advance.

[vbgamer45]

Download the mod from your packages area.
Check out the package-info.xml
It should be something like this

Code: [Select]

<?xml version="1.0"?>
<!DOCTYPE package-info SYSTEM "http://www.simplemachines.org/xml/package-info">

<package-info xmlns="http://www.simplemachines.org/xml/package-info" xmlns:smf="http://www.simplemachines.org/">
<id>vbgamer45:SMFTraderSystem</id>
<name>SMF Trader System</name>
<type>modification</type>
<version>1.0.1</version>
<install for="1.1.1,1.1,1.1 RC3,1.1 RC2">
<readme>ReadMe.txt</readme>
<modification type="file">smftrader.xml</modification>
<require-file name="Trader.php" destination="$sourcedir" />
<require-file name="trader.template.php" destination="$themedir" />
<code>smftraderinstall.php</code>

</install>
<uninstall for="1.1.1,1.1,1.1 RC3,1.1 RC2">
<modification type="file" reverse="true">smftrader.xml</modification>
</uninstall>
<install for="1.0.7,1.0.8,1.0.9,1.0.10">
<readme>ReadMe.txt</readme>
<modification type="file">smftrader107.xml</modification>
<require-file name="Trader.php" destination="$sourcedir" />
<require-file name="trader.template.php" destination="$themedir" />
<code>smftraderinstall.php</code>

</install>
<uninstall for="1.0.7,1.0.8,1.0.9,1.0.10">
<modification type="file" reverse="true">smftrader107.xml</modification>
</uninstall>
</package-info>
Update the file and rezip the package and place it in your packages folder and it should unstiall then.

[choloman05]

I just wanted to say that the mod is a great idea. Thanks for doing it. But I think I have the same request as everyone else - for some kind of admin/mod control over the ratings- to be submitted to them before being finalized. If I knew code, I'd look into it. sorry.

[RoarinRow]

Thank you for this modification     The only thing I did differently was move the 'Trade Count' number below the post count and unbolded the text. 

[vbgamer45]

Looks good there too.

[RoarinRow]

Looks good there too.

Yup, blends in with the post count   

[WebWorm]

Had this installed before the 1.1.1 upgrade wiped it out...I uninstalled the previous version, but when I try to install the system again, I get this message:

Error in Package Installation
At least one error was encountered during a test installation of this package. It is strongly recommended that you do not continue with installation unless you know what you are doing, and have made a backup very recently. This error may be caused by a conflict between the package you're trying to install and another package you have already installed, an error in the package, a package which requires another package that you don't have installed yet, or a package designed for another version of SMF.

Under that, I get:

Installations actions for "SMF Trader System":
Installing this package will perform the following actions:
   Type    Action    Description
1.    Execute Modification    ./Themes/default/languages/Modifications.english.php    Test successful
2.    Execute Modification    ./Themes/default/Profile.template.php                          Test successful
3.    Execute Modification    ./Themes/default/Display.template.php                         Test failed
4.    Execute Modification    ./index.php                                                            Test successful
5.    Execute Modification    ./Sources/ManagePermissions.php                          Test successful
6.    Extract File    ./Sources/Trader.php    
7.    Extract File    ./Themes/default/trader.template.php    
8.    Execute Code    smftraderinstall.php

If I just go into the Display.template.php file and manually include the code that needs to go there (per the XML file info), would I be safe proceeding?

[vbgamer45]

Had this installed before the 1.1.1 upgrade wiped it out...I uninstalled the previous version, but when I try to install the system again, I get this message:

Error in Package Installation
At least one error was encountered during a test installation of this package. It is strongly recommended that you do not continue with installation unless you know what you are doing, and have made a backup very recently. This error may be caused by a conflict between the package you're trying to install and another package you have already installed, an error in the package, a package which requires another package that you don't have installed yet, or a package designed for another version of SMF.

Under that, I get:

Installations actions for "SMF Trader System":
Installing this package will perform the following actions:
   Type    Action    Description
1.    Execute Modification    ./Themes/default/languages/Modifications.english.php    Test successful
2.    Execute Modification    ./Themes/default/Profile.template.php                          Test successful
3.    Execute Modification    ./Themes/default/Display.template.php                         Test failed
4.    Execute Modification    ./index.php                                                            Test successful
5.    Execute Modification    ./Sources/ManagePermissions.php                          Test successful
6.    Extract File    ./Sources/Trader.php    
7.    Extract File    ./Themes/default/trader.template.php    
8.    Execute Code    smftraderinstall.php

If I just go into the Display.template.php file and manually include the code that needs to go there (per the XML file info), would I be safe proceeding?

Yes you would.

[WebWorm]

Thanks vbgamer, I appreciate knowing I won't kill something today. 

[Cyberclone]

Hello vbgamer45

Thanks for your great mod!
One Problem:

after klick on report feedback I have an error

Code: [Select]

Fatal error: Cannot redeclare preparsecode() (previously declared in /home/spocrati/public_html/smf/Sources/Subs-Post.php:158) in /home/spocrati/public_html/smf/Sources/Subs-Post.php on line 158Do you have a solution?

Here the german language part:

Code: [Select]

<file name="$languagedir/Modifications.german.php">
<operation>
<search position="after"><![CDATA[
?>]]></search>
<add><![CDATA[
//Begin SMF Trader System Text Strings
$txt['smftrader_title'] = 'SMF Handelssystem';
$txt['smftrader_version'] = '1.0';
//Display text strings
$txt['smftrader_profile'] = 'Anzahl Gesch&auml;fte: ';
//Profile text strings
$txt['smftrader_submitfeedback'] = 'Abgeben eines Feedbacks f&uuml;r ';
$txt['smftrader_totalfeedback'] = 'Verh&auml;ltnis (+/-): ';
$txt['smftrader_positivefeedbackpercent'] = 'Positive Feedbacks: ';
$txt['smftrader_positivefeedback'] = '<span style="color: #006400;">Positive Feedbacks: </span>';
$txt['smftrader_neutralfeedback'] = 'Neutrale Feedbacks: ';
$txt['smftrader_negativefeedback'] = '<span style="color: #FF0000;">Negative Feedbacks: </span>';
//Start trader.template

//Submit Transaction Rating
$txt['smftrader_whoareu'] = 'Du bist:';
$txt['smftrader_buyer'] = 'K&auml;ufer';
$txt['smftrader_seller'] = 'Verk&auml;ufer';
$txt['smftrader_trade'] = 'Gesch&auml;ft';


$txt['smftrader_transaction'] = 'Bewertung des Handels:';
$txt['smftrader_positive'] = 'Positiv';
$txt['smftrader_neutral'] = 'Neutral';
$txt['smftrader_negative'] = 'Negativ';

$txt['smftrader_shortcomment'] = 'Kurzer Kommentar zum abgewickelten Gesch&auml;ft:';
$txt['smftrader_shortcommentnote'] = 'Max: 100 Zeichen';
$txt['smftrader_topicurl'] = 'URL des Topics: ';
$txt['smftrader_longcomment'] = 'Langer Kommentar zum abgewickelten Gesch&auml;ft:';


//Rating Overview
$txt['smftrader_allfeedback'] = 'Zeige alle Feedbacks';
$txt['smftrader_sellerfeedback'] = 'Zeige Feedbacks als K&auml;ufer';
$txt['smftrader_buyerfeedback'] = 'Zeige Feedback als Verk&auml;ufer';
$txt['smftrader_tradefeedback'] = 'Zeige Feedback zu den abgewickelten Gesch&auml;ften';

//Page Titles
$txt['smftrader_feedbacktitle'] = 'SMF Handelssystem - Uebersicht ';
$txt['smftrader_submittitle'] = 'SMF Handelssystem - Feedback absenden';
$txt['smftrader_reporttitle'] = 'SMF Handelssystem - Falsches Feedback melden';


$txt['smftrader_contact'] = 'Kontakt';
$txt['smftrader_viewprofile'] = 'Zeige das Profil';
$txt['smftrader_sendpm'] = 'Sende dem Benutzer eine PM';
//End trader.template

//Permissions
$txt['permissiongroup_smftrader'] = 'SMF Handelssystem';
$txt['permissionname_smftrader_feedback'] = 'Feedback abgeben zulassen';
$txt['permissionhelp_smftrader_feedback'] = 'User das abgeben eines Feedbacks erlauben';
$txt['permissionname_smftrader_deletefeed'] = 'Feedback L&ouml;schen zulassen';
$txt['permissionhelp_smftrader_deletefeed'] = 'User d&uuml;rfen Feedbacks l&ouml;schen';
$txt['cannot_smftrader_feedback'] = 'Du hast kein Recht ein Feedback abzugeben';
$txt['cannot_smftrader_deletefeed'] = 'Du hast kein Recht ein Feedback zu l&ouml;schen';

//END SMF Trader System Text Strings
]]></add>
</operation>
</file>

[Shonick]

how can I allow only member with 5 post can five feeback?If any member can five feeback then there will be spam on feeback.they can creat a nother account and give themselve good feeback