SMF Discussbot 4.1 final + Orstio 1.1.5 Bridge + Joomla 1.0.10 + SMF 1.1 RC2

[skydig]

I tried to install the SMF Discussbot discussed here :
http://www.simplemachines.org/community/index.php?topic=58578.0

but was unable to make it work.

So I decided to try to modify the code and you can download my mod at the end of this post.

It runs under Joomla 1.0.10 with SEO off (not tested with SEO on).

Be careful ! For forum languages others than English (using special characters), you have to edit the forum section names directly inside of your SMF database (with phpmyadmin) and replace the special characters by the corresponding html entity code (since SMF does not convert them itself). If you do not, the discussbot will not be able to find your forum sections.

Please leave any comment !

[Removed, because I am rude]

[Kindred]

Skydig...

It is extremely impolite to distribute a modified version of someone else's code without first getting permission from the original author.

indicating which lines to be changed is generally acceptable, as is sending your modifications to the author...   but posting a message that essentially says "use my version, not his" is rude.

[skydig]

Does "Open Source" say something to you ?

[Kindred]

neither SMF nor the bridge is actually Open Source please re-read your license agreement.

And even with Open Source, it is STILL polite to get permission before "releasing" a fileset that is just a modified version of someone else's work

[skydig]

I did not modify any of SMF nor the bridge, I modified the discussbot which is obviously "open source", as stated in the file header. For your information, the discussbot is a Joomla! mambot.

I agree that it is kind to inform the author of the software of the modifications, which I will do as soon as possible, if the users give me positive feedback about the modifications (I don't know if the modified version will work on other systems).

My point here was to share rapidly a "maybe" solution with, what seems to be, a lot of users trying to use the mambot with the latest release of Joomla.

Finally, I would have appreciated that you get more aware of the situation before blaming me of modifying an open source project. 

[Kindred]

Skydig...

What I originally said was:

It is extremely impolite to distribute a modified version of someone else's code without first getting permission from the original author.

Which is true of ANY software... as you seem to agree... and yet you are doing just that.

[skydig]

I do not agree to get permission first to modify and/or distribute an open source file since this authorization is already granted by the GNU/GPL terms which you can read here if you don't know them :

http://www.gnu.org/copyleft/gpl.html [nofollow]

If you find it impolite, this is you, but then request for a change in the GNU/GPL terms...

[Kindred]

oh please!   I did not say anything about being illegal.  I said it was IMPOLITE...    which it is. being polite has very little to do with legalese...


(just FYI: while it does not apply in this case, be aware that making a module or component for mambo/joomla does not automatically make it Open Source, there are plenty of modules that are not anything of the sort. Also be aware that the "openness" of a source may be changed at any time with a new release. Just because v4.1 is open source, does not automatically make v4.2 the same)

[Orstio]

I'm sure if you contact Chadness, he wouldn't have any problem with it.

The discussbot has definitely been around the block already:  It was something I modified from Two Shoes Mambo Factory's discussbot for SimpleBoard, (which I did contact them about, but never received a reply), and then was modified by two or three others before Chadness started on it.

Chadness's 4.1 bot hardly even looks like the original discussbot from which it originated.

Chadness is currently a moderator at http://forum.joomla.org .  I'm not certain he still has the time required to continue to update the bot.

[Kindred]

which was my original point...

I don't think Chadness would care that you modify it...   but it is usually polite to check with the author before going around and re-distributing the modified version.   Which is all that I said, in the first place...

[Benson]

Umh the discussbot is distributed under the GNU/GPL licence, so if you modify and redistribute it, you only have to make sure you're still distributing it under the GPL - i don't get why skydig is now blamed for not asking permission... at least skydig is doing something for the community, while the original bot wasn't updated since a long time even it was said again and again that it isn't working. All you can ask him to do is to contact the developer, maybe he's interested in integrating your code.


I will have a look at the code to see what was changed and test it - anyways thanks for your work!

cheers,
Benson

[ckacey]

[Removed, because I am rude]

I'd like to give it a try

[chr!x]

So skydig, could you explain what you modify to make it running 

[skydig]

Here is the link again :

http://skydig.free.fr/smf.discussbot.4.1mod.by.skydig.zip [nofollow]

I just edited the following lines:

line #32

Code Select Expand

require_once ($smf_path."/SSI.php");

to:

Code Select Expand

// Get the configuration.  This will tell Mambo where SMF is, and some integration settings
$database->setQuery("
SELECT `variable`, `value1`
FROM #__smf_config
");
$variables = $database->loadAssocList();

foreach ($variables as $variable){
$variable_name = $variable['variable'];
$$variable_name = $variable['value1'];
}

if (!defined('SMF'))
{
require($smf_path . '/SSI.php');
}

This modification corrects the "SSI.php not found" problem when loading joomla's frontpage.

lines #42, 160 and 162

Code Select Expand

($mosConfig_sef ? "" : $mosConfig_live_site."/").sefRelToAbs

to:

Code Select Expand

sefRelToAbs

This modification prevents the "http://www.yoursite.url/" from being prepended to the well formed link (which ended up in a 404 not found error when trying to click on the "discuss" link).
Again, this modification may not work on other systems or with SEO turned on, as I only tested it on my website.

Thanks for you comments !

I would be glad if my mod worked to send it to the author so that he can include it in an official release (this is the way I see it : the author is the only one who can approve my modifications, since he knows his code more than I do...)

[chr!x]

Great Job man ! 

It's correct all errors !

PS : I'm running Joomla FR 1.0.10 + Bridge SMF Ortisio 1.1.5 + SMF 1.1 RC2 + SMF DiscussBot 4.1 final

[iqapps]

Hi

Working like charm....

Regards
IQAPPS

[ckacey]

the error I'm getting is:
Database Error: Table 'hydspafk_j.smf_sessions' doesn't exist
File: /home/hydspafk/public_html/forum/Sources/Load.php
Line: 1909

[CarefreeSadie]

Thank-you.  This worked perfectly!
Thank-you again.

[Orstio]

the error I'm getting is:
Database Error: Table 'hydspafk_j.smf_sessions' doesn't exist
File: /home/hydspafk/public_html/forum/Sources/Load.php
Line: 1909

That usually means you need to add this to the bottom of your Joomla template:

Code Select Expand

<?php mysql_select_db($GLOBALS['db_name']); ?>

[Orstio]

Very good work, Skydig.  I now have this running on Mambo 4.5.4.  (Just had to remember to edit the params)