Quick Modify Freezing

[twostars]

After the upgrade to SMF 1.1.1 from 1.1RC3 I had many problems. Most of the noticeable ones have been fixed, but I've just noticed a problem with the Quick Reply button.
You click it, and it just sits there with the green text at the top of the screen. It does nothing...

I'm wondering what I should do. Where that script is located is probably good to know, as I might be able to fix it myself, but if somsone knows what I should do, that'd be even better.

Thanks guys. 

[SleePy]

Make sure everything got uploaded correctly if you are having problems.

For Quick Edit I would make sure Display.template.php, script.js, and xml_topic.js are correctly uploaded.

[twostars]

All are correctly uploaded. In IE I get an error message:

'getElementsByTagName(...).0' is null or not an object

[SleePy]

Are you using a custom theme? Make sure that theme is compatible for 1.1.1

[twostars]

Are you using a custom theme? Make sure that theme is compatible for 1.1.1

Dilber MC. I'm using the latest one, which is supposed to support 1.1.1 =\

[SleePy]

Does it work correctly on Default theme?

[twostars]

Does it work correctly on Default theme?

No. Same thing.

[H]

Try re-uploading all javascript files to the themes directory(s)

You can also try a hard refresh (Ctrl + F5) incase an old js file is still in your cache

[pheadrus]

Same problem here for SMF 1.1.1 and Amber Theme (default theme is also not working)...

Firefox Error Console gives me such errors:
1.Error: xml declaration not at start of external entity
Source File: http://www.gunduzgece.com/index.php?action=quotefast;quote=125204;sesc=(bla bla bla);xml
Line: 3, Column: 1
Source Code:
<?xml version="1.0" encoding="iso-8859-9"?>^

2.Error: XMLDoc.getElementsByTagName("quote")[0] has no properties
Source File: http://www.gunduzgece.com/Themes/default/xml_topic.js
Line: 29

Already tried re-uploading the js and display.template.php files...
Pls help, this error makes me nervous for two days...

[pheadrus]

Any idea would be helpful

[metallica48423]

hi, i am going through some older support topics, and came across this

Have you tried upgrading to 1.1.2?  I can say that i've experienced some problems with quick edit before, but i have been unable to pinpoint the reason.

Any mods installed at all?

[dlomneck]

I have this problem... seems to only effect IE though.  Works in firefox.

just get the green "loading" screen when I try to quick edit a post, and the error in JS says:

Line: 63
Char: 2
Error: 'getElementsByTagName(...).0' is null or not an object
Code:0

Thank you for any help you may be able to give.

Sincerely,

David

Edit
My server error log says this:

Database Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')
LIMIT 1' at line 8
File: D:\Inetpub\mysitenamehere\smf\Sources\Post.php
Line: 2038

Then clicking on it to view the error, I get this:

XML Parsing Error: junk after document element
Location: http://www.mysitenamehere.com/smf/index.php?action=quotefast;quote=3;sesc;modify;xml [nofollow]
Line Number 14, Column 1:

<div align="center" style="margin-top: 2ex;"><a href="javascript:history.go(-1)">Back</a></div>
^

Here's the code from those lines +10lines

Code Select Expand


$request = db_query("
SELECT IFNULL(mem.realName, m.posterName) AS posterName, m.posterTime, m.body, m.ID_TOPIC, m.subject, t.locked
FROM ({$db_prefix}messages AS m, {$db_prefix}boards AS b, {$db_prefix}topics AS t)
LEFT JOIN {$db_prefix}members AS mem ON (mem.ID_MEMBER = m.ID_MEMBER)
WHERE m.ID_MSG = " . (int) $_REQUEST['quote'] . "
AND b.ID_BOARD = m.ID_BOARD
AND t.ID_TOPIC = m.ID_TOPIC
AND $user_info[query_see_board]" . (!isset($_REQUEST['modify']) || (!empty($moderate_boards) && $moderate_boards[0] == 0) ? '' : '
AND (t.locked = 0' . (empty($moderate_boards) ? '' : ' OR b.ID_BOARD IN (' . implode(', ', $moderate_boards)) . ')' . ')') . "
LIMIT 1", __FILE__, __LINE__);
$context['close_window'] = mysql_num_rows($request) == 0;

$context['sub_template'] = 'quotefast';
if (mysql_num_rows($request) != 0)
{
$row = mysql_fetch_assoc($request);
mysql_free_result($request);

// Remove special formatting we don't want anymore.
$row['body'] = un_preparsecode($row['body']);


The line in question in the error is this one:

LIMIT 1", __FILE__, __LINE__);

Edit 2

Only mods I have are:
The only mods I have install are:
1.     Inline Attachments      1.0.4.2
2.    SMF Shoutbox    1.16
and I'm using smf 1.1.3

[dlomneck]

Well, when I make a person a member of the "moderator" group, then THAT person can quick edit their posts..  but regular users still can't. 


David

[dlomneck]

Nobody have a solution for this one?  If not, how the heck can I disable quick edit until you are able to get it working properly?  Thank

Dave

[greyknight17]

Backup your database and SMF files...

I want you to replace all your main SMF files. Before you do this though, uninstall all of your mods first. Download the Upgrade Package. Once you downloaded that zip file, open it up and delete upgrade.php and the two .sql files there. Close that zip file and upload it to your webhost. Unzip it via cPanel and it will overwrite all your SMF files. See if this resolves the issue.

[dlomneck]

Since this is a relatively new installation, I can wipe out the entire installation and do it all over again. Should I install the same package that I downloaded previously?

Also, no Cpanel, so I have to unzip the files then FTP them up.

Thanks

Dave

[greyknight17]

I would try testing out the mod on your computer locally (using a program like WAMP). If all works well, then install it live.

No cPanel? How about any control panel? This is really not a good thing if your host doesn't provide some kind of control panel for their members.

[dlomneck]

I use crystal tech, they give a control panel, but it doesn't have any unzipping capabilities...  I they have everything else though.  I'll do a fresh install without any mods, see if it works.  I'm fairly certain it didn't work before I installed my two mods.  From the tests I ran, looks like it was a problem with that code I mentioned above.  Will let you know in a few minutes.

David

[dlomneck]

Yes, still errors out when regular uses try to use quickedit.  when moderators or above use it, it works fine. 

It errors out when regular uses it on Firefox or on IE... the firefox error console says:

Error: junk after document element
Source File: http://www.mysitehere.com/forum/index.php?action=quotefast;quote=3;sesc=edb7da80071f76663a8e9f2c22f55fba;modify;xml [nofollow]
Line: 14, Column: 1
Source Code:
<div align="center" style="margin-top: 2ex;"><a href="javascript:history.go(-1)">Back</a></div>
^

and

Error: XMLDoc.getElementsByTagName("message")[0] has no properties
Source File: http://www.mysitehere.com/forum/Themes/default/xml_topic.js [nofollow]
Line: 62

when a regular user clicks on the "quick edit" button.

In IE, I get the same as above that I stated:

Line: 63
Char: 2
Error: 'getElementsByTagName(...).0' is null or not an object
Code:0

And the error log for the forum shows the same error as above:

Database Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')
LIMIT 1' at line 8
File: D:\Inetpub\mysitenamehere\smf\Sources\Post.php
Line: 2038

is there any other information you need from me to help fix this problem?

here's a thread i found with the exact same problem, no solution given there either:
http://www.simplemachines.org/community/index.php?topic=179908.new#new


David

[dlomneck]

Also, I tried it locally using wamp, and it still errors out.  This should make it extremely easy for you to reproduce the problem on your end and fix the bug.  Here's what you do.

Download the 1.1.3..
install it, create the admin account
register 1 regular user
make the user post in the default "welcome to smf" thread
then try to edit that thread with the quick edit.

That's it.  Don't tweak any settings or modify any code first.  Don't add any other usrs, and you should see, it just sticks that the greeen "loading" bar and you WILL get the errors I posted above.

David