loadTheme $context['browser'] -- no ie8?

[Angelina Belle]

I've got 1.1.9, as an upgrade from a clean 1.1.8 install (no mods at that point)

I noticed in loadTheme, where $context['browser'] is set, that the list does not include ie8.  Is this intentional? 

For ie8 users, $context['browser']['isie'] will also be incorrect.  I think this may cause a slight problem to simplePortal (sp_image_resize doesn't get called at the onload event, unless ie8 is run in compatability mode).

Is this a feature?  Or would it be a good idea to add an ie8 line in Load.php?

Thanks for the advice.

AB

[JBlaze]

See this:

IE 8 implementation

[JBlaze]

To implement IE8 Support modify Load.php

add

Code Select Expand

$context['browser']['is_ie8'] = strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE 8') !== false && !$context['browser']['is_opera'] && !$context['browser']['is_gecko'] && !$context['browser']['is_web_tv'];
before

Code Select Expand

$context['browser']['is_ie7'] = strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE 7') !== false && !$context['browser']['is_opera'] && !$context['browser']['is_gecko'] && !$context['browser']['is_web_tv'];

replace

Code Select Expand

$context['browser']['is_ie'] = $context['browser']['is_ie4'] || $context['browser']['is_ie5'] || $context['browser']['is_ie5.5'] || $context['browser']['is_ie6'] || $context['browser']['is_ie7'];
with

Code Select Expand

$context['browser']['is_ie'] = $context['browser']['is_ie4'] || $context['browser']['is_ie5'] || $context['browser']['is_ie5.5'] || $context['browser']['is_ie6'] || $context['browser']['is_ie7'] || $context['browser']['is_ie8'];

[karlbenson]

IE8, chrome, Safari4, Opera 10 were all released after 1.1 final and so are not fully detected.

Detection of these is built into 2.0 as standard.

[Angelina Belle]

Thanks for the tip!

[Snowy]

IE8, chrome, Safari4, Opera 10 were all released after 1.1 final and so are not fully detected.

Detection of these is built into 2.0 as standard.

Correct. I went to make the edits and they were already in my files. So... no change.