lists and smileys

[emanuele]

Using this code in SMF2 RC4 (SMF 1.1.12 is not affected):

Code Select Expand


[list]
[*] :)
[*] :P
[*] :(
[*] ::)
[/list]


the odd smileys are displayed as expected as images while the others only in text form.

• 
  
• 
  
• 
  
• 
  

And if the list contains an odd number of items:

• 
  
• 
  
• 
  
• 
  
• 
  

the problem affects also the smileys outside the list:

Here the odd are displayed as text probably due to the previous list:

• 
  
• 
  
• 
  
• 
  
• 
  

The sequence (odd/even) is restarted if a formatting code is used in one of the points of the list:

• 
  
• 
  
• some bold
  
• 
  
• 
  

[Brettflan]

I'd just like to confirm that it does happen on another RC4 forum, not just here. I haven't had time to look into it further, though.

[Darknico]

I confirm this bug in my forum with SMF 2.0 RC4...
With SMF 1.1.12 work correctly, this bug is only with SMF 2.0

[Bugo]

Try use normal list format:

Code Select Expand


[list]
[li]:)[/li]
[li]:P[/li]
[li]:([/li]
[li]::)[/li]
[/list]


• 
• 
• 
• 

[emanuele]

I would assume that if there is the possibility to use this syntax it should works (like it does for SMF 1).

BTW with the normal list posted by Bugo there seems to be a misalignment with Opera (see attached picture).

[Brettflan]

Another list example which demonstrates problems, probably related:

Code Select Expand

[list]
[0] aaa
[0] bbb
[0] ccc
[0] ddd
[/list]

• aaa
  
• bbb
  
• ccc
  
• ddd
  

Seems like it might be specifically with BBCode tags which don't require an end tag.

[emanuele]

I don't know if it is intended (and if it is worth another thread):

Code Select Expand


[list type=decimal]
[*] elem 1
[*] elem 2
[/list]

in SMF 1.1 render with numbers, in SMF 2 no.

• elem 1
  
• elem 2
  

[Aleksi "Lex" Kilpinen]

• elem 1
  
• Test
• elem 2
  
• Test

Seems like mixing them together ads strange results too

[emanuele]

Even funnier if you use this:

Code Select Expand


[list type=decimal]
[li] elem 1[/li]
[*] Test
[li] elem 2[/li]
[*] Test
[/list]


• elem 1

• Test
  
  • elem 2
• Test
  

That after "post" becomes:

Code Select Expand


[list type=decimal]
[li] elem 1[/li][/list]
[*] Test
[list][li] elem 2[/li][/list]
[*] Test
[/list]


[emanuele]

In Subs.php:

Code (find) Select Expand

if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", '>')))

Code (replace with) Select Expand

if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>')))

and

Code (find) Select Expand

$message = substr($message, 0, $pos2) . "\n" . (!empty($matches[0]) && substr($matches[0], -1) == '[' ? '[/li]' : '[/li][/list]') . "\n" . substr($message, $pos2);

Code (replace with) Select Expand

$message = substr($message, 0, $pos2) . (!empty($matches[0]) && substr($matches[0], -1) == '[' ? '[/li]' : '[/li][/list]') . substr($message, $pos2);

The first one should fix Brettflan's report, while the second should fix mine.

Problem is the fix for the problem I reported shouldn't break anything because is explicitly for item codes, while the one for Brettflan's bug affects any bbcode, so I'm not 100% sure is doesn't break anything else...if someone would help reviewing and testing them feel free...

[NekoJonez]

In Subs.php:

Code (find) Select Expand

if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", '>')))

Code (replace with) Select Expand

if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>')))

and

Code (find) Select Expand

$message = substr($message, 0, $pos2) . "\n" . (!empty($matches[0]) && substr($matches[0], -1) == '[' ? '[/li]' : '[/li][/list]') . "\n" . substr($message, $pos2);

Code (replace with) Select Expand

$message = substr($message, 0, $pos2) . (!empty($matches[0]) && substr($matches[0], -1) == '[' ? '[/li]' : '[/li][/list]') . substr($message, $pos2);

The first one should fix Brettflan's report, while the second should fix mine.

Problem is the fix for the problem I reported shouldn't break anything because is explicitly for item codes, while the one for Brettflan's bug affects any bbcode, so I'm not 100% sure is doesn't break anything else...if someone would help reviewing and testing them feel free...

Apologies for the bump of this topic but I can't find the first line in my Subs.php in 2.0.4

[emanuele]

Which one of the two first lines?

[NekoJonez]

The stuff above the "and" word

[emanuele]

Strange...maybe I was working on 2.1 and it's a bit different from 2.0? Or maybe you have some mod installed...
Anyway I'm not sure that part is totally safe to apply, it may create nasty problems with other tags, it should be investigated a bit more.

[NekoJonez]

Strange...maybe I was working on 2.1 and it's a bit different from 2.0? Or maybe you have some mod installed...
Anyway I'm not sure that part is totally safe to apply, it may create nasty problems with other tags, it should be investigated a bit more.

Well, I did a test and applied only the 2nd one.

The smileys are fixed and I'm not encountering any other probs.

[Arantor]

Included the patch into 2.1 since it seems to work without any side effects other than all the ones we already know about for the bbc parser. Thanks!