Advertisement:

Author Topic: table.table_grid td  (Read 5424 times)

Offline ahrasis

  • SMF Hero
  • ******
  • Posts: 4,921
  • Gender: Male
  • Busy mode is on.
    • ahrasis on GitHub
    • ahrasis on LinkedIn
    • ElkArte Malaysia
table.table_grid td
« on: December 04, 2010, 06:00:58 PM »
I am not sure whether this is a bug or not but even if it is, it is a minor one. I was playing with SMF css when I noticed this code has caused a creation of solid 1px border to the last part of the column in Message Index. It makes Message Index look nice in all earlier columns except the last one as at the same time it creates the said solid 1px border blank (white) space. Viewable in SMF too.  ;D

Code: [Select]
table.table_grid td
{
padding: 3px;
border-bottom: 1px solid #FFFFFF;
border-right: 1px solid #FFFFFF;
}

Offline Antechinus

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 24,136
  • Master of BBC Abuse
Re: table.table_grid td
« Reply #1 on: December 04, 2010, 07:13:49 PM »
Yeah I know. It's one of those things that is barely noticeable on the default theme. It may be more noticeable on custom themes depending on how they are styled. We decided it wasn't worth extra code to mess around with it in default. Dealing with it to the nth degree would require some annoying php.

Offline Joshua Dickerson

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 12,775
  • Gender: Male
    • joshuaadickerson on GitHub
    • joshuaadickerson on LinkedIn
Re: table.table_grid td
« Reply #2 on: July 05, 2011, 12:23:49 AM »
Ant: are we not going to fix this?
Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

Offline Antechinus

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 24,136
  • Master of BBC Abuse
Re: table.table_grid td
« Reply #3 on: July 05, 2011, 12:41:30 AM »
Oh I already did on my local host dev build. It's also been fixed in my Curve variants. I haven't got around to committing it to svn yet though. All it requires is a 1px right margin on th.last_th.

Of course I didn't think of this earlier, what with everything else that was going on, but it's easy to fix. :)
« Last Edit: July 05, 2011, 12:45:05 AM by Antechinus »

Offline Joshua Dickerson

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 12,775
  • Gender: Male
    • joshuaadickerson on GitHub
    • joshuaadickerson on LinkedIn
Re: table.table_grid td
« Reply #4 on: November 20, 2011, 01:07:53 PM »
Did you commit this yet?
Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

Offline Antechinus

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 24,136
  • Master of BBC Abuse
Re: table.table_grid td
« Reply #5 on: November 20, 2011, 03:37:22 PM »
It's in trunk but not in the 2.0 branch. Seems a bit trivial for a security patch. ;)