Advertisement:

Author Topic: It won't let me upload jpegs to the avatars, but lets me use PNGs  (Read 4430 times)

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 70,508
    • StoryBB/StoryBB on GitHub
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #20 on: April 25, 2013, 04:33:39 PM »
No, but it tells you it was fixed in the Github repository, and on what date, just go back through the repo and find the commits on that day and glance through them.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline butch2k

  • Full Member
  • ***
  • Posts: 416
  • Gender: Male
    • @butch2k on Twitter
    • Planète Roliste
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #21 on: April 25, 2013, 04:40:29 PM »
In Subs Graphics the check has been changed to remove cellTextIsHtml from matching.

Code: [Select]
// Check for potential infection
if (preg_match('~(iframe|(?<!cellTextIs)html|eval|body|script\W|[CF]WS[\x01-\x0C])~i', $prev_chunk . $cur_chunk) === 1)

Offline lurkalot

  • Sophist Member
  • *****
  • Posts: 1,214
  • Gender: Male
  • Tinyportal Support
    • guitaristguild on Facebook
    • Tinyportal on GitHub
    • @GuitaristGuild on Twitter
    • Guitarist Guild
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #22 on: April 25, 2013, 05:07:28 PM »
I'm not sure how you'd do that in PS, never having actually *used* it.

In PS, use the "Save for web" option, this will strip the EXIF data from your jpg's, if that's what you mean by "Extra rubbish"

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 70,508
    • StoryBB/StoryBB on GitHub
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #23 on: April 25, 2013, 05:09:26 PM »
That's not what I meant by extra rubbish. I consider EXIF information useful. I consider Adobe's proprietary extensions to the JFIF/JPEG format to be largely rubbish, however.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline butch2k

  • Full Member
  • ***
  • Posts: 416
  • Gender: Male
    • @butch2k on Twitter
    • Planète Roliste
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #24 on: April 25, 2013, 05:12:15 PM »
That's not what I meant by extra rubbish. I consider EXIF information useful. I consider Adobe's proprietary extensions to the JFIF/JPEG format to be largely rubbish, however.
Indeed... It's bloating images for no reason...

Trying "saving images for the web" rather than "save as" might do the trick though.

Offline lurkalot

  • Sophist Member
  • *****
  • Posts: 1,214
  • Gender: Male
  • Tinyportal Support
    • guitaristguild on Facebook
    • Tinyportal on GitHub
    • @GuitaristGuild on Twitter
    • Guitarist Guild
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #25 on: April 25, 2013, 05:14:00 PM »

That's not what I meant by extra rubbish. I consider EXIF information useful.


True, it is very useful when talking photos, but a pointless waste of space for a Avatar. ;)

Offline Kill Em All

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 8,144
  • Gender: Male
  • Something has to go wrong. Just has to.
    • KEAGaming
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #26 on: April 25, 2013, 05:19:50 PM »
Groovystar, in your Sources/sub-package.php. Find:
Code: [Select]
if ($file_info['compressed_size'] != $file_info['size'])

replace it with:
Code: [Select]
if (!empty($file_info['compress_method']) || ($file_info['compressed_size'] != $file_info['size']))
My Site: KEAGaming.com

Manual Installation of Mods
Prevent Spam and Forum Attacks
Please do not PM or email me for support unless offered, help should be publicly displayed to others.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 70,508
    • StoryBB/StoryBB on GitHub
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #27 on: April 25, 2013, 05:21:35 PM »
Um... how is that related? That's to do with unpacking gzipped data...
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Kill Em All

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 8,144
  • Gender: Male
  • Something has to go wrong. Just has to.
    • KEAGaming
My Site: KEAGaming.com

Manual Installation of Mods
Prevent Spam and Forum Attacks
Please do not PM or email me for support unless offered, help should be publicly displayed to others.

Offline lurkalot

  • Sophist Member
  • *****
  • Posts: 1,214
  • Gender: Male
  • Tinyportal Support
    • guitaristguild on Facebook
    • Tinyportal on GitHub
    • @GuitaristGuild on Twitter
    • Guitarist Guild
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #29 on: April 25, 2013, 05:36:32 PM »
No, I don't want to disable it. Our site has a lot to protect.

But why would it be barring ALL jpegs? Most are clean. This makes no sense. What I need to do is for it to only bar the Jpegs that are actually containing malware.

I'm guessing you got around this problem then? http://warriorcatsrpg.com/index.php?topic=490301.0

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 70,508
    • StoryBB/StoryBB on GitHub
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #30 on: April 25, 2013, 05:41:04 PM »
Part of the commit that:
https://github.com/SimpleMachines/SMF2.1/commit/43a398c88539fe5734886f6dd4da528c76668f54

Yup, it's the last item on the changelog: fixes bypassing deflate step during unzip. Unrelated to the second item on the changelog regarding cellTexIsHtml.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline wynnyelle

  • SMF Hero
  • ******
  • Posts: 2,569
    • Warrior Cats RPG
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #31 on: April 25, 2013, 11:53:13 PM »
Core, I think I didn't know that it hadn't been enabled until recently.
So uh...is there a way this can be fixed or do we just live with it? :P

Offline CoreISP

  • Server Admin
  • Server Team
  • SMF Super Hero
  • *
  • Posts: 17,668
  • Gender: Male
  • CoreISP.net
    • liroyvh on LinkedIn
    • @liroyvh on Twitter
    • CoreISP Corporation :: WebHosting, Dedicated Servers, and more!
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #32 on: April 26, 2013, 10:52:24 PM »
I'd say disable it and ensure the recode suspicious thingies thingy is on. :)
Seems to have worked fine for a long time that way. :)

Otherwise; probably indeed a "deal with it" for now.
- CoreISP.net Corporation -
  WebHosting, Colocation, Domain Registration & Network Services
- DedicatedBox.us Servers -
  Low priced Servers in a high-quality Network, the place for all your (advanced) server needs.
  We specialize in hosting big boards. Contact us!

((U + C + I)x(10 − S)) / 20xAx1 / (1 − sin(F / 10))
President/CEO of Simple Machines - Server Manager
Please do not PM for support - anything else is usually OK.

Offline wynnyelle

  • SMF Hero
  • ******
  • Posts: 2,569
    • Warrior Cats RPG
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #33 on: April 27, 2013, 11:16:05 AM »
Oh well. :P I guess so. Will this be corrected eventually?

Offline Kill Em All

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 8,144
  • Gender: Male
  • Something has to go wrong. Just has to.
    • KEAGaming
Re: It won't let me upload jpegs to the avatars, but lets me use PNGs
« Reply #34 on: April 27, 2013, 10:56:57 PM »
Yes, it is suppose to be corrected in 2.1. When that will be released... eh.
My Site: KEAGaming.com

Manual Installation of Mods
Prevent Spam and Forum Attacks
Please do not PM or email me for support unless offered, help should be publicly displayed to others.