Undefined variable: smf_version_1

[MESWEB]

I see this error in errol logs:

Code Select Expand

Undefined variable: smf_version_1

File: /Themes/default/languages/index.english.php (eval?)

[Arantor]

Can you at least quote the full error please?

[Kindred]

the full error... plus, please disable eval so that we can actually see the REAL error?

[Arantor]

Eh, with the full message it should be easy enough to find the error without worrying about turning off eval

[Kindred]

we're not all psychic code-whisperers like you

[Arantor]

Well, it's not actually that hard. The line number is, invariably, correct when supplied (assuming we're talking about a conventional undefined error) and after that the function name should also be correct, meaning the only question mark is to where that function is - and a simple find 'function functionname' in Notepad++ will give you that.

It's only more complex when you start dealing with parse errors in eval'd code because the line number it invariably gives you is the eval() call itself, e.g. all the errors we see in Load.php around line 2047 which is the eval() call on template code, in which case we're then looking at 'what was called to examine the line number thereafter'. Same sort of deal with create_function, too.

[MESWEB]

Sorry for my time. This is a full error message:

Code Select Expand

/index.php?pretty;action=admin&area=logs;c4d57f882=9b2477f037b2c6cba8d42fae4ca2abc1
8: Undefined variable: smf_version_1
File: /home/messiah/domains/obeznany.pl/public_html/Themes/default/languages/index.english.php (eval?)
Line: 477
There is lot of urls with error like:

Code Select Expand

/index.php?action=viewsmfile;filename=latest-news.js

Code Select Expand

/index.php?action=viewsmfile;filename=current-version.js

And more.

[Arantor]

Strange, there is no mention of smf_version_1 anywhere in the 2.0 source, which leads me to believe it's a mod.

OK, so try as Kindred says to turn off eval because something about your setup prevents even basic debugging.

[MESWEB]

All errors are going to one file:
Themes/default/languages/Modifications.english.php

[Arantor]

So what's in that file then? Especially line 477?

[MESWEB]

I found it. This error are from Cffp mod:

Code Select Expand

$txt['cffp_records'] = 'Records';
if (!$smf_version_1)
$txt['cffp_moderation_area'] = 'Groups of fields on posts';
else
$txt['cffp_moderation_area'] = 'Moderate groups of fields on posts';


[margarett]

That's so wrong...

[Arantor]

Ugh, that's wrong.

[MESWEB]

What i should to delete?

[margarett]

Well, a quick fix would be to use !empty
But language files should not have conditionals... The mod should define both independent strings and then perform the conditional on the code

[MESWEB]

How code should look like?

[margarett]

if (empty($smf_version_1))

[MESWEB]

if (empty($smf_version_1))

Many thanks this look like working.

[Kindred]

So, instead of actually correcting the code, you would rather just hack it further?

[margarett]

Well, it's up to the mod author to property fix it