Not receiving board message reply notifications

[adrianbj]

Thanks - you are right, I had misinterpreted the shortened description.

I guess I will make a request to have this option available.

Thanks,
Adrian

[Daniel Hofverberg]

Daniel, I'll test on my own site...

-edit-
Ok...  just tested. Daniel, please confirm this is the problem:
1- turn on notifications of new topics in a specific board (General Discussion)
2- turn on notification of new replies in a specific thread (test thread)
3- Someone posts a new topic in (General Discussion)
4- someone posts a new reply in (test thread)

You are saying that in this scenario 4 does not send a notification?

Assuming that the thread the reply was posted in was in the same board as you turned on notifications in, correct - I do not get that e-mail. But if someone replies on a thread I have subscribed to on a board that I do not subscribe to, then I do get the e-mail.

The same thing happens on this forum - on the "Svenska/norsk/dansk" board (the only board I have turned on notification of new topics in), I do not get any e-mails when someone replies on a thread that I have turned on notifications for. But for other boards, where I do not have notification of new topics enabled, I do get the e-mails.

But this have only started happening in 1.1 RC2. As far as I can recall, everything worked as it should in earlier versions.

[Kindred]

Adrian,

Glad we cleared that up. subumit it as a feature or mod request.


Ok, Daniel.  I did test this exact scenario (new reply in a subscribed topic thta is in a subscribed board)

It worked properly for me with RC2.
What other mods do you have installed?

[Daniel Hofverberg]

I have no mods installed - just a plain 1.1 RC2 installation (although upgraded from earlier versions).

And as I said, it's not just my forum - it's the same on this very site. Does it work fine for you here?

[Kindred]

you do know that you will not receive notifications of your own posts... and once you receive a notification, you won't get any more for a specific thread until you actually read that thread?

[Daniel Hofverberg]

Yes, of course I know that. But I don't get such notifications from other people's posts either, if it's on a board I have requested new topic notification on.

[Yonkey]

I've noticed this bug before as well.  Here is how I fixed it.

In Sources/Display.php look for:

// Only do this once, but mark the notifications as "not sent yet" for next time.
if (!empty($row['sent']) && $do_once)
{
db_query("
UPDATE {$db_prefix}log_notify
SET sent = 0
WHERE (ID_TOPIC = $topic OR ID_BOARD = $board)
AND ID_MEMBER = $ID_MEMBER
LIMIT 1", __FILE__, __LINE__);
$do_once = false;
}


and replace with:

// Only do this once, but mark the notifications as "not sent yet" for next time.
if (!empty($row['sent']) && $do_once)
{
db_query("
UPDATE {$db_prefix}log_notify
SET sent = 0
WHERE (ID_TOPIC = $topic OR ID_BOARD = $board)
AND ID_MEMBER = $ID_MEMBER
LIMIT 2", __FILE__, __LINE__);
$do_once = false;
}


Basically, the only difference is the line with the LIMIT.  It changes from 1 to 2.

The bug was as you described.  The forum only notifies people who have either new topic notification enabled or new reply notification.  When they request notification on both, the LIMIT 1 causes the forum to not update the correct entry in the database.

[Kindred]

as I said....   I tested this on a clean forum... it worked properly for me.

never-the-less, if it's broken for you, by all means, do this fix.

[Yonkey]

as I said....   I tested this on a clean forum... it worked properly for me.

never-the-less, if it's broken for you, by all means, do this fix.

It's a bit difficult to test, but this bug has been here for a while.  You'd need to request both board notification and topic notification on a topic within that board.  Since the database returns only the first notification entry found, the order that you requested the notifications may have an impact on whether you experience the bug or not.  Also, try requesting notifications on more than one topic within that board.

I also have "Receive reply notification only for the first unread reply." checked in my preferences, but adrianbj experienced this bug even with it unchecked.

[Kindred]

and as I nnoted... I specifically tested this scenario.

You keep referring to it as a bug, but I can not recreate it on a fresh install of SMF 1.1RC2.

[Yonkey]

Hmm.. I guess it doesn't exist in boards that have a fresh 1.1 RC2.  My board, has been through many upgrades so unfortunately I can't pinpoint the exact version that I first noticed this notification problem, but I'm pretty sure it has been there since 1.1 Beta 3 at least, and possibly 1.0.5.

[friesengeist]

and as I nnoted... I specifically tested this scenario.

You keep referring to it as a bug, but I can not recreate it on a fresh install of SMF 1.1RC2.

Hi Kindred, hi everyone,

I can confirm this is a bug on a fresh installation of SMF 1.1 RC2. Steps to replicate on a new installation:

1. Create a new user.
2. Subscribe this user to a board.
3. Subscribe this user to a topic within that board.
4. Have an other user reply to that topic. The new user will receive a mail.
5. Log in with the new user.
6. Visit the topic.
7. Have an other user reply to that topic. The new user will NOT receive a mail.

This only happens for users that have enabled the setting "Receive reply notification only for the first unread reply." in their profile. The proposed patch by Yonkey is absolutely valid to fix this bug.

Basically, the only difference is the line with the LIMIT.  It changes from 1 to 2.

The bug was as you described.  The forum only notifies people who have either new topic notification enabled or new reply notification.  When they request notification on both, the LIMIT 1 causes the forum to not update the correct entry in the database.

Just as a cross reference: http://www.simplemachines.org/community/index.php?topic=73092.0

Hope this helps

[Yonkey]

Thanks.  And yes, ever since I patched this code, I never experienced any problems with notifications ever again.

[Rupert Hawkes]

Fix does NOT work for me :-(

I have the following and made the fix as described above BUT STILL NOT GETTING REPLY NOTIFICATIONS!  PELASE HELP.

ticked - Receive forum announcements and important notifications by email.
unticked (tried ticked too) - Receive reply notification only for the first unread reply.
ticked - Turn notification on when you post or reply to a topic.
ticked - When sending notification of a reply to a topic, send the post in the email (but please don't reply to these emails.)

For topics and boards I've requested notification on, notify me of:  Replies and moderation

[jerm]

Please do not double post Rupert Hawkes.