Email notifications after Joomla 1.0.9 update

[phil_roy]

This is weird....my forum notifications have suddenly started going a bit odd. I've only done two things to the site in that time. First was discussed here...
http://www.simplemachines.org/community/index.php?topic=88399
...but I'm not sure it is relevant.

The other thing I did today was update to Joomla 1.0.9 (bridge 1.1.4 by the way and Open-sef 2 RC5-2). My forum notifications (it was a long weekend here so things were quiet) went from this example on Friday

A reply has been posted to a topic you are watching by Gimli.

View the reply at: http://www.nzmac.com/component/option,com_smf/Itemid,178/topic,2005.new/topicseen,topicseen#new

Unsubscribe to this topic by clicking here: ,"http://www.nzmac.com/component/option,com_smf/Itemid,178/action,notify/topic,2005.0/

More replies may be posted, but you won't receive any more notifications until you read the topic.

Regards,
The NZMac.com Forums Team.

to this today after applying the 1.0.9 Joomla update....

A reply has been posted to a topic you are watching by Philip Testing.

View the reply at:

View the reply at: http://www.nzmac.com/component/option,com_smf/Itemid,178/topic,2030.new/topicseen,topicseen"http://www.nzmac.com/component/option,com_smf/Itemid,178/action,notify/topic,2030.0/

More replies may be posted, but you won't receive any more notifications until you read the topic.

Regards,
The NZMac.com Forums Team.

OK...you can't see it here clearly but in an emaiil it comes out as one very odd long link with a single speechmark in the middle....and the part after the speechmark is the only thing clickable in the email, taking you to the site and asking if you want to disable notification.

I've tried reverting back to previous versions of Subs-Post.php and the Post.english.php files (as they seem to have something to do with notification) but that didn't resolve the issue at all.

This is weird!?

Phil

[phil_roy]

SMF 1.1 RC2 by the way.

Phil

[Orstio]

I've tried reverting back to previous versions of Subs-Post.php and the Post.english.php files (as they seem to have something to do with notification) but that didn't resolve the issue at all.

What do you mean by "reverting back"?  Why were those files modified?

[phil_roy]

Just Post.english.php...I'd changed the wording...So to make sure I hadn't stuffed up the files in any way (and I couldn't remember if I had altered subs-post.php, but was fairly sure I hadn't) I just uploaded fresh versions.

Phil

[Orstio]

Are there any other files you've modified?  With what did you modify them?

[phil_roy]

I use Dreamweaver...and before you say it, have never had an issue with any files I've altered with it 

In terms of files in SMF, yes I probably have altered some files, but mostly themes to get them more compliant (alt tags etc) and looking how I want. I don't believe I have altered any core files.

I havr two mods installed...
* Coar's Skype Mod      1.4
* SMF 1.0.7 / 1.1 RC2 Update    1.0

But as I say....it's all been working fine until after the weekend where I made the update for a dates issue (linked to in my first post) and then Joomla 1.0.9

Phil

[Orstio]

I use Dreamweaver...and before you say it, have never had an issue with any files I've altered with it 

Seigfreid and Roy never had an issue with any tigers, either....

I would say download a clean installation from the downloads page, and upload a clean Themes folder, and possibly a clean Sources folder as well.

[Kindred]

Dreamweaver DOES cause KNOWN issues when editting SMF php files!!!!

use a text editor, like UltraEdit, EditPlus or ConText

[phil_roy]

Seigfreid and Roy never had an issue with any tigers, either....

Very witty. I'll have a try with some of the files you suggest.

Kindred, I'm a Mac user...so I'm not sure those are available...I'll use TextEdit I guess.

Phil

[phil_roy]

I would say download a clean installation from the downloads page, and upload a clean Themes folder, and possibly a clean Sources folder as well.

Did both those things and it had no effect.

Very weird.

Phil

[Mongoose]

Same effect - disapearred string in e-mail message - on operafan.net after upgrading to 1.0.9.
But with RUSSIAN language files. In this case I think it is not language file problem.

[Orstio]

Did both those things and it had no effect.

Very weird.

Phil

Did you also use DreamWeaver to aleter smf.php for use with Joomla 1.0.9?

If so, can you post the contents of the integrate_outoging_email function in smf.php?

[phil_roy]

I did...but to save time I did two things just now....downloaded and installed a text editor for the Mac (TextWrangler). Downloaded the bridge again and applied the 1.0.9 fix needed with the editor and then uploaded the new smf.php file.....the result being the same. 

Phil

[Orstio]

Can you post the contents of the integrate_outgoing_email function?

[phil_roy]

OK sorry. I didn't because I started with a fresh file again...

function integrate_outgoing_email($subject, &$message, $headers)
{
   global $boardurl, $mosConfig_live_site, $Itemid, $scripturl, $mosConfig_sef, $modSettings;
   
   $message = str_replace ('&?', '&', $message);
   if (strpos($message, $scripturl) != 0)
   {
      $message = str_replace ($scripturl, '="' . $scripturl, $message);
      $message = un_htmlspecialchars(ob_mambofix($message));
      $message = str_replace ('="', '', $message);
      if ($mosConfig_sef == '1'){      
         $message = str_replace ($mosConfig_live_site . '/index.php', 'index.php', $message);
         preg_match ('~index\.php.+~', $message, $url);
         if (isset($url[0])){
            $new_url = sefReltoAbs(trim($url[0]));
            $new_url = str_replace(';', '/', $new_url);         
            $message = str_replace($url[0], $new_url, $message);
         }
      }
   }
}

Phil

[Orstio]

Can you find this code in Joomla's index.php?

Code Select Expand

$return = mosGetParam( $_REQUEST, 'return', NULL );
$message = mosGetParam( $_POST, 'message', 0 );
if ($option == 'login') {

[phil_roy]

Yes....lines136 to 140 or thereabouts

Code Select Expand

// frontend login & logout controls
$return = mosGetParam( $_REQUEST, 'return', NULL );
$message = mosGetParam( $_POST, 'message', 0 );
if ($option == 'login') {
$mainframe->login();If this is possibly a login issue I should mention that I still have an ongoing login issue that I just assumed was an issue with the bridge. Eeveryone registering, gets registered but a one line error comes up. Also, if you go to the CB area that I have, it often says you're not logged in and I advise users to imemdiately log out and log in again and that resolves the issue. Sorry if that is completely off-track, but since you seem to be asking about a line related to login.

Note also that I have heavily hacked the bridge login module to provide nothing more than a greeting for logged in users....but that's been working completely fine well before the 1.0.9 update (I did that hack with a text editor).

Phil

[Orstio]

It isn't really related to login;  It is related to how Joomla works with the variables it assumes are used only for login.  This issue was fixed in Mambo 4.5.3h, but never in Joomla.

Change that piece of code to this:

Code Select Expand

// frontend login & logout controls
if ($option == 'login') {
$return = mosGetParam( $_REQUEST, 'return', NULL );
$message = mosGetParam( $_POST, 'message', 0 );
$mainframe->login();

[jocke4u]

Dreamweaver DOES cause KNOWN issues when editting SMF php files!!!!

use a text editor, like UltraEdit, EditPlus or ConText

Or to my opinion, Eclipse + plugin PHPEclipse (+ subversion integration and more) VERY VERY GOOD.
Then as diff-tool I use Beyond Compare, also very good and cheep.

[Orstio]

Or to my opinion, Eclipse + plugin PHPEclipse (+ subversion integration and more) VERY VERY GOOD.

Agreed, but a bit of overkill for most people.