Bug...Duplicate email link in post, i am using 1.0.3....

[ryanbsoftware]

If you're not willing to listen to us when we tell you not to modify/overwrite the default theme

i see no problem with that it works fine on my other forum and i overridden the defualt theme, i don't see why thats such a big deal, it makes more sense to overrite it for mod install convience...

and you're not willing to test it with other themes

i did, i chose a random the, hotmail, i installed it and it only show one link, one of the reasons why i stated it must be the theme

I really don't see why you're bothering to ask us for support?

funny...i do....

Clearly you're too smart for us to help you.

thanks for the compliment, though its not entirely true....

[ryanbsoftware]

Clearly you're too smart for us to help you.

thanks for the compliment, though its not entirely true....

or is it?  i figured it out, the display.template.php file was redundant, it told it to show it twice for some odd reason, i just deleted the code for one of them....

[bloc]

i see no problem with that it works fine on my other forum and i overridden the defualt theme, i don't see why thats such a big deal, it makes more sense to overrite it for mod install convience...

It will be problems doing this way..the Apollo theme may look similar to default, but it isn't exactly the same. When a mod search it, it will be a 50/50 chance of success. If you do it manually, then its all the same, but then you loose out on upgrading...because SMF upgrade script overwrites default theme.

If its convenient to have a custom theme as default..why not disable members ability to choose their theme, set a custom as "forum default" , and just leave the default theme intact?

or is it?  i figured it out, the display.template.php file was redundant, it told it to show it twice for some odd reason, i just deleted the code for one of them....

If you could share what you did, it would be beneficial for me at least...

[ryanbsoftware]

i could install it as a custom theme and all but mods won't effect it without me manually inatlling them or modifying the .mod file....and its never caused me any prblems at all... 

[Gidget]

i figured it out, the display.template.php file was redundant, it told it to show it twice for some odd reason, i just deleted the code for one of them....

If you could share what you did, it would be beneficial for me at least...

Hi Bloc

As Ryan B discovered, this bit of code

Code Select Expand

// Don't show the email address if they want it hidden.
                                if (empty($message['member']['hide_email']))
                                        echo '
                                                                <a href="mailto:', $message['member']['email'], '">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/email_sm.gif" alt="' . $txt[69] . '" title="' . $txt[69] . '" border="0" />' : $txt[69]), '</a>';

appears twice (one after the other) in display.template.php.

Simply deleting one of the instances fixes up the problem of two email links appearing in a post.

Thanks to Ryan for the answer and to Bloc for the wonderful Apollo theme 

Cheers

Gidget

[bloc]

Thanks, Gidget, I will check and correct the mistake.