Joomla Mambo Tag Cleanup

[iqapps]

Hi

The mod had a problem with CSS, or you still have a problem with CSS? The mod won't clean up conflicts with CSS, it focuses on conflicts with alot of the tags that make your site not xhtml valid.

I know abouth this. Yes I still have problem with css. Working on that.
I fixed css intergtion between my Joolma css and SMF css before I install this mode but after I moved the Joomla template_css.css call and install your code I am back to begining.

P.S.

Your code can working on 7dana templates if you change third search and replace syntax
in default templates is

Code Select Expand

</body></html>';
in 7dana templates is

Code Select Expand

</body>
</html>';
Frist and second syntax is exact in both.

Regards
IQAPPS

[Goosemoose]

you can move the call to the templates css is the joomla templaye file to above or below the code you added. that will change which css file takes precedence

[iqapps]

Hi
I have error on my forum page in wrapped mode this error dont appear in "standalone" mode.
Changed this pice of code and error dont appears any more.
Error

Line:28 char:4 Object required

when I click to hide/show info on topmeny.
orginal code

Code Select Expand


// the routine for the info center upshrink
echo '
<script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
var current_header_ic = ', empty($options['collapse_header_ic']) ? 'false' : 'true', ';
function shrinkHeaderIC(mode)
{';

if ($context['user']['is_guest'])
echo '
document.cookie = "upshrinkIC=" + (mode ? 1 : 0);';
else
echo '
smf_setThemeOption("collapse_header_ic", mode ? 1 : 0, null, "', $context['session_id'], '");';

echo '
document.getElementById("upshrink_ic").src = smf_images_url + (mode ? "/expand.gif" : "/collapse.gif");
document.getElementById("upshrinkHeaderIC").style.display = mode ? "none" : "";
current_header_ic = mode;
}
// ]]></script>
';



to
changed code I deleted "IC" entriers.

Code Select Expand


// the routine for the info center upshrink
echo '
<script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
var current_header = ', empty($options['collapse_header']) ? 'false' : 'true', ';
function shrinkHeader(mode)
{';

if ($context['user']['is_guest'])
echo '
document.cookie = "upshrink=" + (mode ? 1 : 0);';
else
echo '
smf_setThemeOption("collapse_header", mode ? 1 : 0, null, "', $context['session_id'], '");';

echo '
document.getElementById("upshrink").src = smf_images_url + (mode ? "/expand.gif" : "/collapse.gif");
document.getElementById("upshrinkHeader").style.display = mode ? "none" : "";
current_header = mode;
}
// ]]></script>
';



Comments please....!?

Regards
IQAPPS

[Goosemoose]

As far as I can tell, this has nothing to do with this mod. The only thing I can think of is that your theme changed the upshrink code from the default. If that's the case then you would need to reflect that change in the Joomla template.

[iqapps]

Hi

Tank you for comments.

Regards
IQAPPS

[Benson]

I tried to make the changes to the SAFblue-Theme, using SMF1.1rc2:

Code Select Expand

Parse error: parse error, unexpected $ in /var/www/www.dachboden-wg.de/content/portal/smf/Themes/safblue/index.template.php on line 418

Double-Checked it for errors, made the changes again but still same error...

[Goosemoose]

Can you post the code that is around line 418? Maybe a few lines above it and below it? Thanks

[Benson]

Line 418 is at the bottom of the file index.template.php...

Code Select Expand

function template_button_strip($button_strip, $direction = 'top')
{
global $settings, $buttons, $context, $txt, $scripturl;

if (empty($button_strip))
return '';

// Create the buttons...
foreach ($button_strip as $key => $value)
{
if (isset($value['test']) && empty($context[$value['test']]))
{
unset($button_strip[$key]);
continue;
}
elseif (!isset($buttons[$key]))
$buttons[$key] = '<a href="' . $value['url'] . '" ' .( isset($value['custom']) ? $value['custom'] : '') . '>' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . ($value['lang'] ? $context['user']['language'] . '/' : '') . $value['image'] . '" alt="' . $txt[$value['text']] . '" border="0" />' : $txt[$value['text']]) . '</a>';

$button_strip[$key] = $buttons[$key];
}

echo '
<td>', implode($context['menu_separator'], $button_strip) , '</td>';
}
?>

[HoTmetal]

Ok, now that a few peeps have used this mod, I'm curious how this has helped you with the search engines...

Can  you guys/gals post your results? thanks again~ great mod Goosemoose

[Goosemoose]

Benson,
   The error must be somewhere else then. It sounds like the theme you are using has quite a few differences. You'll have to compare it to the default theme and find the differences.

rickC,
  The biggest difference for me is that all my search engine results now have the page name included, rather than all showing the default Joomla name.

[HoTmetal]

Benson,
   The error must be somewhere else then. It sounds like the theme you are using has quite a few differences. You'll have to compare it to the default theme and find the differences.

rickC,
  The biggest difference for me is that all my search engine results now have the page name included, rather than all showing the default Joomla name.

Yeah, I should try this. My page ranks with google has gone down hill since my joomla add. (From 4 to a big fat zero )

[Goosemoose]

I went from a 4 to a 0 after chaning to SEF urls. It's taken 2 months to get a few of my pages back to 4's, but most of them are still 0's. I've totally dropped off the rankings in some of the keywords I was number 1 or 2 in

[HoTmetal]

I went from a 4 to a 0 after chaning to SEF urls. It's taken 2 months to get a few of my pages back to 4's, but most of them are still 0's. I've totally dropped off the rankings in some of the keywords I was number 1 or 2 in

Ok so I'm not the only one... Yeah I fell off in ALL of my key words.. Ah the price to pay for a good CMS...

[Benson]

Ok i have managed to modify the template manually - i did it the wrong way, interpreted <search before> that i have to add the code in front of the one you have searched for...

Now it seems to work, but the browser still doesn't display the correct titles - no mather if i use the manually modified template or the standart template. I have added the code to the joomla template and deleted my browsers cache but with no difference...

[rjprince]

I was looking to install this with the new bridge (1.13) on Joomla 1.08. The new bridge doesn't require changes to the template file; it uses a system mambot instead.

Has this mod been tested under that scenario? I'm worried about having the code in their twice.

[Kindred]

RJ...   this mod does not change your joomla template file.

This mod REMOVES the <html><head></head><body></body></html> tags and the appropriate code from your SMF Theme (index.tmeplate.php) for default, babylon and classic themes.

This code is not needed while your system is wrapped, because it is handled in the mambot...

[rjprince]

OK, I just want to make sure I understand what your saying. The mod page says this, which I interpreted as requiring changes to the template file:

IMPORTANT. Open up your Joomla template, move the Joomla template_css.css call to immediately
after the <head> and place the following after template_css call which will replace the current bridge code.
     
Do this before installing this mod. Make sure to backup your template first.

Code Select Expand

lots of code

So are you saying that in Joomla 1.08 using bridge 1.13, I don't need to change the template code in any way?

Sorry for the confusion.

[Kindred]

that is correct. On Joomla, with bridge v1.1.3, you do not need to change the joomla template code in any way.

[rjprince]

Thank you.

May I suggest someone update the mod page, then (assuming I didn't miss an update already there, in which case I'll be horribly embarassed. )

[rjprince]

Thanks for the help - it worked perfectly. And great mod, by the way.

the browser still doesn't display the correct titles - no mather if i use the manually modified template or the standart template.

I had to make the changes by hand because I'm using a different template. While I was in there, I added this code just after the } at the end of the second set of inserted code (the closing brace for the first if statement):

Code Select Expand

else {
global $mainframe;
$mainframe->setPageTitle($context['page_title']);
}

This makes the title work correctly by using Joomla's title-setting function. Hope this helps.