Hi need help to Remove HELP button

[~DS~]

Why? It's better than removing because you might just need them back one day by changing it to 'true'.

I just prefer using comments if I wanted to remove something, its easier to remember for me.

@♪ JohnCcCcCc ♫, I wasn't saying that there was only one way, there are multiple ways to achieve this.

Comments? You mean comment out the line? Or adding // ? How?

[ɔɔɔɔɔɔuɥoɾ]

either // or open comment and close it with /* */

[~DS~]

Code Select Expand

/* 'help' => array(
'title' => $txt['help'],
'href' => $scripturl . '?action=help',
'show' => true,
'sub_buttons' => array(
),
), */

Code Select Expand

                   // 'help' => array(
'title' => $txt['help'],
'href' => $scripturl . '?action=help',
'show' => true,
'sub_buttons' => array(
),
),
Like that?

[ɔɔɔɔɔɔuɥoɾ]

Yea like the top one (recommended)

You would have to add // to every single line to comment the whole thing out

[Kill Em All]

Exactly.

I'll also usually add a comment above the block of code I commented out such as:

Code Select Expand


// HEY, we commented this out so that we can remove/add/whatever this feature


Just makes life a lot easier, atleast for me.

[ɔɔɔɔɔɔuɥoɾ]

I was thinking about making things easier for mods though, I already know you dont agree with me Kill Em All

However, the less code changed, the less chance of failed tests, I don't think anybody in their right mind would make a mod where you;

Code (FIND) Select Expand


         'help' => array(
            'title' => $txt['help'],
            'href' => $scripturl . '?action=help',
            'show' => true,
            'sub_buttons' => array(
            ),
         ),


Code (Add Before) Select Expand


Some code
goes here
maybe some more
here


While it could just be

Code (find) Select Expand


         'help' => array(
            'title' => $txt['help'],
            'href' => $scripturl . '?action=help',


Code (add before) Select Expand


Some code
goes here
maybe some more
here


You can see then if someone was to change true to false, it would not effect the mod, as removing the code completely or commenting it out would effect it.


I would do this

Code Select Expand


//We disabled this button, since we dont need it, default setting = 'show' => true,

         'help' => array(
            'title' => $txt['help'],
            'href' => $scripturl . '?action=help',
            'show' => false,
            'sub_buttons' => array(
            ),
         ),


[Kill Em All]

Well first its unlikely a mod is going to be playing around with other buttons. But for argument sake lets say a lot of mods do.

The way the package manager works, it has to be the exact same code when its finding and replacing that block of code. Even if a space is off, its going to give a test failed. So its not really helping the cause anyways.

Its not that I don't agree with you per say, its just that I think my way is better, but there really is no better way because any way will work. Everyone codes differently, thats whats great about coding, you can be free and no subject to such strict guidelines.

[ɔɔɔɔɔɔuɥoɾ]

Well first its unlikely a mod is going to be playing around with other buttons. But for argument sake lets say a lot of mods do.

The way the package manager works, it has to be the exact same code when its finding and replacing that block of code. Even if a space is off, its going to give a test failed. So its not really helping the cause anyways.

Its not that I don't agree with you per say, its just that I think my way is better, but there really is no better way because any way will work. Everyone codes differently, thats whats great about coding, you can be free and no subject to such strict guidelines.

If they wish to add another button, they will need to search one of the arrays however.

I recently created a mod, which allows you to add upto 5 buttons (why, been hearing "how do I add custom buttons" all week long, lol) anywho

This is part of the code

Code ( Find) Select Expand


'search' => array(
'title' => $txt['search'],
'href' => $scripturl . '?action=search',


Code ( Add before) Select Expand


The rest of the code is here, but u get the point (5 custom button arrays)
                'sub_buttons' => array(
                ),
            ),


I did this because, I know people who add buttons may also want to remove existing buttons, as to save space.
Like in my mod that lets you remove buttons, I changed the show part of the array, just so you can use both mods together.

You see my point here though..

[Kill Em All]

I see. So we don't end up confusing the topic author, we will just leave it at that.

FrancisVic, do you need any further assistance with this, if not, please feel free to mark this as solved.

[FrancisVic]

thanks guy.

[Kill Em All]

I am going to mark the topic solved, please feel free to unmark it solved if you have further questions.