Grudges Post moderation MOD - errors

[Owdy]

After post moderation mod installation, when you go in permissions area:

Code Select Expand

Parse error: parse error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ')' in /www/34234/hoitajat/public_html/foorumi/Sources/ManagePermissions.php on line 766

766 is this:

Code Select Expand

'poll_add_any',

[Owdy]

Got it, its this

Code Select Expand

<search for>
'merge_any',
'split_any',
'poll_lock_any',
'poll_remove_any',
</search for>

<add after>
'pmod_approve_any'
</add after>

Should be:

Code Select Expand

<search for>
'merge_any',
'split_any',
'poll_lock_any',
'poll_remove_any',
</search for>

<add after>
'pmod_approve_any',
</add after>

[Owdy]

Second, i have board where guest can post. Its post moderated. After they post, they get this error:

An Error Has Occurred!   
The topic or board you are looking for appears to be either missing or off limits to you.

Should it be some other notice?

edit: got it. I got back to topic by default.

[Owdy]

I gave my moderators permission to use this, but they dont see this annoucment:
// Moderated posts...
      if (isset($context['show_moderation']))
         echo '<br />', $context['show_moderation'] == 1 ? $txt['postmod_there_' .  bllaa blaa.

Any ideas why?

[Owdy]

4th issue. I have one board post moderated, posts and new topics. However, post moderation only work with guests and only with new topics. Only guests is just ok, its better exactly, but i need moderate guest replyes also. This MOD would be super if it works.

[Grudge]

First error I'll fix when I package this back up once I sort the other two. The second error I couldn't quite understand what you mean.

The third error isn't an error per se, it's the best I can do. Basically, it will only show how many posts need moderating if the moderator is in a board that was posts outstanding (i.e they have to be in a board they moderate which has outstanding posts).

Forth problem I can't pin down. Can you check that the isModerated column on the board in question has a value of 2 in it?

I know this MOD isn't perfect, but all I'm gonna be able to do is try fix up the bugs. I dearly wanted to see post moderation in 1.1 but think we may stuggle to get it all in

[Owdy]

The second error I couldn't quite understand what you mean.

If you are post moderated, and default setting in board is  to return to topic after post, you get that error.  Thats all.

The third error isn't an error per se, it's the best I can do. Basically, it will only show how many posts need moderating if the moderator is in a board that was posts outstanding (i.e they have to be in a board they moderate which has outstanding posts).

Forth problem I can't pin down. Can you check that the isModerated column on the board in question has a value of 2 in it?

I dont get you I mean that notify ' There are 2 messages awaiting approval'. Admin see that notice, global moderator wont see it. They cant post moderate via admin panel, but they wont see that notice up there with PM notification text..

I dearly wanted to see post moderation in 1.1

Me too

[Owdy]

Forth problem I can't pin down. Can you check that the isModerated column on the board in question has a value of 2 in it?

Yes it does.

[Grudge]

I see, thanks Owdy, I'll have to try take a look at these tomorrow.

[Owdy]

Ok, thanks!

[Grudge]

Yea, didn't get to it today - hopefully tomorrow

[Grudge]

Sorry, this is taking me a while to get to, I really have more pressing things to do but I will try get it done this weekend :/

[Owdy]

Heh, okay.

[Grudge]

Have updated the package at last. Please let me know what still is broken, think I got to quite a lot of it.

[Owdy]

Code Select Expand

Parse error: parse error, unexpected T_BOOLEAN_OR, expecting ')' in /www/asiakkaat/32424234/public_html/foorumi/Themes/default/Post.template.php on line 432

line 432:

Code Select Expand

<td class="smalltext"><label for="check_back"><input type="checkbox" name="goback" id="check_back"' . ($context['back_to_topic'] || !empty($options['return_to_post'] || $context['is_moderated']) ? ' checked="checked"' : '') . ' ', $context['is_moderated'] ? 'disabled="disabled"' : '', ' value="1" class="check" /> ' . $txt['back_to_topic'] . '</label></td>


[Grudge]

Grrr.. think I've fixed it.. again

[Owdy]

It works allmost Only thing, my moderators wont see that notice in index.template. Only admin sees that.

I have feature reg to this mod. If i set moderation on in some board, i'd like to choose what groups should  be moderated. Currently i have guest board, where guests are allowed to post. I want them to be moderated, but if member posts to that area, they shouldnt be moderated.  Make any sense?

[Grudge]

OK, things are getting there. I'll try look at this again tomorrow. Been coding about 4 different things on different software today and my brain hurts

[Owdy]

Now it works with moderators like this; when they open just any topic in my board, they see that notice. If they arent in some topic, they wont see it. I see it everywhere. Weird..

[Grudge]

That's how it should work for moderators, unless they are a global moderator. The problem is there is no way to tell someone is a moderator outside of a board they moderate without an extra query - which is slow... so this is the compromise You could force it to display a link to the post moderation area at all times so they can always check easily