OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]

Started by Branko., December 06, 2008, 05:23:42 AM

Previous topic - Next topic

cieplutki





.

Eclipse16V

@ PascalCX

Mozilla/5.0 (Android; Linux armv7l; rv:7.0) Gecko/20110922 Firefox/7.0 Fennec/7.0
I worked with:
SMF 2 in German

Shop:
SID Giessen

Doburpally

@ Eclipse16V

I can see the problem, I tested using default browser in my android and os detector picks up Android.
Soon as I use Firefox it picks it up as Linux. Odd.

@ cieplutki
That's great ;) but I have already made a package :P

#Pascal

firefox doesn't announce android version in user agent, so that it doesn't match the regex in the code.
I can fix firefox detection, wait for a while

#Pascal

Android detection(fixed)


// Android
    if(preg_match('/android/si', $user_agent))
    {
    $client_data['system'] = "Android";
    $client_data['system_icon'] = "android";
    if(preg_match('/android ([0-9.]+).*/si', $user_agent, $tmp_array))
      {
      $client_data['system'] = "Android" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      }
    }


Doburpally

#365
Thanks PascalCX ;)

Attached is the package with all the changes.
I have taken the liberty edit the readme file to include the new changes ;D

Eclipse16V

I worked with:
SMF 2 in German

Shop:
SID Giessen

ddabcd277

So far so good.  Why don't you name it version 1.6?  :)

SD-X

I agree. That'd be awesome to have a new version including these additional browsers/OS'es :)

Doburpally

#369
Okay that's easy ;)

package attached :)

Branko.

Hi, Reaper.CSF.
I found several errors in languages.xml , e.g.
- line 38    <file name="$languagedir/Modifications.finnish.php.php" error="skip">
- line 122  <file name="$languagedir/Modifications.serbian.php" error="skip">
- line 137  <file name="$languagedir/Modifications.serbian-utf8.php" error="skip">
- line 152  <file name="$languagedir/Modifications.serbian-utf8-lat.php" error="skip">
Also added serbian_cyrillic and croatian translation, both iso/utf8

Here is modified languages.xml and readme.txt
Strong people don't put others down, they lift them up.
A clever person solves a problem. A wise person avoids it.

Doburpally

#371
Quote from: Branko. on October 05, 2011, 02:35:25 PM
Hi, Reaper.CSF.
I found several errors in languages.xml , e.g.
- line 38    <file name="$languagedir/Modifications.finnish.php.php" error="skip">
- line 122  <file name="$languagedir/Modifications.serbian.php" error="skip">
- line 137  <file name="$languagedir/Modifications.serbian-utf8.php" error="skip">
- line 152  <file name="$languagedir/Modifications.serbian-utf8-lat.php" error="skip">
Also added serbian_cyrillic and croatian translation, both iso/utf8

Here is modified languages.xml and readme.txt

Thanks m8 ;)

Package Attached

Perhaps i should take over this mod, if the mod owner is no longer around ;)

Branko.

I think you're right ...I tried to find him, but it is not on his forum.I think that he abandoned all.
Strong people don't put others down, they lift them up.
A clever person solves a problem. A wise person avoids it.

French

Thx installed Version 1.6,
We are using Modification tapatalk on our Forum, still waiting for test results if OS & Browsers detection works when users are using tapatalk i.c.w the Galaxy S GT-I9000 (Running android 2.1)

#Pascal

French
I suppose that tapatalk doesn't compatable with this mod

French

Oke thanks Pascal ....I suppose it might be better to submit questions about compatibility to community/forum tapatalk  ;)

Doburpally

Quote from: Branko. on October 06, 2011, 05:33:32 PM
I think you're right ...I tried to find him, but it is not on his forum.I think that he abandoned all.

He is still registered in these forums X3mE

Date last seen in this topic = 13th May 2009 :o

Branko.

Yes, I know..and last login  20-09-2010 .I think it's gone forever  :-\
Strong people don't put others down, they lift them up.
A clever person solves a problem. A wise person avoids it.

French

Still looking to get system_icon LinuxMint in Mod OS & Browser.
edit this line   elseif(preg_match('/linuxmint/si', $user_agent))
        {
        $client_data['system'] .= " (Linuxmint)";
        $client_data['system_icon'] = "linuxmint"

in os_browser_detection.php,but unfortunately the system icon didn´t change
Info My User Agent.
Your User Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20100101 Firefox/7.0.1

Also looking for the same issue when using Bodhi Linux (Waiting for User Agent info by one of the Bodhi Linux users)

Doburpally

#379
Quote from: French on October 10, 2011, 04:15:01 AM
Still looking to get system_icon LinuxMint in Mod OS & Browser.
edit this line   elseif(preg_match('/linuxmint/si', $user_agent))
        {
        $client_data['system'] .= " (Linuxmint)";
        $client_data['system_icon'] = "linuxmint"

in os_browser_detection.php,but unfortunately the system icon didn´t change
Info My User Agent.
Your User Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20100101 Firefox/7.0.1

Also looking for the same issue when using Bodhi Linux (Waiting for User Agent info by one of the Bodhi Linux users)


I'm sure I got this right
      elseif(preg_match('/mint/si', $user_agent))
        {
      $client_data['system'] = " (Linux Mint)";
      $client_data['system_icon'] = "mint";
        }


Attached is the icon that goes in /Themes/default/images/os_browser_detection/
Also attached is the full package that includes the changes.

Advertisement: