Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: [SAP]Francis on November 10, 2009, 12:13:44 AM

Title: Ban list bug
Post by: [SAP]Francis on November 10, 2009, 12:13:44 AM
Here is what I see in my ban list. (For Add a ban page)

Title: Re: Ban list bug
Post by: tyty1234 on November 10, 2009, 12:41:08 AM
that's very strange....was this a fresh install?
Title: Re: Ban list bug
Post by: Arantor on November 10, 2009, 07:42:03 AM
And have you Ctrl-F5 to reload the page ensuring it uses updated CSS?
Title: Re: Ban list bug
Post by: [SAP]Francis on November 10, 2009, 07:51:50 AM
I did. And yes it is a fresh install. I just installed three mods being Team page, SMF Media Gallery and Download System. Things that do not touch the ban page.
Title: Re: Ban list bug
Post by: Arantor on November 10, 2009, 07:53:26 AM
What version of Firefox?
Title: Re: Ban list bug
Post by: [SAP]Francis on November 11, 2009, 07:44:51 AM
Copied from my About dialog:

QuoteMozilla/5.0 (Windows; U; Windows NT 6.0; fr; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 (.NET CLR 3.5.30729)
Title: Re: Ban list bug
Post by: IchBin™ on November 11, 2009, 09:42:09 AM
I do not get this problem on my site using FF 3.0.10 or 3.5.5 on WinXP.
Title: Re: Ban list bug
Post by: Aaron on November 11, 2009, 01:12:35 PM
Unable to reproduce on my end, too. [SAP]Francis, could you try re-uploading the admin.css file?
Title: Re: Ban list bug
Post by: [SAP]Francis on November 11, 2009, 07:16:23 PM
I re-uploaded my admin.css file, but still the same problem happens.
Title: Re: Ban list bug
Post by: Arantor on November 11, 2009, 07:22:40 PM
Did you then Ctrl-F5 while in the admin panel after doing that?
Title: Re: Ban list bug
Post by: [SAP]Francis on November 11, 2009, 07:56:16 PM
Yes I did. Still nothing as I stated.
Title: Re: Ban list bug
Post by: tyty1234 on November 12, 2009, 04:12:42 AM
Maybe try clearing the file cache? (Admin -> Maintenance -> Forum Maintenance -> Routine -> Empty the file cache)
Title: Re: Ban list bug
Post by: [SAP]Francis on November 12, 2009, 07:53:35 AM
Quote from: tyty1234 on November 12, 2009, 04:12:42 AM
Maybe try clearing the file cache? (Admin -> Maintenance -> Forum Maintenance -> Routine -> Empty the file cache)
Did that too before posting here. Nothing.
Title: Re: Ban list bug
Post by: Windy on November 12, 2009, 09:56:55 AM
How does it look in a different browser?
Title: Re: Ban list bug
Post by: [SAP]Francis on November 12, 2009, 04:53:52 PM
Same thing with IE happens.
Title: Re: Ban list bug
Post by: hadesflames on November 12, 2009, 11:52:56 PM
Try to change your viewing preferences to drop down by clicking those double arrows next to "main"
Title: Re: Ban list bug
Post by: [SAP]Francis on November 13, 2009, 09:50:09 PM
Quote from: hadesflames on November 12, 2009, 11:52:56 PM
Try to change your viewing preferences to drop down by clicking those double arrows next to "main"
Same thing, it appears in the same spot, above the dropdowns.
Title: Re: Ban list bug
Post by: tyty1234 on November 14, 2009, 03:26:06 AM
Well in that case, try re-uploading your ManageBans.template.php file.
Title: Re: Ban list bug
Post by: H on November 14, 2009, 08:28:12 AM
Please PM an admin login for your site so I can attempt to re-produce the problem :)
Title: Re: Ban list bug
Post by: [SAP]Francis on November 14, 2009, 10:47:04 AM
Quote from: H on November 14, 2009, 08:28:12 AM
Please PM an admin login for your site so I can attempt to re-produce the problem :)
Will do.
Title: Template issue on "Add A Ban" section
Post by: king kratos on November 14, 2009, 06:38:29 PM
I am having some odd template issues in the "Add A Ban" area in Admin Section of my forum.

I have attached two screenshots to show what is happening and have attached my ManageBans.template.php.

Screenshot one is showing some of the fields appearing just below the main menu and above the admin menu.
Screenshot two is showing the check box at the bottom of the "Add A Ban" area but nothing after it. The fields that are to be after it are appearing above the Admin area and below the main menu as seen in screenshot one.

I have played around with the code in ManageBans.template.php and cannot seem to get it correct. Any help would be appreciated.

Thank you,
Kratos
Title: Re: Ban list bug
Post by: [SAP]Francis on November 15, 2009, 09:39:27 AM
^-- That's the same problem as me.
Title: Re: Ban list bug
Post by: Arantor on November 15, 2009, 09:40:54 AM
That's what I thought, so I merged the two threads and moved them both into Bug Reports.
Title: Re: Ban list bug
Post by: H on November 15, 2009, 10:55:52 AM
I confirmed the problem with your site however I also tested on my own test site and couldn't reproduce the problem there.

king kratos, which mods have you got installed? Perhaps you both have a the same mod that is causing the problem
Title: Re: Ban list bug
Post by: king kratos on November 15, 2009, 12:05:38 PM
Quote from: H on November 15, 2009, 10:55:52 AM
I confirmed the problem with your site however I also tested on my own test site and couldn't reproduce the problem there.

king kratos, which mods have you got installed? Perhaps you both have a the same mod that is causing the problem

Attached is a list of my mods. I also have downloaded a fresh copy of the full (new install) RC2 package and replaced my ManageBans.template.php with the new one.


Something very interesting that I just found is that when I disable hostname lookups through server settings, this issue goes away. See the screenshot addban_hostname_lookup_disabled.png to see what I am talking about. I took that screenshot after disabling hostname lookups. When I enable hostname lookups, the issue (see my first post on this thread) returns.

This tells me that the issue lies within the code for adding a ban on hostname. I just cannot figure out what part of that code is doing it. I've tried playing with that section of code every way I can think of and no fix.

Kratos
Title: Re: Ban list bug
Post by: [SAP]Francis on November 15, 2009, 12:36:46 PM
Seems like we have Download System in common.
Title: Re: Ban list bug
Post by: king kratos on November 15, 2009, 12:57:51 PM
Quote from: [SAP]Francis on November 15, 2009, 12:36:46 PM
Seems like we have Download System in common.

Yep, it just seems odd that none of these mods are touching ManageBans.template.php and yet we are seeing this issue. It also seems odd that others are not able to recreate this issue with their own forums.

Edit: I believe that the ban on hostname code is the culprit. I have removed that portion of the code and the issue went away. (By removed, I mean in the code, I literally deleted that section). The screenshot I posted in my second post is what happens when I remove this portion of code.

@ [SAP]Francis, can you disable hostname lookup from the server settings in admin cp and verify that this resolves the issue? Also, if you feel comfortable doing so, can you also remove that line of code in the file and see if that fixes this issue as well? If you don't feel comfortable editing the template file, please don't do it.

Kratos
Title: Re: Ban list bug
Post by: [SAP]Francis on November 15, 2009, 09:36:58 PM
Indeed, turning off the hostnames lookups fixes it. But I need hostnames lookup on on my forum. So I can't turn it off.
Title: Re: Ban list bug
Post by: king kratos on November 15, 2009, 09:55:00 PM
Ok, well, that gives the experts some more information. Let's wait to see what they have to say about this issue.

Thanks,
Kratos
Title: Re: Ban list bug
Post by: Norv on December 03, 2009, 12:01:17 AM
Please try the fix here:
http://www.simplemachines.org/community/index.php?topic=351261.msg2383455#msg2383455
Title: Re: Ban list bug
Post by: king kratos on December 03, 2009, 01:11:16 AM
That fixed it perfectly! I cannot believe I missed that simple little </td>!!!!! Funny how one simple little error like that can make such a big difference in the final output.

Thanks for the help.

Kratos
Title: Re: Ban list bug
Post by: Norv on December 03, 2009, 01:14:30 AM
Cheers, good to hear!