Ban list bug

[king kratos]

I am having some odd template issues in the "Add A Ban" area in Admin Section of my forum.

I have attached two screenshots to show what is happening and have attached my ManageBans.template.php.

Screenshot one is showing some of the fields appearing just below the main menu and above the admin menu.
Screenshot two is showing the check box at the bottom of the "Add A Ban" area but nothing after it. The fields that are to be after it are appearing above the Admin area and below the main menu as seen in screenshot one.

I have played around with the code in ManageBans.template.php and cannot seem to get it correct. Any help would be appreciated.

Thank you,
Kratos

[[SAP]Francis]

^-- That's the same problem as me.

[Arantor]

That's what I thought, so I merged the two threads and moved them both into Bug Reports.

[H]

I confirmed the problem with your site however I also tested on my own test site and couldn't reproduce the problem there.

king kratos, which mods have you got installed? Perhaps you both have a the same mod that is causing the problem

[king kratos]

I confirmed the problem with your site however I also tested on my own test site and couldn't reproduce the problem there.

king kratos, which mods have you got installed? Perhaps you both have a the same mod that is causing the problem

Attached is a list of my mods. I also have downloaded a fresh copy of the full (new install) RC2 package and replaced my ManageBans.template.php with the new one.


Something very interesting that I just found is that when I disable hostname lookups through server settings, this issue goes away. See the screenshot addban_hostname_lookup_disabled.png to see what I am talking about. I took that screenshot after disabling hostname lookups. When I enable hostname lookups, the issue (see my first post on this thread) returns.

This tells me that the issue lies within the code for adding a ban on hostname. I just cannot figure out what part of that code is doing it. I've tried playing with that section of code every way I can think of and no fix.

Kratos

[[SAP]Francis]

Seems like we have Download System in common.

[king kratos]

Seems like we have Download System in common.

Yep, it just seems odd that none of these mods are touching ManageBans.template.php and yet we are seeing this issue. It also seems odd that others are not able to recreate this issue with their own forums.

Edit: I believe that the ban on hostname code is the culprit. I have removed that portion of the code and the issue went away. (By removed, I mean in the code, I literally deleted that section). The screenshot I posted in my second post is what happens when I remove this portion of code.

@ [SAP]Francis, can you disable hostname lookup from the server settings in admin cp and verify that this resolves the issue? Also, if you feel comfortable doing so, can you also remove that line of code in the file and see if that fixes this issue as well? If you don't feel comfortable editing the template file, please don't do it.

Kratos

[[SAP]Francis]

Indeed, turning off the hostnames lookups fixes it. But I need hostnames lookup on on my forum. So I can't turn it off.

[king kratos]

Ok, well, that gives the experts some more information. Let's wait to see what they have to say about this issue.

Thanks,
Kratos

[Norv]

Please try the fix here:
http://www.simplemachines.org/community/index.php?topic=351261.msg2383455#msg2383455

[king kratos]

That fixed it perfectly! I cannot believe I missed that simple little </td>!!!!! Funny how one simple little error like that can make such a big difference in the final output.

Thanks for the help.

Kratos

[Norv]

Cheers, good to hear!