Simple Machines Community Forum

Customizing SMF => Modifications and Packages => Topic started by: Dannii on July 25, 2005, 04:24:08 PM

Title: Group Moderators 1.4
Post by: Dannii on July 25, 2005, 04:24:08 PM
Link to Mod (http://mods.simplemachines.org/index.php?mod=171)

This mod will allow you to add Group Moderators: members of your forum who have control of the specific groups you set them over. They can add and remove members from only these specific groups. Essential for large forums with multiple private boards and groups.

Copyright 2005-2006 - Please see licence.txt (http://smfgroups.googlecode.com/svn/trunk/licence.txt) for details.

Project home page (http://code.google.com/p/smfgroups/)
Changelog (http://smfgroups.googlecode.com/svn/trunk/changelog.txt)



Possible Future plans

Possibly more.
Title: Re: Group Moderators
Post by: stargazer_1017 on July 25, 2005, 04:41:37 PM
Sounds great! Do you have any screenshots of this mod in action?

-Shayna
Title: Re: Group Moderators
Post by: mennou on July 25, 2005, 04:42:07 PM
it didn't  work on my  beta3 public  forum
Title: Re: Group Moderators
Post by: dtm.exe on July 25, 2005, 04:43:30 PM
Quote from: stargazer_1017 on July 25, 2005, 04:41:37 PM
Sounds great! Do you have any screenshots of this mod in action?

-Shayna

http://www.simplemachines.org/community/index.php?topic=40023.msg307258#msg307258

Quote from: mennou on July 25, 2005, 04:42:07 PM
it didn't  work on my  beta3 public  forum

It's for SMF 1.0.5 only.

-Dan The Man
Title: Re: Group Moderators
Post by: mennou on July 25, 2005, 04:49:47 PM
can u make it for  beta..  ur mod sounds  nice.. lol i am curious to see how it works
Title: Re: Group Moderators
Post by: Dannii on July 25, 2005, 06:36:33 PM
I'll be making it for beta.. well after I install beta :P I'll try and get it out as soon as possible.

Screenshots:

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fweb.aanet.com.au%2Feldacar%2Fdata%2Fscreeny03.png&hash=12da12a9d47bcfb077886776715cd39dd8de7955)

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fweb.aanet.com.au%2Feldacar%2Fdata%2Fscreeny04.png&hash=f342bb41fb221aaf3b084a988b702fbb215ea397)
Title: Re: Group Moderators
Post by: rhizome on July 25, 2005, 06:55:38 PM
Hey, this a really useful mod!
Look forward to 1.1 version

thanks
Title: Re: Group Moderators
Post by: trenchteam on July 25, 2005, 07:41:05 PM
Group Moderators?  Can you explain a bit more. I never used phpBB so Im not sure what this does.
Title: Re: Group Moderators
Post by: Dannii on July 25, 2005, 08:51:45 PM
It lets you set people who are moderators of particular groups. They then have the ability to manage their own group, without needing to have the moderate_membergroups permission. If they had that instead they could add and delete members to all groups, which is not wanted in most cases, and the alternative is an admin doing everything. This would be useful for gaming groups, or anything really where a group has a private board and the admin isn't really involved.
Title: Re: Group Moderators 1.0b
Post by: Dannii on July 26, 2005, 12:52:00 AM
Version 1.0b  is now ready for release
el_groupmods_10b.tar.gz (http://mods.simplemachines.org/index.php?a=download;mod=171;id=8776)
changelog.txt (http://mods.simplemachines.org/index.php?a=download;mod=171;id=8777)

This one should be 1.1 compatible now. Let me know if you come across bugs/problems in either version.

I still need to figure out how to do the uninstallation properlly :|
Title: Re: Group Moderators 1.0b
Post by: mennou on July 26, 2005, 12:56:54 AM
install nice but now  how can i see the mod on my site?
Title: Re: Group Moderators 1.0b
Post by: Dannii on July 26, 2005, 12:59:38 AM
In the admin panel go to manage member groups, and edit the ones you want, and add names to the group moderators field. Then go to index.php?action=groups to see the above.

Only groups for which you are mod will be shown. I'm admin at my forum, but I don't see any groups to manage (because they have their own proper leaders) unless i add myself for test purposes.
Title: Re: Group Moderators 1.0b
Post by: russ on July 27, 2005, 08:04:03 AM
Got it working fine :)

Could this script be adapted to show any member the ranks and which members are in the various ranks. kinda like a rank ladder?
Title: Re: Group Moderators 1.0b
Post by: Dannii on July 27, 2005, 09:43:00 AM
I'm not sure what you mean by a rank ladder, put probably not. This mod won't have anything to do with post count groups. But I do plan on adding features to show the list of members with editable permissions, as well as application services.
Title: Re: Group Moderators 1.0b
Post by: mazdago on July 27, 2005, 02:58:01 PM
how i can install this mod?
Title: Re: Group Moderators 1.0b
Post by: Dannii on July 27, 2005, 08:58:33 PM
Download and install through the package manager. 1.0b will install in both 1.0.5 and 1.1 beta 3 public
Title: Re: Group Moderators 1.0c
Post by: Dannii on July 31, 2005, 08:48:06 AM
Version 1.0c  is now ready for release
el_groupmods_10c.tar.gz (http://mods.simplemachines.org/index.php?a=download;mod=171;id=8915)
GroupMods_uninstall.php (http://mods.simplemachines.org/index.php?a=download;mod=171;id=8916)
changelog.txt (http://mods.simplemachines.org/index.php?a=download;mod=171;id=8917)

Minor update. No functionality change, I've just fixed it so the files will be removed on uninstallation.

GroupMods_uninstall.php is a simple tool I've written for you to permantely remove this mod. Please use it after uninstalling through the package manager. Only use it if you do not want to ever install this mod or a later version again.
Title: Re: Group Moderators 1.0c
Post by: mazdago on July 31, 2005, 11:25:36 AM
i tryed... but some files has to be chmod... what files?... thru package manager dont work... i cannot chmod becouse i dont know which files


Title: Re: Group Moderators 1.0c
Post by: Dannii on July 31, 2005, 11:48:57 PM
Having problems with the package manager? (http://www.simplemachines.org/community/index.php?topic=28393.0)
Title: Re: Group Moderators 1.0c
Post by: DangerGirl on August 01, 2005, 06:09:11 AM
This is the perfect mod for my gaming community.  But where does the Group Mod go to do his thing?  I registered a demo name and I don't see an Admin function anywhere.
Title: Re: Group Moderators 1.0c
Post by: Ivan Minic on August 01, 2005, 06:15:37 AM
And why would you see admin if it is group moderator feature?!
Title: Re: Group Moderators 1.0c
Post by: DangerGirl on August 01, 2005, 06:21:10 AM
Well, some panel that allows the Group Mod to add the members to the group.  I don't get anything right now, it's as if I never did anything.

Unless I've completely misunderstood what the mod is supposed to do.
Title: Re: Group Moderators 1.0c
Post by: Ivan Minic on August 01, 2005, 06:37:36 AM
Ah no... silly me.. i missunderstood you...
Feature can be controled from: Member Controls   | Edit Membergroups
Sorry for my mistake..
Title: Re: Group Moderators 1.0c
Post by: DangerGirl on August 01, 2005, 07:01:49 AM
Oh, it's no problem.  Unfortunately I still don't seem to have a function anywhere.  I'm trying the mod on both a 1.05 and public beta forum and neither seem to have it, though I know it is installed.
Title: Re: Group Moderators 1.0c
Post by: Dannii on August 01, 2005, 08:14:54 AM
No no.

It is there, and it is completely unrelated to the admin functions. It can be accessed at http://yourforum/index.php?action=groups

I haven't made it put buttons anywhere because it is a feature that will only be used by a very few people. Later expanded versions will include buttons.

However, a member will not see anything except for a blank table unless they are a mod over a group. To set group moderators, edit the groups in the admin panel.
Title: Re: Group Moderators 1.0c
Post by: DangerGirl on August 01, 2005, 04:22:07 PM
Ohhh I see it now, hehe.  I have an RPG forum so we have about 50+ private boards and membergroups which becomes very time consuming for me to maintain.  That's why this mod comes in handy so much.  I can't thank you enough!

Actually, one last question.  Is there a possibility to have a membergroup be Group Mods for another membergroup?

Instead of going through 40 membergroups/priv forums to add a Group Mod to each, I'd be adding the 10 or so separate membergroups that contain my forum moderators that moderate those 40 different membergroups/priv forums.  I hope that makes sense. lol
Title: Re: Group Moderators 1.0c
Post by: DangerGirl on August 01, 2005, 04:28:09 PM
Quote from: eldacar on July 17, 2005, 02:35:20 AM
[The next step will be allowing mods to add and remove members of their group.
Gotcha.  Good luck, am looking forward to it.  :D
Title: Re: Group Moderators 1.0c
Post by: Dannii on August 01, 2005, 10:27:55 PM
No, its all finished. version 1.0a-c all work. they can add and delete.

Having groups manage other groups? Possibly in the future i could do that i suppose.. but not for now.
Title: Re: Group Moderators 1.0c
Post by: Dannii on August 02, 2005, 03:34:21 AM
My Plans for this mod:

Current

Future

Possibly more.
Title: Re: Group Moderators 1.0c
Post by: Harelin on August 02, 2005, 02:12:03 PM
Suggestion: allow group moderators to send PM's and/or emails to members of the groups they moderate.  This would really come in useful for me.
Title: Re: Group Moderators 1.0c
Post by: Dannii on August 02, 2005, 07:04:26 PM
Group PMs? That is a good idea. Probably not too hard to do either.
Title: Re: Group Moderators 1.0c
Post by: mkress on August 09, 2005, 10:20:58 PM
Quote from: eldacar on August 01, 2005, 08:14:54 AMHowever, a member will not see anything except for a blank table unless they are a mod over a group. To set group moderators, edit the groups in the admin panel.

admins should be always able to show the groups (index.php?action=groups).
because now a admin is not able to show the groups if he is not in the moderator group
or am i wrong???

(i am using smf 1.1b3)

Markus
Title: Re: Group Moderators 1.0c
Post by: Dannii on August 10, 2005, 08:33:21 AM
For now you see nothing special as an admin (because you can see everything in the admin panel anyway). But i will change this in future versions.
Title: Re: Group Moderators 1.0c
Post by: Byohki on August 15, 2005, 03:33:27 AM
Is it maybe also possible to give the group moderator a link in his profile like we have now as:

Account Related Settings
Forum Profile Information

But then for the group moderator panel? Since I know allot of ppl hate it to install new buttons (as do I.. :P) Specialy since it's not available yet for that theme..
Title: Re: Group Moderators 1.0c
Post by: JokeAss on August 25, 2005, 11:03:25 AM
Well...  Nice... But, it would be great if you could make group moderators for the admin and global moderator groups, which are the groups you need it the most for......
Please add in the next version: Admin/Moderator groups support...

Otherwise, it is a great mod
Title: Re: Group Moderators 1.0c
Post by: Dannii on August 26, 2005, 12:12:44 AM
I think that would be too much of a security risk. And besides, any admin already has full control, and on my forum at least, GMods have normal group control as well.
Title: Re: Group Moderators 1.0c
Post by: DangerGirl on August 30, 2005, 04:22:31 PM
It seems to be working great for my community.  The only issue I have is that when a group mod adds a player to his membergroup, that membergroup is added as the primary membergroup for that person and thus put in his title.  How can I get it so that it is made secondary?  Thanks a bunch.
Title: Re: Group Moderators 1.0c
Post by: Dannii on August 30, 2005, 06:18:07 PM
I'm not sure. That will be essential for the next version. It's bad if that group doesn't have permissions, cause then they won't be able to do anything.
Title: Re: Group Moderators 1.0c
Post by: Harelin on September 04, 2005, 01:29:17 AM
Quote from: DangerGirl on August 30, 2005, 04:22:31 PM
It seems to be working great for my community.  The only issue I have is that when a group mod adds a player to his membergroup, that membergroup is added as the primary membergroup for that person and thus put in his title.  How can I get it so that it is made secondary?  Thanks a bunch.

This (http://mods.simplemachines.org/index.php?mod=124) mod may prove useful to you.  My forum makes heavy use of secondary groupage so these two mods combined have been essential.
Title: Re: Group Moderators 1.0c
Post by: DangerGirl on September 04, 2005, 06:38:41 AM
Well, the issue that I am having is that when a Group Mod places someone in that membergroup, it gets put as their Primary membergroup.  When that happens, it gives them the membergroup title, which is always a private board name that I'd rather not disclose to the other players, and it takes away board access to other boards that membergroup does not have access to, that they otherwise would.

I did just install the multiple group names mod though, and it is really nice, thanks for auggesting it!  I may end up using it for the forum after I figure out what to do with this current problem. :D
Title: Re: Group Moderators 1.0c
Post by: Dannii on September 14, 2005, 08:20:25 AM
Here's a bandaid fix. Sorry it's so late coming, but I've been busy. I'll work on an updated version of the mod soon.

find this in Groups.php
while ($row = mysql_fetch_assoc($request))
{
// Verify that they are not already a member - and add them to our array.
if ($row['ID_GROUP'] != $_REQUEST['id'] && !in_array($_REQUEST['id'], explode(',', $row['additionalGroups'])))
$memberQuery[$row['ID_GROUP'] == 0 ? 'main_group' : 'additional'][] = $row['ID_MEMBER'];
}
mysql_free_result($request);

replace with
while ($row = mysql_fetch_assoc($request))
{
// Verify that they are not already a member - and add them to our array.
if ($row['ID_GROUP'] != $_REQUEST['id'] && !in_array($_REQUEST['id'], explode(',', $row['additionalGroups'])))
$memberQuery['additional'][] = $row['ID_MEMBER'];
}
mysql_free_result($request);


This will force all new members added to a group using the groups function (admin is unaffected) to be added as a secondary group only. If you want it to be their primary group you will have to use the admin panel sorry, until the next version when I'll include more options.
Title: Re: Group Moderators 1.0c
Post by: e2p2 on September 22, 2005, 11:29:56 AM
Is there a time frame on when this mod will be updated to support RC1?  Also can you add a button, maybe on the home page (for those with Group Mod Permissions), to access the group mod page.
Title: Re: Group Moderators 1.0c
Post by: Dannii on September 22, 2005, 08:15:26 PM
A permission will be added in the next version, but it will be up to everyone else to make buttons. RC1... maybe after I download it.
Title: Re: Group Moderators 1.0c
Post by: zwilson on September 26, 2005, 01:24:18 AM
I'm having problems with the settings saving.  I've installed the package, and when I have action=groups? the box and everything comes up, so I know it's installed.  However, my problem comes when I try to add moderators for the groups.  I'm in the "Manage Membergroups" area and when I modify a group I get two boxes with "Group Moderator(s)" where I have added my moderators and have pressed save.  But nothing happens.  When I return the group moderators aren't there and when I try the "action="groups?" there is no change.  Is it not recording the changes?  Do I need to change some settings or permissions somewhere?  Please help.
Title: Re: Group Moderators 1.0c
Post by: Harelin on September 26, 2005, 02:15:33 AM
Quote from: zwilson on September 26, 2005, 01:24:18 AM
I'm having problems with the settings saving.  I've installed the package, and when I have action=groups? the box and everything comes up, so I know it's installed.  However, my problem comes when I try to add moderators for the groups.  I'm in the "Manage Membergroups" area and when I modify a group I get two boxes with "Group Moderator(s)" where I have added my moderators and have pressed save.  But nothing happens.  When I return the group moderators aren't there and when I try the "action="groups?" there is no change.  Is it not recording the changes?  Do I need to change some settings or permissions somewhere?  Please help.

What exactly are you typing in the field?  It is fairly sensitive; mistype a moderator's name and you will not receive an error message.  Likewise, if you're inputting several moderators per group and don't separate the names with commas (i.e. moderator1 moderator2 moderator3 as opposed to moderator1,moderator2,moderator3), it will have the exact result you're reporting.  Consider for a second whether your input could be flawed in any way.
Title: Re: Group Moderators 1.0c
Post by: zwilson on September 26, 2005, 02:28:46 AM
Hey, well I kind of got it working.  The input wasn't flawed.  I just had to enter in the moderators name in the bottom field instead of the upper field.  This makes me believe it might have been installed twice, and the upper field was just reminiscent of the previous install - and because of the second install it rendered it defective?  If that's the case it was my fault.  Anyway - I think I got it going - thanks for the help!  Great mod!
Title: Re: Group Moderators 1.0c
Post by: Dannii on September 26, 2005, 02:56:29 AM
Hmm :S There should only be one field.

For input, its done exactly how its done for entering moderators for a board. Prehaps I should make it better.. Anyways, if you're not sure, use the search tool and add them that way, with a comma between each. The search tool will always return the proper username
Title: Re: Group Moderators 1.0c
Post by: Harelin on September 26, 2005, 06:26:57 PM
I think the input is fine, unless other people are reporting problems.  That was just a suggestion to troubleshoot.  A note to separate names with commas would be a nice touch, but not necessary.
Title: Re: Group Moderators 1.0c
Post by: ^Raven^ on October 26, 2005, 11:29:52 PM
I just want to be sure I understand this properly.  I could create a group called like Overlords.  Then add members to that group.  The Overlords group could then be assigned as mods to certain boards on my forum.  That would allow everyone in the Overlords group to have moderator control of those certain boards.  Is this correct?
Title: Re: Group Moderators 1.0c
Post by: Dannii on October 26, 2005, 11:48:09 PM
No, although I am possibly going to add the possibility of setting a group as a mod over a board in the future.

This mod allows you to set individuals who can add and delete members to their group. This can be used instead of the manage-membergroups permission if you don't want them to have access to every group in your forum.

Example.
Person A is an admin
Person B leads a private group of the forum
Person C wants to be a member of that group
Person D leads another private group
In the old system B and C would have to ask A to add C to the group, or else A could give B permissions over everygroup, but then person D wouldn't be very happy.

In my mod person B can add C him/herself. A and D don't even have to know. This will be very useful for large forums where the admin previously would have to be adding 20 people a day to various groups.
Title: Re: Group Moderators 1.0c
Post by: ^Raven^ on October 26, 2005, 11:50:41 PM
Oh I get it now.  Not really useful for my forum.  But, when you add the feature, which will allow the group to be a mod over a board or multiple boards it'll be very useful.  I believe I installed the mod ages ago thinking it would allow the group to moderate boards with me (the owner/admin) placing members in the group.

Any idea when you'll be doing that?
Title: Re: Group Moderators 1.0c
Post by: Dannii on October 26, 2005, 11:56:56 PM
Actually I'm thinking now it would be better suited as a separate mod, because they are independant. I would make this mod integrate with it though.

However it's not even needed, if you use local permissions for the board any group can be moderator.
Title: Re: Group Moderators 1.0c
Post by: ^Raven^ on October 27, 2005, 12:01:53 AM
Not sure I understand how to do that.  Of course, I've been told by David to avoid local permissions because they help people make mistakes and owners tend to forget about them especially on forums my size or larger.
Title: Re: Group Moderators 1.0c
Post by: BlueGoku on November 02, 2005, 04:18:22 PM
Any idea when a new version of this is released so it's compatible with 1.1 RC1?
Title: Re: Group Moderators 1.0c security threat - UNINSTALL NOW
Post by: Dannii on November 13, 2005, 01:09:26 AM
zwackelmann has alerted me to a very serious security threat. Please immediately uninstall this mod until I can release a fixed version. Sorry :'(
Title: Re: Group Moderators 1.0c
Post by: Harelin on November 13, 2005, 07:22:24 PM
ETA?  I hope this won't require a huge amount of re-coding on your part.  This mod is the backbone of my forum.
Title: Re: Group Moderators 1.0c
Post by: Dannii on November 13, 2005, 09:42:19 PM
I know the problem so as soon as I can fix it I will release. Hopefully later today. RC1 and new features will still have to wait till after my exams.
Title: Re: Group Moderators 1.0c
Post by: Harelin on November 13, 2005, 10:49:01 PM
No complaints about RC1... I'm still on 1.0.5 myself :)

Thanks for all your work - this mod has been of great use.
Title: Re: Group Moderators 1.1
Post by: Dannii on November 15, 2005, 10:08:44 AM
Version 1.1 has been released
el_groupmods_11.tar.gz (http://mods.simplemachines.org/index.php?a=download;mod=171;id=11143)
changelog.txt (http://mods.simplemachines.org/index.php?a=download;mod=171;id=11144)

The security flaw has been fixed. In addition, the permissions 'band-aid' fix has been incorporated.
Title: Re: Group Moderators 1.1b
Post by: Dannii on November 24, 2005, 05:34:25 AM
Version 1.1b has been released
el_groupmods_11b.tar.gz (http://mods.simplemachines.org/index.php?a=download;mod=171;id=11403)
changelog.txt (http://mods.simplemachines.org/index.php?a=download;mod=171;id=11405)

This should now work for 1.1 RC1. Please tell me if it doesn't.
Title: Re: Group Moderators 1.1b
Post by: Dannii on November 25, 2005, 08:41:44 AM
If you have used this mod can you please post in this poll?

http://www.simplemachines.org/community/index.php?topic=58064.0
Title: Re: Group Moderators 1.1b
Post by: Dannii on November 27, 2005, 09:04:52 AM
Argh another bug. v1.1b won't allow you to add new group moderators. it's a simple bug to fix but I don't really want to make another release as I'm trying to do more and add extra features. So unless you're on 1.1RC1 just use the v1.1 release. I'll fix this in a few days, or ASAP if someone is using RC1 and asks me to.
Title: Re: Group Moderators 1.1b
Post by: BlueGoku on November 29, 2005, 12:21:53 PM
We're using RC1, think you can fix it for us?
Title: Re: Group Moderators 1.1b
Post by: Dannii on November 29, 2005, 11:24:41 PM
Sure. I'm not at home now but I'll try and release it later today.
Title: Re: Group Moderators 1.2
Post by: Dannii on November 30, 2005, 04:57:09 AM
Version 1.2 has been released
el_groupmods_12.tar.gz (http://mods.simplemachines.org/index.php?a=download;mod=171;id=11560)
changelog.txt (http://mods.simplemachines.org/index.php?a=download;mod=171;id=11561)

Okay This now should work in 1.1RC1.
There are also numerous code changes, most of which won't matter to you. There is a significant change in functionality though. There will be a tick box in the "Edit group" page under the list of group moderators. If it is unchecked (default) then new members added through the groups interface will be forced into a secondary group. If it is checked then if new members have no primary group, when added they will then change to that group as primary. Only check the box for groups which have full normal permissions. Otherwise they will be incapacitated.
There are also some small template changes, including a nice linktree :)
Title: Re: Group Moderators 1.2
Post by: BlueGoku on December 01, 2005, 07:22:57 PM
Thanks a million! We've got so many private boards and groups on our board that it would be a nightmare for the admin to take care of everything. We used the mod back when we were using 1.0.5, but ever since we updated it's been difficult to keep up with all the group changes.

Thanks again.
Title: Re: Group Moderators 1.2
Post by: BlueGoku on December 03, 2005, 07:05:16 PM
We slightly modified the script so group mods get a text button at the top taking them to the group mod screen. Today I had some free time and made a gif button for it (for the default forum theme, since that's what we use), here it is in case anyone else wants to use it:

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg225.imageshack.us%2Fimg225%2F415%2Fgroups4uj.gif&hash=6682c53d2478d4b93eda34383498c3b418f8ae4a)
Title: Re: Group Moderators 1.2
Post by: Dannii on December 03, 2005, 09:46:52 PM
Ahh great :D
In the next version I will make a new permission for this, and will edit the default theme. Do you mind if I use that image? When that's done you'll be able to select exactly which groups can view the groups page with the new permission, and the image will show only to those groups.
Title: Re: Group Moderators 1.2
Post by: BlueGoku on December 04, 2005, 12:13:50 AM
That sounds neat. Sure, you're welcomed to use the image.
Title: Re: Group Moderators 1.2
Post by: ZuMe on December 09, 2005, 06:55:50 AM
Quotehm. I tried to install that, but it seems not to work. Im using your 1.2 mod and SMF 1.1 RC 1.
When i enter index.php?action=groups, the forum says "error - couldnt load the main template".

In the administration backend, there is a textfield for entering a username, i guess, but it is not labled in any way so i dont know what should be entered there. anyway, when i enter a username and click on submit, i just get a php error "Fatal error: Call to undefined function: insertgroupmods() in {homedir}/Sources/ManageMembergroups.php on line 510"

If i saw it right what the installer does, this mod only works with the default template and english language then ?

isn't there any way to at least include other templates ? I wouldnt mind about a little english in my german forum, but i mind about blowing to hell my stylesheet :(

I have to correct myself. Even if i change the language and the stylesheet to english and default, both of the errors above occur. What am i doing wrong ? The package installation said everything was installed correctly.

--> I think i found the error. Some files had 0 bytes when they where installed. When i downloaded the package to my harddisk, extracted it and uploaded those files manually, it works. Perhaps, this is due to the name of the file ? (there are [ and ] in there, which totally flipped over my browser at first.)

yours,
ZuMe


Title: Re: Group Moderators 1.2
Post by: ZuMe on December 09, 2005, 08:03:07 AM
if someone could tell me what to insert here so only moderators can see it :
if ($context['allow_??????'])

i could insert that button and be happy all over  :D

Yours
ZuMe


Title: Re: Group Moderators 1.2
Post by: Dannii on December 09, 2005, 09:57:35 AM
There shouldn't be any [ or ] in the file names... But yes uploading the files again should fix it.

It should work in any template (as the default will be used), however only in English. There are however only about 10-15 texts, if you feel up to translating them I will certainly include them in the next version.

You won't be able to do such tests in 1.2, however in 1.3 there is a permission and button in the default theme. It will be very easy to add buttons to other themes.
Title: Re: Group Moderators 1.2
Post by: ZuMe on December 10, 2005, 10:24:20 AM
Hmm.. Eldacar, i translated the texts into german and this works out great - thanks again !

As i'm administering a german roleplay project right now, i made those texts (as well als all the others in that specific forum) sound a little archaic and generally adressed everyone with the german equivalent of "thee, thy" etc.
While i think this would probably bring a smile on the faces of a lot of people, I think it wouldn't be much of a help at more serious projects  :D

Anyway, it really wasn't a lot of work. So if you like, i will give you a correct (modern ;)) german translation asap. Would you like a german informal or a formal translation ? (there's always the point on how to adress someone in german, "Sie" or "Du") - or both ?
Probably I can also change the button accordingly.

Yours
ZuMe
Title: Re: Group Moderators 1.2
Post by: Dannii on December 10, 2005, 10:26:12 PM
Hmm informal or formal? :S I'm not really sure. Formal probably? It's up to you. :)
Title: Re: Group Moderators 1.2
Post by: ZuMe on December 11, 2005, 07:11:01 AM
http://www.doogle.de/downloads/el_groupmods_12_germanchanges.zip

Actually, there isn't much need to change GroupMods_language.xml also, but i just translated anything that was there.  ;)
It's formal now, i think that fits anyway.

yours
Suse
Title: Re: Group Moderators 1.3
Post by: Dannii on December 12, 2005, 12:22:58 AM
Version 1.3 has been released
el_groupmods_13_r11.tar.gz (http://mods.simplemachines.org/index.php?a=download;mod=171;id=11931)
changelog.txt (http://mods.simplemachines.org/index.php?a=download;mod=171;id=11874)

There is now a permission which determines where someone can view the groups page. It is on by default. There's also a simple description for the "who's online page", and there is a button in the default theme.
If you wish to add a button in a different theme, here is the basic code which you can alter to fit your specific theme: // View Groups Interface... [groups]
if (allowedTo('view_groups'))
echo '
<a href="', $scripturl, '?action=groups">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/groups.gif" alt="' . $txt['elgm4'] . '" style="margin: 2px 0;" border="0" />' : $txt['elgm4']), '</a>', $context['menu_separator'];
I haven't incorporated ZuMe's German translations, but i will in the next version. ZuMe, could you PM me with your Email address?

Oh, and hopefully there won't be any bugs, but if there are, please post them here.
Title: Re: Group Moderators 1.3
Post by: Dannii on December 15, 2005, 03:57:28 AM
I've been told the mod was upload was corrupted. I checked and it seemed fine to me, but I uploaded it again: http://mods.simplemachines.org/index.php?a=download;mod=171;id=11931
Title: Re: Group Moderators 1.3
Post by: xcooling on December 15, 2005, 08:35:10 AM
workign now, thanks
Title: Re: Group Moderators 1.3
Post by: xcooling on December 19, 2005, 06:38:19 AM
I have installed the mod.

I would like to nkow how i would go about assigning a moderator to a specific group
Title: Re: Group Moderators 1.3
Post by: Dannii on December 19, 2005, 06:51:38 AM
Edit the specific group in the admin section, and you'll see a field there. add the exact names of the users you want there, separate by commas.
Title: Re: Group Moderators 1.3
Post by: xcooling on December 19, 2005, 07:50:50 AM
thanks
Title: Re: Group Moderators 1.3
Post by: L.G.S on December 19, 2005, 08:02:32 AM
it installs fully,

but when I click Groups it comes up with a groups table, but with no ADD button?
Title: Re: Group Moderators 1.3
Post by: Dannii on December 19, 2005, 09:11:40 AM
What are you wanting to add?
Title: Re: Group Moderators 1.3
Post by: L.G.S on December 19, 2005, 09:17:10 AM
a user or group?

In the index.php?action=groups

its all text, I have no add features,

I checked member groups and permissions, but it doesnt have anything about groups
Title: Re: Group Moderators 1.3
Post by: Dannii on December 19, 2005, 09:19:19 AM
This mod has nothing to do with making new groups. Add groups through the admin groups page...
Title: Re: Group Moderators 1.3
Post by: Harelin on December 19, 2005, 10:00:54 PM
Quote from: The Outsider on December 19, 2005, 09:17:10 AM
a user or group?

In the index.php?action=groups

its all text, I have no add features,

I checked member groups and permissions, but it doesnt have anything about groups

Add yourself as a moderator to a group, and then visit the index.php?action=groups page.  You'll see the fully functional meat of the mod at that point (click on the # next to the group name).
Title: Re: Group Moderators 1.3
Post by: L.G.S on December 20, 2005, 08:00:48 AM
That's the thing, I have no option to create myself as a moderator for any group
Title: Re: Group Moderators 1.3
Post by: Dannii on December 20, 2005, 09:31:57 AM
Quote from: eldacar on December 19, 2005, 06:51:38 AM
Edit the specific group in the admin section, and you'll see a field there. add the exact names of the users you want there, separate by commas.
:) You add group moderators though the admin control panel.
Title: Re: Group Moderators 1.3
Post by: L.G.S on December 21, 2005, 02:05:21 PM
Can you show me an image of where it is?

As there is no option for it on the admin nav bar
Title: Re: Group Moderators 1.3
Post by: Harelin on December 21, 2005, 05:01:54 PM
Head to Admin > Edit Membergroups > and 'Modify' a membergroup in the same way you'd change its name.  The 'Group Moderators' field will be toward the bottom.  Add someone in that field, and then the respective group they're now a moderator to will be seen on the Group Moderator CP.
Title: Re: Group Moderators 1.3
Post by: Dannii on December 21, 2005, 08:28:56 PM
You have to be specifically the group moderator to do anything. In a later version I will allow admins to moderate any group without needing to be on the list.
Title: Re: Group Moderators 1.3
Post by: Ohmer on December 30, 2005, 08:54:19 PM
Hi,

I made a french translation of your mod.  I can provide it to you if you want to integrate it in a future release.
Title: Re: Group Moderators 1.3
Post by: Dannii on December 30, 2005, 10:41:47 PM
Great :)
If you could PM me your email, I'll send you an advance release of the next version (when it's ready) with instructions on what needs translating. Shouldn't be much.
Title: Re: Group Moderators 1.3
Post by: geraintw1uk on January 05, 2006, 04:10:21 PM
Pls can you help me with the installation of this mod.

i have downloaded the package so far and the zip file is sitting in the packages directory of my forum and in the browse packaces in the admin section is now seeing it the but only lets me list files or delete it, not to install, i have clicked list files and then clicked on the install file but it just shows me inside the file... im stuck not very good at this... can anyone help


edit: sorry version 1.1 rc2  fresh forum install

thanks
geraint
Title: Re: Group Moderators 1.3
Post by: Dannii on January 05, 2006, 09:08:10 PM
I haven't updated it for 1.1RC2 yet. I shall try to soon.
Title: Re: Group Moderators 1.3
Post by: Ruth on January 09, 2006, 10:16:31 PM
First let me apologize to all of you who have this thread on "watch", I've replied, deleted and replied a couple times as I discover where I'm making my mistakes.

So I finally figured out how to use the Packages Manager (never had to before and stopped trying waaaay back when it was still just a "soon-to-be-released" feature) and I finally figured out I should be CHMODing the specified files... but I still can't install this mod.

I thought, ok, maybe it's just me. So I tried installing another mod... something simple that just adds fields to the profile. No problem. It installed fine. I don't know what I've done here, it keeps telling me the files aren't writable, but I've checked all of them (and the folders they are in) and can't find any of them that aren't already writable... sooooo what's next?
Title: Re: Group Moderators 1.3
Post by: Dannii on January 09, 2006, 10:27:23 PM
Which version of SMF do you use?
Can you provide a screenshot of the messages it says when you try to install?
Title: Re: Group Moderators 1.3
Post by: Ruth on January 09, 2006, 11:45:27 PM
1.0.5 and it looks exactly the same as it does *before* I click "proceed", there's no error message, it simply doesn't install.

In the FTP Information Required field it says (as it always does) "Some of the files this package needs to modify are not writable. This needs to be changed by logging into FTP and chmoding the files."

I don't get errors, I just don't get an install. This happened on the other packages while I was fiddling around trying to figure out how to use the packages manager, until I realized I needed to CHMOD the files listed in the "here's what we're going to do" list to be writable.

I've CHMOD'd all the files listed here that state "Execute Modification", I obviously can't CHMOD the extracted files since they didn't extract :) (Just to be sure I made them all 777, writable and executable. If I get fed up fiddling, I'll change them all back before ending my session).

Installing this package will perform the following actions:  Type Action Description
1. Execute Modification ./index.php Success
2. Execute Modification ./Sources/ManageMembers.php Success
3. Execute Modification ./Sources/ManagePermissions.php Success
4. Execute Modification ./Themes/default/index.template.php Success
5. Execute Modification ./Themes/default/ManageMembers.template.php Success
6. Execute Modification ./Themes/default/languages/Modifications.english.php Success
7. Execute Modification ./Themes/default/languages/Help.english.php Success
8. Extract File ./Sources/Groups.php 
9. Extract File ./Themes/default/Groups.template.php 
10. Extract File ./Themes/default/languages/Groups.english.php 
11. Extract File ./Themes/default/images/english/groups.gif 
12. Execute Code GroupMods_install.php

Thanks for such a quick reply :)
Title: Re: Group Moderators 1.3
Post by: Dannii on January 10, 2006, 12:10:57 AM
Well that looks perfect. But it doesn't install? What happens if you go to yourdomain/index.php?action=groups
Title: Re: Group Moderators 1.3
Post by: Ruth on January 10, 2006, 05:01:15 AM
I get the main page:
http://forums.packspirit.com/index.php?action=groups

I just installed so don't mind all the test stuff and default colours and such :)
Title: Re: Group Moderators 1.3
Post by: Dannii on January 10, 2006, 05:31:50 AM
So after it comes up with that lovely list and you click install, it does nothing? I really don't know why it wouldn't be installing.
Title: Re: Group Moderators 1.3
Post by: Ruth on January 10, 2006, 06:23:32 PM
I almost threw my monitor out the window /cry

So I uninstalled the other two mods (which, as I said, were just making extra fields in the profile) and tried again. Nothing. I rechecked all the CHMOD settings for the files listed. Nothing. Then I uninstalled the message board, deleted left over files (saving Settings.php) reuploaded and reinstalled, then uploaded the package (fresh download), redid the CHMOD, tried again and nothing.

I have no idea what I'm doing wrong!

But any time I try to click "proceed" it just reloads this page:
http://forums.packspirit.com/index.php?action=packages;sa=install;package=el_groupmods_13_r111.tar.gz
(which is the page it was on to begin with)

Is it because it's not a zip file? the mods that were zips worked fine.

How do I go about manually installing this mod? it's the one mod I've wanted for SMF (And YaBBSE) since I started using the forum. I've had too many clients choose PHPBB over SMF because of a lack of this mod and I really like SMF more than PHPBB. Help! Please! lol
Title: Re: Group Moderators 1.3
Post by: Ruth on January 10, 2006, 07:13:21 PM
Update:

I uninstalled 1.0.5 and installed 1.1 RC2
I uploaded the package via the Package manager and I get this error when I "apply mod":

"The package you are trying to download or install is either corrupt or not compatible with this version of SMF. "

This is listed right where the list of files use to be listed when I tried installing on 1.0.5.

Did I miss a post in this thread about it not being compatible with RC2? If so, I apologize.
Title: Re: Group Moderators 1.3
Post by: Dannii on January 11, 2006, 03:03:33 AM
Yes it isn't 1.1 RC2 compatible yet sorry. I'll get to work on that soon.
If when i've done that, and you still can't install it, if you give me a temp admin account I'll see if I can find the problem.
Title: Re: Group Moderators 1.3
Post by: Ruth on January 11, 2006, 02:46:49 PM
Eep, sorry!

I will keep an eye out for the update (remember, offline life comes first, don't kill yourself over it). Thank you very much for your help.
Title: Re: Group Moderators 1.3b
Post by: Dannii on January 16, 2006, 03:46:19 AM
Version 1.3b has been released
el_groupmods_13b_r12.tar.gz (http://mods.simplemachines.org/index.php?a=download;mod=171;id=12895)
changelog.txt (http://mods.simplemachines.org/index.php?a=download;mod=171;id=12896)

This should be 1.1 RC2 compatible now. I haven't tested it though. Let me know if you have any problems.
Title: Re: Group Moderators 1.3b
Post by: Snape on January 19, 2006, 11:25:15 AM
Quick question- Does each group that you enable this for have to be updated with the individual names of the people you want to moderate it?  Or could you create something like a local moderators group and then make that group the group moderator for the other groups?

Let's say UserA, UserB, and UserC are your desired group moderators for boards News, Announcements, and Enhancements.  Could you create a membergroup called 'Mods', put UserA, UserB, and UserC in that group, then set 'Mods' as the group moderator for those three boards?  Then you can just add people at will to 'Mods' and don't need to update News, Announcements, and Enhancements to add/delete individuals.

Let me know if I didn't explain this well enough.  :)
Title: Re: Group Moderators 1.3b
Post by: Dannii on January 19, 2006, 10:02:34 PM
You have to set the individual users. I may add more functions later, depending on how much time I have and how hard it will be.

But i think you might miss understand what the mod is for. This doesn't have anything to do with boards. You can do what you were saying already if you use custom board permissions.
Title: Re: Group Moderators 1.3b
Post by: Snape on January 20, 2006, 09:51:37 AM
Quote from: eldacar on January 19, 2006, 10:02:34 PM
You have to set the individual users. I may add more functions later, depending on how much time I have and how hard it will be.

But i think you might miss understand what the mod is for. This doesn't have anything to do with boards. You can do what you were saying already if you use custom board permissions.
Sorry...I meant to reference groups instead of boards.  So basically, I'm looking for a group to manage select other groups.
Title: Re: Group Moderators 1.3b
Post by: Snape on January 20, 2006, 10:30:27 AM
Also- slight mod question: How could Groups.php be tweaked to allow the primary group to be overwritten if the 'allow primary' checkbox is checked for the group?
Title: Re: Group Moderators 1.3b
Post by: Dannii on January 20, 2006, 11:07:56 PM
I'm not sure... it isn't done that way anywhere is SMF and all I basically did was to borrow code. this is the code that adds them: // Verify that they are not already a member - and add them to our array.
if ($row['ID_GROUP'] != $_REQUEST['id'] && !in_array($_REQUEST['id'], explode(',', $row['additionalGroups'])))
$memberQuery[$row['ID_GROUP'] == 0 && substr_count($context['group']['options'], 'P') == 1 ? 'main_group' : 'additional'][] = $row['ID_MEMBER'];
What you'll want to do is change the current primary group to a secondary first. I'm not sure how to do that, but I might be able to have a better try tomorrow. Or if not you could try, or ask for help in the coding board. ;)
Title: Re: Group Moderators 1.3b
Post by: Ohmer on January 29, 2006, 01:17:37 PM
Hello,

When I install the SMF 1.0.6 update, I don't see anymore the "uninstall" link in the package manager for this mod.  If I remove the update, I see again the "uninstall" link.  Also, if I install the update before the group moderators mod, I cannot install the mod, because I don't see the "install" link :(.

Anyone have the same bug ?  It only happen with this mod.
Title: Re: Group Moderators 1.3b
Post by: Snape on January 29, 2006, 03:02:41 PM
Quote from: eldacar on January 20, 2006, 11:07:56 PM
I'm not sure... it isn't done that way anywhere is SMF and all I basically did was to borrow code. this is the code that adds them: // Verify that they are not already a member - and add them to our array.
if ($row['ID_GROUP'] != $_REQUEST['id'] && !in_array($_REQUEST['id'], explode(',', $row['additionalGroups'])))
$memberQuery[$row['ID_GROUP'] == 0 && substr_count($context['group']['options'], 'P') == 1 ? 'main_group' : 'additional'][] = $row['ID_MEMBER'];
What you'll want to do is change the current primary group to a secondary first. I'm not sure how to do that, but I might be able to have a better try tomorrow. Or if not you could try, or ask for help in the coding board. ;)
The thing is, I don't need to keep the original primary group.  So I'm fine with the new group replacing whatever was there before as long as the 'primary group' checkbox has been checked.
Title: Re: Group Moderators 1.3b
Post by: Dannii on January 29, 2006, 09:49:31 PM
Ohmer, it was released before 1.0.6 so that is why. If you really need to uninstall it, open the package-info.xml file and change install for="1.0.5" to "1.0.5, 1.0.6"

Sometime I'll update it properly.
Title: Re: Group Moderators 1.3b
Post by: Ohmer on February 04, 2006, 12:27:36 AM
YOur mod is not MySQL 5.0 compatible :(

This query canot be executed with MySQL 5.0:
$query = db_query("


SELECT mg.ID_GROUP, mg.groupName, mg.minPosts, mg.onlineColor, mg.stars, COUNT(mem.ID_MEMBER) AS num_members


FROM {$db_prefix}membergroups AS mg, {$db_prefix}groupmods as mods


LEFT JOIN {$db_prefix}members AS mem ON (mem.ID_GROUP = mg.ID_GROUP OR FIND_IN_SET(mg.ID_GROUP, mem.additionalGroups) OR mg.ID_GROUP = mem.ID_POST_GROUP)


WHERE mg.ID_GROUP = mods.ID_GROUP AND mods.ID_MEMBER = $ID_MEMBER


GROUP BY mg.ID_GROUP


ORDER BY mg.minPosts, IF(mg.ID_GROUP < 4, mg.ID_GROUP, 4), mg.groupName", __FILE__, __LINE__);


The error message is:
Unknown column 'mg.ID_GROUP' in 'on clause'
Fichier: /var/www/sites/forums/Sources/Groups.php
Ligne: 41


What should I modify ?

Thanks.
Title: Re: Group Moderators 1.3b
Post by: Dannii on February 04, 2006, 01:00:32 AM
FROM {$db_prefix}membergroups AS mg, {$db_prefix}groupmods as mods

to

FROM ({$db_prefix}membergroups AS mg, {$db_prefix}groupmods as mods)

Will hopefully fix it. I'll update the mod soon.
Title: Re: Group Moderators 1.3b
Post by: Ohmer on February 04, 2006, 01:55:21 AM
It works, thanks :)
Title: Re: Group Moderators 1.3b
Post by: ArkServer on February 04, 2006, 08:18:15 AM
is it possibel that anyoen can sign up for the group but the moderators of the group can accept or reject them?
Title: Re: Group Moderators 1.3b
Post by: Dannii on February 04, 2006, 10:24:10 PM
Not yet. Although they could always PM the group owner.
Title: Re: Group Moderators 1.3b
Post by: FairyPrincess on February 11, 2006, 10:42:56 PM
Eldacar, thanks for the neat mod! I'm excited to try it out. Are you considering adding the feature mentioned above to this mod that would allow members to request membership in a group allow the mod to approve or deny their request? That would be absolutely awesome if you do! Thanks again for all your hard work so far! You're a gem!

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi2.photobucket.com%2Falbums%2Fy11%2Ffluttering_fairy_princess%2Fpanda_blinkie_lavendar_ricepaper_We.gif&hash=3d108193ca9f961ab6c0a2d8e6f9c24a63261d53)
Title: Re: Group Moderators 1.3b
Post by: perplexed on February 11, 2006, 11:55:34 PM
hello

I am on RC2 now and I tried to install this today via package manager and it gave me 'test failed' in /sources/managemembergroups.php so I didnt continue as I was not sure what it would do to the forum.

I tried the latest version and then the two previous versions, all with the same error message.  I only installed RC2 today so there should be no problems?

Can you please advise how to fix this?

Thanks
Title: Re: Group Moderators 1.3b
Post by: Dannii on February 12, 2006, 05:58:10 AM
FairyPrincess, eventually I would like to, but I'm rather busy right now.
perplexed, do you have any other mods installed?
Title: Re: Group Moderators 1.3b
Post by: perplexed on February 12, 2006, 06:23:57 AM
Quote from: eldacar on February 12, 2006, 05:58:10 AM
FairyPrincess, eventually I would like to, but I'm rather busy right now.
perplexed, do you have any other mods installed?


yes, lots lol:

1. Ad Managment 1.4.1   [ Uninstall ] [ List Files ] [ Delete ] 
2. Board Notes 1.0.4   [ Uninstall ] [ List Files ] [ Delete ] 
3. Enhanced Move Tag 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
4. Karma On Memberlist 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
5. SMFShop 2.0   [ Uninstall ] [ List Files ] [ Delete ] 
6. Gmail Field 1.1   [ Uninstall ] [ List Files ] [ Delete ] 
7. PJIRC Integrated Chat Mod 2.0   [ Uninstall ] [ List Files ] [ Delete ] 
8. PaypalDonations 1.4   [ Uninstall ] [ List Files ] [ Delete ] 
9. Streaming 4.2.1b 4.2.1b   [ Uninstall ] [ List Files ] [ Delete ] 
10. Show Multiple Badges (Aka Stars) 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
11. Ultimate Shoutbox 1.33   [ Uninstall ] [ List Files ] [ Delete ] 
12. Fly Tag 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
13. Invisible Tag 1.1   [ Uninstall ] [ List Files ] [ Delete ] 
14. EmailFlash 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
15. MessagePreviewOnHover 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
16. Group Moderators 1.2  [ List Files ] [ Delete ] 
17. Enhanced Quick Reply 1.1RC2   [ Uninstall ] [ List Files ] [ Delete ] 
18. Thank You Mod 1.01  [ Apply Mod ] [ List Files ] [ Delete ]   NOT INSTALLED
19. TinyPortal 0.86  [ Apply Mod ] [ List Files ] [ Delete ]  NOT INSTALLED
20. Location Mod 1.2   [ Uninstall ] [ List Files ] [ Delete ] 
21. Karma Description Mod 1.9.4   [ Uninstall ] [ List Files ] [ Delete ] 
22. Sticky First Post (extends sticky topic) 1.2   [ Uninstall ] [ List Files ] [ Delete ] 
23. Users Online Today Mod 1.3.1   [ Uninstall ] [ List Files ] [ Delete ] 
24. Location Mod - Additional Maps 1.2   [ Uninstall ] [ List Files ] [ Delete ] 
25. Location Mod - Who Flags 1.2   [ Uninstall ] [ List Files ] [ Delete ] 




Title: Re: Group Moderators 1.3b
Post by: Dannii on February 12, 2006, 06:55:17 AM
One of those are clashing with my mod - I suspect Show Multiple Badges.

There are only 4 (mostly small changes) made to the ManageMembergroups.php file, so you should be able to make them manually:
<operation>
<search position="before"><![CDATA[
// Set variables to their proper value.
]]></search>
<add><![CDATA[
$options = $_POST['elgm_primary'] == '1' ? 'P' : '';
]]></add>
</operation>
That one is simply an extra line. Can't see problems with that.
<operation>
<search position="replace"><![CDATA[
// Do the update of the membergroup settings.
db_query("
UPDATE {$db_prefix}membergroups
SET groupName = '$_POST[group_name]', onlineColor = '$_POST[online_color]',
]]></search>
<add><![CDATA[
// Do the update of the membergroup settings.
db_query("
UPDATE {$db_prefix}membergroups
SET groupName = '$_POST[group_name]', onlineColor = '$_POST[online_color]', GroupModOptions = '$options',
]]></add>
</operation>
That one adds the last option. You can simple add GroupModOptions = '$options', to the end of the line.
<operation>
<search position="replace"><![CDATA[
// There might have been some post group changes.
]]></search>
<add><![CDATA[
// Reset current moderators for this group - if there are any!
db_query("
DELETE FROM {$db_prefix}groupmods
WHERE ID_GROUP = " . (int) $_REQUEST['group'], __FILE__, __LINE__);

// Validate and get the IDs of the new moderators.
if (isset($_POST['groupmods']) && trim($_POST['groupmods']) != '')
{
require_once($sourcedir . '/Groups.php');
insertGroupMods($_POST['groupmods'], $_REQUEST['group'], 1);
}

// There might have been some post group changes.
]]></add>
</operation>
That one is simple, shouldn't have any problems.
<operation>
<search position="replace"><![CDATA[
// Fetch the current group information.
$request = db_query("
SELECT groupName, minPosts, onlineColor, maxMessages, stars
]]></search>
<add><![CDATA[
// Fetch the current group information.
$request = db_query("
SELECT groupName, minPosts, onlineColor, maxMessages, stars, GroupModOptions
]]></add>
</operation>
This one is easy.
<operation>
<search position="replace"><![CDATA[
'allow_delete' => $_REQUEST['group'] == 2 || $_REQUEST['group'] > 4
);
]]></search>
<add><![CDATA[
'allow_delete' => $_REQUEST['group'] == 2 || $_REQUEST['group'] > 4,
'allow_primary' => substr_count($row['GroupModOptions'], 'P') == 1
);

// Group Mods.
$request = db_query("
SELECT mem.memberName
FROM {$db_prefix}groupmods AS mods, {$db_prefix}members AS mem
WHERE mods.ID_GROUP = " . (int) $_REQUEST['group'] . "
AND mem.ID_MEMBER = mods.ID_MEMBER", __FILE__, __LINE__);
$context['group']['moderators'] = array();
while ($row = mysql_fetch_assoc($request))
$context['group']['moderators'][] = $row['memberName'];
mysql_free_result($request);
]]></add>
</operation>
This one is kind of major. Firstly add 'allow_primary' => substr_count($row['GroupModOptions'], 'P') == 1 to the array. If you have others there after allow_delete, do NOT remove them. Then add the bottom code block straight after. Shouldn't be any problems there.
Title: Re: Group Moderators 1.3b
Post by: perplexed on February 12, 2006, 12:35:12 PM
could I just uninstall the multiple badges and then do it then reinstall badges later?
Title: Re: Group Moderators 1.3b
Post by: Harelin on February 12, 2006, 07:17:51 PM
Requesting to join membergroups is a good idea.

I'd have to say my wish list for this mod is, in order of preference,
1) Ability for group moderators to mass PM/email their groups
2) Ability for members to request to join groups
3) Ability to cluster membergroups under categories, so that if you have a large number of membergroups... changes can be made on a mass scale rather than having to go through each membergroup and adjust the group moderator manually.
4) Ability for group moderators to have their own static page (like the static page mod) that they can edit, would tie in nicely with the join request feature.

Just some ideas.
Title: Re: Group Moderators 1.3b
Post by: Ohmer on February 12, 2006, 07:22:24 PM
Oh, if it's the requesting day, I will request one thing also :)

I would like to assign a group as moderator of a board instead of a member name.
Title: Re: Group Moderators 1.3b
Post by: Dannii on February 12, 2006, 10:01:44 PM
Harelin, already had all of those, except for the cluster idea. interesting...
Ohmer, you can do that already through local board permissions. They won't get stars, but they will still be able to mod the board.

Perplexed, you could do so, but it's unlikely that the other mod would install properly if you install this one first.
Title: Re: Group Moderators 1.3b
Post by: Ohmer on February 12, 2006, 11:06:38 PM
Quote from: eldacar on February 12, 2006, 10:01:44 PM
Ohmer, you can do that already through local board permissions. They won't get stars, but they will still be able to mod the board.

Yes I know.  But local permissions with many forums is not the ideal solution.  It's what I do, but I would like use only global permissions and groups moderators.
Title: Re: Group Moderators 1.3b
Post by: perplexed on February 13, 2006, 02:31:24 PM
Quote from: eldacar on February 12, 2006, 10:01:44 PM
Harelin, already had all of those, except for the cluster idea. interesting...
Ohmer, you can do that already through local board permissions. They won't get stars, but they will still be able to mod the board.

Perplexed, you could do so, but it's unlikely that the other mod would install properly if you install this one first.

I had to uninstall nearly all the mods so  I could install the arcade yesterday lol so I reinstalled group moderators first and now it works perfectly.  Thanks
Title: Re: Group Moderators 1.3b
Post by: FairyPrincess on February 13, 2006, 10:25:23 PM
Quote from: eldacar on February 12, 2006, 05:58:10 AM
FairyPrincess, eventually I would like to, but I'm rather busy right now.

Eldacar, I understand how that can be (getting very busy). You seem to spend lots of time sharing your help for the SMF community, and I appreciate your efforts! If you do ever get the time and create it I'll be one happy camper. Thanks again!

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi2.photobucket.com%2Falbums%2Fy11%2Ffluttering_fairy_princess%2Fpanda_blinkie_lavendar_ricepaper_We.gif&hash=3d108193ca9f961ab6c0a2d8e6f9c24a63261d53)
Title: Re: Group Moderators 1.3b
Post by: passenger on February 13, 2006, 10:54:33 PM
Hello im hoping to get some help with installing the mod.

Just upgraded to 1.0.6, no other mods installed, i get the same problem as ruth before when running the install package some files are success and the others nothing. Same chmod problem asking for ftp access which by the way dosent do anything. Only change i made to the files was adding the install for 1.0.6 in the info xml.

The thing is even the installation of smf caused me problems, ive only been able to install themes without a problem, all other files ive been installing and chmoding them manually . So i take it is a bug.

Also I uploaded the remaining files and changed the permissions to 777 and tried to run GroupMods_install.php manually and the following error happend:

Fatal error: Call to undefined function: db_query() in /GroupMods_install.php on line 5

So big question is... how can i install the mod manually, and which files must set permissions?

Thanks a lot
Title: Re: Group Moderators 1.3b
Post by: Dannii on February 13, 2006, 11:01:24 PM
I'll update to 1.0.6 soon
Title: Re: Group Moderators 1.3b
Post by: dracomiconia on February 20, 2006, 12:57:36 PM
Waiting for upgrade to 1.06... I have almost 50 membergroups.... :D :D :D :D
Title: Re: Group Moderators 1.3b
Post by: dracomiconia on March 01, 2006, 12:51:29 PM
Is there any new in this mod?
Title: Re: Group Moderators 1.3c
Post by: Dannii on March 01, 2006, 08:43:05 PM
Version 1.3c has been released
el_groupmods_13c_r13.tar.gz (http://mods.simplemachines.org/index.php?action=download;mod=171;id=13915)
changelog.txt (http://mods.simplemachines.org/index.php?action=download;mod=171;id=13916)

This should be 1.0.6. I haven't tested it though. Let me know if you have any problems.
This also should be MySQL 5 compatible.
Title: Re: Group Moderators 1.3c
Post by: dracomiconia on March 02, 2006, 03:46:59 AM
Thank u very much.

This afternoon it will be installed (I will tell u)
Title: Re: Group Moderators 1.3c
Post by: MadPax on March 26, 2006, 02:21:31 PM
OK my question about this is:

There's no menu coming up after installation to access the mod. Where's the actual link to access it if you're admin or moderator?

I managed to get to it by doing action=groups, but there should certainly be a place to get there. I checked the code and didn't find anything that would display a link on the main menu. Is that possible to do?

Thnks.

Otherwise I might have to get rid of the smf menu and use the Joomla one.
Title: Re: Group Moderators 1.3c
Post by: Dannii on March 26, 2006, 09:12:45 PM
There is a menu button in bablyon (default for < 1.1RC2) and core.
Title: Re: Group Moderators 1.3c
Post by: dracomiconia on March 27, 2006, 04:14:40 AM
Runs in 106 with no problem....
Title: Re: Group Moderators 1.3c
Post by: MadPax on March 27, 2006, 03:54:44 PM
Had to go into my template and write the menu in myself.

No problem.

The thing is I just wanted it to show up for group moderators only but my check for that didn't work;

if ($context['is_moderator']) {.show menu here.}
Title: Re: Group Moderators 1.3c
Post by: Dannii on March 27, 2006, 10:01:25 PM
Instead do
// View Groups Interface... [groups]
if (allowedTo('view_groups'))
{ echo 'menu button'; }
Title: Re: Group Moderators 1.3c
Post by: MadPax on March 28, 2006, 07:46:36 AM
Great eldacar, /* humbly bows beneath the great god */

Thnks for the hint. ;D

Pax

Title: Re: Group Moderators 1.3c
Post by: geraintw1uk on March 30, 2006, 07:02:51 PM
hi all,

there seems to be an error with this mod when used with the tiny portal mod, it says test failed on

Installing this package will perform the following actions:  Type Action Description
1. Execute Modification ./index.php Test successful
2. Execute Modification ./Sources/ManageMembergroups.php Test successful
3. Execute Modification ./Sources/ManagePermissions.php Test failed
4. Execute Modification ./Themes/default/index.template.php Test successful
5. Execute Modification ./Themes/default/../babylon/index.template.php Test successful
6. Execute Modification ./Themes/default/ManageMembergroups.template.php Test successful
7. Execute Modification ./Themes/default/languages/Modifications.english.php Test successful
8. Execute Modification ./Themes/default/languages/Help.english.php Test successful
9. Extract File ./Sources/Groups.php 
10. Extract File ./Themes/default/Groups.template.php 
11. Extract File ./Themes/default/languages/Groups.english.php 
12. Extract File ./Themes/default/../babylon/images/english/groups.gif 
13. Execute Code GroupMods_install.php 


i have only got the tiny portal mod and the latest patch for rc2 installed on my forum.

is there any way to fix this or a patch available...

www.cyber-star.co.uk

thanks 

geraint
Title: Re: Group Moderators 1.3c
Post by: Dannii on March 31, 2006, 12:25:02 AM
Install the mod like that, and then manually make these changes to ManagePermissions.php

<operation>
<search position="before"><![CDATA[
// Restrictive - ie. guests.
$groupLevels['global']['restrict'] = array(
]]></search>
<add><![CDATA[
'view_groups',
]]></add>
</operation>

<operation>
<search position="replace"><![CDATA[
)
),
'board' => array(
'general_board' => array(
'moderate_board' => false,
]]></search>
<add><![CDATA[
),
'view_groups_group' => array(
'view_groups' => false,
)
),
'board' => array(
'general_board' => array(
'moderate_board' => false,
]]></add>
</operation>
Title: Re: Group Moderators 1.3c
Post by: mieserwicht on March 31, 2006, 07:13:39 AM
Quote from: eldacar on March 27, 2006, 10:01:25 PM
// View Groups Interface... [groups]
if (allowedTo('view_groups'))
{ echo 'menu button'; }


This Code does not work in my forum. It was correctly added by the mod installer. But even a Guest can see the Groups menu. http://dirk.quirm.de/idf/index.php?action=groups

I am using SMF 1.1 RC2 with the new offical bug fix and Group Moderators 1.3c (with slight modifications for use in a german forum).
The active template is the new default template Core.
Title: Re: Group Moderators 1.3c
Post by: Dannii on March 31, 2006, 09:38:47 AM
Guests must have that permission then.
Title: Re: Group Moderators 1.3c
Post by: mieserwicht on March 31, 2006, 11:12:50 AM
Quote from: eldacar on March 31, 2006, 09:38:47 AM
Guests must have that permission then.

Oh... I didn't notice that there was a special group-permission added.
I did not see the reason for this permission. Everyone without group-moderator-status sees nothing on this page (not even the administrator). Thatswhy it would be usefull if the button is per default hidden to all users exept group-moderators. Isn't it?
Title: Re: Group Moderators 1.3c
Post by: Dannii on March 31, 2006, 08:23:15 PM
No the button is linked to the permission. Eventually non mods will be able to do stuff at the groups page.
Title: Re: Group Moderators 1.3c
Post by: MadPax on April 01, 2006, 09:52:33 AM
Like what Eldacar?
Title: Re: Group Moderators 1.3c
Post by: mieserwicht on April 01, 2006, 11:03:40 AM
Quote from: eldacar on March 31, 2006, 08:23:15 PM
No the button is linked to the permission.

Yes. The Permission to view the groups. But there are no groups listet to users execpt group-moderators.

Quote from: eldacar on March 31, 2006, 08:23:15 PM
Eventually non mods will be able to do stuff at the groups page.

There are group-moderators, who have the permission to manage the groups. And they have the groups, they may manage, listed correctly. But no other groups are shown here.

There is one function provided by your mod: To gave the permission to single users to manage the members of single groups.
But there are to permission levels:
1. To view the groups (where only the groups are listet, where you have the second permission on)
2. To manage the members of single groups (which is only usaable if you have the first permission)

Is there a function or option in your mod I am missing? Or is the functionality like I listed above?


Besides that little problem. This is a great and very usefull mod :)
Title: Re: Group Moderators 1.3c
Post by: Dannii on April 01, 2006, 09:46:30 PM
There isn't anything more yet, but I plan to add more. Eventually group mods will be able to write a group description and set some other settings. Non-mods will be able to view the group descriptions and member lists, if they have the permission to and if the group mod wants that. An example of this will be for a team page - the admins and mods will be listed with a brief description ;)
Title: Re: Group Moderators 1.3c
Post by: geraintw1uk on April 02, 2006, 05:16:10 PM
Hi,
Still trying to edit the files for this, i am stuck as i have to files nearly the same i have "managepermissions.php" and "managepermissions.php~" which on do i change.

If i PM or email these files to someone could you do the alterations and send them back as i am really stuck now and this would be a great help.

Also i have noticed that on the permissions page for "administrator" it says that the permissions are allowed 1 and denied none and it cant be modified, is this correct and if not how do i fix it.... thanks for everyones help

Geraint

Title: Re: Group Moderators 1.3c
Post by: Dannii on April 02, 2006, 09:05:51 PM
Admin can do everything so ignore that.

.php~ files are Backups. edit the .php file
Title: Re: Group Moderators 1.3c
Post by: akmaetakta on April 09, 2006, 11:24:31 AM
hi again
i have TP 0.86 and SMF1.1Rc2 installed.
Today i had install this mod, and because i'am running TP after the installation it was required to edit manually the file ManagePermissions.php wich i had done and seems to be ok..

and now its seems something is missing cuz i can't see any button called "something groups" (lol) :|
and when i try to acess to http://portaldafisica.net/smf/index.php?action-groups (http://portaldafisica.net/smf/index.php?action-groups)
its empty... what's up? any ideas?

also

can someone tellme step by step how to add buttons...  :-\

(sorry this bad english)
Title: Re: Group Moderators 1.3c
Post by: geraintw1uk on April 09, 2006, 11:30:11 AM
Hi All,

I have also managed to get this working with TP, I found that if you uninstall TP then install Group Moderators then reinstall TP it works fine without you editing anything manually, but i am using this with a few different themes, helios tp and enterprise mainly but they do not have the groups button for this i need to swap back to smf default theme can anyone tell me how to add the button to the themes and would it be the same method to add it to all themes, i mainly want it added to helios tp and enterprise.... 

Thanks for all your help

Geraint
Title: Re: Group Moderators 1.3c
Post by: Dannii on April 09, 2006, 07:07:18 PM
Try http://portaldafisica.net/smf/index.php?action=groups
i think you'll need to translate it.

As for buttons, many of bloc's themes have a online button maker you can use.

I'm also considering updating this mod to try and remove the incompatibilities. If you have it installed you won't have to update though.
Title: Re: Group Moderators 1.3c
Post by: corrigan on April 10, 2006, 05:52:54 PM
I tried to install this on my new 1.0.7 install and it said it wasn't for this version (or something like that).  I went into the "package-info.xml" file and added 1.0.7 into the "install for" line.

Now I'm getting the same error that people had with the 1.0.6 version where it just doesn't seem to install correctly and it asks me to ftp to fix the permissions.

Is there a 1.0.7 update coming soon?
Thanks

btw this mod sounds great.
Title: Re: Group Moderators 1.3c
Post by: Dannii on April 11, 2006, 02:22:58 AM
I'll update it for 1.0.7 soon, but it shouldn't require anything more than just adding 1.0.7 to the install for line.
If you're getting ftp errors that is a problem with your server and package manager, and not related to this mod.
Title: Re: Group Moderators 1.3d
Post by: Dannii on April 14, 2006, 12:34:26 AM
Version 1.3d has been released
el_groupmods_13d_r14.tar.gz (http://mods.simplemachines.org/index.php?action=download;mod=171;id=15177)
changelog.txt (http://mods.simplemachines.org/index.php?action=download;mod=171;id=15178)

This should be 1.0.7. I haven't tested it though. Let me know if you have any problems.
This should also (hopefully) install with no problems on TinyPortal SMF's.
Title: Re: Group Moderators 1.3d
Post by: ChrisFBBS on April 23, 2006, 12:20:56 AM
Where and what do I edit to get the button there for the mods? I have tried everything listed here. From editing the permissions file to editing the theme's index.template.php file.
I can get the link in the menu but it throws the whole menu off, and the button doesn't show up. Thepath is correct I checked that. I have tried quite a few different times and I still can not get it right.
This is such a great mod too!!
Any help is greatly appreciated!! :)

What am I doing wrong?
Title: Re: Group Moderators 1.3d
Post by: Dannii on April 23, 2006, 07:42:55 AM
Which theme?
Title: Re: Group Moderators 1.3d
Post by: ChrisFBBS on April 23, 2006, 11:22:51 AM
Quote from: eldacar on April 23, 2006, 07:42:55 AM
Which theme?
TP Apollo.
Not sure if I had mentioned earlier or not. I'm using it with RC2 and TP 0.8.6.
Title: Re: Group Moderators 1.3d
Post by: Dannii on April 23, 2006, 07:44:12 PM
There is no Apollo image in the mod. You will have to make your own with Bloc's button generator.
Title: Re: Group Moderators 1.3d
Post by: ChrisFBBS on April 23, 2006, 10:54:51 PM
Quote from: eldacar on April 23, 2006, 07:44:12 PM
There is no Apollo image in the mod. You will have to make your own with Bloc's button generator.
I'm not that much of a noob!!  :)
I'm only enough of a noob not to know which file I need to edit.
Thanks for all you have done!!! :)
Title: Re: Group Moderators 1.3d
Post by: Dannii on April 23, 2006, 10:56:30 PM
Edit index.template.php in themes/Apollo. Apollo doesn't use tabs, so have a look at the changes made to themes/Babylon, which is more similar.
Title: Re: Group Moderators 1.3d
Post by: ChrisFBBS on April 24, 2006, 05:07:44 PM
Thanks a Lot!!  :D
I got it working and it is exactly what I needed!
I can' t thank you enough for sharing your skills and talent.
Title: Re: Group Moderators 1.3d
Post by: Fiery on April 30, 2006, 01:25:22 PM
Hello,

When I try to install 1.3d I get:

1. Execute Modification ./index.php Success
2. Execute Modification ./Sources/ManageMembers.php Failure
3. Execute Modification ./Sources/ManagePermissions.php Success
4. Execute Modification ./Themes/default/index.template.php Success
5. Execute Modification ./Themes/default/ManageMembers.template.php Success
6. Execute Modification ./Themes/default/languages/Modifications.english.php Success
7. Execute Modification ./Themes/default/languages/Help.english.php Success
8. Extract File ./Sources/Groups.php 
9. Extract File ./Themes/default/Groups.template.php 
10. Extract File ./Themes/default/languages/Groups.english.php 
11. Extract File ./Themes/default/images/english/groups.gif 
12. Execute Code GroupMods_install.php

I have

Mod Name Version   
1. SMF 1.0.6 Update 1.0   [ List Files ] [ Delete ] 
2. Integrated Chat 2.3   [ Uninstall ] [ List Files ] [ Delete ] 
3. Member Specific Permissions 1.31   [ Uninstall ] [ List Files ] [ Delete ] 
4. Visual Warning / Post Moderation 1.21   [ Uninstall ] [ List Files ] [ Delete ] 
5. Gmail Field 1.1   [ Uninstall ] [ List Files ] [ Delete ] 
6. Zodiac Signs 1.0   [ List Files ] [ Delete ] 
7. SMF Arcade 1.2.1   [ Uninstall ] [ List Files ] [ Delete ] 
8. SMF 1.0.7 / 1.1 RC2 Update 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
9. SmileysAlign 1.0.0   [ List Files ] [ Delete ] 
10. Show Multiple Group Names 0.1   [ Uninstall ] [ List Files ] [ Delete ] 
11. Topic Ratings 1.02   [ Uninstall ] [ List Files ] [ Delete ] 
12. Static Page Mod 1.3  [ Apply Mod ] [ List Files ] [ Delete ] 
13. Thread's Bookmarks 1.2  [ List Files ] [ Delete ] 
14. Total Login Time, Days to Day 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
15. MySQL 5.0.12 Compatibility Update 1.0   [ List Files ] [ Delete ] 
16. Karma Log 1.0.2   [ Uninstall ] [ List Files ] [ Delete ] 
17. Buddy List 1.21   [ Uninstall ] [ List Files ] [ Delete ] 
18. OnLine Users Today 1.3   [ List Files ] [ Delete ] 
19. Topic Solved 1.21   [ Uninstall ] [ List Files ] [ Delete ] 
20. Group Moderators 1.0b   [ List Files ] [ Delete ] 
21. Message Icon Manager (Quick Reply) 1.2   [ Uninstall ] [ List Files ] [ Delete ] 
22. Board Notes 1.0.2  [ Apply Mod ] [ List Files ] [ Delete ] 
23. Lots_o_Smileys 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
24. Report PM to Administrator 0.2   [ Uninstall ] [ List Files ] [ Delete ] 
25. Award Mod 1.0  [ Apply Mod ] [ List Files ] [ Delete ] 
26. PHP 4.4.0 Compatibility Update 1.0   [ List Files ] [ Delete ] 
27. MySpace Field 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
28. The Bar Of Experience 1.2  [ Apply Mod ] [ List Files ] [ Delete ] 
29. Group Moderators 1.3d   [ Uninstall ] [ List Files ] [ Delete ] 
30. Message Icon Manager 1.2   [ Uninstall ] [ List Files ] [ Delete ] 
31. G&S_Sticky 1.1   [ List Files ] [ Delete ]

What do I need to fix?

Thanks!
Title: Re: Group Moderators 1.3d
Post by: Fiery on April 30, 2006, 03:38:45 PM
Apparently I have 1.0b installed (I had no idea).  There is no uninstall for this, how do I get rid of it?  The uninstall php file that was added to the mod page says to only use it if you are never installing this mod again..and I want to use the newer version.

Let me know.

Thanks,

Brian
Title: Re: Group Moderators 1.3d
Post by: Dannii on April 30, 2006, 08:41:36 PM
What version of SMF do you have?

If you can post or PM me your ManageMembers.php file I'll fix it.
Title: Re: Group Moderators 1.3d
Post by: Fiery on May 01, 2006, 01:54:55 PM
Quote from: eldacar on April 30, 2006, 08:41:36 PM
What version of SMF do you have?

If you can post or PM me your ManageMembers.php file I'll fix it.

Hello,

Thank you for your reply.  I am using 1.0.7 ... I  PMed you.

---

The file is also at http://www.ndbison.com/managemembers.txt (it wouldnt attach to this message)
Title: Re: Group Moderators 1.3d
Post by: Dannii on May 04, 2006, 02:42:30 AM
Okay try replacing it with this one.
If that doesn't work, try replacing it with a new copy from the 1.0.7 install package, but be careful because that might break your other mods.
Title: Re: Group Moderators 1.3d
Post by: Fiery on May 04, 2006, 05:01:06 PM
Hello,

Thanks for the attempt, but it does not work.  With your code when I try to modify the member groups I get the following error on the Edit Group page:

An Error Has Occurred!
2: implode(): Bad arguments.
File: /public_html/forums/Themes/default/languages/ManageMembers.english.php (eval?)
Line: 192

However without your changes it doesnt have any errors on that page.  The only error is on the groups page it is:

2: call_user_func(ModifyMembergroups): First argument is expected to be a valid callback
File: /home/ndbisonc/public_html/forums/index.php
Line: 119

without your modification.  If you would not mind looking at my index.php, it is attached below.

Thank you!
Title: Re: Group Moderators 1.3d
Post by: Dannii on May 08, 2006, 02:56:30 AM
Remove the following line from index.php
'groups' => array('Groups.php', 'ModifyMembergroups'),
Title: Re: Group Moderators 1.3d
Post by: Fiery on May 10, 2006, 12:58:31 PM
Quote from: eldacar on May 08, 2006, 02:56:30 AM
Remove the following line from index.php
'groups' => array('Groups.php', 'ModifyMembergroups'),

Sweet!  Thank you very much.  It is now working!!!  :)

Great mod!

Title: Re: Group Moderators 1.3d
Post by: DangerGirl on May 29, 2006, 08:24:10 PM
SMF RC2, GM 1.3d

Hello, I'm having an issue with my Group Mods not being allowed to moderate their groups.  They used to be able to until I upgraded from 1.05 to RC2.  The Group button does not pop up for them, and they get this when they go to the link directly:

Sorry, you're not allowed to view the Groups interface.

I can see it just fine and it appears to work just fine for me.  They're listed as Group Mods for their groups as they should be.  Is there a new setting that I'm missing maybe?  Or is there maybe a limit to how many membergroups can have group mods?

Just for reference, I had issues with having too many membergroups, but that was taken care of recently by changing memberGroups in the boards table from tinytext to mediumtext.
Title: Re: Group Moderators 1.3d
Post by: Dannii on May 29, 2006, 10:06:48 PM
That sounds like they don't have the 'view_groups' permission. Check that you've given it to them and they aren't in any groups which have it denied.
Title: Re: Group Moderators 1.3d
Post by: DangerGirl on May 29, 2006, 10:25:45 PM
Thanks for the quick reply, I absolutely love this mod.

I thought I saw something new in permissions by membergroup a month or so ago, but I thought it was my imagination because I don't see it anymore.
Title: Re: Group Moderators 1.3d
Post by: Dannii on May 29, 2006, 10:31:35 PM
The 'view_groups' permission isn't there anymore? :o
Title: Re: Group Moderators 1.3d
Post by: DangerGirl on May 29, 2006, 10:35:03 PM
If we're talking about the same thing, then correct. lol  ACP - Permissions - Modify?
Title: Re: Group Moderators 1.3d
Post by: Dannii on May 29, 2006, 10:39:05 PM
Yep.

Okay, it must have gotten removed somehow. you can add it fairly easily.

Find in ManagePermissions.php
// This is just a helpful array of permissions guests... cannot have.
Add before:
$permissionList['membergroup']['view_groups_group'] = array('view_groups' => false);
Title: Re: Group Moderators 1.3d
Post by: DangerGirl on May 29, 2006, 10:54:01 PM
Perrrfect. You rock, thanks! :D
Title: Re: Group Moderators 1.3d
Post by: SleePy on June 04, 2006, 06:35:33 PM
Hey,
Im having some problems.
Some reason when a group mod (even myself) adds a person who is not in a group they dont get that group set ast their primary group.
I checked the group and I do have checked to allow it to go to primary group. and Checked my mysql database for that group and GroupModOptions is set to 1.
I got no clue why It isn't working. It worked before I think. But for some reason I cant get it to work.
Title: Re: Group Moderators 1.3d
Post by: sbclansite.com on June 04, 2006, 06:53:47 PM
Quote from: eldacar on May 29, 2006, 10:39:05 PM
Yep.

Okay, it must have gotten removed somehow. you can add it fairly easily.

Find in ManagePermissions.php
// This is just a helpful array of permissions guests... cannot have.
Add before:
$permissionList['membergroup']['view_groups_group'] = array('view_groups' => false);

Strange guests can still view the Group Button. Shouldnt only members and others be allowed to see that group button?
Title: Re: Group Moderators 1.3d
Post by: Dannii on June 04, 2006, 10:45:21 PM
SleePy: hmmm.. I'll have a look at my code again and test it some more, but I don't know how that would be happening.

SeoFriendly, well have you given guests the view_groups permission?
Title: Re: Group Moderators 1.3d
Post by: SkyFlyer on June 06, 2006, 05:28:07 AM
I'm having a bit of a problem getting the button to show up on my custom theme... I've hammered away for about 3 or 4 hours now... I just can't seem to get it. I usually have no problem installing mods to my extra themes.... maybe its because its 4am. :(

Here is the code for the other buttons:

<td><a href="', $scripturl, '" onmouseover="titlebar.src=\'' . $settings['images_url'] . '/' . $context['user']['language'] . '/titlebar_member_home.gif\'" onmouseout="titlebar.src=\'' . $settings['images_url'] . '/blank.gif\'"><img border="0" src="' . $settings['images_url'] . '/menu/home.gif" width="40" height="40" alt="home" /></a></td>
<td><a href="', $scripturl, '?action=help" target="_blank" onmouseover="titlebar.src=\'' . $settings['images_url'] . '/' . $context['user']['language'] . '/titlebar_member_help.gif\'" onmouseout="titlebar.src=\'' . $settings['images_url'] . '/blank.gif\'"><img border="0" src="' . $settings['images_url'] . '/menu/help.gif" width="40" height="40" alt="help" /></a></td>
<td><a href="', $scripturl, '?action=search" onmouseover="titlebar.src=\'' . $settings['images_url'] . '/' . $context['user']['language'] . '/titlebar_member_search.gif\'" onmouseout="titlebar.src=\'' . $settings['images_url'] . '/blank.gif\'"><img border="0" src="' . $settings['images_url'] . '/menu/search.gif" width="40" height="40" alt="search" /></a></td>';
if ($context['allow_calendar']) {
echo ' <td><a href="', $scripturl, '?action=calendar" onmouseover="titlebar.src=\'' . $settings['images_url'] . '/' . $context['user']['language'] . '/titlebar_member_calendar.gif\'" onmouseout="titlebar.src=\'' . $settings['images_url'] . '/blank.gif\'"><img border="0" src="' . $settings['images_url'] . '/menu/calendar.gif" width="40" height="40" alt="calendar" /></a></td>';
} else
echo ' <td><a href="', $scripturl, '?action=stats" onmouseover="titlebar.src=\'' . $settings['images_url'] . '/' . $context['user']['language'] . '/titlebar_member_stats.gif\'" onmouseout="titlebar.src=\'' . $settings['images_url'] . '/blank.gif\'"><img border="0" src="' . $settings['images_url'] . '/menu/stats.gif" width="40" height="40" alt="stats" /></a></td>
<td><a href="', $scripturl, '?action=who" onmouseover="titlebar.src=\'' . $settings['images_url'] . '/' . $context['user']['language'] . '/titlebar_member_who.gif\'" onmouseout="titlebar.src=\'' . $settings['images_url'] . '/blank.gif\'"><img border="0" src="' . $settings['images_url'] . '/menu/who.gif" width="40" height="40" alt="who" /></a></td>
<td><a href="', $scripturl, '?action=mlist" onmouseover="titlebar.src=\'' . $settings['images_url'] . '/' . $context['user']['language'] . '/titlebar_member_mlist.gif\'" onmouseout="titlebar.src=\'' . $settings['images_url'] . '/blank.gif\'"><img border="0" src="' . $settings['images_url'] . '/menu/mlist.gif" width="40" height="40" alt="member list" /></a></td>';
if ($context['allow_edit_profile']) {
echo ' <td><a href="', $scripturl, '?action=profile" onmouseover="titlebar.src=\'' . $settings['images_url'] . '/' . $context['user']['language'] . '/titlebar_member_profile.gif\'" onmouseout="titlebar.src=\'' . $settings['images_url'] . '/blank.gif\'"><img border="0" src="' . $settings['images_url'] . '/menu/profile.gif" width="40" height="40" alt="profile" /></a></td>';
} else {
echo ' <td><a href="', $scripturl, '?action=profile" onmouseover="titlebar.src=\'' . $settings['images_url'] . '/' . $context['user']['language'] . '/titlebar_member_profile_off.gif\'" onmouseout="titlebar.src=\'' . $settings['images_url'] . '/blank.gif\'"><img border="0" src="' . $settings['images_url'] . '/menu/profile.gif" width="40" height="40" alt="profile" /></a></td>';
}
echo ' <td><a href="', $scripturl, '?action=logout;sesc='.$context['session_id'].'" onmouseover="titlebar.src=\'' . $settings['images_url'] . '/' . $context['user']['language'] . '/titlebar_member_logout.gif\'" onmouseout="titlebar.src=\'' . $settings['images_url'] . '/blank.gif\'"><img border="0" alt="" src="' . $settings['images_url'] . '/menu/logout.gif" width="40" height="40" alt="logout" /></a></td>


Thank you very much.
Title: Re: Group Moderators 1.3d
Post by: Dannii on June 06, 2006, 05:32:16 AM
You should ask the theme's author how to add buttons, I've never seen any themes like that sorry.
Title: Re: Group Moderators 1.3d
Post by: SkyFlyer on June 06, 2006, 05:47:59 AM
Quote from: eldacar on June 06, 2006, 05:32:16 AM
You should ask the theme's author how to add buttons, I've never seen any themes like that sorry.

Ok. Thanks.
Title: Re: Group Moderators 1.3d
Post by: JohnR on June 07, 2006, 05:27:01 AM
Quote from: sbclansite.com on June 04, 2006, 06:53:47 PM
Strange guests can still view the Group Button. Shouldnt only members and others be allowed to see that group button?
I have that too. It may be because I modified index.template.php previously. Also, I have TinyPortal installed, which might make a difference, I gather it makes some fairly significant patches.

I'm just wondering, there must be an issue with conflicts between packages, in general?

(I'm fairly new to SMF.)
Title: Re: Group Moderators 1.3d
Post by: The Burning Man on June 12, 2006, 03:43:36 PM
I too am having the same issue. The mod is incredible, and everythin on it is working properly from what I have tested, except this minor issue. A guest can see the Groups pic and page.
Title: Re: Group Moderators 1.3d
Post by: Dannii on June 12, 2006, 05:24:04 PM
Well do guests have the view_groups permission, or are they seeing it even without?
Title: Re: Group Moderators 1.3d
Post by: The Burning Man on June 12, 2006, 05:56:16 PM
Argh, my apologies. That was my issue. I am a noob among noobs at this depth of forum administration. Muwhahaha.
Title: Should this install in 1.1 RC2 with the package manager?
Post by: andyevans on July 12, 2006, 12:21:17 PM
Hi,

I have downloaded 1.1 RC2 and installed the security update.

Clean new install using default core theme.

I then downloaded and installed the package 1.3d , which showed no errors and that it had been sucessfully installed.

It has created extra table in mysql
It has added the new files (group.php etc)
It has created backups of files to be modified

BUT it has NOT modified any files (they are all 777)

Do I have to do this manually?

Andy
Title: Re: Group Moderators 1.3d
Post by: Frog on July 13, 2006, 12:01:45 PM
I'm trying to install this file, but the packages are supposedly corrupt. Even trying to unzip them manualy.

Any suggestions?
Title: Re: Group Moderators 1.3d
Post by: Dannii on July 14, 2006, 02:10:29 AM
andyevans, hmm try 775 instead, if that still won't work then make a new support topic. That's a package manager problem (not specific to my mod) and someone that knows more will be able to help.

Frog, try downloading them again? I've unzipped them all and they always seem fine to me.
Title: Re: Group Moderators 1.3d
Post by: andyevans on July 14, 2006, 08:34:29 AM
Hi Eldacar,

I tried various permissions, even chown to nobody but with no luck.

I switched to 1.07 and package installed correctly!

I think I will wait for 1.1 (or whatever it will be called) to be released.

Thanks
Andy
Title: Re: Group Moderators 1.3d
Post by: tthmaz on July 19, 2006, 03:07:04 PM
Hi, when i modify a membergroup, there's an option where it says:

-----------------------------------
Allow primary group:
When someone is added through the Groups interface allow it to be set to Primary?
-----------------------------------

What does this option really means?
Title: Re: Group Moderators 1.3d
Post by: Dannii on July 20, 2006, 05:09:40 AM
It won't replace an existing primary group, but it will allow the group to become primary if there isn't one already.
Disabling that option will mean that anybody added through the action=groups interface will never have the new group be their primary group.
Title: Re: Group Moderators 1.3d
Post by: perplexed on July 20, 2006, 08:36:18 AM
I had this mod installed and working fine. Then I had a problem with my forum, had to back up, uninstall all the mods, and reinstall files.  I have not reinstalled this mod as it had a 'test failed' however, even though its not installed, there are tons of errors in the log on various files 'undefined index elgm4'

I cant get rid of them, any ideas how to get this gone so I can reinstall again?
Title: Re: Group Moderators 1.3d
Post by: Dannii on July 20, 2006, 08:43:24 AM
add the following to modifications.english.php$txt['elgm4'] = 'Groups';
Title: Re: Group Moderators 1.3d
Post by: perplexed on July 20, 2006, 09:03:38 AM
thanks

I would like to reinstall it but I cant seem to get it to install without 'test failed' .  I will try again and try the above

~thanks
Title: Re: Group Moderators 1.3d
Post by: perplexed on July 20, 2006, 11:31:58 AM
I am still getting errors in the log:

8: Undefined index: elgm4
File: /home/me/public_html/forum/Themes/default/Themes.template.php (main_above sub template - eval?)
Line: 577
   

8: Undefined index: mm_mm
File: /home/mepublic_html/forum/Themes/default/Themes.template.php (main_above sub template - eval?)
Line: 570

any ideas?
Title: Re: Group Moderators 1.3d
Post by: Dannii on July 20, 2006, 09:47:51 PM
Add the language entry I previously posted into modifications.english.php

as for mm_mm, it hasn't got anything to do with my mod.
Title: Re: Group Moderators 1.3d
Post by: perplexed on July 21, 2006, 11:01:38 AM
thanks, I think that might be the member map thing.  The lang entry seems to have fixed the error message - thanks :)
Title: Re: Group Moderators 1.3d
Post by: adapter on August 16, 2006, 04:20:47 AM
Hi,

Great mod but how can i use it whit other language then english?
Title: Re: Group Moderators 1.3d
Post by: Dannii on August 16, 2006, 10:02:39 AM
Unzip the package, and look at the Groups.english.php and Languages.xml file. Translate the changes made in those files.

If you send me the translations, I'll include them in the next release :)
Title: Re: Group Moderators 1.3d
Post by: adapter on August 17, 2006, 03:54:50 AM
Tanks for help going to work on it right now..

Edit: An request

1. It wold be greate  if the Groups is shown to all.
2. if a user klicks on Groups the can show all groups and apply to one.

Title: Re: Group Moderators 1.3d
Post by: doug@atd on August 23, 2006, 12:32:57 PM
Any plans to update this mod for use with 1.0.8?  I haven't used the mod with 1.0.7 yet, so I couldn't compare results if I tried it with 1.0.8.

Thanks!
Title: Re: Group Moderators 1.3d
Post by: DawnsWebDesigns on August 23, 2006, 08:57:46 PM
Will you please update this to RC3...pretty please?   :D
Title: Re: Group Moderators 1.3d
Post by: Dannii on August 24, 2006, 02:52:40 AM
Quote from: doug@atd on August 23, 2006, 12:32:57 PMAny plans to update this mod for use with 1.0.8?  I haven't used the mod with 1.0.7 yet, so I couldn't compare results if I tried it with 1.0.8.

Thanks!
It should work perfectly fine in 1.0.8 already.

Quote from: DawnsWebDesigns on August 23, 2006, 08:57:46 PMWill you please update this to RC3...pretty please?   :D
Soon.. You can try putting ;version_emulate=1.1-RC2 in the package manager url and see if that works
Title: Re: Group Moderators 1.3d
Post by: adapter on August 24, 2006, 05:50:24 AM
Quote from: DawnsWebDesigns on August 23, 2006, 08:57:46 PMWill you please update this to RC3...pretty please?   :D
Soon.. You can try putting ;version_emulate=1.1-RC2 in the package manager url and see if that works
[/quote]

I search all the filed can't find ;version_emulate=1.1-RC2. Can u explain it lite better?
Title: Re: Group Moderators 1.3d
Post by: Dannii on August 24, 2006, 06:16:57 AM
Add it straight to the end of your forum's url when you open the package manager page.
Title: Re: Group Moderators 1.3d
Post by: adapter on August 24, 2006, 06:51:41 AM
Tanks! Keep up the good work whit this mod its great for our forum
Title: Re: Group Moderators 1.3d
Post by: DawnsWebDesigns on August 24, 2006, 07:52:19 PM
Quote from: eldacar on August 24, 2006, 06:16:57 AM
Add it straight to the end of your forum's url when you open the package manager page.

I'm still lost.  Plus I tried something last night only to crash my site/had to re-upload several files & re-add several mods.  So I think I'll wait 'til you're done.  ;)
Title: Re: Group Moderators 1.3d
Post by: doug@atd on August 24, 2006, 08:04:32 PM
Thanks eldacar!

Installed the package to 1.0.8 last night and all my testing appeared successful.  I had to create the new Groups button to match my button set, but that's all.

I did have one error message that I noticed in the error log that was around the time of testing, but it seemed like everything worked, anyway:

http://.../index.php?action=membergroups;sa=edit;id=9 (I removed the path info)
8: Undefined index: elgm_primary
File: forum/Sources/ManageMembers.php (I removed the root path info)
Line: 344

Mean anything to you?

I did have one suggestion - the Groups button appears all the time, even for Guests.  No groups appear in the window if you click the button and you're not the correct Moderator, but I guess I expected the Groups button wouldn't appear for Guests (ideally, only for the correct Moderator, but the code to accomplish that would probably be a nightmare!).

Otherwise, awesome mod!  Private boards will take my forum to a new level.
Title: Re: Group Moderators 1.3d
Post by: Dannii on August 24, 2006, 09:23:08 PM
There is a permission which says whether you can view the groups interface, and whether you can see the button.

I'll have a look into that error.
Title: Re: Group Moderators 1.3d
Post by: doug@atd on August 24, 2006, 10:29:09 PM
I was able to clear the permissions for all but the new membergroup, so only the new group sees the Groups button.  But I can't get it to show only for the Moderator of the new membergroup.  Only the moderator can see the interface details, so that's good.  Can you tell me what I missed in these testing steps?

1. I registered a new member that will be the Moderator (the actual member would have done this, first).
2. I created the new membergroup, setting the new member from step 1 as the Group Moderator.
3. I set the permissions for the new group the same as the Ungrouped Members (having set them as I liked earlier), then cleared the "View the Group Interface" from all groups except my new membergroup.
4. I added the private board, setting the access to only the new membergroup, and setting the board Moderator as the same person in step 2. (now I've set Group Moderator and Moderator of the board as same person. Are both steps necessary?
5. The private board didn't show for the Moderator, so I added him to the new membergroup.
6. I registered a new member, then logged in as the new group's Moderator and added the new member to the new membergroup.

I didn't see where I could hide the Group button from the new membergroup members that are not a Moderator, but otherwise everything seems to work as expected.  Was there anything I should've done differently?

Not your mod, but a related question; I'm a little confused by the n/a on the Moderator membergroup permissions.  Is it true that if I modify the permissions of the Moderator role, even though it's n/a, that it will save settings that apply to all Moderators in all boards throughout the forum (excluding Global Moderators)?

Thanks for all your help!

***Ooops!
I just noticed something strange.  In the Member's List, the member that I set as the Moderator of the new group, and of the private board, has it's Position listed as the new group name (I did add him to the group in step 5 above). But the new member that the Moderator (myself) added to the new group (via the group interface) is listed as a "newbie".  Is that the correct result?
Title: Re: Group Moderators 1.3d
Post by: DawnsWebDesigns on August 28, 2006, 04:38:25 PM
Quote from: eldʌkaːɹ on August 24, 2006, 06:16:57 AM
Add it straight to the end of your forum's url when you open the package manager page.

When I click on packages...I get this: http://dawnswebdesigns.com/sg/index.php?action=packages

I've tried adding what you put after it & it did nothing.  Should I have put space between packages & ;

I tried to upload the package straight from the mod site...but when I clicked on install a pop up box appeared asking me if I want to open or save index.php.

Can I try to pull off using your RC2 mod on my RC3 software by adding it manually?  Cuz I think I've got the hang of adding mods manually...finally. :D  Or does anybody have an edited for RC3 version I could try to pull off manually?  ???  Cuz I want some private groups/boards. 

Even without this mod...I can still have private groups/boards...I'd just have to slap a mod on each one right?  I couldn't have the groups moderate their own boards with a leader is all right?  Cuz my forum's a support group site.  To protect peeps privacy most of it's blocked off to guests.  But once peeps register...it's open.  I want to allow kids...they need support too...but I don't want them to see most of the support group boards.  I'd like private groups/boards for them...plus they can see anything guests can see.  I also want private groups/boards for shy men & women.  Plus a moderators group/board.

So to have all this...without your mod...I'd have to make my mods all global mods to allow them access to their own private group/board...right?  Otherwise I'd have to add each mod to that board invidually & could end up with quite a list of names next to that board...right?  Thanks...in advance...for any/all help.  :D
Title: Re: Group Moderators 1.3d
Post by: Dannii on August 30, 2006, 02:51:31 AM
Doug: The permissions allows everyone to see it, regardless of whether they can do anything in the Groups page. This is because I plan to eventually add more features that non-mods can do there.
If you only want your group mods to view the page, you'll have to make a new group for them, and only give them the permission.
QuoteNot your mod, but a related question; I'm a little confused by the n/a on the Moderator membergroup permissions.  Is it true that if I modify the permissions of the Moderator role, even though it's n/a, that it will save settings that apply to all Moderators in all boards throughout the forum (excluding Global Moderators)?
Correct.
QuoteI just noticed something strange.  In the Member's List, the member that I set as the Moderator of the new group, and of the private board, has it's Position listed as the new group name (I did add him to the group in step 5 above). But the new member that the Moderator (myself) added to the new group (via the group interface) is listed as a "newbie".  Is that the correct result?
There is an 'allow primary' option for each group. If this is enabled, then members added through the groups page will have the new group added as their primary group if they currently have no primary group. If it's disabled, all new members will always have the new group added as a secondary group.
The setting does not influence anything other than the groups page though.

DawnsWebDesigns: try http://dawnswebdesigns.com/sg/index.php?action=packages;version_emulate=1.1-RC2
And yes you can add the mod manually, but it takes a little bit of work ;)
Title: Group Moderators 1.3d & 1.1RC3
Post by: IlyZor on September 03, 2006, 07:58:22 AM
Hey folks,
I've got 1.1RC3 and want to install 1.3d (worked on RC2). But there's no install link? We've got about 20 groups on our forums and not having group mods significantly increases the work of the admins. PMs there and here.

Can anyone please tell what's wrong?
Title: Re: Group Moderators 1.3d
Post by: Dannii on September 03, 2006, 08:02:41 AM
Until I get around to releasing another version, try what I said above about adding ;version_emulate=1.1-RC2 to the end of your package manager url.
Title: Re: Group Moderators 1.3d
Post by: IlyZor on September 03, 2006, 05:02:27 PM
Thanks but it looks like there are some probs with the default template and the package.
Title: Re: Group Moderators 1.3d
Post by: Dannii on September 03, 2006, 08:14:55 PM
Which problems? What errors did you get?
Title: Re: Group Moderators 1.3d
Post by: IlyZor on September 04, 2006, 10:23:04 AM
This is what I get when I press the groups button in the default template (+ other old ones):

An Error Has Occurred!
Unable to load the 'main' template. 
Title: Re: Group Moderators 1.3d
Post by: Dannii on September 04, 2006, 10:35:00 AM
Check that the Groups.template.php file has been installed properly. If it hasn't, unzip the install file and copy it to the Themes/default/ folder manually with FTP.
Title: Re: Group Moderators 1.3d
Post by: SleePy on September 04, 2006, 01:00:09 PM
Hey eldʌka,

How Would I change it so Administrators can see all groups?
I prefer using this over editing a persons account (unless changing primary group) when adding people into groups.

I looked at your source Code but My mysql knowledge is limited which is what I need to get it to show all for admins.
Title: Re: Group Moderators 1.3d
Post by: Dannii on September 04, 2006, 09:57:40 PM
Add them to the list of mods for each group. There's no easy way sorry.
Title: Re: Group Moderators 1.3d
Post by: SleePy on September 04, 2006, 11:27:58 PM
no easy way...

Hmm.. I like hard..  ;)
I will attempt anything that will work..
Title: Re: Group Moderators 1.3d
Post by: IlyZor on September 08, 2006, 07:35:50 AM
Quote from: eldʌkaː on September 04, 2006, 10:35:00 AM
Check that the Groups.template.php file has been installed properly. If it hasn't, unzip the install file and copy it to the Themes/default/ folder manually with FTP.

Looks like it wasn't properly installed. 0 byte. So I replaced it with the one in the .zip package. You write that Im supposed to move the install file there. What do I do after that? Do I need to uninstall it and install it manually?
Title: Re: Group Moderators 1.3d
Post by: Dannii on September 08, 2006, 07:57:28 AM
Unzip the file, and then copy only Groups.template.php to /Themes/default
Leave everything else the same for now.
Title: Re: Group Moderators 1.3d
Post by: IlyZor on September 08, 2006, 12:12:24 PM
That's done now. But I get the same error.

"Unable to load the 'main' template. "
Title: Re: Group Moderators 1.3d
Post by: Dannii on September 08, 2006, 10:19:01 PM
Run this querry in phpmyadmin so it will return a more descriptive message.  It will change eval() to require()


REPLACE INTO smf_settings VALUES ('disableTemplateEval', '1');

What is phpMyAdmin? (http://www.simplemachines.org/community/index.php?topic=21919.0)

Hopefully that will give a better error message.
Title: Re: Group Moderators 1.3e
Post by: Dannii on September 09, 2006, 03:31:38 AM
Version 1.3e has been released
el_groupmods_13e_r15.tar.gz (http://mods.simplemachines.org/index.php?action=download;mod=171;id=18810)
changelog.txt (http://mods.simplemachines.org/index.php?action=download;mod=171;id=18811)

This should install on 1.1 RC3. If you're not using 1.1 RC3, ignore this release.
Title: Re: Group Moderators 1.3e
Post by: IlyZor on September 09, 2006, 01:09:54 PM
It works. Thank you very much!  :)
Title: Re: Group Moderators 1.3e
Post by: URPG on September 10, 2006, 08:11:55 AM
This does allow moderators to add users to certain groups... nice :)

Questions:
Can i select the groups moderators are able to add / remove users from?
Will moderators be able to see all usergroups?
Title: Re: Group Moderators 1.3e
Post by: Dannii on September 10, 2006, 08:29:31 AM
Yes, add the mods in the edit group page. They see only the groups which they have permission for.
Title: Re: Group Moderators 1.3e
Post by: DawnsWebDesigns on September 11, 2006, 08:06:36 PM
You posted a link for me to use before & it completely crashed my site.  Now I've just tried your latest release for 1.1 RC3 & had an error uploading it.  Now I can't get into packages to do squat...I keep getting an error page.  Hopefully I can get into the directory on the server & delete this package & all will be well.  :(
Title: Re: Group Moderators 1.3e
Post by: Medice on September 12, 2006, 06:51:33 PM
nice mod - but there seems to be a smal glitch:

if you click on the "!" Icon next to the Group-Mod-Name-Definition-field, the pop-up-window is unable to enter a membername

modifying "GroupMods_templates_11.xml":
find "action=findmember;input=groupmods;"
change into "action=findmember;input=groupmods_input;"

this helped and seems to be wrong in GroupMods_templates_11rc1.xml as well but is correct in 105-version.
Title: Re: Group Moderators 1.3e
Post by: Dannii on September 12, 2006, 08:57:45 PM
Thanks for finding that! :)
Title: Re: Group Moderators 1.3e
Post by: mpenfield on September 18, 2006, 10:46:35 AM
Thanks for a great mod. I installed and is working great...one question - how can I change some of the language in the Groups.english.php file ( I cannot find it on my server). Thanks!!
Title: Re: Group Moderators 1.3e
Post by: Dannii on September 18, 2006, 11:09:10 AM
Do you want to change it to another language? What do you mean you can't find it? It should be in Themes/default/languages
Title: Re: Group Moderators 1.3e
Post by: mpenfield on September 18, 2006, 02:32:55 PM
Thanks. That was what I needed. And again thanks for a terrific mod!
Title: Re: Group Moderators 1.3e
Post by: Dannii on October 03, 2006, 08:40:21 AM
DawnsWebDesigns, did you solve the problems?
Title: Re: Group Moderators 1.3e
Post by: phoenix elite on October 19, 2006, 08:14:59 AM
I can't open the file in a .tar format. Could you upload a version in a .zip format?
Title: Re: Group Moderators 1.3e
Post by: Dannii on October 19, 2006, 08:22:43 AM
Why can't you open it? You shouldn't need to though, because your server should be able to.
Title: Re: Group Moderators 1.3e
Post by: perplexed on October 20, 2006, 04:23:20 AM
Quote from: eldʌkaː on September 09, 2006, 03:31:38 AM
Version 1.3e has been released
el_groupmods_13e_r15.tar.gz (http://mods.simplemachines.org/index.php?action=download;mod=171;id=18810)
changelog.txt (http://mods.simplemachines.org/index.php?action=download;mod=171;id=18811)

This should install on 1.1 RC3. If you're not using 1.1 RC3, ignore this release.

Hi

I tried to upload this to package manager but got this message:

An Error Has Occurred!
The package you tried to upload either is not a valid package or has become corrupted.

(I'm using RC3 ) :(
Title: Re: Group Moderators 1.3e
Post by: Dannii on October 22, 2006, 09:18:12 AM
Can you try downloading it again? Noone else has had problems with it being corrupt.
Title: Re: Group Moderators 1.3e
Post by: perplexed on October 23, 2006, 05:00:10 AM
yeah I tried again and it still wont download :(  very strange
Title: Re: Group Moderators 1.3e
Post by: Dannii on October 23, 2006, 05:07:48 AM
Try the attachment.
Title: Re: Group Moderators 1.3e
Post by: Xarcell on November 06, 2006, 01:09:55 AM
I get this error in my log:

8: Undefined index: elgm_primary
File: /home/.abigaildryer/xarcell/feyorin.com/smf/Sources/ManageMembergroups.php
Line: 424

Any ideas on how to fix it?
Title: Re: Group Moderators 1.3e
Post by: Dannii on November 06, 2006, 01:28:49 AM
Thanks for reminding me about that.

Find:
$options = $_POST['elgm_primary'] == '1' ? 'P' : '';
replace:
$options = isset($_POST['elgm_primary']) && $_POST['elgm_primary'] == '1' ? 'P' : '';

It will be fixed in the next release too.
Title: Re: Group Moderators 1.3e
Post by: Xarcell on November 06, 2006, 12:19:02 PM
which file?
Title: Re: Group Moderators 1.3e
Post by: Dannii on November 07, 2006, 08:43:29 AM
ManageMembergroups.php of course, the one with the error ;)
Title: Re: Group Moderators 1.3e
Post by: Xarcell on November 11, 2006, 11:00:21 PM
Could you post an example snippet of a link to the groups page that only appears to those that actually have a group to moderate?

I think it would be better than posting a link to a groups page with no groups in it.

Thanx...
Title: Re: Group Moderators 1.3e
Post by: Dannii on November 11, 2006, 11:08:52 PM
I'm not sure what you're asking?
Title: Re: Group Moderators 1.3e
Post by: Xarcell on November 13, 2006, 09:22:02 AM
Let's say I make groups viewiable to "group 1". The link to the groups page shows up for everyone in "group 1". It comes up empty except for the modertor of that group.

How do I create a link to the groups page that only appears to person who has a group to moderate.

Here is what I'm using now:

// the Clan Management
if (allowedTo('view_groups'))
{
echo '<td class="windowbg2" onMouseOver="this.className=\'windowbg\'" onMouseOut="this.className = \'windowbg2\'">
<table border="0" cellpadding="0" cellspacing="0" margin="0" width="100%">
<td width="2" class="smalltext">:</td>
<td width="*" class="smalltext" style="padding-left: 10px;"><a href="', $scripturl, '?action=groups" target="_self">Clan Management</a></td>
<td width="2" class="smalltext">:</td>
</tr>
</table>
</td></tr><tr>';
}


I've experimented with changing:

if (allowedTo('view_groups'))

But haven't had any luck on makeing that link appear to only those who have a group they are moderating.
Title: Re: Group Moderators 1.3e
Post by: Xarcell on November 13, 2006, 12:51:13 PM
I think I was using the mod differently than intended.

I was setting it up so that 1 member of a member would be the group moderator.

Now I'm using 2 groups. A user that is a member of the group he is moderatoring, and also in a membergroup called group moderators. I made the "group moderators" could access the page. This seems to work fine. Thanx for your help, I love this mod.
Title: Re: Group Moderators 1.3e
Post by: Dannii on November 13, 2006, 07:49:25 PM
Yeah I'm not really sure if a permission is the best way. However to find out if the user is a group moderator takes an extra query, and would be much slower.. I might investigate other options but I think I'll leave it as a permission.
Title: Re: Group Moderators 1.3e
Post by: Adamzon on November 17, 2006, 11:41:31 AM
i dont get any groups showing in this mod ?? :-X

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fglidarhoj.se%2Fgroups.jpg&hash=db05dbdb3f8428ce13faae863a0e042502d9eef4)
Title: Re: Group Moderators 1.3e
Post by: Xarcell on November 17, 2006, 10:13:17 PM
All you need to do is only make the link visiable only to those that are group moderators.
Title: Re: Group Moderators 1.3e
Post by: Dannii on November 18, 2006, 07:25:46 AM
You won't see the groups listed there unless you are a group moderator for them. Even admins won't see groups. I do intend to change that however.
Title: Re: Group Moderators 1.3e
Post by: Adamzon on November 20, 2006, 09:31:52 AM
ok, so the mod wont show avalible groups to no one exemt the modurators or admins?

Title: Re: Group Moderators 1.3e
Post by: maddog1169 on November 24, 2006, 10:01:54 AM
1.1 RC3(a) Beta in use with TP Mod 0.96b

Groups seem to work even the Group mod show the correct members, however the group

"Moderators" does not get updated if I make Members Moderators ?

It shows no member count at all.

What's wrong here ?
Title: Re: Group Moderators 1.3e
Post by: Dannii on November 26, 2006, 08:27:07 AM
Adamzon: correct.

maddog1169: The "Moderators" group is special - you are only a member of it in boards for which you are in the mods list. Outside of that board they are not in it. This has been answered many times before, it would have been nice if you could have searched ;)
Title: Re: Group Moderators 1.3e
Post by: IlyZor on December 07, 2006, 02:56:02 PM
Has anyone managed to get the Group Mods work for 1.1?
Title: Re: Group Moderators 1.4
Post by: Dannii on December 07, 2006, 10:26:42 PM
Version 1.4 released!
Several major changes.. see the Changelog (http://smfgroups.googlecode.com/svn/trunk/changelog.txt) for details.
It will install on 1.1 and up now.
Title: Re: Group Moderators 1.4
Post by: aalt1n on December 08, 2006, 01:10:04 AM
I get the following error when installing this mod:

4.  Execute Modification  ./Themes/default/index.template.php  Test failed

QuoteError in Package Installation
At least one error was encountered during a test installation of this package. It is strongly recommended that you do not continue with installation unless you know what you are doing, and have made a backup very recently. This error may be caused by a conflict between the package you're trying to install and another package you have already installed, an error in the package, a package which requires another package that you don't have installed yet, or a package designed for another version of SMF.
Title: Re: Group Moderators 1.4
Post by: Dannii on December 08, 2006, 01:24:17 AM
Have you installed other mods?
Title: Re: Group Moderators 1.4
Post by: krust on December 08, 2006, 03:44:40 AM
HEllo,

I've just installed the mod and I have the same error than two messages up.

I'm administrator of the forum and register a member that is moderator. I logout and log as the member (mod).

Click on the tab 'Groups' and there is no members, ...

Don't know...
Title: Re: Group Moderators 1.4
Post by: Dannii on December 08, 2006, 07:56:03 AM
Can you provide an account on your forum and PM or email me the details please?
Title: Re: Group Moderators 1.4
Post by: aalt1n on December 08, 2006, 09:58:25 AM
Quote from: eldʌkaː on December 08, 2006, 01:24:17 AM
Have you installed other mods?
Tiny Portal 0.96 is the only mod that i have.
SMF version: 1.1.
Group Moderator mod: 1.4
Title: Re: Group Moderators 1.4
Post by: Dannii on December 08, 2006, 08:59:44 PM
I've looked at the TP code and I can't find anything that clashes.
How about you try installing it with the error, and then we can fix it after we see what's wrong.
Title: Re: Group Moderators 1.4
Post by: aalt1n on December 11, 2006, 10:35:37 AM
Quote from: eldʌkaː on December 08, 2006, 08:59:44 PM
I've looked at the TP code and I can't find anything that clashes.
How about you try installing it with the error, and then we can fix it after we see what's wrong.
Done. Everything seems to be ok.
Title: Re: Group Moderators 1.4
Post by: Dannii on December 11, 2006, 09:13:38 PM
Ok good :)
If you do come across problems in the future, please do post about them.
Title: Re: Group Moderators 1.4
Post by: rick9109 on December 14, 2006, 05:00:00 AM
Hello, I had previous versions of this mod running perfectly on previous versions of SMF (thank you by the way).  When I upgraded to 1.1, I upgraded to the latest version of the mod as well and installed it, but I still see no group buttons or any indication that the mod worked or is working.

I thought it was a theme issue, but I reset to default theme and still no dice. 


Title: Re: Group Moderators 1.4
Post by: Dannii on December 14, 2006, 06:18:48 AM
Were there any errors when you installed it? Other installed mods?
Title: Re: Group Moderators 1.4
Post by: geraintw1uk on December 14, 2006, 11:10:50 PM
Hi,

I have just installed a new fresh copy of smf 1.1 Final (complete fresh install) and intalled the latest TP mod version 0.97 but when i then install the group moderators 1.4 mod i get the following errors in the package manager.

1. Execute Modification ./index.php Test successful
2. Execute Modification ./Sources/ManageMembergroups.php Test successful
3. Execute Modification ./Sources/ManagePermissions.php Test successful
4. Execute Modification ./Themes/default/index.template.php Test failed  
5. Execute Modification ./Themes/default/../babylon/index.template.php Test successful
6. Execute Modification ./Themes/default/ManageMembergroups.template.php Test successful
7. Execute Modification ./Themes/default/languages/Modifications.english.php Test successful
8. Execute Modification ./Themes/default/languages/Modifications.swedish.php Skipping file
9. Execute Modification ./Themes/default/languages/Help.english.php Test successful
10. Execute Modification ./Themes/default/languages/Help.swedish.php Skipping file
11. Extract File ./Sources/Groups.php 
12. Extract File ./Themes/default/Groups.template.php 
13. Extract File ./Themes/default/languages/Groups.english.php 
14. Extract File ./Themes/default/languages/Groups.swedish.php 
15. Extract Tree ./Themes/default/../babylon/images 
16. Execute Code GroupMods_install.php

Can anyone help with this please.

Thanks
Geraint
Title: Re: Group Moderators 1.4
Post by: Dannii on December 14, 2006, 11:16:39 PM
I'll have to take a look at that, although it installed perfectly for me, many people are having issues :S
Try installing it anyways, if there are problems I'll fix them for you.
Title: Re: Group Moderators 1.4
Post by: rick9109 on December 15, 2006, 04:42:53 AM
Quote from: eldʌkaː on December 14, 2006, 06:18:48 AM
Were there any errors when you installed it? Other installed mods?

Nope, no errors, everything said "success" and I haven't installed any other mods yet.
Title: Re: Group Moderators 1.4
Post by: Dannii on December 15, 2006, 07:23:45 AM
What happens when you go to action=groups?
Its possible that none of the files got changed - a problem with the package manager on some servers. If thats the case, then you should ask for help in the package manager problems thread.
Title: Re: Group Moderators 1.4
Post by: geraintw1uk on December 15, 2006, 10:55:54 AM
Quote from: eldʌkaː on December 14, 2006, 11:16:39 PM
I'll have to take a look at that, although it installed perfectly for me, many people are having issues :S
Try installing it anyways, if there are problems I'll fix them for you.

Hi,

I have installed this now ignoring the fail message and it seems to be working as there are no errors in the error log and it will allow me to add moderators to it and the option is there in the menu (i am using the default menu) but dont know if it will work with other themes has i have not tried that yet..
do you know if it will work with many other themes and how hard is it to add to themes myself.

Thanks for your help

Geraint
Title: Re: Group Moderators 1.4
Post by: Dannii on December 15, 2006, 10:10:14 PM
It won't automatically add itself to other themes, but you should be able to easily do it yourself. Only the button has to be added, and, you don't really even need the button if you know how to get to it by action=groups
Title: Re: Group Moderators 1.4
Post by: IlyZor on December 16, 2006, 04:57:57 PM
Thanks a lot! Works great. Can't understand why this mod isn't built in per default.
Title: Re: Group Moderators 1.4
Post by: Dannii on December 19, 2006, 10:09:20 PM
I've change the way it alters the default template slightly, to make it more compatible with other mods. I don't think this change is big enough to warrant another release, so it will wait till the next big changes. If you do get errors on Default/index.template.php just install it anyways, it should work fine, just the tabs might not be correct. If you want, you can replace the GroupMods_templates_11.xml file in your package with this one: http://smfgroups.googlecode.com/svn/trunk/GroupMods_templates_11.xml
Title: Re: Group Moderators 1.4
Post by: Viporizer on January 03, 2007, 01:27:50 PM
To start of, nice mod you made! I realy enjoy it.

But here comes my problem. I tried to add it to my current theme. But it won't work. At the install it gives an testing error (index.template.php from the theme)and when i go on with the installation all seems fine. But when i want to mange the groups it says "Unable to load the 'main' template." Also edited the package with your latest version of the .xml file. Didn't seem to work. Can you help me out? I'm using the theme called: pdx-dk06
Title: Re: Group Moderators 1.4
Post by: Dannii on January 04, 2007, 02:46:20 AM
Which SMF version are you using? Can you check if the Groups.template.php file was uploaded correctly? If it wasn't that might explain the "unable to load.." error.
Title: Re: Group Moderators 1.4
Post by: Viporizer on January 04, 2007, 04:00:14 AM
I'm using the latest 1.1.1 version. The groups.template.php is in the theme directory. It all works on the default template but not yet with mine.
Title: Re: Group Moderators 1.4
Post by: Dannii on January 04, 2007, 04:21:38 AM
Could you set up a temporary admin account and PM me the details? I'll have a look at it for you.
Title: Re: Group Moderators 1.4
Post by: Viporizer on January 04, 2007, 05:18:21 AM
If you could take a look, that would be great!
Thanks in advance!
Title: Re: Group Moderators 1.4
Post by: Dannii on January 04, 2007, 05:48:10 AM
http://forum.vipmob.org/index.php?action=theme;th=1;sa=edit
This (did) show that Groups.template.php is an empty file. I think I've fixed it now.
Title: Re: Group Moderators 1.4
Post by: Viporizer on January 04, 2007, 05:59:41 AM
You are great! You fixed it alright :D You made me as happy as a kid with a lolly pop !! Thanks again!!
Title: Re: Group Moderators 1.4
Post by: higherauthority on January 06, 2007, 01:39:21 PM
I love this mod!!!!  Great JOB.

How can I get it to show the groups tab on all my themes? Once I figure this out I am all set

Is 1.4 the latest version .  When i installed it it gave me an error something about /index.template.php in the file list of the package.  but it seems to work fine weird.   

Title: Re: Group Moderators 1.4
Post by: Dannii on January 06, 2007, 10:07:00 PM
You'll have to add an extra tab, that links to action=groups. Ask your theme's author if you're not sure exactly how to.
Title: Re: Group Moderators 1.4
Post by: townies on January 16, 2007, 06:29:56 PM
 ???So what do we need to do in order to see the membergroups after hitting the groups tab?  I added myself in every group that I have, including admin and mods but still no members come up?   ::)
Title: Re: Group Moderators 1.4
Post by: Dannii on January 16, 2007, 09:15:41 PM
Did you add yourself to the list of group moderators, that you see when you edit a group?
Title: Re: Group Moderators 1.4
Post by: perplexed on January 23, 2007, 09:29:50 AM
Quote from: perplexed on October 23, 2006, 05:00:10 AM
yeah I tried again and it still wont download :(  very strange

I never did get this to install without the corrupt message.  I am due to upgrade to 1.1.1 so I'm going to give it another bash, since I really miss having it :)
Title: Re: Group Moderators 1.4
Post by: Dannii on January 23, 2007, 04:23:59 PM
Let me know if you still have troubles.
Title: Re: Group Moderators 1.4
Post by: kimber on January 28, 2007, 05:36:59 AM
Is there a way to have the button only show if the member is a moderator of a group? Similar to the Admin button for Administrators.
Title: Re: Group Moderators 1.4
Post by: Dannii on January 28, 2007, 07:41:38 AM
It will only display for those with the view_groups permission, so you can restrict it that way. It won't automatically detect who is a moderator though.
Title: Re: Group Moderators 1.4
Post by: kimber on January 28, 2007, 12:26:33 PM
I had to install it manually (not using default theme) and it stays visible with or without the view_groups option checked. 

I have this code placed in the index.template is there something else I should have done?

// View Groups Interface... [groups]
if (allowedTo('view_groups'))
echo '
<a href="', $scripturl, '?action=groups">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/groups.gif" alt="' . $txt['elgm4'] . '" style="margin: 2px 0;" border="0" />' : $txt['elgm4']), '</a>', $context['menu_separator'];


Thank you for your quick reply.   ;)

ETA:  Corrected this problem.  Thanks again!
Title: Re: Group Moderators 1.4
Post by: ThK on January 29, 2007, 01:57:31 PM
Hi,

I installed Your mod to my board. As I had to translate it anyway, I packaged up a German Translation.

Maybe, You'd like to check it and add to the mod or the mod-page.

Cheers,
ThK
Title: Re: Group Moderators 1.4
Post by: tracilynnb on January 29, 2007, 03:43:27 PM
I cannot get past the FTP screen through the package manager after pressing Apply Mod. It won't even unzip the files so I can install it.... I'm using SMF 1.1.1
Title: Re: Group Moderators 1.4
Post by: Dannii on January 29, 2007, 09:45:07 PM
Quote from: ThK on January 29, 2007, 01:57:31 PMI installed Your mod to my board. As I had to translate it anyway, I packaged up a German Translation.

Maybe, You'd like to check it and add to the mod or the mod-page.
Thanks, I'll see if I can include it for the next version.

QuoteI cannot get past the FTP screen through the package manager after pressing Apply Mod. It won't even unzip the files so I can install it.... I'm using SMF 1.1.1
Are you sure you have the correct FTP details?
Title: Re: Group Moderators 1.4
Post by: tracilynnb on January 31, 2007, 02:34:05 PM
Quote from: eldʌkaː on January 29, 2007, 09:45:07 PM
QuoteI cannot get past the FTP screen through the package manager after pressing Apply Mod. It won't even unzip the files so I can install it.... I'm using SMF 1.1.1
Are you sure you have the correct FTP details?

Yes I don't know why it wasn't working, but the next day I tried it agian and it worked fine. Thanks for your reply :D
Title: Re: Group Moderators 1.4
Post by: rick9109 on February 01, 2007, 12:51:19 AM
Quote from: eldʌkaː on December 14, 2006, 11:16:39 PM
I'll have to take a look at that, although it installed perfectly for me, many people are having issues :S
Try installing it anyways, if there are problems I'll fix them for you.

Hey there, have you figured out how to fix this issue yet? 

I've looked everywhere and I"m still lost.  I still can't seem to get things to go.  My forums are at http://www.thecrimsontide.org/forum and if there's anything you can do to help I'd really appreciate it :)
Title: Re: Group Moderators 1.4
Post by: Dannii on February 01, 2007, 01:05:56 AM
I haven't found anything that would cause problems. In any case only the menu is changed, and action=groups will still work.
Title: Re: Group Moderators 1.4
Post by: rick9109 on February 02, 2007, 04:57:58 AM
Well darn, it doesn't for me and I can't figure out what's wrong with the package manager either.  Oh well .  It was a great mod while I could use it !
Title: Re: Group Moderators 1.4
Post by: BlaZeR on February 05, 2007, 06:28:00 AM
4.     Execute Modification     ./Themes/default/index.template.php     Test failed
i get this ,how do i fix it?
Title: Re: Group Moderators 1.4
Post by: Dannii on February 05, 2007, 07:41:15 AM
It's probably conflicting with other mods. The only thing that's added to the index template is a menu button, it's not essential. You could either add it in manually, or just not bother.
Title: Re: Group Moderators 1.4
Post by: Vizibelli on February 07, 2007, 02:08:58 PM
Just to thank you for this great mod.

Had 1.3d with 1.1RC2, now upgraded to 1.4 with 1.1.1 and all is ok.

Eldʌkaː, do you need translation to Brazilian Portuguese? I can send it to you.

Ricardo
Title: Re: Group Moderators 1.4
Post by: Dannii on February 07, 2007, 08:03:34 PM
Sure, send it to me if you like :)
Title: Re: Group Moderators 1.4
Post by: rsxhitman on February 14, 2007, 05:26:55 AM
the index.php?action=groups just leads me back to the board index, this mod is giving me a headache, i couldnt figure out which file to use to install on my theme, and when i did try to use the 11 file, i couldnt find half the stuff, and you said this isnt essential, well the index.php?action=groups still just brings me back to the board index
Title: Re: Group Moderators 1.4
Post by: Dannii on February 14, 2007, 06:34:23 AM
If it's leading you back to the index then the changes to index.php weren't made. Those changes are essential, but the changes to index.template.php aren't.
Title: Re: Group Moderators 1.4
Post by: perplexed on February 14, 2007, 07:44:00 AM
Well I tried to get this to install as we do miss it but it just wont play nice with Multiple Badges and a few others, so installing it in any order with these mods, gives me errors.

I would have liked to have it again but I will have to do without.  Just letting you know.  
Title: Re: Group Moderators 1.4
Post by: rsxhitman on February 14, 2007, 04:34:44 PM
which xml file do i use for instalation on 1.1.2?

and what changes do i make to the index, and which index is it it the root index or the theme index
Title: Re: Group Moderators 1.4
Post by: OSU Searles on February 14, 2007, 07:16:32 PM
How do I manually add the button to index.template.php?  I am getting the same test failed.  Only mods installed are: Links, Gallery, Online Today, and Enhanced Calendar.

I also modded the index.template.php so that my logo incorporates a URL.

Thanks in advance for the assistance.

-Tom
Title: Re: Group Moderators 1.4
Post by: OSU Searles on February 14, 2007, 07:20:23 PM
Sorry to reply so quickly.  I just did the Apply Mod and the button showed up.  So no manual change is needed (atleast in my case) for the index.template.php.

Thanks again.
Title: Re: Group Moderators 1.4
Post by: Dannii on February 14, 2007, 10:16:22 PM
Quote from: rsxhitman on February 14, 2007, 04:34:44 PM
which xml file do i use for instalation on 1.1.2?

and what changes do i make to the index, and which index is it it the root index or the theme index
You need to add this to the big array, if it isn't already there.
'groups' => array('Groups.php', 'GroupMods'),
Title: Re: Group Moderators 1.4
Post by: rsxhitman on February 16, 2007, 03:38:45 PM
ok i have another problem, basically NONE of the files were edited, but that isnt the problem, my template does NOT have the ManageMembergroups.template.php file
Title: Re: Group Moderators 1.4
Post by: Dannii on February 16, 2007, 10:09:00 PM
If your theme doesn't have a file, it will use the default theme's file instead.
Title: Re: Group Moderators 1.4
Post by: Valiantheart on February 21, 2007, 05:00:07 AM
I'm using SMF 1.1.2.

I get this error after I tried to install.

Quote
Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ')' in /home/adestiny/public_html/Sources/ManageMembergroups.php on line 542

Any idea what went wrong?
Title: Re: Group Moderators 1.4
Post by: Dannii on February 22, 2007, 07:12:13 AM
Can you post from 5 lines about 542 to 5 lines below of that file please?
Title: Re: Group Moderators 1.4
Post by: Valiantheart on February 22, 2007, 12:05:39 PM
Oh right, silly me.


$context['boards'][] = array(
'id' => $row['ID_BOARD'],
'name' => $row['name'],
'child_level' => $row['childLevel'],
'selected' => !empty($row['can_access']),
);
mysql_free_result($result);
}
$context['sub_template'] = 'edit_group';
$context['page_title'] = $txt['membergroups_edit_group'];
}
Title: Re: Group Moderators 1.4
Post by: Dannii on February 22, 2007, 09:01:06 PM
Hmm, this mod doesn't touch that part of the file, and I can't see anything wrong with it either. Any other mods installed?
Title: Re: Group Moderators 1.4
Post by: Valiantheart on February 23, 2007, 12:18:11 AM
I have the Multiple Badges mod installed.
Title: Re: Group Moderators 1.4
Post by: Dannii on February 23, 2007, 12:27:51 AM
The problem is probably with that mod then, it might change those lines.
Title: Re: Group Moderators 1.4
Post by: Valiantheart on February 23, 2007, 02:36:53 AM
I just realised I copied the code from the wrong file. I uninstalled the multi badge mod and tried to reinstall this. Still doesn't work. Same error. This is the code at the error page.

'star_image' => isset($row['stars'][1]) ? $row['stars'][1] : '',
'is_post_group' => $row['minPosts'] != -1,
'allow_post_group' => $_REQUEST['group'] == 2 || $_REQUEST['group'] > 4,
'allow_delete' => $_REQUEST['group'] == 2 || $_REQUEST['group'] > 4,
'allow_primary' => substr_count($row['GroupModOptions'], 'P') == 1
);

// Group Moderators
$request = db_query("
SELECT mem.memberName
FROM {$db_prefix}groupmods AS mods, {$db_prefix}members AS mem
WHERE mods.ID_GROUP = " . (int) $_REQUEST['group'] . "
Title: Re: Group Moderators 1.4
Post by: Dannii on February 23, 2007, 06:21:17 AM
Can you post or email the whole file to me. I still can't see any problems with it, but it's possible the issue is a lot higher than the line number indicates.
Title: Re: Group Moderators 1.4
Post by: Valiantheart on February 28, 2007, 12:51:23 PM
It's alright. I uninstalled both mods, installed this first and then install the multiple badges mod. Both of them are working fine now. No idea why but :D
Title: Re: Group Moderators 1.4
Post by: Dannii on February 28, 2007, 06:31:52 PM
Weird, but I'm glad it's working! :)
Title: Re: Group Moderators 1.4
Post by: Dandy_Don on March 08, 2007, 02:02:15 AM
I get the default/index.template error. I try to install it, Im using 1.1.2 with Babylon, and it adds a button to the menu but there is a large chunk of php code at the top of my site showing the code which decides whether or not a user can see the groups.

Kris
Title: Re: Group Moderators 1.4
Post by: Dannii on March 08, 2007, 04:32:23 AM
Can you post up your index.template.php for Babylon
Title: Re: Group Moderators 1.4
Post by: drossman on March 08, 2007, 08:34:39 AM
I love this mod.  I have a suggestion.   It would be great if when a member goes to the groups page, all of the groups are displayed with links to request membership and/or administer the membership.  This accomplishes 2 things:  publicizes the available groups and gives members an easy way to join a group.

:)
Title: Re: Group Moderators 1.4
Post by: Dandy_Don on March 08, 2007, 09:09:52 AM
Quote
// Initialize the template... mainly little settings.
function template_init()
{
   global $context, $settings, $options, $txt;

   /* Use images from default theme when using templates from the default theme?
      if this is 'always', images from the default theme will be used.
      if this is 'defaults', images from the default theme will only be used with default templates.
      if this is 'never' or isn't set at all, images from the default theme will not be used. */
   $settings['use_default_images'] = 'never';

   /* What document type definition is being used? (for font size and other issues.)
      'xhtml' for an XHTML 1.0 document type definition.
      'html' for an HTML 4.01 document type definition. */
   $settings['doctype'] = 'xhtml';

   /* The version this template/theme is for.
      This should probably be the version of SMF it was created for. */
   $settings['theme_version'] = '1.1';

   /* Set a setting that tells the theme that it can render the tabs. */
   $settings['use_tabs'] = false;

   /* Use plain buttons - as oppossed to text buttons? */
   $settings['use_buttons'] = false;

   /* Show sticky and lock status seperate from topic icons? */
   $settings['seperate_sticky_lock'] = false;
}

// The main sub template above the content.
function template_main_above()
{
   global $context, $settings, $options, $scripturl, $txt, $modSettings;

   // Show right to left and the character set for ease of translating.
   echo '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"', $context['right_to_left'] ? ' dir="rtl"' : '', '><head>
   <meta http-equiv="Content-Type" content="text/html; charset=', $context['character_set'], '" />
   <meta name="description" content="', $context['page_title'], '" />', empty($context['robot_no_index']) ? '' : '
   <meta name="robots" content="noindex" />', '
   <meta name="keywords" content="PHP, MySQL, bulletin, board, free, open, source, smf, simple, machines, forum" />
   <script language="JavaScript" type="text/javascript" src="', $settings['default_theme_url'], '/script.js?fin11"></script>
   <script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
      var smf_theme_url = "', $settings['theme_url'], '";
      var smf_images_url = "', $settings['images_url'], '";
      var smf_scripturl = "', $scripturl, '";
      var smf_iso_case_folding = ', $context['server']['iso_case_folding'] ? 'true' : 'false', ';
      var smf_charset = "', $context['character_set'], '";
   // ]]></script>
   <title>', $context['page_title'], '</title>';

   // The ?fin11 part of this link is just here to make sure browsers don't cache it wrongly.
   echo '
   <link rel="stylesheet" type="text/css" href="', $settings['theme_url'], '/style.css?fin11" />
   <link rel="stylesheet" type="text/css" href="', $settings['default_theme_url'], '/print.css?fin11" media="print" />';

   /* Internet Explorer 4/5 and Opera 6 just don't do font sizes properly. (they are big...)
      Thus, in Internet Explorer 4, 5, and Opera 6 this will show fonts one size smaller than usual.
      Note that this is affected by whether IE 6 is in standards compliance mode.. if not, it will also be big.
      Standards compliance mode happens when you use xhtml... */
   if ($context['browser']['needs_size_fix'])
      echo '
   <link rel="stylesheet" type="text/css" href="', $settings['default_theme_url'], '/fonts-compat.css" />';

   // Show all the relative links, such as help, search, contents, and the like.
   echo '
   <link rel="help" href="', $scripturl, '?action=help" target="_blank" />
   <link rel="search" href="' . $scripturl . '?action=search" />
   <link rel="contents" href="', $scripturl, '" />';

   // If RSS feeds are enabled, advertise the presence of one.
   if (!empty($modSettings['xmlnews_enable']))
      echo '
   <link rel="alternate" type="application/rss+xml" title="', $context['forum_name'], ' - RSS" href="', $scripturl, '?type=rss;action=.xml" />';

   // If we're viewing a topic, these should be the previous and next topics, respectively.
   if (!empty($context['current_topic']))
      echo '
   <link rel="prev" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=prev" />
   <link rel="next" href="', $scripturl, '?topic=', $context['current_topic'], '.0;prev_next=next" />';

   // If we're in a board, or a topic for that matter, the index will be the board's index.
   if (!empty($context['current_board']))
      echo '
   <link rel="index" href="' . $scripturl . '?board=' . $context['current_board'] . '.0" />';

   // We'll have to use the cookie to remember the header...
   if ($context['user']['is_guest'])
      $options['collapse_header'] = !empty($_COOKIE['upshrink']);

   // Output any remaining HTML headers. (from mods, maybe?)
   echo $context['html_headers'], '

   <script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
      var current_header = ', empty($options['collapse_header']) ? 'false' : 'true', ';

      function shrinkHeader(mode)
      {';

   // Guests don't have theme options!!
   if ($context['user']['is_guest'])
      echo '
         document.cookie = "upshrink=" + (mode ? 1 : 0);';
   else
      echo '
         smf_setThemeOption("collapse_header", mode ? 1 : 0, null, "', $context['session_id'], '");';

   echo '
         document.getElementById("upshrink").src = smf_images_url + (mode ? "/upshrink2.gif" : "/upshrink.gif");

         document.getElementById("upshrinkHeader").style.display = mode ? "none" : "";

         current_header = mode;
      }
   // ]]></script>
</head>
<body>';

   // Because of the way width/padding are calculated, we have to tell Internet Explorer 4 and 5 that the content should be 100% wide. (or else it will assume about 108%!)
   echo '
   <div id="headerarea" style="padding: 12px 30px 4px 30px;', $context['browser']['needs_size_fix'] && !$context['browser']['is_ie6'] ? ' width: 100%;' : '', '">';

   // The logo and the three info boxes.
   echo '
      <table cellspacing="0" cellpadding="0" border="0" width="100%" style="position: relative;">
         <tr>
            <td colspan="2" valign="bottom" style="padding: 5px; white-space: nowrap;">';

   // This part is the logo and forum name.  You should be able to change this to whatever you want...
   echo '
               <img src="', $settings['images_url'], '/smflogo.gif" style="width: 200px; float: ', !$context['right_to_left'] ? 'right' : 'left', ';" alt="" />';
   if (empty($settings['header_logo_url']))
      echo '
               <span style="font-family: Georgia, sans-serif; font-size: xx-large;">', $context['forum_name'], '</span>';
   else
      echo '
               <img src="', $settings['header_logo_url'], '" alt="', $context['forum_name'], '" border="0" />';

   echo '
            </td>
         </tr>
         <tr id="upshrinkHeader"', empty($options['collapse_header']) ? '' : ' style="display: none;"', '>
            <td valign="top">
               <div class="headertitles" style="margin-right: 5px; position: relative;"><img src="', $settings['images_url'], '/blank.gif" height="12" alt="" /></div>
               <div class="headerbodies" style="position: relative; margin-right: 5px; background-image: url(', $settings['images_url'], '/box_bg.gif);">
                  <img src="', $settings['images_url'], '/', $context['user']['language'], '/userinfo.gif" style="position: absolute; left: ', $context['browser']['is_ie5'] || $context['browser']['is_ie4'] ? '0' : '-1px', '; top: -16px; clear: both;" alt="" />
                  <table width="99%" cellpadding="0" cellspacing="5" border="0"><tr>';

   if (!empty($context['user']['avatar']))
      echo '<td valign="middle">', $context['user']['avatar']['image'], '</td>';

   echo '<td valign="top" class="smalltext" style="width: 100%; font-family: verdana, arial, sans-serif;">';

   // If the user is logged in, display stuff like their name, new messages, etc.
   if ($context['user']['is_logged'])
   {
      echo '
                     ', $txt['hello_member'], ' <b>', $context['user']['name'], '</b>';

      // Only tell them about their messages if they can read their messages!
      if ($context['allow_pm'])
         echo ', ', $txt[152], ' <a href="', $scripturl, '?action=pm">', $context['user']['messages'], ' ', $context['user']['messages'] != 1 ? $txt[153] : $txt[471], '</a>', $txt['newmessages4'], ' ', $context['user']['unread_messages'], ' ', $context['user']['unread_messages'] == 1 ? $txt['newmessages0'] : $txt['newmessages1'];
      echo '.<br />';

      // Is the forum in maintenance mode?
      if ($context['in_maintenance'] && $context['user']['is_admin'])
         echo '
                     <b>', $txt[616], '</b><br />';

      // Are there any members waiting for approval?
      if (!empty($context['unapproved_members']))
         echo '
                     ', $context['unapproved_members'] == 1 ? $txt['approve_thereis'] : $txt['approve_thereare'], ' <a href="', $scripturl, '?action=viewmembers;sa=browse;type=approve">', $context['unapproved_members'] == 1 ? $txt['approve_member'] : $context['unapproved_members'] . ' ' . $txt['approve_members'], '</a> ', $txt['approve_members_waiting'], '<br />';

      // Show the total time logged in?
      if (!empty($context['user']['total_time_logged_in']))
      {
         echo '
                     ', $txt['totalTimeLogged1'];

         // If days is just zero, don't bother to show it.
         if ($context['user']['total_time_logged_in']['days'] > 0)
            echo $context['user']['total_time_logged_in']['days'] . $txt['totalTimeLogged2'];

         // Same with hours - only show it if it's above zero.
         if ($context['user']['total_time_logged_in']['hours'] > 0)
            echo $context['user']['total_time_logged_in']['hours'] . $txt['totalTimeLogged3'];

         // But, let's always show minutes - Time wasted here: 0 minutes ;).
         echo $context['user']['total_time_logged_in']['minutes'], $txt['totalTimeLogged4'], '<br />';
      }

      echo '
                     <a href="', $scripturl, '?action=unread">', $txt['unread_since_visit'], '</a><br />
                     <a href="', $scripturl, '?action=unreadreplies">', $txt['show_unread_replies'], '</a><br />
                     ', $context['current_time'];
   }
   // Otherwise they're a guest - so politely ask them to register or login.
   else
   {
      echo '
                     ', $txt['welcome_guest'], '<br />
                     ', $context['current_time'], '<br />

                     <script language="JavaScript" type="text/javascript" src="', $settings['default_theme_url'], '/sha1.js"></script>

                     <form action="', $scripturl, '?action=login2" method="post" accept-charset="', $context['character_set'], '" style="margin: 3px 1ex 1px 0;"', empty($context['disable_login_hashing']) ? ' onsubmit="hashLoginPassword(this, \'' . $context['session_id'] . '\');"' : '', '>
                        <div style="text-align: right;">
                           <input type="text" name="user" size="10" /> <input type="password" name="passwrd" size="10" />
                           <select name="cookielength">
                              <option value="60">', $txt['smf53'], '</option>
                              <option value="1440">', $txt['smf47'], '</option>
                              <option value="10080">', $txt['smf48'], '</option>
                              <option value="43200">', $txt['smf49'], '</option>
                              <option value="-1" selected="selected">', $txt['smf50'], '</option>
                           </select>
                           <input type="submit" value="', $txt[34], '" /><br />
                           ', $txt['smf52'], '
                           <input type="hidden" name="hash_passwrd" value="" />
                        </div>
                     </form>';
   }

   echo '
                  </td></tr></table>
               </div>

               <form action="', $scripturl, '?action=search2" method="post" accept-charset="', $context['character_set'], '" style="margin: 0;">
                  <div style="margin-top: 7px;">
                     <b>', $txt[182], ': </b><input type="text" name="search" value="" style="width: 190px;" />&nbsp;
                     <input type="submit" name="submit" value="', $txt[182], '" style="width: 8ex;" />&nbsp;
                     <a href="', $scripturl, '?action=search;advanced">', $txt['smf298'], '</a>
                     <input type="hidden" name="advanced" value="0" />';

   // Search within current topic?
   if (!empty($context['current_topic']))
      echo '
                     <input type="hidden" name="topic" value="', $context['current_topic'], '" />';

      // If we're on a certain board, limit it to this board ;).
   elseif (!empty($context['current_board']))
      echo '
                     <input type="hidden" name="brd[', $context['current_board'], ']" value="', $context['current_board'], '" />';

   echo '
                  </div>
               </form>

            </td>
            <td style="width: 262px; ', !$context['right_to_left'] ? 'padding-left' : 'padding-right', ': 6px;" valign="top">';

   // Show a random news item? (or you could pick one from news_lines...)
   if (!empty($settings['enable_news']))
      echo '
               <div class="headertitles" style="width: 260px;"><img src="', $settings['images_url'], '/blank.gif" height="12" alt="" /></div>
               <div class="headerbodies" style="width: 260px; position: relative; background-image: url(', $settings['images_url'], '/box_bg.gif); margin-bottom: 8px;">
                  <img src="', $settings['images_url'], '/', $context['user']['language'], '/newsbox.gif" style="position: absolute; left: -1px; top: -16px;" alt="" />
                  <div style="height: 50px; overflow: auto; padding: 5px;" class="smalltext">', $context['random_news_line'], '</div>
               </div>';

   // The "key stats" box.
   echo '
               <div class="headertitles" style="width: 260px;"><img src="', $settings['images_url'], '/blank.gif" height="12" alt="" /></div>
               <div class="headerbodies" style="width: 260px; position: relative; background-image: url(', $settings['images_url'], '/box_bg.gif);">
                  <img src="', $settings['images_url'], '/', $context['user']['language'], '/keystats.gif" style="position: absolute; left: -1px; top: -16px;" alt="" />
                  <div style="', !$context['browser']['is_ie'] ? 'min-height: 35px;' : 'height: 4em;', ' padding: 5px;" class="smalltext">
                     <b>', $context['common_stats']['total_posts'], '</b> ', $txt[95], ' ', $txt['smf88'], ' <b>', $context['common_stats']['total_topics'], '</b> ', $txt[64], ' ', $txt[525], ' <span style="white-space: nowrap;"><b>', $context['common_stats']['total_members'], '</b> ', $txt[19], '</span><br />
                     ', $txt[656], ': <b> ', $context['common_stats']['latest_member']['link'], '</b>
                  </div>
               </div>';

   echo '
            </td>
         </tr>
      </table>

      <a href="javascript:void(0);" onclick="shrinkHeader(!current_header); return false;"><img id="upshrink" src="', $settings['images_url'], '/', empty($options['collapse_header']) ? 'upshrink.gif' : 'upshrink2.gif', '" alt="*" title="', $txt['upshrink_description'], '" style="margin: 2px 2ex 2px 0;" border="0" /></a>';

      // Show the menu here, according to the menu sub template.
      template_menu();

   echo '
   </div>';

   // The main content should go here.  A table is used because IE 6 just can't handle a div.
   echo '
   <table width="100%" cellpadding="0" cellspacing="0" border="0"><tr>
      <td id="bodyarea" style="padding: 1ex 20px 2ex 20px;">';
}

function template_main_below()
{
   global $context, $settings, $options, $scripturl, $txt;

   echo '</td>
   </tr></table>';

   // Show the "Powered by" and "Valid" logos, as well as the copyright.  Remember, the copyright must be somewhere!
   echo '

   <div id="footerarea" style="text-align: center; padding-bottom: 1ex;', $context['browser']['needs_size_fix'] && !$context['browser']['is_ie6'] ? ' width: 100%;' : '', '">
      <script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
         function smfFooterHighlight(element, value)
         {
            element.src = smf_images_url + "/" + (value ? "h_" : "") + element.id + ".gif";
         }
      // ]]></script>
      <table cellspacing="0" cellpadding="3" border="0" width="100%">
         <tr>
            <td width="28%" valign="middle" align="', !$context['right_to_left'] ? 'right' : 'left', '">
               <a href="http://www.mysql.com/" target="_blank"><img id="powered-mysql" src="', $settings['images_url'], '/powered-mysql.gif" alt="', $txt['powered_by_mysql'], '" width="54" height="20" style="margin: 5px 16px;" border="0" onmouseover="smfFooterHighlight(this, true);" onmouseout="smfFooterHighlight(this, false);" /></a>
               <a href="http://www.php.net/" target="_blank"><img id="powered-php" src="', $settings['images_url'], '/powered-php.gif" alt="', $txt['powered_by_php'], '" width="54" height="20" style="margin: 5px 16px;" border="0" onmouseover="smfFooterHighlight(this, true);" onmouseout="smfFooterHighlight(this, false);" /></a>
            </td>
            <td valign="middle" align="center" style="white-space: nowrap;">
               ', theme_copyright(), '
            </td>
            <td width="28%" valign="middle" align="', !$context['right_to_left'] ? 'left' : 'right', '">
               <a href="http://validator.w3.org/check/referer" target="_blank"><img id="valid-xhtml10" src="', $settings['images_url'], '/valid-xhtml10.gif" alt="', $txt['valid_xhtml'], '" width="54" height="20" style="margin: 5px 16px;" border="0" onmouseover="smfFooterHighlight(this, true);" onmouseout="smfFooterHighlight(this, false);" /></a>
               <a href="http://jigsaw.w3.org/css-validator/check/referer" target="_blank"><img id="valid-css" src="', $settings['images_url'], '/valid-css.gif" alt="', $txt['valid_css'], '" width="54" height="20" style="margin: 5px 16px;" border="0" onmouseover="smfFooterHighlight(this, true);" onmouseout="smfFooterHighlight(this, false);" /></a>
            </td>
         </tr>
      </table>';

   // Show the load time?
   if ($context['show_load_time'])
      echo '
      <span class="smalltext">', $txt['smf301'], $context['load_time'], $txt['smf302'], $context['load_queries'], $txt['smf302b'], '</span>';

   echo '
      </div>';

   // This is an interesting bug in Internet Explorer AND Safari.  Rather annoying, it makes overflows just not tall enough.
   if (($context['browser']['is_ie'] && !$context['browser']['is_ie4']) || $context['browser']['is_mac_ie'] || $context['browser']['is_safari'] || $context['browser']['is_firefox'])
   {
      // The purpose of this code is to fix the height of overflow: auto div blocks, because IE can't figure it out for itself.
      echo '
      <script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[';

      // Unfortunately, Safari does not have a "getComputedStyle" implementation yet, so we have to just do it to code...
      if ($context['browser']['is_safari'])
         echo '
         window.addEventListener("load", smf_codeFix, false);

         function smf_codeFix()
         {
            var codeFix = document.getElementsByTagName ? document.getElementsByTagName("div") : document.all.tags("div");

            for (var i = 0; i < codeFix.length; i++)
            {
               if ((codeFix.className == "code" || codeFix.className == "post" || codeFix.className == "signature") && codeFix.offsetHeight < 20)
                  codeFix.style.height = (codeFix.offsetHeight + 20) + "px";
            }
         }';
      elseif ($context['browser']['is_firefox'])
         echo '
         window.addEventListener("load", smf_codeFix, false);
         function smf_codeFix()
         {
            var codeFix = document.getElementsByTagName ? document.getElementsByTagName("div") : document.all.tags("div");

            for (var i = 0; i < codeFix.length; i++)
            {
               if (codeFix.className == "code" && (codeFix.scrollWidth > codeFix.clientWidth || codeFix.clientWidth == 0))
                  codeFix.style.overflow = "scroll";
            }
         }';         
      else
      {
         echo '
         var window_oldOnload = window.onload;
         window.onload = smf_codeFix;

         function smf_codeFix()
         {
            var codeFix = document.getElementsByTagName ? document.getElementsByTagName("div") : document.all.tags("div");

            for (var i = codeFix.length - 1; i > 0; i--)
            {
               if (codeFix.currentStyle.overflow == "auto" && (codeFix.currentStyle.height == "" || codeFix.currentStyle.height == "auto") && (codeFix.scrollWidth > codeFix.clientWidth || codeFix.clientWidth == 0) && (codeFix.offsetHeight != 0 || codeFix.className == "code"))
                  codeFix.style.height = (codeFix.offsetHeight + 36) + "px";
            }

            if (window_oldOnload)
            {
               window_oldOnload();
               window_oldOnload = null;
            }
         }';
      }

      echo '
      // ]]></script>';
   }

   // The following will be used to let the user know that some AJAX process is running
   echo '
      <div id="ajax_in_progress" style="display: none;', $context['browser']['is_ie'] && !$context['browser']['is_ie7'] ? 'position: absolute;' : '', '">', $txt['ajax_in_progress'], '</div>
   </body>
</html>';
}

// Show a linktree.  This is that thing that shows "My Community | General Category | General Discussion"..
function theme_linktree()
{
   global $context, $settings, $options;

   // Folder style or inline?  Inline has a smaller font.
   echo '<span class="nav"', $settings['linktree_inline'] ? ' style="font-size: smaller;"' : '', '>';

   // Each tree item has a URL and name.  Some may have extra_before and extra_after.
   foreach ($context['linktree'] as $link_num => $tree)
   {
      // Show the | | |-[] Folders.
      if (!$settings['linktree_inline'])
      {
         if ($link_num > 0)
            echo str_repeat('<img src="' . $settings['images_url'] . '/icons/linktree_main.gif" alt="| " border="0" />', $link_num - 1), '<img src="' . $settings['images_url'] . '/icons/linktree_side.gif" alt="|-" border="0" />';
         echo '<img src="' . $settings['images_url'] . '/icons/folder_open.gif" alt="+" border="0" />&nbsp; ';
      }

      // Show something before the link?
      if (isset($tree['extra_before']))
         echo $tree['extra_before'];

      // Show the link, including a URL if it should have one.
      echo '<b>', $settings['linktree_link'] && isset($tree['url']) ? '<a href="' . $tree['url'] . '" class="nav">' . $tree['name'] . '</a>' : $tree['name'], '</b>';

      // Show something after the link...?
      if (isset($tree['extra_after']))
         echo $tree['extra_after'];

      // Don't show a separator for the last one.
      if ($link_num != count($context['linktree']) - 1)
         echo $settings['linktree_inline'] ? ' &nbsp;|&nbsp; ' : '<br />';
   }

   echo '</span>';
}

// Show the menu up top.  Something like [home] [help] [profile] [logout]...
function template_menu()
{
   global $context, $settings, $options, $scripturl, $txt;

   // Show the [home] and [help] buttons.
   echo '
            <a href="', $scripturl, '">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/home.gif" alt="' . $txt[103] . '" style="margin: 2px 0;" border="0" />' : $txt[103]), '</a>', $context['menu_separator'], '
            <a href="', $scripturl, '?action=help">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/help.gif" alt="' . $txt[119] . '" style="margin: 2px 0;" border="0" />' : $txt[119]), '</a>', $context['menu_separator'], '
            <a href="', $scripturl, '?action=arcade">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/arcade.gif" alt="Arcade" style="margin: 2px 0;" border="0" />' : Arcade), '</a>', $context['menu_separator'];

   // How about the [search] button?
   if ($context['allow_search'])
      echo '
            <a href="', $scripturl, '?action=search">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/search.gif" alt="' . $txt[182] . '" style="margin: 2px 0;" border="0" />' : $txt[182]), '</a>', $context['menu_separator'];

   // Is the user allowed to administrate at all? ([admin])
   if ($context['allow_admin'])
      echo '
            <a href="', $scripturl, '?action=admin">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/admin.gif" alt="' . $txt[2] . '" style="margin: 2px 0;" border="0" />' : $txt[2]), '</a>', $context['menu_separator'];

   // Edit Profile... [profile]
   if ($context['allow_edit_profile'])
      echo '
            <a href="', $scripturl, '?action=profile">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/profile.gif" alt="' . $txt[79] . '" style="margin: 2px 0;" border="0" />' : $txt[467]), '</a>', $context['menu_separator'];

   // The [calendar]!
   if ($context['allow_calendar'])
      echo '
            <a href="', $scripturl, '?action=calendar">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/calendar.gif" alt="' . $txt['calendar24'] . '" style="margin: 2px 0;" border="0" />' : $txt['calendar24']), '</a>', $context['menu_separator'];

   // If the user is a guest, show [login] and [register] buttons.
   if ($context['user']['is_guest'])
   {
      echo '
            <a href="', $scripturl, '?action=login">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/login.gif" alt="' . $txt[34] . '" style="margin: 2px 0;" border="0" />' : $txt[34]), '</a>', $context['menu_separator'], '
            <a href="', $scripturl, '?action=register">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/register.gif" alt="' . $txt[97] . '" style="margin: 2px 0;" border="0" />' : $txt[97]), '</a>';
   }
   // Otherwise, they might want to [logout]...
   else
      echo '
            <a href="', $scripturl, '?action=logout;sesc=', $context['session_id'], '">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/logout.gif" alt="' . $txt[108] . '" style="margin: 2px 0;" border="0" />' : $txt[108]), '</a>';
}

// Generate a strip of buttons, out of buttons.
function template_button_strip($button_strip, $direction = 'top', $force_reset = false, $custom_td = '')
{
   global $settings, $buttons, $context, $txt, $scripturl;

   if (empty($button_strip))
      return '';

   // Create the buttons...
   foreach ($button_strip as $key => $value)
   {
      if (isset($value['test']) && empty($context[$value['test']]))
      {
         unset($button_strip[$key]);
         continue;
      }
      elseif (!isset($buttons[$key]) || $force_reset)
         $buttons[$key] = '<a href="' . $value['url'] . '" ' .( isset($value['custom']) ? $value['custom'] : '') . '>' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . ($value['lang'] ? $context['user']['language'] . '/' : '') . $value['image'] . '" alt="' . $txt[$value['text']] . '" border="0" />' : $txt[$value['text']]) . '</a>';

      $button_strip[$key] = $buttons[$key];
   }

   echo '
      <td ', $custom_td, '>', implode($context['menu_separator'], $button_strip) , '</td>';
}

?>
Title: Re: Group Moderators 1.4
Post by: mpenfield on March 14, 2007, 10:35:07 PM
Great mod! Great job! Many, many thanks!
Title: Re: Group Moderators 1.4
Post by: Dannii on March 14, 2007, 10:53:42 PM
Dandy_Don, I can't see anything wrong with it, except prehaps for adding <?php to the very beginning
Title: Re: Group Moderators 1.4
Post by: ramiz on March 20, 2007, 06:51:29 AM
Quote from: eldʌkaː on July 25, 2005, 06:36:33 PM
I'll be making it for beta.. well after I install beta :P I'll try and get it out as soon as possible.

Screenshots:

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fweb.aanet.com.au%2Feldacar%2Fdata%2Fscreeny03.png&hash=12da12a9d47bcfb077886776715cd39dd8de7955)

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fweb.aanet.com.au%2Feldacar%2Fdata%2Fscreeny04.png&hash=f342bb41fb221aaf3b084a988b702fbb215ea397)


hi
i am using this mod on 1.1rc3
everything is going fine except i am not able to see members under specefic membergroup

the exact problem is like the member groupname(like house,ziohn...as shown) is not clickable in my site(the exact path in my site...admin-->Membergroups--> Regular group)

but in the url if i directly give
http://www.iimbaa.org/index.php?option=com_smf&Itemid=45&action=membergroups;sa=members;group=1
here i can see the above screensort for my admin

any help plz
Title: Re: Group Moderators 1.4
Post by: Dannii on March 20, 2007, 07:25:27 AM
Hmm, anything in the error log?
Title: Re: Group Moderators 1.4
Post by: ramiz on March 20, 2007, 07:42:52 AM
plz dont mind....
where should i see this error logs
Title: Re: Group Moderators 1.4
Post by: Dannii on March 20, 2007, 07:44:44 AM
In your admin panel, towards the bottom of the menu.
Title: Re: Group Moderators 1.4
Post by: ramiz on March 20, 2007, 07:51:10 AM
hi i am sending my latest error logs .......
---------------------------------------------------------------------------------------------------
http://iimbaa.org/forum/index.php?option=com_smf&amp;Itemid=45&amp;option

Undefined variable: sidenav
File: /home/iimbaao/public_html/templates/rt_versatility_ii_sienna/index.php
Line: 114
----------------------------------------------------------------------------------------------------

but is it related to my issue?
Title: Re: Group Moderators 1.4
Post by: ramiz on March 20, 2007, 07:58:32 AM
many many thanks for your quick reply

give me some way of solution plz..my site is live
Title: Re: Group Moderators 1.4
Post by: Dannii on March 20, 2007, 08:01:20 AM
No that error wouldn't be related. I'd like to give you a solution, but I can't do that until I know the problem. But it's not like it's going to impact on your members, just your admins and mods.
Can you please PM me details for a temp admin account?
Title: Re: Group Moderators 1.4
Post by: Dannii on March 20, 2007, 08:40:58 AM
You should PM passwords!
Is the mod even installed in the second forum?
Title: Re: Group Moderators 1.4
Post by: ramiz on March 20, 2007, 09:05:36 AM
yes second one is the testsite and the mod is installed over there

but the first one is live one....

plz help me out...
Title: Re: Group Moderators 1.4
Post by: Dannii on March 20, 2007, 10:24:07 AM
It's not installed on the testsite, but it is installed on the main one, and it looks fine to me.
Title: Re: Group Moderators 1.4
Post by: ramiz on March 21, 2007, 07:24:55 AM

hi...
many many thanks for ur reply

are u able to click  on Regular groups like Jobs, PGPTestBatch, PGP1971.......
but still i cant see my members inside membergroup in "http://www.iimbaa.org"
Title: Re: Group Moderators 1.4
Post by: Dannii on March 21, 2007, 07:28:43 AM
I added the admin account as a moderator for the "Jobs" and "PGP Test Batch" groups and its working perfectly.
Title: Re: Group Moderators 1.4
Post by: ramiz on March 21, 2007, 07:34:04 AM
could u plz tell me how exactly ur checking
so that i can verify it with the same admin account
plz just tell me the steps.... actually its a huge site and i am bit new in this
Title: Re: Group Moderators 1.4
Post by: Dannii on March 21, 2007, 07:35:41 AM
I logged in, went to action=groups, and it worked fine.
Title: Re: Group Moderators 1.4
Post by: ramiz on March 21, 2007, 07:38:46 AM
very very sorry again

after login where should i give this action=group...in the url
plz tell me in details
Title: Re: Group Moderators 1.4
Post by: Dannii on March 21, 2007, 07:40:49 AM
Yes in the url, it would appear in the menu if you used the default theme.
Title: Re: Group Moderators 1.4
Post by: ramiz on March 21, 2007, 07:43:53 AM
but i am not using default theme....i am using silkpro graphite

could u plz  send me the exact url while mentioning action = group

plz  
Title: Re: Group Moderators 1.4
Post by: Dannii on March 21, 2007, 07:59:15 AM
http://iimbaa.org/forum/index.php?action=groups
Title: Re: Group Moderators 1.4
Post by: ramiz on March 21, 2007, 08:01:26 AM
thanks  :)
i got it .....it showing Jobs and PGPTestBatch with the admin account

but is there any way to see this members under membergroups

because in my forum if i make some member as groupmodarator for a particular group
i need to personally tell him go to url and give action = group(that person might not be knowing all this)
so if there some option so that the member can see and just click...then the job will be easy
Title: Re: Group Moderators 1.4
Post by: Dannii on March 21, 2007, 08:06:06 AM
Well add it to your custom theme's menu.
Title: Re: Group Moderators 1.4
Post by: ramiz on March 21, 2007, 08:10:27 AM
sorry.....i dint get what to add and where to add
plz tell me in details i am new to this
Title: Re: Group Moderators 1.4
Post by: Dannii on March 21, 2007, 08:16:24 AM
Ask the theme's author then!
Title: Re: Group Moderators 1.4
Post by: ramiz on March 21, 2007, 08:18:39 AM
many many thanks........................ for reply

regards,
ramiz

Title: Re: Group Moderators 1.4
Post by: savantmg on March 22, 2007, 12:24:51 PM
Hello,

Wow - I hope I can get this to work  - it will be a real lifesaver for a project of mine!

I am running SMF 1.2 and I successfully installed it (or so it said) but I cannot find any link for it in the admin menu.  I am using the default theme and have tried http://url.com/forumfolder/index.php?action=groups and all I get is a blank page with an empty tab (between Profile and My Messages) selected at top.

Can anybody advise?  Many thanks!

Andy
Title: Re: Group Moderators 1.4
Post by: Dannii on March 22, 2007, 08:19:40 PM
Anything in the error log?
Btw, there is no SMF 1.2
Title: Re: Group Moderators 1.4
Post by: Dannii on March 24, 2007, 10:07:07 AM
Just for everyone's information, I don't think I will be developing this any further as I'm not too interested in it anymore, and I don't have a lot of free time. I would have liked to add lots of interesting features, but realistically, I stopped after it did all I needed it to. If anyone would like to develop it, I would be happy to transfer the mod to them, and to give them SVN access etc. I would love for someone to finish making it SMF DE compatible (half of it's compatible so far), so a team member or beta tester might be needed to do that.. but if anyone would like to help that would be great.
Title: Re: Group Moderators 1.4
Post by: savantmg on March 28, 2007, 12:09:33 PM
Quote from: eldʌkaː on March 22, 2007, 08:19:40 PM
Anything in the error log?
Btw, there is no SMF 1.2

Sorry - 1.1.2!
Title: Re: Group Moderators 1.4
Post by: savantmg on March 28, 2007, 02:03:05 PM
Thanks for the info - since development is questionable on this I think I found an alternative via PHPbb so I am going to try that for time being.
Title: Re: Group Moderators 1.4
Post by: savantmg on March 28, 2007, 07:58:54 PM
I think that we found the fix thanks to Metallica48423 - thanks!
Title: Re: Group Moderators 1.4
Post by: Dannii on March 28, 2007, 10:05:18 PM
I'm glad you were able to fix it! What was the solution if I can ask?

And honestly, there hasn't been much development on this mod for a very long time, but that's okay, it's a stable mod. I was more saying that I won't be implementing any need features that people have been asking for because I don''t have the time.
Title: Re: Group Moderators 1.4
Post by: tribalost on March 29, 2007, 03:26:46 PM
:( and i was soo looking forward to the group able to moderate a board like in phpbb :(

ohh well... anyone knows a mod like that? or has the same function at least?.
Title: Re: Group Moderators 1.4
Post by: Dannii on March 29, 2007, 09:37:24 PM
You can let a group moderate a board by using local board permissions.
Title: Re: Group Moderators 1.4
Post by: tribalost on March 29, 2007, 11:51:52 PM
yeah but its kinda too complicated if you want a board each group and having lots of boards :(
Title: Re: Group Moderators 1.4
Post by: Shonick on April 18, 2007, 08:17:51 PM
I have search over this topic, but I don't know how to use this mod. I went to the groups section.But I could not do anything there.Where is the control for this mod.?thanks
Title: Re: Group Moderators 1.4
Post by: codenaught on April 18, 2007, 08:42:59 PM
If the mod installed successfully you should be able to go to Admin / Membergroups to assign group moderators next to the field "Group moderators." As soon as a member is a group moderator they can go click the tab in the main menu "Groups" and add members there by clicking the number in the member count.
Title: Re: Group Moderators 1.4
Post by: Shonick on April 18, 2007, 08:57:36 PM
Quote from: akabugeyes on April 18, 2007, 08:42:59 PM
If the mod installed successfully you should be able to go to Admin / Membergroups to assign group moderators next to the field "Group moderators." As soon as a member is a group moderator they can go click the tab in the main menu "Groups" and add members there by clicking the number in the member count.

I have installed successful, but in the Admin / Membergroups , I did not see any change.

and I did not see this word"Group moderators" there?
If I was wrong , can you explan again for me.
Thank you.
Title: Re: Group Moderators 1.4
Post by: Dannii on April 18, 2007, 09:23:29 PM
Go and edit a group, and you should see the box to add names to.
Title: Re: Group Moderators 1.4
Post by: Shonick on April 18, 2007, 10:08:32 PM
Oh.thanks I saw it now.that is so great.
Another question.If a member want to join a group. How can they request to join.Like Vbulletin they go to their cp to choose a group and then make a request to the leader join.
Do we have that thing.

If not. Could we have something like in the next version.?
Title: Re: Group Moderators 1.4
Post by: Dannii on April 18, 2007, 10:12:07 PM
At the moment they can't request formally, but they could always send a PM.
As I said above, I'm not going to be actively developing this mod, but aka said he was interested at one time...
Title: Re: Group Moderators 1.4
Post by: codenaught on April 18, 2007, 10:27:59 PM
Indeed I am. :)

Such a feature will be available in SMF 2.0, however I will take a look into either writing a mod that can do this for 1.1 or adding the feature directly into this mod. The latter may be a pretty good option actually, but then maybe I will want to rename the mod to something more suitable for the added functionality. Such as "Group Moderators and Membership" or something like that.
Title: Re: Group Moderators 1.4
Post by: Dannii on April 18, 2007, 10:35:24 PM
I had planned on renaming it to SMF Groups and adding everything Group related, but.. got lazy :P
Title: Re: Group Moderators 1.4
Post by: ramiz on April 23, 2007, 08:14:19 AM
Hi eldʌkaː,

thanks again for this nice mod and i am using sucessfully in my forum

but in my forum i have nearly 15 to 20 groups...thus 15 to 20 group moderators are there

is there any way to get the list of all gorups moderatots...........means just wana display all the group moderators at one place  for the user's convenient

thanks in advance
Title: Re: Group Moderators 1.4
Post by: Dannii on April 23, 2007, 08:53:28 AM
Not easily sorry.
Title: Re: Group Moderators 1.4
Post by: CreatorFFM on April 24, 2007, 04:24:05 PM
Just wanted to say thanks for this mod. It has saved me a lot of headaches and works beautifully! :D Thanks again
Title: Re: Group Moderators 1.4
Post by: ms_ukyankee on April 25, 2007, 07:56:37 PM
Great mod, thank you! 8)
Title: Re: Group Moderators 1.4
Post by: floyd on April 26, 2007, 08:35:20 AM
I am using TP and I installed a different theme.

I am getting errors on install... can I not use this mod?

1. Execute Modification ./index.php Test successful
2. Execute Modification ./Sources/ManageMembergroups.php - Test successful
3. Execute Modification ./Sources/ManagePermissions.php - Test successful
4. Execute Modification ./Themes/default/index.template.php - Test failed
5. Execute Modification ./Themes/default/../babylon/index.template.php - Test successful
6. Execute Modification ./Themes/default/ManageMembergroups.template.php - Test successful
7. Execute Modification ./Themes/default/languages/Modifications.english.php - Test successful
8. Execute Modification ./Themes/default/languages/Modifications.swedish.php - Skipping file
9. Execute Modification ./Themes/default/languages/Help.english.php T- est successful
10. Execute Modification ./Themes/default/languages/Help.swedish.php - Skipping file
11. Extract File ./Sources/Groups.php 
12. Extract File ./Themes/default/Groups.template.php 
13. Extract File ./Themes/default/languages/Groups.english.php 
14. Extract File ./Themes/default/languages/Groups.swedish.php 
15. Extract Tree ./Themes/default/../babylon/images 
16. Execute Code GroupMods_install.php
Title: Re: Group Moderators 1.4
Post by: Dannii on April 26, 2007, 08:43:33 AM
It's probably conflicting with another mod. That's probably okay, the only thing you'll miss is a menu button, which you could add anyways.
Title: Re: Group Moderators 1.4
Post by: floyd on April 26, 2007, 01:04:18 PM
OK.... apparently it worked... I think.

What buttons am I missing and where shoud they link.
Title: Re: Group Moderators 1.4
Post by: Dannii on April 26, 2007, 09:50:38 PM
There should be a groups button in the menu. If its already there... then don't worry at all.
Title: Re: Group Moderators 1.4
Post by: IceMan314 on May 01, 2007, 06:27:25 AM
I got this mod but in the membergroup editing interface it just gives me a blank box with no explanation of what it's for and a tick box.
http://iceman314.net/sds.bmp (http://iceman314.net/sds.bmp)
Title: Re: Group Moderators 1.4
Post by: Dannii on May 01, 2007, 06:33:46 AM
Looks like the language entries weren't added correctly. You can add them yourself to modifications.english.php

Also, don't use .bmp images on the net!
Title: Re: Group Moderators 1.4
Post by: IceMan314 on May 01, 2007, 07:13:45 AM
I know, I forgot to convert it to .PNG before I uploaded it.
Title: Re: Group Moderators 1.4
Post by: eagled2 on May 09, 2007, 01:16:15 PM
I didn't realize there was a topic for each mod posted but I had a hard time getting this mod to work. After getting help from two people and making some syntax changes to the code change in membergroups.template.php I was able to get it to work. I don't know if I have permission to upload the edited file from the mod owner so I won't upload it but if I do have permission please email me. [email protected] and I'll upload it. For all other files I followed the instuctions exactly as the auto install was trying to do it for the files that had errors updating.
Title: Re: Group Moderators 1.4
Post by: Surfy on May 09, 2007, 06:31:29 PM

I hope someone could help me out:

Die Installation dieses Paketes führt folgende Aktionen aus:  Typ Aktion Beschreibung
1. Modifikation ausführen GroupMods_sources_11.xml Modifikation Parse-Error
2. Modifikation ausführen - Modifikation Parse-Error
3. Modifikation ausführen GroupMods_templates_11.xml Modifikation Parse-Error
4. Modifikation ausführen - Modifikation Parse-Error
5. Modifikation ausführen GroupMods_language.xml Modifikation Parse-Error
6. Modifikation ausführen - Modifikation Parse-Error


I have a clean SMF 1.1.2

Title: Re: Group Moderators 1.4
Post by: Dannii on May 09, 2007, 09:53:35 PM
Have you been able to install other mods? I've never seen anyone get modification parse errors on every file.
Title: Re: Group Moderators 1.4
Post by: El Reclutador 2003 on May 12, 2007, 08:07:06 PM
Hello there:

i've installed this mod, but i don't see the button in cpanel. where is the link in the administration panel? Thanks!
Title: Re: Group Moderators 1.4
Post by: Dannii on May 12, 2007, 10:51:45 PM
When you edit a ground, you'll see the new fields there.
Title: Re: Group Moderators 1.4
Post by: El Reclutador 2003 on May 13, 2007, 08:33:05 AM
Sorry i dont understand you :S im spanish

Do you say in admin >> user settings or admin >> usergroup settings? Thanks
Title: Re: Group Moderators 1.4
Post by: Dannii on May 13, 2007, 09:06:33 AM
Sorry when you edit a group. Typos suck.
Membergroups -> A group (global mods for example) -> Edit
You'll see two fields there.
Title: Re: Group Moderators 1.4
Post by: El Reclutador 2003 on May 13, 2007, 10:19:56 AM
I saw it! Thanks!!!!!! :)
Title: Re: Group Moderators 1.4
Post by: CrimsonGuard on May 16, 2007, 06:05:38 AM
Just wanted to say a big thank you for this mod!

I'm the admin of a gaming community, well over 100 members (and growing).  This mod has reduced my work load tremendously, and increased senior member satisfaction greatly.  Not only do they have a fancy tool to play with (with rules ofc), but they also feel entrusted with some formal responsibilities.

I ran into a snag with the install myself, but it was just a issue with how another mod left the modifcations.english.php file.  The php document was closed off, but still had one line left - so I had some nasty php code spill onto the index page. 

With that, all I can request is that instead of searching for the end of a document (which may or may not be closed), if it's possible to search for the ending php code.  This would elliminate the problem once and for all.

Many thanks again!
Title: Re: Group Moderators 1.4
Post by: Dannii on May 16, 2007, 08:41:32 AM
Glad you find it useful :)
Title: Re: Group Moderators 1.4
Post by: Surfy on June 02, 2007, 05:13:35 PM

For me it now also works very well  :-*

The errors i had become, while trying Modinstallation, occured because i had false Folder permissions...

Many thanks for this mod!
Title: Re: Group Moderators 1.4
Post by: uberLeet on June 17, 2007, 08:03:42 AM
Nice mod, I am currently using it myself.

Just 1 question though - is there any way of setting it so if I move someone to a certain membergroup (all members in this membergroup would all have the same power aswell), that they will automatically become a group moderator over certain groups? I dunno if I've worded that in an understanble manner...

Sorry if this has been asked/answered before, but I didn't exactly feel like going through 20 pages of posts :x

Keep up the good work ^^
Title: Re: Group Moderators 1.4
Post by: Dannii on June 17, 2007, 08:33:05 AM
No, you have to individually set members as moderators over another group.
Title: Re: Group Moderators 1.4
Post by: uberLeet on June 21, 2007, 11:18:38 AM
Quote from: eldʌkaː on June 17, 2007, 08:33:05 AM
No, you have to individually set members as moderators over another group.

Ok, thanks for the reply.
Title: Re: Group Moderators 1.4
Post by: Meira on June 27, 2007, 10:32:00 PM
Olá eldʌkaː,
Poderia esclarecer pra mim o porque da falha que está aparecendo quando aplico o MOD Group Moderators 1.4 ?
Veja a imagem anexa.

Uso fórum smf 1.1.2, Default.
Title: Re: Group Moderators 1.4
Post by: Dannii on June 28, 2007, 12:16:41 AM
I don't know what you said, but you should be able to install it anyways, the only change to index.template.php is the button, which isn't needed.
Title: Re: Group Moderators 1.4
Post by: Meira on June 28, 2007, 12:09:44 PM
Translating:
--------------------
Hello eldʌkaː,     
Could it clear for me the because of the flaw that is appearing when I apply MOD Group Moderators 1.4?   
See the image.   
   
I use forum smf 1.1.2, Default.

Explain to me?
Title: Re: Group Moderators 1.4
Post by: Dannii on June 28, 2007, 11:22:56 PM
You can install it with that error, there just won't be an extra menu button. It will still work if you go to action=groups. If you need the button, you can add it yourself manually.
Title: Re: Group Moderators 1.4
Post by: Meira on June 29, 2007, 01:03:39 PM
How I do to add the button manually? Is it in which file?
Title: Re: Group Moderators 1.4
Post by: Dannii on June 29, 2007, 10:54:53 PM
index.template.php
Title: Re: Group Moderators 1.4
Post by: Meira on June 30, 2007, 12:12:10 PM
Quote from: eldʌkaː on June 29, 2007, 10:54:53 PM
index.template.php

* What is modification in the file that I should do for the icon to appear in the theme Default in " index.template.php "?
* Where do appear the icon "groups"?

Thanks.
Title: Re: Group Moderators 1.4
Post by: Dannii on June 30, 2007, 11:01:21 PM
http://docs.simplemachines.org/index.php?topic=564.0 Hopefully that will help.
Title: Re: Group Moderators 1.4
Post by: kamili34 on July 01, 2007, 07:05:39 PM
I can't install it on smf 1.1.3 theme saf multicolour

2.  Wykonaj modyfikację  ./Sources/ManageMembergroups.php  Not success
6. Wykonaj modyfikację ./Themes/default/ManageMembergroups.template.php Not success


Please help :(
Title: Re: Group Moderators 1.4
Post by: Dannii on July 02, 2007, 03:01:23 AM
Got any other mods that have edited those files?
Title: Re: Group Moderators 1.4
Post by: kamili34 on July 02, 2007, 03:30:23 AM
my mods

1.  Seo 4 SMF  0.2.9.6   
2. Moderator Activity Report for SMF1.1.2 1.2
3. VisualWarning 1.32
4. SMF 1.0.11 / 1.1.3 Update 1.1
5. Profil Moderator Managment 1.0.0
6. LogModAccountEdits 1.9
7. FontandSizeDropdown1.1.2 1.1.2
8. User Agent Mod 0.97
9. Users Online Today Mod 1.4.0
Title: Re: Group Moderators 1.4
Post by: Dannii on July 02, 2007, 04:02:38 AM
it's probably one of these three:

2.    Moderator Activity Report for SMF1.1.2    1.2
5.    Profil Moderator Managment    1.0.0    
6.    LogModAccountEdits    1.9    
Title: Re: Group Moderators 1.4
Post by: kamili34 on July 02, 2007, 05:18:00 AM
So what should i do ? ::)
Title: Re: Group Moderators 1.4
Post by: Dannii on July 02, 2007, 07:52:52 AM
You can try editing the files manually yourself, shouldn't be too hard, there aren't very big changes.
Title: Re: Group Moderators 1.4
Post by: kamili34 on July 02, 2007, 10:42:05 AM
So I shoul this mod install manualy and not using menager packets ?

I think I do it without pitfals  :P

Thanks in advance  :)
Title: Re: Group Moderators 1.4
Post by: Dannii on July 02, 2007, 11:02:36 AM
I'd suggest installing it with the package manager (even though there are errors) and then doing the conflicting changes in those two files yourself.
Title: Re: Group Moderators 1.4
Post by: kamili34 on July 02, 2007, 01:33:27 PM
And last guestion but not least  :P

Ok i will do this as you say.  But this two files with errors will not installed so i must only modify  it manualy, am i correct ?
Title: Re: Group Moderators 1.4
Post by: Meira on July 02, 2007, 06:05:02 PM
Quote from: eldʌkaː on June 30, 2007, 11:01:21 PM
http://docs.simplemachines.org/index.php?topic=564.0 Hopefully that will help.

eldʌkaː,
I don't dominate English a lot. 
Will it be that could place the necessary codes here they be her done manually in the file " index.template.php " so that appeared the icon GROUPS? (Please) 
 
Thank you.
Title: Re: Group Moderators 1.4
Post by: Dannii on July 04, 2007, 01:13:25 AM
kamili34, yeah you'll only need to modify the files with errors, the others will be done by the package manager.
Meira, I suggest you ask for help in one of the language specific boards then, it's quite simple so they should be able to help you.
Title: Re: Group Moderators 1.4
Post by: Meira on July 04, 2007, 05:05:20 PM
Did I get, now as I do to place the members of the groups for us to appear inside of the icon " groups " that appears in the home?

Thanks.
Title: Re: Group Moderators 1.4
Post by: Dannii on July 04, 2007, 11:33:40 PM
I'm not sure what you're asking, but to add moderators to a group, go to the admin panel -> membergroups -> edit the group. There is a list where names can be added.
Title: Re: Group Moderators 1.4
Post by: Meira on July 06, 2007, 11:54:46 PM
How do I do to translate those names that one find circulated in red in the annexed image? Which is the file?

It was worth!
Title: Re: Group Moderators 1.4
Post by: Dannii on July 07, 2007, 10:07:56 AM
They should just use the standard ManageMembers language file I think.
Title: Re: Group Moderators 1.4
Post by: SkyFlyer on July 10, 2007, 10:02:26 PM
Will this be release for 1.1.3? I noticed that a lot of great mods haven't been updated for 1.1.3 yet :(
Title: Re: Group Moderators 1.4
Post by: Dannii on July 10, 2007, 10:47:55 PM
It already should work in 1.1.3, I just forgot to tick the box.
Title: Re: Group Moderators 1.4
Post by: SkyFlyer on July 10, 2007, 10:57:37 PM
Any chance you could reup it for 1.1.3 so the package manager doesn't wet itself?  ;D
Title: Re: Group Moderators 1.4
Post by: Dannii on July 11, 2007, 12:56:33 AM
Did you try it yet? Were there errors?
Title: Re: Group Moderators 1.4
Post by: SkyFlyer on July 11, 2007, 02:35:07 AM
The package you are trying to download or install is either corrupt or not compatible with this version of SMF.


I get that with all 1.1.2 packages. I guess I could edit the xml file but I'm rather lazy.
Title: Re: Group Moderators 1.4
Post by: Dannii on July 11, 2007, 03:30:16 AM
Well the mod supports 1.1.3, so there's a problem with your package manager or server. Editing the XML file won't help.
Title: Re: Group Moderators 1.4
Post by: SkyFlyer on July 11, 2007, 11:22:23 AM
Quote from: eldʌkaː on July 11, 2007, 03:30:16 AM
Well the mod supports 1.1.3, so there's a problem with your package manager or server. Editing the XML file won't help.
its a clean install, and other packages (that say 1.1.3) work.
Title: Re: Group Moderators 1.4
Post by: Dannii on July 11, 2007, 09:52:24 PM
I just downloaded the file, and it already has 1.1.3 in the package-info.xml file, so I don't know what the problem is.
Title: Re: Group Moderators 1.4
Post by: SkyFlyer on July 12, 2007, 01:30:03 AM
Huh. Interesting.

Any chance you could host it on your own webspace or putfile? Maybe there's some corruption going on. =\
Title: Re: Group Moderators 1.4
Post by: Dannii on July 12, 2007, 02:21:33 AM
http://code.google.com/p/smfgroups/downloads/list
Get it there then.
Title: Re: Group Moderators 1.4
Post by: SkyFlyer on July 12, 2007, 02:45:38 AM
Quote from: eldʌkaː on July 12, 2007, 02:21:33 AM
http://code.google.com/p/smfgroups/downloads/list
Get it there then.

Thank you.

I've installed a number of other packages as well, but also had some packages for 1.1.2 fail as well.
Title: Re: Group Moderators 1.4
Post by: Mark W on July 16, 2007, 02:19:29 AM
I'm also having a problem with this on SMF 1.3 - clean install.

One of the errors I'm getting is "
Fatal error: packageinstall(): Failed opening required '/PATH/Discuss/Packages/temp/./GroupMods_install.php' (include_path='.:/usr/local/lib/php') in '/PATH/Discuss/Sources/Packages.php on line 552
"

(where PATH is the path to the root of the site).

I tried the manual edit & some of the files seem different than the XML thinks they are. Like Sources/ManageMembers.php for example. I'm going to try to download 1.2 and installing this mod.
Title: Re: Group Moderators 1.4
Post by: JOSHSKORN on July 17, 2007, 11:59:19 PM
I've installed this mod.  When I click on the 'Groups' button, it's empty.  Can someone provide me with some guidance?  What exactly am I suppose to see and how am I suppose to get there?  My forum has many groups in it.
Title: Re: Group Moderators 1.4
Post by: Snape on July 18, 2007, 10:11:25 PM
Quote from: JOSHSKORN on July 17, 2007, 11:59:19 PM
I've installed this mod.  When I click on the 'Groups' button, it's empty.  Can someone provide me with some guidance?  What exactly am I suppose to see and how am I suppose to get there?  My forum has many groups in it.
You won't see membergroups in the groups interface until you add yourself as a group moderator for that group (Admin, Membergroups, Modify).
Title: Re: Group Moderators 1.4
Post by: kn0w3r on July 26, 2007, 02:50:58 AM
A big thanks to eldʌkaː for making a wondeful mod. By the way, I have some question here. I hope anyone can help me to solve this problem. How do I add a member to my group? I only see this in the Group page. There is no add member to group function in the Group page
Title: Re: Group Moderators 1.4
Post by: Dannii on July 26, 2007, 05:59:29 AM
Click on the number of members to see the list and add new people.
Title: Re: Group Moderators 1.4
Post by: RustyBarnacle on August 07, 2007, 02:39:39 PM
As with a couple people I've had problems with the groups button not being added and I would like the button to be there for those who have access to groups.

When you add the button do you have some code you could share that checks to see if they are a group mod and if so then add the button instead of just putting on a groups button for everyone whether they are a group mod or not?

Thanks.
Title: Re: Group Moderators 1.4
Post by: Dannii on August 07, 2007, 09:12:32 PM
No, however you could use the view_groups permission to do that. Checking whether someone's a group mod would be too intensive to do every page.
Title: Re: Group Moderators 1.4
Post by: RustyBarnacle on August 10, 2007, 02:47:34 PM
Are you considering language packs?

I tried using a free editor to make a language file for french and finnish in utf8 but I have no idea if they sound goofy or not.  Lots of free translators online dont do a great job.
Title: Re: Group Moderators 1.4
Post by: Dannii on August 10, 2007, 11:19:43 PM
It already has English and Swedish. Feel free to make more, but I'm not updating this mod anymore sorry.
Title: Re: Group Moderators 1.4
Post by: RustyBarnacle on August 10, 2007, 11:35:07 PM
Oh, very sorry to hear that , I'm only starting my site and this is one I considered my most important mod.
Title: Re: Group Moderators 1.4
Post by: Clarkey88 on August 19, 2007, 07:18:20 AM
6.     Execute Modification     ./Themes/default/ManageMembergroups.template.php     Test failed

Getting that when trying to apply it.  Any ideas?
Title: Re: Group Moderators 1.4
Post by: Dannii on August 19, 2007, 09:13:17 AM
It's probably conflicting with another mod. What else do you have installed?
Title: Re: Group Moderators 1.4
Post by: Clarkey88 on August 19, 2007, 09:21:49 AM
1.     YouTube BBC Tag (XHTML Compliant)      1.0       [ Uninstall ]  [ List Files ]  [ Delete ]
2.    Country Flags    1.0.1    [ Uninstall ] [ List Files ] [ Delete ]
3.    Ad Managment    2.3    [ Uninstall ] [ List Files ] [ Delete ]
4.    Custom Profile Field Mod    3.16    [ Uninstall ] [ List Files ] [ Delete ]
5.    Enhanced Quick Reply Box 2.0    2.0    [ Uninstall ] [ List Files ] [ Delete ]
6.    Display Age and Location next to posts    1.0    [ Uninstall ] [ List Files ] [ Delete ]
7.    Reason For Editing Mod    1.14    [ Uninstall ] [ List Files ] [ Delete ]
8.    PM On Registration    1.0.2    [ Uninstall ] [ List Files ] [ Delete ]
9.    View Single PM    1.3    [ Uninstall ] [ List Files ] [ Delete ]
10.    Group Moderators    1.4    [ Apply Mod ] [ List Files ] [ Delete ]
Title: Re: Group Moderators 1.4
Post by: Dannii on August 19, 2007, 09:30:53 AM
Hmm, I don't know which it might be conflicting with. You can try installing it manually, the changes aren't too complicated.
Title: Re: Group Moderators 1.4
Post by: Clarkey88 on August 19, 2007, 11:27:49 PM
Seeing as how it works with everything except ./Themes/default/ManageMembergroups.template.php can I just change that one manually?  How do I know what to change?
Title: Re: Group Moderators 1.4
Post by: Dannii on August 20, 2007, 01:07:12 AM
Yes you could install it and then fix that file manually. If you open up the zip file, you'll see a file called GroupMods_sources_11.xml which has the changes required.
Title: Re: Group Moderators 1.4
Post by: Clarkey88 on August 20, 2007, 02:40:27 AM
Sorry, but I'm a newbie at this sort of stuff.  Do I just copy everything from that .xml file and paste it in?  If so, where exactly?
Title: Re: Group Moderators 1.4
Post by: Dannii on August 20, 2007, 03:49:23 AM
See here: http://docs.simplemachines.org/index.php?topic=402.0
Title: Re: Group Moderators 1.4
Post by: tobijahk on September 16, 2007, 05:19:39 AM
I have SMF 1.1.3, fresh install, swedish language and SMF default skin selected and no other mods installed. I can't get this mod to work. It only shows the header (here you can see bla bla text) but not the form where the group moderator should be able to add/remove members, neither are the members of the group listed.

Is the 1.4 version of this mod really supposed to work with SMF 1.1.3?
Title: Re: Group Moderators 1.4
Post by: Dannii on September 16, 2007, 07:36:39 AM
I just installed it then on a new 1.1.3 forum, and it works fine. Anything in the error log?
Title: Re: Group Moderators 1.4
Post by: Neorics on September 16, 2007, 12:48:24 PM
installation error on index.template.php
i'm using the following mods

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg160.imageshack.us%2Fimg160%2F7602%2Fmodsbz9.jpg&hash=d6804d46c1aa3164b89868bf200fedbada5a6eaa)

can i get the manual code just for the index.template.php?

also this mod aint working with the mod parser
http://modparser.dev.dansoftaustralia.net/
Title: Re: Group Moderators 1.4
Post by: Dannii on September 16, 2007, 08:34:33 PM
The only thing that is modified on index.template.php is the menu button. Install it anyways, and then add the button in yourself manually, or not, it's pretty useless.
Title: Re: Group Moderators 1.4
Post by: RustyBarnacle on September 17, 2007, 12:36:52 AM
Again, I find it to be one of my most important mods, definitely not useless as long as you have a link to it.
Title: Re: Group Moderators 1.4
Post by: Neorics on September 17, 2007, 09:06:00 AM
Quote from: Neorics on September 16, 2007, 12:48:24 PM
installation error on index.template.php
i'm using the following mods

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg160.imageshack.us%2Fimg160%2F7602%2Fmodsbz9.jpg&hash=d6804d46c1aa3164b89868bf200fedbada5a6eaa)

can i get the manual code just for the index.template.php?

also this mod aint working with the mod parser
http://modparser.dev.dansoftaustralia.net/

aight cool thanks, great mod btw
Title: Re: Group Moderators 1.4
Post by: Neorics on September 17, 2007, 12:41:43 PM
dude umm... can i still have the code on what it does though?

i mean even if the installation test failed on the index.template.php it would still try to do it if i installed the package right? or smf didnt do that part cause the test failed and my index.template.php isnt modified?
Title: Re: Group Moderators 1.4
Post by: KD4FBI on September 17, 2007, 01:52:24 PM
I am trying to use the Group Moderators mod.
I did the editing like the xml file told me to.
I keep getting an error on a section of the code for managemembergroups.template.php.
The section is:
// Group Moderators
   if ($context['group']['allow_delete'] && !$context['group']['is_post_group'])
      echo '
   <tr class="windowbg2" style="padding-top: 1em;">
   <th align="right"><label for="groupmods_input">', $txt['elgm1'], ':</label></th>
   <td><input type="text" name="groupmods" id="groupmods_input" value="', implode(',', $context['group']['moderators']), '" size="30" />
   <a href="', $scripturl, '?action=findmember;input=groupmods_input;quote;sesc=', $context['session_id'], '" onclick="return reqWin(this.href, 350, 400);"><img src="', $settings['images_url'], '/icons/assist.gif" border="0" alt="', $txt['find_members'], '" /></a></td>
   </tr>
The line that is errored is:
   if ($context['group']['allow_delete'] && !$context['group']['is_post_group']).
The error I get is:
Parse error: parse error, unexpected T_STRING, expecting ',' or ';' in /home/content/m/i/c/mickeymaam/html/hraforums/Themes/default/ManageMembergroups.template.php on line 237.
Can you tell me what I may have done wrong?
Thank you very much,
Mickey
Title: Re: Group Moderators 1.4
Post by: Dannii on September 17, 2007, 09:44:39 PM
Neorics, look in GroupMods_templates_11.xml
KD4FBI, You must be missing a single quote(') somewhere there. Is there one after the final </tr>?
Title: Re: Group Moderators 1.4
Post by: Neorics on September 18, 2007, 01:20:26 PM
yeah... thanks
Title: Re: Group Moderators 1.4
Post by: Niklas_ on September 30, 2007, 12:16:34 PM
I just installed the mod in my SMF 1.1.3 Forum. But I can't find a function to add am moderator to a group.

Neither in the german nor in the english Admin Panel is a possibility to set a person to be moderator of a group.

Thank you!
Title: Re: Group Moderators 1.4
Post by: Dannii on September 30, 2007, 06:22:45 PM
Were there any errors when you installed?
Title: Re: Group Moderators 1.4
Post by: Niklas_ on October 01, 2007, 12:04:39 PM
Not that I noticed, it just said that it succeeded in all the important part, it scipped the swedish language files and did not say anything about new files to be created...

I just reinstalled it after chmodding all the files to the phprun, but it did not change anything. I think the files belonged to phprun before anyway. Where exacly am I supposed to find the option? Do I have to use another template?

Edit: I just checked in the SMF Standard Template - no link..
If you tell me where I should be able to find the modifications I can check if they are there...
Title: Re: Group Moderators 1.4
Post by: Dannii on October 01, 2007, 10:11:07 PM
Just checking, when you go to edit a group, there's no text box labeled "group moderators"?
Title: Re: Group Moderators 1.4
Post by: Niklas_ on October 02, 2007, 01:19:22 PM
No, there isn't... Neither next to the List of the Members, nor on the page where I can Edit the Name, Colour, Number of Stars, etc...

My SMF is running on a Joomla! Bridge and I have got the Visual Verification Options 0.3.1 installed. No other Mod. At the Moment I (still) run the 1.1.3 Version because the Group Mod Mod Page doesn't say that the mod works on 1.1.4.....
Title: Re: Group Moderators 1.4
Post by: Dannii on October 03, 2007, 04:07:39 AM
It's possible the mod is conflicting with one of those (somehow). You could try manually editing your the ManageMembers.template.php file.
Title: Re: Group Moderators 1.4
Post by: Niklas_ on October 03, 2007, 04:41:28 AM
I could do that, yes, where do I find out what I need to change??
Title: Re: Group Moderators 1.4
Post by: Dannii on October 03, 2007, 04:54:16 AM
It will be in GroupMods_templates_11.xml. Hopefully only the templates need to be manually edited...
Title: Re: Group Moderators 1.4
Post by: JCDenton314 on October 06, 2007, 02:12:50 PM
I have just installed this mod on my SMF 1.1.4 forum yet there is no label for the modertor, nor a button to access moderating pages.
Screenshot (http://icetalk.net/images/ss.JPG)
What is the problem here?
Title: Re: Group Moderators 1.4
Post by: Dannii on October 06, 2007, 06:06:11 PM
Looks like the language entries didnt get added. You can easily manually add them to modifications.english.php though,
Title: Re: Group Moderators 1.4
Post by: burobu on October 07, 2007, 12:21:20 AM
I have the exact same problem as Niklas_ even though there were no errors during install. I will try editing the managemembers template manually.

EDIT: looks like nothing got edited after installing this.. have to do it all manually

The database additions were installed though

Thanks for the great mod!
Title: Re: Group Moderators 1.4
Post by: jackulator on October 15, 2007, 06:11:21 PM
I installed this mod - and it was the first time I installed anything if it said there was an error after applying - I'd just done a backup a couple of hours before, and I sort of just wanted to see what would happen, plus, I'd also downloaded the uninstall file that comes with this

but I had an error message at some point, so I FTP-ed the uninstall file into my smf directory and browsed to it, but it said:

Groupmods Uninstall
Error removing groupmods table.

"; } else echo "

Uninstallation successful. Remember to delete this file.
"; ?>

and now, whenever I try to modify a member group I get:

Unknown column 'GroupModOptions' in 'field list'
File: ........(my database).........Sources/ManageMembergroups.php
Line: 523

Note: It appears that your database may require an upgrade. Your forum's files are currently at version SMF 1.1.4, while your database is at version 1.1.3. The above error might possibly go away if you execute the latest version of upgrade.php.


have I completely screwed things up now or is there an easy fix for this?
Title: Re: Group Moderators 1.4
Post by: Dannii on October 15, 2007, 08:02:19 PM
That uninstall file is outdated sorry.
Title: Re: Group Moderators 1.4
Post by: jackulator on October 16, 2007, 03:10:06 AM
so what should I do about this?
Title: Re: Group Moderators 1.4
Post by: jackulator on October 16, 2007, 03:51:34 AM
nevermind - I just copied ManageMemberGroups.php from my test forum into the Sources folder of my main forum and it works again
Title: Re: Group Moderators 1.4
Post by: pdeoliveira on November 06, 2007, 05:07:18 AM
Hello,
This mod is great and we're going to use it for the support forum of our service (forum.sporama.fr).
I have developed a french version of this mod. Whom should I send it to to have it included in the "standard" version ?
This is my first translation of a SMF mod, so I may have made errors ...
Title: Re: Group Moderators 1.4
Post by: Dannii on November 06, 2007, 05:41:28 AM
I'm no longer developing this mod, so unless someone else picks it up, there's unlikely to be any further updates. Feel free to upload the code here though, in case anyone wants it :)
Title: Re: Group Moderators 1.4
Post by: pdeoliveira on November 06, 2007, 09:55:17 AM
OK; So here is a link to the mod Group Moderators 1.4 with english, swedish and french versions included. All comments on the french version are welcome !

http://www.ramaplus.fr/download/smf_1-1-4_french.tar.bz2 (http://www.ramaplus.fr/download/smf_1-1-4_french.tar.bz2)
Title: Re: Group Moderators 1.4
Post by: eleven0 on November 12, 2007, 08:33:03 PM
First off all, groups tab doesn't appear in menu. which kinda works for me. because i couldn't set permissions for that. Can you tell me how i can do that?

and when someone is viewing their group page, It says     "Viewing the Groups interface." in who is online list. I want to change that. How?

Thanks.
Title: Re: Group Moderators 1.4
Post by: Dannii on November 12, 2007, 10:24:02 PM
QuoteFirst off all, groups tab doesn't appear in menu. which kinda works for me. because i couldn't set permissions for that. Can you tell me how i can do that?
It's just a normal permission. Why couldn't you set it?

Quoteand when someone is viewing their group page, It says     "Viewing the Groups interface." in who is online list. I want to change that. How?
edit $txt['who_groups'] in Modifications.english.php
Title: Re: Group Moderators 1.4
Post by: h4tr3d on December 29, 2007, 06:48:01 PM
I install SMF 1.1.3 (from my distributive repositaries) and update it up to 1.1.4, after i try to install Group Moderators mod but SMF says me that this archive is not package or corrupt, but manualy it unpacked well.
Title: Re: Group Moderators 1.4
Post by: h4tr3d on December 30, 2007, 04:04:26 AM
Hmmm... Error in crc32 checking
Title: Re: Group Moderators 1.4
Post by: Dannii on December 30, 2007, 04:09:35 AM
What error?
Title: Re: Group Moderators 1.4
Post by: jackregan on January 10, 2008, 03:12:23 AM
I am having a problem installing this mod and could do with a tip...

It fails the test on the index.template.php file, which does not suprise me since this is heavily edited on my forum (default theme)

So I am thinking of 2 options:

1. To backup the index.template.php file and then just copy back in the old one when the installation messes it up.

2. to get inside the mods xml files and remove the operations to alter this particular file. I have tried to do this but whenever I zip it all up again to .zip or .gtar format, SMF doesn't recognise it a a valid package!!


...after each option, I would just change the index.template.php manually to add a menu option ?action=groups
Title: Re: Group Moderators 1.4
Post by: Dannii on January 10, 2008, 04:49:09 AM
When you install it, it won't mess up your index.template.php file, it just won't add in the menu item. You can add it in yourself, or just leave it out.
Title: Re: Group Moderators 1.4
Post by: jackregan on January 10, 2008, 12:26:41 PM
Okay, I've done that and it works fine.

Good mod :)


By the way, is there any plan to develop this mod so that users can create their own groups?
Title: Re: Group Moderators 1.4
Post by: Dannii on January 10, 2008, 09:34:29 PM
No, as I said above,
Quote from: Dannii on November 06, 2007, 05:41:28 AM
I'm no longer developing this mod, so unless someone else picks it up, there's unlikely to be any further updates. Feel free to upload the code here though, in case anyone wants it :)
Title: Adding the groups button in personal theme
Post by: Viporizer on February 11, 2008, 09:55:07 AM
Adding the button in SMF 1.1.4

Take the index.template.php from your personal Theme.

Search for: // Login

and add above it:


   // Groups
   $context['menubox'][]=array(
            'title' => 'Groups',
            'link' => $scripturm.'?action=groups',
            'chosen' => 'groups',
            'mermberonly' => true,
            'guestonly' => false,
            'permission' => 'allow_memberlist',
            );
Title: Re: Group Moderators 1.4
Post by: Damian1221 on February 13, 2008, 08:11:31 PM
Quote from: Viporizer on February 11, 2008, 09:55:07 AM
Adding the button in SMF 1.1.4

Take the index.template.php from your personal Theme.

Search for: // Login

and add above it:


   // Groups
   $context['menubox'][]=array(
            'title' => 'Groups',
            'link' => $scripturm.'?action=groups',
            'chosen' => 'groups',
            'mermberonly' => true,
            'guestonly' => false,
            'permission' => 'allow_memberlist',
            );


not working for me in 1.1.4 dilbermc theme that code doesn't work and a bunch of code gets added to the top of my page
Title: Re: Group Moderators 1.4
Post by: Dannii on February 13, 2008, 08:40:31 PM
Ask the theme's author for help.
Title: Re: Group Moderators 1.4
Post by: Damian1221 on February 14, 2008, 08:34:51 PM
// Group Moderators $txt['elgm1'] = 'Group moderators'; $txt['elgm2'] = 'Allow Primary Group'; $txt['elgm3'] = 'When someone is added through the Groups interface allow it to be set to Primary?'; $txt['elgm4'] = 'Groups'; $txt['permissionname_view_groups'] = 'View the Groups interface'; $txt['permissionhelp_view_groups'] = 'The Groups interface allows groups to be moderated by specific non-admin members.'; $txt['cannot_view_groups'] = 'Sorry, you\'re not allowed to view the Groups interface.'; $txt['permissiongroup_view_groups_group'] = 'Groups'; $txt['whoall_groups'] = 'Viewing the Groups interface.';


I get this at the top and I can't go to my index.php?action=group it just brings me back to the index

any ideas i really want to use this mod  :(
Title: Re: Group Moderators 1.4
Post by: Dannii on February 18, 2008, 02:45:32 AM
Check that there's only one ?> in modifications.english.php and that it's at the end of the file.
Title: Re: Group Moderators 1.4
Post by: Kender on February 20, 2008, 01:18:07 AM
okay, i have installed this mod, i do see its not supported, but i hope someone can help

I have added a member to a membergroup as group moderator, but he cannot see the button/menu item, i do have the group by default not set for that permission, because i only would like the menu item visible to the moderator, not to the whole usergroup who will have no use for the button
Title: Re: Group Moderators 1.4
Post by: Dannii on February 20, 2008, 06:13:56 AM
You could always make a new group and only add that member to the group. That would be the simplest way.
Title: Re: Group Moderators 1.4
Post by: Narcotic on March 24, 2008, 04:09:09 PM
problem ? http://www.sevdigim.net/index.php?action=groups
Title: Re: Group Moderators 1.4
Post by: Dannii on March 24, 2008, 09:02:47 PM
What's the problem?
Title: Re: Group Moderators 1.4
Post by: digit on April 01, 2008, 12:50:42 AM
Quote from: Dannii on March 24, 2008, 09:02:47 PM
What's the problem?

I have a little problem with a manual install (after so many mods, I have learned to manually install all new mods!)

It seems that there are funky characters in place of new line characters...  at least in the

GroupMods_sources_11.xml file.

Usually I can do a simple search and replace (using BBEdit on a Mac) but it isn't working.  :(

See the attachment. 

Is there anyway to give me updated files where those characters are replaced with "\r" ???


Title: Re: Group Moderators 1.4
Post by: Dannii on April 01, 2008, 01:41:12 AM
Hmm well I would have thought it should use that line ending already. Does it work if you copy it from http://smfgroups.googlecode.com/svn/trunk/GroupMods_templates_11.xml?
Title: Re: Group Moderators 1.4
Post by: digit on April 01, 2008, 01:55:24 AM
Well, this is probably a mac thing...  I simply changed the carraige return settings from Windoze to UNIX, and I was able to search and replace.

I have another problem though.

When I go into manage Membergroups, I do not see any  "Group Moderator(s)" boxes.... and when I go to action=groups, (as non admin) I don't see any way to add anything...  just an empty table. 

See attachments.  Attachment 1 is what the non global moderator sees by accessing action=groups, (but he is a moderator of one forum) , attachment 2 is what I, the admin sees in the edit membergroup area.

Any idea?  I have double checked everything!
Title: Re: Group Moderators 1.4
Post by: Dannii on April 01, 2008, 11:52:10 AM
Does the theme come with it's own ManageMembergroups template perhaps? In any case, it shouldn't be too hard to manually add the input box yourself.
Title: Re: Group Moderators 1.4
Post by: digit on April 01, 2008, 03:12:41 PM
DOH!  I see now, I didn't edit the ManageMembergroups.template.php

Thanks!
Title: Re: Group Moderators 1.4
Post by: OutofOrder on April 16, 2008, 09:42:40 AM
Dannii, this is a terrific mod :D Excellent job.

I've manually translated the strings to spanish (modifications.spanish and help.spanish) to make it available in my forum. But for some reason they aren't being shown in my test forum. (See attached screenshot)

The mod, however, works fine in english. Also, the corresponding strings are being shown within the Admin panel (when editing membergroups)... which makes this bug more confusing, at least for me  ???

Would you hint me where to look for? Since i'm kinda lost.
The Groups template section is accesed via Groups.template.php, right? Why wouldn't the language strings load? I've respected $txt indexes when translating.
Looking forward to your reply :)
Title: Re: Group Moderators 1.4
Post by: Dannii on April 16, 2008, 09:51:04 AM
Did you add a Groups.spanish.php file too?
Title: Re: Group Moderators 1.4
Post by: OutofOrder on April 16, 2008, 10:04:36 AM
D'oh. *facepalm*

Indeed. There's my problem :) Thanks a lot.
Title: Re: Group Moderators 1.4
Post by: e2p2 on April 16, 2008, 10:46:29 AM
Does any one have this working with SMF 2.0 Beta 3 Public?  If so can you post the modifications or files.
Title: Re: Group Moderators 1.4
Post by: Dannii on April 16, 2008, 10:57:00 AM
You don't need it on SMF 2, as it's a default feature.
Title: Re: Group Moderators 1.4
Post by: e2p2 on April 16, 2008, 11:11:31 AM
Yes there is a moderator feature in SMF2.0.  But the moderator cannot add or remove people from a group like this group moderator mod allows.
Title: Re: Group Moderators 1.4
Post by: Dannii on April 16, 2008, 11:38:56 AM
Edit a group and add a name to the moderator field, just like this mod. They can then add/remove members through the moderator CP.
Title: Re: Group Moderators 1.4
Post by: e2p2 on April 16, 2008, 01:47:25 PM
I looked at the permissions available to the "moderator" group, it is missing the Member Administration section and Manage and Assign Member Groups permission.  I have to make a user a Global Moderator, in which I have enabled the permission Manage and Assign Member Groups.  Then the moderator can add and remove users to any group.  I would like it so that the moderator can only add and remove users from the group which they are moderating.
Title: Re: Group Moderators 1.4
Post by: Dannii on April 16, 2008, 06:45:56 PM
No, you don't understand. It has nothing to do with permissions. You edit the page of the group you want, then add the name of the user. Not the Mod or Global Mod group (unless you want someone to moderate the Global Mod group that is...)
Title: Re: Group Moderators 1.4
Post by: Apllicmz on May 28, 2008, 10:26:21 PM
Nice WORK
update portuguese and brazilian Linguage

<?php
// Version: 1.2; Groups
// Translate By Candidosa2 Suporte By Joomlamz.com
$txt['groups_add'] = 'Adicionar membros';
$txt['groups_add_title'] = 'Adicionar um membro ao grupo';
$txt['groups_add_desc'] = 'Adicionar a Lista dos membros';
$txt['groups_count'] = 'Membro contar';
$txt['groups_description'] = 'Aqui você pode visualizar e gerenciar as listas sobre qualquer membro grupos para os quais você está mais moderador.';
$txt['groups_list_desc'] = 'Abaixo está uma lista de todos os membros que actualmente pertencem a este grupo membro.';
$txt['groups_member'] = 'Membro grupos';
$txt['groups_members_title'] = 'Visualizar todos os membros do grupo';
$txt['groups_name'] = 'Nome';
$txt['groups_no_members'] = 'Este grupo está atualmente vazia';
$txt['groups_remove'] = 'Remover do grupo';
$txt['groups_return'] = 'Regresso aos grupos moderação';
$txt['groups_title'] = 'Grupos moderação';
$txt['not_groupmod _error'] = 'Você não é moderador deste grupo.';

?>


<file name="$languagedir/Modifications.portuguese.php" error="skip">
<operation>
<search position="end"></search>
<add><![CDATA[
// Group Moderators
$txt['elgm1'] = 'Group moderators';
$txt['elgm2'] = 'Permitam grupo primário';
$txt['elgm3'] = 'Quando alguém é adicionado através da interface Grupos lhe permitem ser ajustado para a Primária?';
$txt['elgm4'] = 'Groupos';
$txt['permissionname_view_groups'] = 'Ver os Grupos interface';
$txt['permissionhelp_view_groups'] = 'A interface permite Grupos de ser moderado por grupos específicos não-administrador membros.';
$txt['cannot_view_groups'] = 'Desculpa, você não está autorizado a visualizar os grupos interface.';
$txt['permissiongroup_view_groups_group'] = 'Groupos';
$txt['whoall_groups'] = 'Vendo o <a href="' . $scripturl . '?action=groups">Groupos</a> interface.';
]]></add>
</operation>
</file>

<file name="$languagedir/Modifications.brazilian.php" error="skip">
<operation>
<search position="end"></search>
<add><![CDATA[
// Group Moderators
$txt['elgm1'] = 'Group moderators';
$txt['elgm2'] = 'Permitam grupo primário';
$txt['elgm3'] = 'Quando alguém é adicionado através da interface Grupos lhe permitem ser ajustado para a Primária?';
$txt['elgm4'] = 'Groupos';
$txt['permissionname_view_groups'] = 'Ver os Grupos interface';
$txt['permissionhelp_view_groups'] = 'A interface permite Grupos de ser moderado por grupos específicos não-administrador membros.';
$txt['cannot_view_groups'] = 'Desculpa, você não está autorizado a visualizar os grupos interface.';
$txt['permissiongroup_view_groups_group'] = 'Groupos';
$txt['whoall_groups'] = 'Vendo o <a href="' . $scripturl . '?action=groups">Groupos</a> interface.';
]]></add>
</operation>
</file>


<file name="$languagedir/Help.portuguese.php" error="skip">
<operation>
<search position="end"></search>
<add><![CDATA[
// Group Moderators
$helptxt['groups'] = '<b>Groupos de Moderador</b><br />
Aqui você pode visualizar e gerenciar as listas sobre qualquer membro grupos para os quais você está mais moderador. Clique sobre o Estado contam para mostrar uma lista dos membros actuais, onde você também pode adicionar e excluir membros.';
]]></add>
</operation>
</file>

<file name="$languagedir/Help.brazilian.php" error="skip">
<operation>
<search position="end"></search>
<add><![CDATA[
// Group Moderators
$helptxt['groups'] = '<b>Groupos de Moderador</b><br />
Aqui você pode visualizar e gerenciar as listas sobre qualquer membro grupos para os quais você está mais moderador. Clique sobre o Estado contam para mostrar uma lista dos membros actuais, onde você também pode adicionar e excluir membros.';
]]></add>
</operation>
</file>
Title: Re: Group Moderators 1.4
Post by: xistense on May 29, 2008, 07:27:54 AM
Hello,

I'm trying to install this mod and it seems not to work. On my forum I have set as default "orange-lt115v1" theme and now when I try to install "Group moderators" fails the test for Themes/default/index.template.php and I tried a manual install, but it doesn't seem to work.

Is there from the theme or perhaps because of some mods I've added? How can I install this in the current situation
Title: Re: Group Moderators 1.4
Post by: Dannii on May 29, 2008, 08:09:10 AM
It's only trying to add a menu item, and as you're using a custom theme that doesn't even matter. Ignore the error and install it.
Title: Re: Group Moderators 1.4
Post by: Acans on May 30, 2008, 11:19:55 PM
Ok, Now in this Post he shows My problem

Quote from: digit on April 01, 2008, 01:55:24 AM
Well, this is probably a mac thing...  I simply changed the carraige return settings from Windoze to UNIX, and I was able to search and replace.

I have another problem though.

When I go into manage Membergroups, I do not see any  "Group Moderator(s)" boxes.... and when I go to action=groups, (as non admin) I don't see any way to add anything...  just an empty table. 

See attachments.  Attachment 1 is what the non global moderator sees by accessing action=groups, (but he is a moderator of one forum) , attachment 2 is what I, the admin sees in the edit membergroup area.

Any idea?  I have double checked everything!

And in the one you tell him out to fix, now i have found that managemembergroups template file, so how do i manually add the input box?? as you stated in this one below.

Quote from: Dannii on April 01, 2008, 11:52:10 AM
Does the theme come with it's own ManageMembergroups template perhaps? In any case, it shouldn't be too hard to manually add the input box yourself.
Title: Re: Group Moderators 1.4
Post by: Dannii on May 30, 2008, 11:40:56 PM
You'll find the changes to make here: http://custom.simplemachines.org/mods/index.php?action=parse;mod=171;attach=22016;smf_version=1.1.5
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 01, 2008, 07:28:57 PM
I have two small problems. first, the text for 'Groups' did not show up. Secondly, when I manually made it the text 'Groups' and clicked on it, it shows index.php?action=groups, but leads me back to the index page.
Title: Re: Group Moderators 1.4
Post by: Dannii on June 01, 2008, 11:16:53 PM
Are you sure it installed properly? Anything in the error log? It sounds like the files didn't actually get modified.
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 01, 2008, 11:36:59 PM
All worked except index.template.php, which I modified myself.
Title: Re: Group Moderators 1.4
Post by: Dannii on June 01, 2008, 11:51:54 PM
Well if it's taking you back to the boardindex, then index.php musn't have been modified either.
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 02, 2008, 08:31:54 AM
the index.php was placed to sources...from the package parser thing, it doesn't seem like themes/<mytheme>/index.php needed  editing.
Title: Re: Group Moderators 1.4
Post by: Dannii on June 02, 2008, 08:54:08 AM
None of the themss index.php need to be edited correct, but the index.php in the root folder does. Can you check that the groups action was in fact added to it?
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 02, 2008, 03:37:34 PM
I manually edited all the files, and now I have this error when I try to add group moderators:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' stars = ''
WHERE ID_GROUP = 9LIMIT 1' at line 3
File: /home/maplehun/public_html/forum/Sources/ManageMembergroups.php
Line: 440

Note: It appears that your database may require an upgrade. Your forum's files are currently at version SMF 1.1.5, while your database is at version 1.1.4. The above error might possibly go away if you execute the latest version of upgrade.php.
Title: Re: Group Moderators 1.4
Post by: Dannii on June 02, 2008, 09:53:59 PM
Are you sure you edited it correctly? It looks like the linebreaks are missing.
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 02, 2008, 11:46:58 PM
if you want, I can upload the entire .PHP file and send that to you.
Title: Re: Group Moderators 1.4
Post by: Dannii on June 03, 2008, 04:26:17 AM
I'd kind of rather not... I haven't been wanting to support this mod for over a year now.
Just check the file yourself to make sure the line breaks are there. If you really can't get it working post it here.
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 03, 2008, 09:05:43 AM
I'm no expert at PHP, so I guess it's better if I have you look at it...

http://files.filefront.com/ManageMembergroupsrar/;10475783;/fileinfo.html
Title: Re: Group Moderators 1.4
Post by: Dannii on June 03, 2008, 10:11:02 AM
You have a line like this:
WHERE ID_GROUP = " . (int) $_REQUEST['group'] . "LIMIT 1", __FILE__, __LINE__);
Add a line break before LIMIT.
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 03, 2008, 02:27:02 PM
ok. I changed it to:

         WHERE ID_GROUP = " . (int) $_REQUEST['group'] .
"LIMIT 1", __FILE__, __LINE__);

It still displays this error:


You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' stars = ''
WHERE ID_GROUP = 9LIMIT 1' at line 3
File: /home/maplehun/public_html/forum/Sources/ManageMembergroups.php
Line: 441

Note: It appears that your database may require an upgrade. Your forum's files are currently at version SMF 1.1.5, while your database is at version 1.1.4. The above error might possibly go away if you execute the latest version of upgrade.php.


Also, could you please tell me what to change it to? I'm no expert in any programming language at all, and my HTML is too rusty.
Title: Re: Group Moderators 1.4
Post by: Dannii on June 03, 2008, 09:16:19 PM
No, before the LIMIT not before the quote... like this:
WHERE ID_GROUP = " . (int) $_REQUEST['group'] . "
LIMIT 1", __FILE__, __LINE__);
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 03, 2008, 10:34:24 PM
I'm still getting this error:
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' stars = ''
WHERE ID_GROUP = 9
LIMIT 1' at line 3
File: /home/maplehun/public_html/forum/Sources/ManageMembergroups.php
Line: 441

Note: It appears that your database may require an upgrade. Your forum's files are currently at version SMF 1.1.5, while your database is at version 1.1.4. The above error might possibly go away if you execute the latest version of upgrade.php.

I think it wants me to put something at stars=
Title: Re: Group Moderators 1.4
Post by: Dannii on June 03, 2008, 10:47:09 PM
Is there still a field for stars in the template?
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 03, 2008, 11:43:19 PM
I don't know what you're talking about... :'(

Do you have MSN or something, so we can talk about this faster?
Title: Re: Group Moderators 1.4
Post by: Dannii on June 04, 2008, 01:25:53 AM
When you go to edit a membergroup is there still a field for the group's stars?

Also, do you have any other mods installed?

As I said before, I haven't been supporting this mod for over a year and I haven't looked at the code in that time either. If you can't get it working I suggest you start over with a fresh set of source files from the upgrade package.
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 04, 2008, 01:34:42 AM
yes, there is still a field for the location of the group's star(s), but even if i fill it in or not, the same error occurs.
Title: Re: Group Moderators 1.4
Post by: Dannii on June 04, 2008, 01:42:05 AM
Okay, I suggest you start over with a fresh set of source files from the upgrade package.
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 04, 2008, 02:49:52 AM
if I do that, will I have to redo all the changes that needs to be done for my other mods as well?
Title: Re: Group Moderators 1.4
Post by: Dannii on June 04, 2008, 02:55:50 AM
Well yes, though perhaps you could just replace ManageMembers.php. Have any of your other mods edited it?
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 04, 2008, 09:01:47 AM
I believe around 3- mods have.
Title: Re: Group Moderators 1.4
Post by: Dannii on June 04, 2008, 09:18:16 AM
What are the other mods? They might just be incompatible.
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 04, 2008, 02:18:58 PM
Ok. I edited it, and it all works fine now. Thanks. However, I have another question. Is it possible to assign a membergroup to be a group moderator?
Title: Re: Group Moderators 1.4
Post by: Dannii on June 04, 2008, 10:26:11 PM
Good to hear!
No you can't.
Title: Re: Group Moderators 1.4
Post by: louislam123 on June 05, 2008, 01:40:41 AM
Thanks for all your help!
Title: Re: Group Moderators 1.4
Post by: Lynx123 on June 15, 2008, 12:39:07 AM
Hey guys when i try to add a new group i get this this error.

Field 'GroupModOptions' doesn't have a default value
File: C:\vg\Sources\ManageMembergroups.php
Line: 255

I am using SMF 1.1.5

Help is appreciated
Title: Re: Group Moderators 1.4
Post by: Dannii on June 15, 2008, 01:07:19 AM
Hmm, you'll have to add a default value to the table. You can do that with phpMyAdmin.
Title: Re: Group Moderators 1.4
Post by: Lynx123 on June 15, 2008, 02:27:12 AM
Quote from: Dannii on June 15, 2008, 01:07:19 AM
Hmm, you'll have to add a default value to the table. You can do that with phpMyAdmin.
\

Thank you very much it works now
Title: Re: Group Moderators 1.4
Post by: Acans on July 13, 2008, 07:05:56 AM
will it be made for 1.0.5
Title: Re: Group Moderators 1.4
Post by: Dannii on July 18, 2008, 03:52:52 AM
Already is. Just install it.
Title: Re: Group Moderators 1.4
Post by: Acans on July 19, 2008, 07:27:22 AM
Quote from: Dannii on July 18, 2008, 03:52:52 AM
Already is. Just install it.
sorry i ment 1.1.5
Title: Re: Group Moderators 1.4
Post by: Dannii on July 20, 2008, 08:09:26 AM
Yes, just install it.
Title: Re: Group Moderators 1.4
Post by: Irythros on July 27, 2008, 12:50:12 PM
Ok, im getting 2 errors.

Quotehttp://xxx.com/forums/index.php?action=membergroups;sa=edit;group=9
Apply Filter: Only show the errors with the same message
2: implode() [<a href='function.implode'>function.implode</a>]: Bad arguments.
File: /home/barelyvi/public_html/forums/Themes/default/ManageMembergroups.template.php (edit_group sub template - eval?)
Line: 244

and

Quotehttp://xxx.com/forums/index.php?action=membergroups;sa=edit;group=9
Apply Filter: Only show the errors with the same message
8: Undefined index: moderators
File: /home/barelyvi/public_html/forums/Themes/default/ManageMembergroups.template.php (edit_group sub template - eval?)
Line: 244

From what it looks like, if the 'Moderators' text box in the Manage Membergroup section is supposed to retain the username of the moderator, it does not.  It is however entered into the database.
On the user that was set to moderator, that account does not have the 'Groups' tab.  When using the URL to get to it, it says its not allowed to view it.

Im using the af316-smf(final) theme and the following mods:
ViewAnyTopicPermission
MCLegendII
LimitAGuestsDailyPageViewsMod_v1.0


Installed the mod manually after seeing nothing was done by the auto-installer.  Could it be a missing column in the database?


Edit: I fixed the problem of the set user not being able to access the 'Groups' section.  I didnt know I also had to set group permission for them to see it.  So thats fixed, but I'm still having problems with the errors and the box not retaining group moderator name.
Title: Re: Group Moderators 1.4
Post by: Dannii on July 27, 2008, 07:30:16 PM
Hmmm, all I can suggest is reinstalling it.
Title: Re: Group Moderators 1.4
Post by: Ulborn on July 28, 2008, 01:33:23 PM
I tried to install this package and got the following error.

4.  Execute Modification  ./Themes/default/index.template.php  Test failed

Does anyone know what I have to "apply" to the index.template.php file to get this to work?
Do I have to uninstall all my themes? 
Do I have to apply the change to EVERY theme?

Title: Re: Group Moderators 1.4
Post by: Dannii on July 28, 2008, 02:03:25 PM
The only change it makes to the index template is adding a menu button. If you go to it by URL directly (index.php?action=groups) don't even bother editing the file manually. If you want to add the menu button it won't be hard.
Title: Re: Group Moderators 1.4
Post by: Ulborn on July 28, 2008, 03:00:55 PM
Okay, got it installed and called it up, but I do not see a way to manage the groups, even tried logging in as the Administrator.

I do see Groups moderation
Here you may view and manage the member lists on any groups for which you are moderator over.
Member groups
Name Member count


but I do not see a way to add/manage groups. :(
Title: Re: Group Moderators 1.4
Post by: Ulborn on July 28, 2008, 03:22:15 PM
Added the items to the index.template.php.  Get a menu when at ?action=groups, but it has no text.  (menu.jpg) When in another menu tab there is a space for the tab, but again no text. (menu2.jpg)
Title: Re: Group Moderators 1.4
Post by: ccbtimewiz on July 28, 2008, 06:31:35 PM
Quote from: woe on July 28, 2008, 03:22:15 PM
Added the items to the index.template.php.  Get a menu when at ?action=groups, but it has no text.  (menu.jpg) When in another menu tab there is a space for the tab, but again no text. (menu2.jpg)

Looks like a language string error. Make sure that the $txt[] strings installed correctly.
Title: Re: Group Moderators 1.4
Post by: Dannii on July 28, 2008, 07:39:51 PM
Quote
but I do not see a way to add/manage groups. :(
You have to add yourself as a moderator first in the edit membergroups admin page.
Title: Re: Group Moderators 1.4
Post by: Ulborn on July 29, 2008, 10:21:52 AM
I got the text to work, but the package did not install correctly.  I am assuming that this is because I had SMF Gallery Lite 1.8.2 installed.  It appears that SMF Gallery Lite changed many of the files that this package uses and because the file was changed from the default, the package did not modify the files correctly.

I have tried to edit the files manually, but have apparently missed something as I can not get the package to work. :(
Title: Re: Group Moderators 1.4
Post by: Dannii on July 29, 2008, 10:28:23 AM
What about it isn't working correctly?
Title: Re: Group Moderators 1.4
Post by: Ulborn on July 29, 2008, 10:30:22 AM
Quote from: Dannii on July 28, 2008, 07:39:51 PM
Quote
but I do not see a way to add/manage groups. :(
You have to add yourself as a moderator first in the edit membergroups admin page.
My account is the Global Moderator , and I still can not see the groups on the Groups page, nor can I see an Add section.

I'm sorry to be such a pain about this.  I can usually muddle my way through this type of stuff.

I tried to manually apply the modifications to the ManageMembergroups.template.php, but I obviously messed something up as I had to restore the backup I had made before I edited the file.

When I add the code:// Group Moderators
if ($context['group']['allow_delete'] && !$context['group']['is_post_group'])
echo '
<tr class="windowbg2" style="padding-top: 1em;">
<th align="right"><label for="groupmods_input">', $txt['elgm1'], ':</label></th>
<td><input type="text" name="groupmods" id="groupmods_input" value="', implode(',', $context['group']['moderators']), '" size="30" />
<a href="', $scripturl, '?action=findmember;input=groupmods_input;quote;sesc=', $context['session_id'], '" onclick="return reqWin(this.href, 350, 400);"><img src="', $settings['images_url'], '/icons/assist.gif" border="0" alt="', $txt['find_members'], '" /></a></td>
</tr>
<tr class="windowbg2">
<th align="right"><label for="groupmods_primary">', $txt['elgm2'], ':</label>
<div class="smalltext" style="font-weight: normal">', $txt['elgm3'], '</div></th>
<td><input type="checkbox" name="elgm_primary" id="groupmods_primary" value="1"', $context['group']['allow_primary'] ? ' checked="checked"' : '', ' class="check" /></td>
</tr>';

before the line:<input type="text" name="max_messages" id="max_messages_input" value="', $context['group']['id'] == 1 ? 0 : $context['group']['max_messages'], '" size="6" ', $context['group']['id'] == 1 ? 'disabled="disabled"' : '', '/>

I get a parse error when I go to the page "action=membergroups".
Title: Re: Group Moderators 1.4
Post by: Dannii on July 29, 2008, 11:15:51 AM
Add it after that line (actually after the </tr>';)

Are you following these instructions?
http://custom.simplemachines.org/mods/index.php?action=parse;mod=171;attach=22016;smf_version=1.1.5
Title: Re: Group Moderators 1.4
Post by: Ulborn on July 29, 2008, 01:36:31 PM
My bad.

Followed the instructions, did the SQL queries.  Gave Administrator, Global Moderator, Moderator and Founder permissions with VALUES
('view_groups', ", $groups) . ", 1)
Obviously replacing the php code with the GROUP_ID :)

Still do not have any options in the Groups page. (See groups.jpg)

I included a picture of my Manage Membergroups as well. (membergroups.jpg)
Title: Re: Group Moderators 1.4
Post by: Dannii on July 29, 2008, 09:12:21 PM
You'll need to add yourself as a moderator first in the edit groups page.
Title: Re: Group Moderators 1.4
Post by: Ulborn on July 29, 2008, 10:21:14 PM
I'm confused.  I'm in the Global Moderator Group.  The Moderator Group does not allow anyone to be added to it.
Moderator (?)  *****  n/a  Modify
Title: Re: Group Moderators 1.4
Post by: Dannii on July 29, 2008, 10:33:20 PM
No, go to the group you want to moderate and add your name to the box for group moderators.

Do you understand what the mod is for? It's really not useful for an admin, only other members.
Title: Re: Group Moderators 1.4
Post by: Ulborn on July 30, 2008, 12:19:20 AM
My goal is to set up a hierarchical system where Founders can manager any group, Officers can manage any group but Founders, Esquires can manage etc....

My problem is that you have told me twice to go to a page that does NOT exist on my system for some reason. 

On the Groups Tab I still have NO options what so ever!

In the Admin - Membergroups there is no place for me to do what you ask!

I know that you are sick of answering my questions, and I am sorry that this module did not install itself and that I had to do it manually, but I have provided you with the screens that I have and you are still telling me to do something else, but I have not a clue what it is that you are asking me to do, since on the pages that you indicate that I am to
QuoteNo, go to the group you want to moderate and add your name to the box for group moderators.
I do not have a checkbox on the Groups tab or on the  Admin - Membergroups page!

Title: Re: Group Moderators 1.4
Post by: Dannii on July 30, 2008, 02:16:57 AM
When you go to Admin -> Membergroups and edit a group that isn't the moderator group or a post group you'll see a box for the group moderators. That is unless the ManageMembergoups template wasn't edited correctly.
Title: Re: Group Moderators 1.4
Post by: Ulborn on July 30, 2008, 09:11:47 AM
Thank you. :) Sorry that I needed more direction as to where this was.

Thanks again for you patience and help.
Title: Re: Group Moderators 1.4
Post by: Dannii on July 30, 2008, 09:23:31 AM
Okay, pleased to hear you've sorted it out.
Title: Re: Group Moderators 1.4
Post by: Amun on September 02, 2008, 08:28:17 PM
Just wanted to say love this mod! Very useful. Also I was wondering if there was a way to take this mod a step further and allow members to beable to create the membergroups aswell, apposed to the admins making the membergroup and setting someone as the moderator. I think forum users could have alot of fun with this.

Sorry if this was already suggested or requested but please understand myself being reluctant to read through 29 pages of posts :)
Title: Re: Group Moderators 1.4
Post by: Mozrin on September 02, 2008, 10:11:28 PM
I also think this MOD is very useful, and would like to suggest a change ...

It would be very useful to be able to create a hierarchy of groups for moderation delegation. For example, if I create Team Lead groups, Supervisor groups, Manager groups and Owner groups with the express purpose of delegating the moderation of members, I could arrange it like:

Team Lead = John
Supervisor = Joan
Manager = Tom
Owner = Sue

Team GM = Team Lead, Supervisor, Manager, Owner
Supervisor GM = Supervisor, Manager, Owner
Manager GM = Manager, Owner

This way, as my organization changes, I have a minimal number of changes to make to keep the groups in line.

Just a thought :-)

Regardless ... it is a nice mod.

cheers,
Moz
Title: Re: Group Moderators 1.4
Post by: Dannii on September 03, 2008, 06:21:37 AM
I won't be developing this mod any further sorry.
Title: Re: Group Moderators 1.4
Post by: Amun on September 12, 2008, 02:53:36 PM
Oh well it is still kick ass as is... <3 this mod
Title: Re: Group Moderators 1.4
Post by: Evil Penguin on September 15, 2008, 07:03:38 PM
Okay..  can anyone link me the color code section so I can mod it to work with my board's colors?
Title: Re: Group Moderators 1.4
Post by: ke4obt on September 20, 2008, 12:34:23 PM
Quote from: Dannii on July 29, 2008, 11:15:51 AM
Add it after that line (actually after the </tr>';)

Are you following these instructions?
http://custom.simplemachines.org/mods/index.php?action=parse;mod=171;attach=22016;smf_version=1.1.5

Dannii,
I had followed the instructions. When I go to the Membergroups section in my Admin CP, I get this error:

Parse error: syntax error, unexpected '<' in .../Themes/default/ManageMembergroups.template.php on line 252

If I post my ManageMembergroups.template.php, is there any way you can look at it and see where I went wrong?

Thanks in advance,
Flip

Title: Re: Group Moderators 1.4
Post by: Dannii on September 20, 2008, 10:29:41 PM
Please post up lines 245-260.
Title: Re: Group Moderators 1.4
Post by: ke4obt on September 20, 2008, 10:34:54 PM
Thank you. It's kind of hard trying to code when you can't see it and depend on a screen reader. Don't quite get all of the subtleties, if you know what I mean.  :D
ok, here they are:

<a href="', $scripturl, '?action=findmember;input=groupmods_input;quote;sesc=', $context['session_id'], '" onclick="return reqWin(this.href, 350, 400);"><img src="', $settings['images_url'], '/icons/assist.gif" border="0" alt="', $txt['find_members'], '" /></a></td>
</tr>
<tr class="windowbg2">
<th align="right"><label for="groupmods_primary">', $txt['elgm2'], ':</label>
<div class="smalltext" style="font-weight: normal">', $txt['elgm3'], '</div></th>
<td><input type="checkbox" name="elgm_primary" id="groupmods_primary" value="1"', $context['group']['allow_primary'] ? ' checked="checked"' : '', ' class="check" /></td>
</tr>';
<tr class="windowbg2">
<th align="right" style="padding-top: 1em;">
<label for="monitorGroup">', $txt['membergroups_monitorGroup'], ':</label>
</th>
<td>
<input type="checkbox" name="monitorGroup" ', $context['group']['monitorGroup'] ? 'checked="checked"' : '', '/>
</td>
</tr>';
if (!empty($context['boards']))


again, thanks,
Flip
Title: Re: Group Moderators 1.4
Post by: Dannii on September 20, 2008, 11:26:57 PM
Hmm, ok can you email me the whole file please.
Title: Re: Group Moderators 1.4
Post by: ke4obt on September 20, 2008, 11:30:31 PM
Quote from: Dannii on September 20, 2008, 11:26:57 PM
Hmm, ok can you email me the whole file please.
Hmm, couldn't figure out how to attach a file to the e-mail, so, here it is.
Thanks,
Flip
Title: Re: Group Moderators 1.4
Post by: Dannii on September 20, 2008, 11:54:01 PM
It looks like you've actually installed the Moderator Activity Report mod incorrectly.
Title: Re: Group Moderators 1.4
Post by: ke4obt on September 21, 2008, 12:20:08 AM
I must be getting old or blonde. :)
I can't figure out where I messed up on this file.
Can you please point me in the right direction, which lines, etc.? I can't find anything to do with the Moderator Activity Report in the file.

Thanks,
Mickey - Flip's wife
Title: Re: Group Moderators 1.4
Post by: Dannii on September 21, 2008, 12:28:51 AM
               <tr class="windowbg2">
               <th align="right" style="padding-top: 1em;">
                  <label for="monitorGroup">', $txt['membergroups_monitorGroup'], ':</label>

It's the very next few lines, starting with these three. From what I can tell this mod has been installed correctly, but the mod activity report code has been inserted in the wrong place.
Title: Re: Group Moderators 1.4
Post by: ke4obt on September 21, 2008, 12:32:19 AM
well, I thought I had found where to fix it, but I'm still getting the "Parse error: syntax error, unexpected '<' in .../Themes/default/ManageMembergroups.template.php on line 239"
I'm attaching the most recently messed up/fixed MangeMembergroups.template.php file.
Sorry to be such a bother.
Mickey

ps - I started where you just posted was the error and thought I had it all arranged correctly. Obviously, I was wrong.

Title: Re: Group Moderators 1.4
Post by: ke4obt on September 21, 2008, 12:49:44 AM
I posted in the Moderator Activity Report forum section.
I had thought the problem was with Group Moderators, but after I moved the offending code to where it was SUPPOSED to be, the parse error moved with it.
So, obviously (at least to me), the error is in the other mod, not this one. *shamefaced*
Thanks for the help, Dannii. Hope I wasn't too big of a pain. :)

Flip
Title: Re: Group Moderators 1.4
Post by: Dannii on September 21, 2008, 01:02:20 AM
Good to hear you've fixed it now. :)
Title: Re: Group Moderators 1.4
Post by: ke4obt on September 24, 2008, 02:19:27 PM
 :-[
Hey Dannii,
Thanks for all your help, but now I can't seem to figure out how to set a user as a group mod.
so i have one thing left to say "PLEASE HELP!".
i'm at a totle lose and the wife is gone till Friday night and well i guess i'm a little impationt, bad habbit of mine i know.
     Thanks again,
     Flip - KE4OBT
     The Blind Ham
Title: Re: Group Moderators 1.4
Post by: Dannii on September 24, 2008, 07:10:25 PM
You add their name to the box when you edit the group.
Title: Re: Group Moderators 1.4
Post by: ke4obt on September 24, 2008, 07:36:52 PM
Hey Dannii,

Thanks for the quick reply,
got the message in e-mail and allready found where to do the edit.
THANKS BILLIONS, I feel like a ditz .
i've used this mod before, must have got lost in the dust and spider-webs in my pea-brain, just couldn't remember where to do the edit.  :D

     Thanks Again,
     Flip - KE4OBT
     The Blind Ham
Title: Re: Group Moderators 1.4
Post by: The Cadet on October 08, 2008, 11:07:52 AM
Is it possible to add more than one person as group moderator?
Title: Re: Group Moderators 1.4
Post by: Dannii on October 08, 2008, 11:10:32 AM
Yes, just separate their names by commas.
Title: Re: Group Moderators 1.4
Post by: The Cadet on October 08, 2008, 01:20:39 PM
'k, thanks. ^_°_^
Title: Re: Group Moderators 1.4
Post by: Adalla on October 12, 2008, 03:04:31 AM
This mod solved a fundamental SMF flaw in that only admins could manage groups.

Thanx SO much for this mod.

Title: Re: Group Moderators 1.4
Post by: Acans on November 25, 2008, 12:29:23 AM
how do i unistall using the groupmoderators_unistall.php file?
Title: Re: Group Moderators 1.4
Post by: RustyBarnacle on November 25, 2008, 12:33:35 AM
Go to the package manager and use the uninstall link.
Title: Re: Group Moderators 1.4
Post by: Acans on November 25, 2008, 12:46:34 AM
Quote from: RustyBarnacle on November 25, 2008, 12:33:35 AM
Go to the package manager and use the uninstall link.

Information not helpfull. Causes errors, im asking dannii becuase on the download page hes including a uninstall.php file but i dont know how to use it
Title: Re: Group Moderators 1.4
Post by: Kinesthesia on January 09, 2009, 09:30:43 AM
Any chance of this mod being updated for 1.1.7 ?
Title: Re: Group Moderators 1.4
Post by: Dannii on January 09, 2009, 08:41:12 PM
The uninstall file is outdated, and was only for use after the package manager anyways.

And it should support 1.1.7 already!
Title: Re: Group Moderators 1.4
Post by: Kinesthesia on January 10, 2009, 11:03:57 AM
I was a little concerned when I hit "Apply Mod" and saw:

!!
Error in Package Installation
At least one error was encountered during a test installation of this package. It is strongly recommended that you do not continue with installation unless you know what you are doing, and have made a backup very recently. This error may be caused by a conflict between the package you're trying to install and another package you have already installed, an error in the package, a package which requires another package that you don't have installed yet, or a package designed for another version of SMF.
Installation Readme
Install Group Moderators version 1.4

Written by Eldacar Labs - [email protected]
Copyright 2006 - Please see licence.txt for details.

SMF Mods page: http://mods.simplemachines.org/index.php?mod=171
Project home: http://code.google.com/p/smfgroups/
Support: http://www.simplemachines.org/community/index.php?topic=43396

This mod will allow you to add Group Moderators: members of your forum who have control of the specific groups you set them over. They can add and remove members from only these specific groups. Essential for large forums with multiple private boards and groups.

Install Actions
Installations actions for "Group Moderators":
Installing this package will perform the following actions:
   Type    Action    Description
1.    Execute Modification    ./index.php    Test successful
2.    Execute Modification    ./Sources/ManageMembergroups.php    Test successful
3.    Execute Modification    ./Sources/ManagePermissions.php    Test successful
4.    Execute Modification    ./Themes/default/index.template.php    Test failed
5.    Execute Modification    ./Themes/default/../babylon/index.template.php    Test successful
6.    Execute Modification    ./Themes/default/ManageMembergroups.template.php    Test successful
7.    Execute Modification    ./Themes/default/languages/Modifications.english.php    Test successful
8.    Execute Modification    ./Themes/default/languages/Modifications.swedish.php    Skipping file
9.    Execute Modification    ./Themes/default/languages/Help.english.php    Test successful
10.    Execute Modification    ./Themes/default/languages/Help.swedish.php    Skipping file
11.    Extract File    ./Sources/Groups.php    
12.    Extract File    ./Themes/default/Groups.template.php    
13.    Extract File    ./Themes/default/languages/Groups.english.php    
14.    Extract File    ./Themes/default/languages/Groups.swedish.php    
15.    Extract Tree    ./Themes/default/../babylon/images    
16.    Execute Code    GroupMods_install.php
Title: Re: Group Moderators 1.4
Post by: Dannii on January 10, 2009, 10:08:07 PM
That just means the menu button won't get added. You can go ahead and add the button manually, or just access it by URL (action=groups).
Title: Re: Group Moderators 1.4
Post by: heavyccasey on January 11, 2009, 01:45:03 AM
Adding members requires their log-in name, not their display name. So people won't be able to add members who've changed their names unless they know their original.

It's probably at Groups.php, find:

$request = db_query("
SELECT ID_MEMBER, ID_GROUP, additionalGroups
FROM {$db_prefix}members
WHERE memberName IN ('" . implode("', '", $memberQuery) . "')", __FILE__, __LINE__);

and change "memberName" to "realName" or something like that.

EDIT: It worked.

I think the groups interface should only be visible if you actually have a group to moderate.
Title: Re: Group Moderators 1.4
Post by: Dannii on January 11, 2009, 04:38:29 AM
Well the visibility is based on a permission. I had orginally planned on having extra features for non moderators, like requesting group membership etc.
Title: Re: Group Moderators 1.4
Post by: heavyccasey on January 11, 2009, 05:16:02 AM
Oh, is that on your to-do list? Because that would be a great feature to have. Take your time :)
Title: Re: Group Moderators 1.4
Post by: Dannii on January 11, 2009, 06:16:24 AM
I haven't been working on this mod in years sorry. You're free to do so though!
Title: Re: Group Moderators 1.4
Post by: Kinesthesia on January 11, 2009, 09:36:59 AM
Quote from: Dannii on January 10, 2009, 10:08:07 PM
That just means the menu button won't get added. You can go ahead and add the button manually, or just access it by URL (action=groups).

Forgive me, but I do not know how to do either of these things.  Can anyone explain exactly how to add the button manually ?  Or alternately exactly what the url would be ?

I tried forum/Sources/Groups.php and got an Internal Server Error.
Title: Re: Group Moderators 1.4
Post by: redone on January 11, 2009, 11:18:17 AM
As for the question on the button as Danni mentioned you can do two things with this:

1. type the url manually and it would look like this:(your url)/index.php?action=groups
2. look at your current index.template.php file

Find
if (in_array($context['current_action'], array('search', 'admin', 'calendar', 'profile', 'mlist', 'register', 'login', 'help', 'pm')))


Replace with
if (in_array($context['current_action'], array('search', 'admin', 'calendar', 'profile', 'mlist', 'register', 'login', 'help', 'pm', 'groups')))


Find the following
// Edit Profile... [profile]
if ($context['allow_edit_profile'])
echo ($current_action == 'profile' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'profile' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=profile">' , $txt[79] , '</a>
</td>' , $current_action == 'profile' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';


Add this before
// View Groups Interface... [groups]
if (allowedTo('view_groups'))
echo ($current_action == 'groups' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'groups' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=groups">' , $txt['elgm4'] , '</a>
</td>' , $current_action == 'groups' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';
Title: Re: Group Moderators 1.4
Post by: redone on January 11, 2009, 11:21:28 AM
Quote from: Kinesthesia on January 09, 2009, 09:30:43 AM
Any chance of this mod being updated for 1.1.7 ?
This modification installs just fine for 1.1.7 actually. The only issues you may have are if you have other mods installed which is the same for any mod.

;)
Title: Re: Group Moderators 1.4
Post by: heavyccasey on January 11, 2009, 07:00:18 PM
Quote from: Dannii on January 11, 2009, 06:16:24 AM
I haven't been working on this mod in years sorry. You're free to do so though!
Here's a quick hack to hide the button if they don't actually moderate any groups:

Load.php
Find:
function loadPermissions()
{
global $user_info, $db_prefix, $board, $board_info, $modSettings;

Replace:
function loadPermissions()
{
global $user_info, $db_prefix, $board, $board_info, $modSettings, $ID_MEMBER;

Find:
if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2)
cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240);

Add before:
// Do they have a group mod permissions?
if ($key = array_search('view_groups', $user_info['permissions'])) {
$request = db_query("
SELECT count(ID_MEMBER)
FROM `{$db_prefix}groupmods`
WHERE ID_MEMBER = $ID_MEMBER");
$count = mysql_fetch_row($request);

if ($count[0] < 1) {
unset($user_info['permissions'][$key]);
}

mysql_free_result($request);
}
Title: Re: Group Moderators 1.4
Post by: Dannii on January 11, 2009, 08:19:10 PM
Cool, good work everyone!
Title: Re: Group Moderators 1.4
Post by: Kinesthesia on January 12, 2009, 11:24:57 AM
I haven't tried editing any code yet, but I did some testing with the url and I just want to say thank you for developing this mod and for all the assistance getting it working (getting me to understand).  It has taken a huge load off of my shoulders.
Title: Re: Group Moderators 1.4
Post by: forepro on February 26, 2009, 02:43:44 PM
Hi

I saw in the changelog the latest version is 1.5 but in mod site it looks like v.1.4. Did I miss anything?

Thanks for the mod!  :)
Title: Re: Group Moderators 1.4
Post by: Dannii on February 26, 2009, 04:56:11 PM
I had only started 1.5 and never finished or released it.
Title: Re: Group Moderators 1.4
Post by: kenrank on April 19, 2009, 11:13:01 AM
This Mod is exactly what we need!

But...!   (there's always a "but"   lol)

When I tried to install from the Package Mgr, it gives me:
The package you are trying to download or install is either corrupt or not compatible with this version of SMF.

When I downloaded the package and try to install from Package Mgr's upload, I get:
The package you tried to upload either is not a valid package or has become corrupted.

We're running SMF 1.1.8
Can you think of any reason I'm getting these errors?

Thanks in advance!
Title: Re: Group Moderators 1.4
Post by: Dannii on April 20, 2009, 02:41:11 AM
There could be lots of reasons. Check you error logs.
Title: Re: Group Moderators 1.4
Post by: kenrank on April 20, 2009, 03:33:11 AM
OK.  I checked both the error log from cPanel as well as the Forum Error Log and there are no errors at all related to this!

The only errors in there are from a few days ago and, if it helps, the error is:

Ken Rank       April 14, 2009, 04:53:42 PM
74.234.158.42���      
http://discoverhebrewroots.com/index.php?action=smileys;sa=editsmileys
Database Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'LENGTH(code) DESC' at line 2
File: /home/dhr/public_html/Sources/ManageSmileys.php
Line: 654
   
Ken Rank    April 14, 2009, 04:51:45 PM
74.234.158.42���      
http://discoverhebrewroots.com/index.php?action=smileys;sa=addsmiley
No code for this smiley was given.
Title: Re: Group Moderators 1.4
Post by: Dannii on April 20, 2009, 05:10:59 AM
There's probably a problem with permissions. Try asking for help in the smf help boards, as I don't have the time to support this mod anymore sorry.
Title: Re: Group Moderators 1.4
Post by: den2 on April 30, 2009, 10:10:34 AM
Quote from: Lynx123 on June 15, 2008, 12:39:07 AM
Hey guys when i try to add a new group i get this this error.

Field 'GroupModOptions' doesn't have a default value
File: C:\vg\Sources\ManageMembergroups.php
Line: 255

I am using SMF 1.1.5

Help is appreciated

same problem.. I cant uninstall
Title: Re: Group Moderators 1.4
Post by: Dannii on April 30, 2009, 10:13:18 AM
Why can't you uninstall?
Title: Re: Group Moderators 1.4
Post by: den2 on April 30, 2009, 10:21:25 AM
Quote from: Dannii on April 30, 2009, 10:13:18 AM
Why can't you uninstall?
umm
I'm uninstalling and I deleted smf_groupmods table.


But gettings this error


Field 'GroupModOptions' doesn't have a default value
File: D:\Program\EasyPHP 3.09\www\xx\Sources\ManageMembergroups.php
Line: 255
Title: Re: Group Moderators 1.4
Post by: Dannii on April 30, 2009, 10:32:19 AM
If you've uninstalled that and you're getting an error then the changes musn't have all been reversed. You'll have to manually go through and reverse them.
Title: Re: Group Moderators 1.4
Post by: kenrank on May 11, 2009, 07:14:36 PM
We're running SMF 1.1.8 with english-utf8 and I just installed Group Moderators 1.4

After the install, I got a series of errors that I think are related to the fact that we are running with english-utf8.  Any idea of what's going on here?

Attached is a text file with the errors.

Thank you
Title: Re: Group Moderators 1.4
Post by: Dannii on May 12, 2009, 03:36:28 AM
Go and copy all the language entries from modifications.english.php to modifications.english-utf8.php.
Title: Re: Group Moderators 1.4
Post by: kenrank on May 12, 2009, 04:06:15 PM
Quote from: Dannii on May 12, 2009, 03:36:28 AM
Go and copy all the language entries from modifications.english.php to modifications.english-utf8.php.

OK.  Done.  I also did the mod's that were done to Help.english.php to Help.english-utf8.php

That seemed to fix a bunch of the problems...  I can now see
Group moderators:
and
Allow Primary Group:
When someone is added through the Groups interface allow it to be set to Primary?

Which I couldn't see before.  I can now also see (in Permissions):
Groups
   View the Groups interface


But!  There's always a but...  :(

When I click the member count button, I get a 404 screen:
Not Acceptable

An appropriate representation of the requested resource /index.php could not be found on this server.

Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.
Apache/2.2.11 (Unix) mod_ssl/2.2.11 OpenSSL/0.9.7a mod_auth_passthrough/2.1 mod_bwlimited/1.4 FrontPage/5.0.2.2635 Server at discoverhebrewroots.com Port 80


No forum errors are generated from this.  However, the website error log gives:
[Tue May 12 15:02:43 2009] [error] [client 76.26.10.201] File does not exist: /home/dhr/public_html/406.shtml, referer: http://discoverhebrewroots.com/index.php?action=groups

The link clicked was:
http://discoverhebrewroots.com/index.php?action=groups;sa=members;id=9


I'm not sure where to go from here...

Thanks
Title: Re: Group Moderators 1.4
Post by: Dannii on May 12, 2009, 10:50:06 PM
Ahh, try logging out and in again. Could be a permissions problem?
Title: Re: Group Moderators 1.4
Post by: kenrank on May 13, 2009, 12:13:02 AM
Quote from: Dannii on May 12, 2009, 10:50:06 PM
Ahh, try logging out and in again. Could be a permissions problem?

I logged in and out.  Same error.  I made sure I have permission to View Groups Interface and also am set as moderator of the membergroup.

Wait a sec...  do you mean permissions from admin control panel?  or file permissions?  I noticed some world writable files that were a security risk, so the write permissions were stripped.  Could this have something to do with it?

Thanks
Title: Re: Group Moderators 1.4
Post by: Dannii on May 13, 2009, 07:00:51 AM
It quite well could have. Maybe not all of the files were modified... would explain why the language entries were missing. Go through all the manual instructions and check the changes were made.
Title: Re: Group Moderators 1.4
Post by: kenrank on May 13, 2009, 10:49:44 AM
Quote from: kenrank on May 13, 2009, 12:13:02 AM
Quote from: Dannii on May 12, 2009, 10:50:06 PM
Ahh, try logging out and in again. Could be a permissions problem?

I logged in and out.  Same error.  I made sure I have permission to View Groups Interface and also am set as moderator of the membergroup.

Wait a sec...  do you mean permissions from admin control panel?  or file permissions?  I noticed some world writable files that were a security risk, so the write permissions were stripped.  Could this have something to do with it?

Thanks
Quote from: Dannii on May 13, 2009, 07:00:51 AM
It quite well could have. Maybe not all of the files were modified... would explain why the language entries were missing. Go through all the manual instructions and check the changes were made.

OK.  I went thru all the manual instructions and made sure they were all installed.  They were, but I did notice the 2 utf8 files I changed weren't listed.

So far I've found nothing that doesn't match what the manual install says needs to be done.  It seems like the install worked ok.

Same 404 error though  :(

Thanks
Title: Re: Group Moderators 1.4
Post by: Dannii on May 13, 2009, 09:10:52 PM
http://www.simplemachines.org/community/index.php?topic=34270.0
Does following the instructions in that post help?
Title: Re: Group Moderators 1.4
Post by: kenrank on May 14, 2009, 10:01:21 PM
Quote from: Dannii on May 13, 2009, 09:10:52 PM
http://www.simplemachines.org/community/index.php?topic=34270.0
Does following the instructions in that post help?

I did the .htaccess change, didn't seem to make a difference...  the forum keeps running.  When I click:
http://discoverhebrewroots.com/index.php?action=groups;sa=members;id=9
it gives me:

Not Acceptable

An appropriate representation of the requested resource /index.php could not be found on this server.

Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.
Apache/2.2.11 (Unix) mod_ssl/2.2.11 OpenSSL/0.9.7a mod_auth_passthrough/2.1 mod_bwlimited/1.4 FrontPage/5.0.2.2635 Server at discoverhebrewroots.com Port 80


The server error log gives:
[Thu May 14 20:45:14 2009] [error] [client **.**.**.***] File does not exist: /home/dhr/public_html/406.shtml, referer: http://discoverhebrewroots.com/index.php?action=groups

Forum Error Log had no errors either.

Thank you
Title: Re: Group Moderators 1.4
Post by: Dannii on May 15, 2009, 02:49:55 AM
It definitely seems to be a mod_security thing. If that topic doesn't help you'll have to ask your host.
Title: Re: Group Moderators 1.4
Post by: Nas187 on May 15, 2009, 09:43:31 AM
is there a version for 1.1.8
Title: Re: Group Moderators 1.4
Post by: Dannii on May 15, 2009, 09:50:07 AM
Yes, the one on the downloads page.
Title: Re: Group Moderators 1.4
Post by: Nas187 on May 15, 2009, 10:08:35 AM
I cant add the Groups  button to my theme, :S I'm just a beginner at this. Can some one help me out? template attached
Title: Re: Group Moderators 1.4
Post by: Dannii on May 15, 2009, 07:59:08 PM
I'm not really supporting this mod anymore and don't have a lot of time, sorry. Maybe you could ask on the Help Wanted board. People are usually pretty friendly and helpful there :)
Title: Re: Group Moderators 1.4
Post by: Filipina on May 31, 2009, 10:54:16 AM
Quote from: Dannii on May 15, 2009, 07:59:08 PM
I'm not really supporting this mod anymore and don't have a lot of time, sorry. Maybe you could ask on the Help Wanted board. People are usually pretty friendly and helpful there :)

42K downloads seems like a great MOD... anyone put the word out to see if someone might want to take it over for you? I am going to try it on 1.1.9 hope it works.. this is the closest thing I can find to groups like you see on other social networking sites where the group owner controls who is and is not a member... awesome.
Title: Re: Group Moderators 1.4
Post by: bemax on July 14, 2009, 04:19:17 AM
Hi,

is there a chance to get a member of the google code project ?

I like to add the utf8 support for german and english and also want to add some smaller features.
- see every group you belong to and see who is the moderator of these groups ..
- also like to change the default who sees the "Group"-Button. I like to exclude the "guest"-group and "ungrouped members"

also there is already a version 1.5 in the code which can not be downloaded .. only via svn

Title: Re: Group Moderators 1.4
Post by: Dannii on July 17, 2009, 05:29:50 AM
Yes sure, send me a PM with your gmail address. :)
Title: Re: Group Moderators 1.4
Post by: heavyccasey on July 30, 2009, 02:11:52 AM
Here's a suggestion. I used this mod before and I was a little annoyed that the usernames were searched instead of real names. It was fairly easy to change, and I think this feature should be added to the mod.
Title: Re: Group Moderators
Post by: Viporizer on August 04, 2009, 05:51:45 AM
Tested on SMF 1.1.10
Works fine.
Title: Re: Group Moderators 1.4
Post by: rosuvladut on August 31, 2009, 05:59:51 PM
On SMF 1.1.10
Error in Package Installation At least one error was encountered during a test installation of this package. It is strongly recommended that you do not continue with installation unless you know what you are doing, and have made a backup very recently. This error may be caused by a conflict between the package you're trying to install and another package you have already installed, an error in the package, a package which requires another package that you don't have installed yet, or a package designed for another version of SMF.
Title: Re: Group Moderators 1.4
Post by: Dannii on August 31, 2009, 06:45:22 PM
That's a problem with the package manager, not with this mod. I suggest asking for help in the general SMF support boards.
Title: Re: Group Moderators 1.4
Post by: Kevin Waggoner on September 01, 2009, 11:40:03 PM
With me I just don't know how to actually set someone as a group mod, could you explain to where I go and what I need to do to have a member as a group mod please?
Title: Re: Group Moderators 1.4
Post by: Dannii on September 02, 2009, 04:59:11 AM
When you modify a group there's a new box you can add the moderators' names too.
Title: Re: Group Moderators 1.4
Post by: Kevin Waggoner on September 02, 2009, 05:13:08 AM
Quote from: Dannii on September 02, 2009, 04:59:11 AM
When you modify a group there's a new box you can add the moderators' names too.

Ok I see it, I looked before but i guess I got to excited and skipped over it xD

Thanks alot and and also thanks for this wonderful mod ^_^
Title: Re: Group Moderators 1.4
Post by: goldsky on October 17, 2009, 11:38:40 PM
Quote from: rosuvladut on August 31, 2009, 05:59:51 PM
On SMF 1.1.10
Error in Package Installation At least one error was encountered during a test installation of this package. It is strongly recommended that you do not continue with installation unless you know what you are doing, and have made a backup very recently. This error may be caused by a conflict between the package you're trying to install and another package you have already installed, an error in the package, a package which requires another package that you don't have installed yet, or a package designed for another version of SMF.
You can do it manually by adding the code in your notepad.
Usually it happens because you have another Mod installed that changed to the same code insertion.
Title: Re: Group Moderators 1.4
Post by: goldsky on October 18, 2009, 02:14:59 AM
Anyhow,
I've uninstalled this again. Too much pain in coding. I wasted too much time just to make this work.

Wrong MySQL Alteration
The file modification didn't work completely. And if I did it manually, it has wrong <after> / <before> in manager's templates, and wrong table alteration structure in groupmod's template
Uninstall file doesn't include dropping 'GroupModOptions' in 'membergroups' database

I was hoping to use this heavily, but this Mod should be written back from the scratch.

cheers,
rico
SMF 1.1.10
Title: Re: Group Moderators 1.4
Post by: Dannii on October 18, 2009, 08:50:04 PM
What are you going on about?
What exactly do you think is wrong??
Title: Re: Group Moderators 1.4
Post by: goldsky on October 19, 2009, 03:07:34 PM
Dooh...
Hang on for 1 or 2 days, you're pushing me to install it back to show the error, while i'm busy at the moment.
I'll post here when I'm ready.

FYI,
My forum is heavily moded, so that's 1 of the trouble.

Quote from: goldsky on October 18, 2009, 02:14:59 AM

  • Wrong MySQL Alteration
  • The file modification didn't work completely.
  • And if I did it manually, it has wrong <after> / <before> in manager's templates,
  • and wrong table alteration structure in groupmod's template
  • Uninstall file doesn't include dropping 'GroupModOptions' in 'membergroups' database
Those're my problems yesterday.

I'll try it for the SMF's clean install and find out the different.
Title: Re: Group Moderators 1.4
Post by: Dannii on October 20, 2009, 08:50:09 AM
What exactly is wrong? Tell me what is wrong with the MySQL alteration, or which file modification didn't work etc. And are you sure you understand the format correctly?

The uninstall file isn't supposed to remove it, so that if you upgrade to a new version of the mod, you won't lose your settings.
Title: Re: Group Moderators 1.4
Post by: goldsky on October 20, 2009, 09:49:51 PM
quick reply:

This is just my opinion.
Don't you think that you should not change the original database structure, while you are absolutely not sure that you can revert back successfuly.
Please make a new table for `GroupModOptions` field, dont alter the `membergroups` table.

I just installed the Group Manager from http://code.google.com/p/smfgroups/ , NOT from http://mods.simplemachines.org/index.php?mod=171 , the mods WORKS in my clean installed SMF.

I'll diving a little bit to see the codes to find the errors I got previously.
Title: Re: Group Moderators 1.4
Post by: Dannii on October 20, 2009, 10:16:48 PM
Deleting fields is really really super easy,  but leaving it in won't cause any problems to anything else. And the groups table is small, it's not like it will massively increase your database size if you leave it in.

Anyways, I'm not developing this mod anymore.
Title: Re: Group Moderators 1.4
Post by: goldsky on October 20, 2009, 11:15:22 PM
I've compared the files.
You should notified everyone to install Group_Manager_1_5.tar.gz from its Project Home, as it's the stable one.

You should terminate the http://mods.simplemachines.org/index.php?mod=171 page, or upload that 1.5 version into it.


Last Modified:
    August 04, 2009, 05:54:11 AM <<== people see this as an updated mod.
Latest Version:
    1.4 <<== it did trick me.
Compatible With:
    1.0.5, 1.0.6, 1.0.7, 1.0.8, 1.0.9, 1.0.10, 1.1 Beta 3 Public, 1.1 RC1, 1.1 RC2, 1.1 RC3, 1.1, 1.1.1, 1.1.2, 1.1.3, 1.1.4, 1.1.5, 1.1.8, 1.1.10
Total Downloads:
    42913 <<== you have a number of big fans, although you want to run. :)



This's a good news, i'll try this mod to my live forum.
Title: Re: Group Moderators 1.4
Post by: Dannii on October 21, 2009, 03:50:19 AM
What exactly was incompatible??? Which precise file edit? Why do you refuse to answer?
Title: Re: Group Moderators 1.4
Post by: goldsky on October 21, 2009, 05:42:36 AM
LOL... hang on, dude.
I don't refuse, i just don't have much time to dig.
I only compared 1.4 with 1.5. I didn't make any change to the 1.5 ver.
You made those mods, right? You know the difference between those files.

So, another quick reply:
Your codes search strings with complete lines, meanwhile that line has been altered with another mod: Personal Message to Groups (http://custom.simplemachines.org/mods/index.php?mod=2178) or ezPortal.

It and Group Moderators share the same line alteration.
What I caught about EzPortal:

<file name="$themedir/index.template.php">
<operation>
<search position="replace"><![CDATA[
// Are we using right-to-left orientation?
]]></search>

the string is with 1 tab space before "// Are we using right-to-left orientation?".

eZPortal changed it with 2 tabs.


// EzPortal
if (isset($context['current_action2']))
$current_action = $context['current_action2'];

// Are we using right-to-left orientation?


May be that's my case.
Title: Re: Group Moderators 1.4
Post by: Dannii on October 21, 2009, 07:00:31 AM
Seeing as my mod was released long before theirs, isn't it their responsibility to make sure they're compatible with mine? ;)

And actually someone else took over development for 1.5, but it doesn't look like he's active anymore.
Title: Re: Group Moderators
Post by: s_m_f_forumuser on October 31, 2009, 02:08:23 PM
Quote from: Viporizer on August 04, 2009, 05:51:45 AM
Tested on SMF 1.1.10
Works fine.

I'm also using that version but I cannot see any difference in my forum system after the installation of this mod?? I have really meticulously looked around in the member group part in the administration center. I cannot find a way to add a specific moderator for a member group. There just is no such field when I click modify on the member group.

Title: Re: Group Moderators 1.4
Post by: Dannii on October 31, 2009, 11:50:47 PM
Are you using the default theme?
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 01, 2009, 05:49:50 AM
Quote from: Dannii on October 31, 2009, 11:50:47 PM
Are you using the default theme?

Yes: SMF Default Theme - Core
SMF 1.1.10
Neither Group Moderators 1.4 nor Group Moderators 1.5 works
Title: Re: Group Moderators 1.4
Post by: Dannii on November 01, 2009, 06:09:00 AM
Which membergroup are you trying to add moderators for?
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 01, 2009, 10:10:01 AM
A member group that I created myself and that is "based off of" Regular Members. The installation of the mod went well according to SMF but I can see no difference whatsoever in the SMF interface.
Title: Re: Group Moderators 1.4
Post by: Dannii on November 01, 2009, 09:56:26 PM
Can you check that the changes were made to ManageMembergroups.template.php correctly?
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 04, 2009, 05:13:55 AM
I m not sure how to see if those changes were made. I have attached the file /Themes/default/ManageMembergroups.template.php

SMF said the installation went well anyway?
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 04, 2009, 05:25:16 AM
When I know try to uninstall

Group_Manager_1_5.tar.gz

from my SMF-forum I get the following error messages:
------------
Installing this package will perform the following actions:    Type   Action   Description
1.   Execute Modification   ./index.php   Test failed
2.   Execute Modification   ./Sources/ManageMembergroups.php   Test failed
3.   Execute Modification   ./Sources/ManagePermissions.php   Test failed
4.   Execute Modification   ./Themes/default/index.template.php   Test failed
5.   Execute Modification   ./Themes/default/../babylon/index.template.php   Test failed
6.   Execute Modification   ./Themes/default/ManageMembergroups.template.php   Test failed
7.   Execute Modification   ./Themes/default/languages/Modifications.english.php   Test failed
8.   Execute Modification   ./Themes/default/languages/Modifications.swedish.php   Test failed
9.   Execute Modification   ./Themes/default/languages/Modifications.german.php   Skipping file
10.   Execute Modification   ./Themes/default/languages/Help.english.php   Test failed
11.   Execute Modification   ./Themes/default/languages/Help.swedish.php   Test failed
12.   Execute Modification   ./Themes/default/languages/Help.german.php   Skipping file
13.   Delete File   ./Sources/Groups.php   
14.   Delete File   ./Themes/default/Groups.template.php   
15.   Delete File   ./Themes/default/languages/Groups.english.php   
16.   Delete File   ./Themes/default/languages/Groups.german.php   
17.   Delete File   ./Themes/default/languages/Groups.swedish.php   
18.   Delete File   ./Themes/default/../babylon/images/english/groups.gif   
19.   Delete File   ./Themes/default/../babylon/images/german/groups.gif   
20.   Delete File   ./Themes/default/../babylon/images/swedish/groups.gif   
--------------
When I did the installation before it said however that everything went well. However before that I had done an installation and uninstallation of

smfgroups_1_4.tar.gz

which should be the previous version according to the information in this discussion thread as well as on other places. I have no idea whether that can have anything to do with it?
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 04, 2009, 06:05:56 AM
Do I need to make certain files writable manually before the installation?
Title: Re: Group Moderators 1.4
Post by: Dannii on November 04, 2009, 06:26:26 AM
If all those files are getting errors it's likely they were never modified in the first place.

Yes, make everything writeable.
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 04, 2009, 06:39:32 AM
Make every file in the whole forum writable?

What shall I do with the uninstallation? Should I uninstall anyway despite SMFs strong recommendation not to?
Title: Re: Group Moderators 1.4
Post by: Dannii on November 04, 2009, 07:11:16 AM
Yes every file. If you want you can always change them back after...

Well as the files haven't been modified nothing should happen to them when you uninstall it. Alternatively, you could delete the mod and upload it again.
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 04, 2009, 07:26:45 AM
Are there any security issues with having all files in the forum writabe all the time? Otherwise that seems easiest.
Title: Re: Group Moderators 1.4
Post by: Dannii on November 04, 2009, 07:38:12 AM
http://www.simplemachines.org/community/index.php?topic=2987.0

775 is probably also fine.
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 04, 2009, 10:08:24 AM
I uninstalled it, checked every file listed above and they were already 777 all of them actually. Then I reinstalled it with the following successful testresult according to SMF before I went through with the installation:

Type   Action   Description
1.   Execute Modification   ./index.php   Test successful
2.   Execute Modification   ./Sources/ManageMembergroups.php   Test successful
3.   Execute Modification   ./Sources/ManagePermissions.php   Test successful
4.   Execute Modification   ./Themes/default/index.template.php   Test successful
5.   Execute Modification   ./Themes/default/../babylon/index.template.php   Test successful
6.   Execute Modification   ./Themes/default/ManageMembergroups.template.php   Test successful
7.   Execute Modification   ./Themes/default/languages/Modifications.english.php   Test successful
8.   Execute Modification   ./Themes/default/languages/Modifications.swedish.php   Test successful
9.   Execute Modification   ./Themes/default/languages/Modifications.german.php   Skipping file
10.   Execute Modification   ./Themes/default/languages/Help.english.php   Test successful
11.   Execute Modification   ./Themes/default/languages/Help.swedish.php   Test successful
12.   Execute Modification   ./Themes/default/languages/Help.german.php   Skipping file
13.   Extract File   ./Sources/Groups.php   
14.   Extract File   ./Themes/default/Groups.template.php   
15.   Extract File   ./Themes/default/languages/Groups.english.php   
16.   Extract File   ./Themes/default/languages/Groups.german.php   
17.   Extract File   ./Themes/default/languages/Groups.swedish.php   
18.   Extract Tree   ./Themes/default/../babylon/images   
19.   Execute Code   GroupMods_install.php   

Then I compared the file

ManageMembergroups.template.php

with the one I had in the previous nonworking installation and it is exactly the same content as in the file I attached about. However I'm not sure what changes to look for so I cannot say for sure whether this installation have made any changes in that file or not. Perhaps someone who knows what to look for can have a look?

Title: Re: Group Moderators 1.4
Post by: Dannii on November 04, 2009, 10:26:17 AM
You'll have to just manually install it I guess.
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 04, 2009, 10:50:57 AM
Is there some kind of guide for doing that manual install? Where do I look for what changes to make? I'm not very good at this kind of coding. But sometimes I have installed mods with a manual description in in phpBB.
Title: Re: Group Moderators 1.4
Post by: Dannii on November 04, 2009, 11:02:06 AM
Yes, the mod page has a "Manual Install Instructions for SMF" box you can use.
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 04, 2009, 12:16:04 PM
Now I have done these changes manually in all the PHP files. However in the first
SQL query I get the following error message:

Error

SQL query:

CREATE TABLE IF NOT EXISTS {$db_prefix}groupmods(
`ID_GROUP` smallint( 5 ) unsigned NOT NULL default '0',
`ID_MEMBER` mediumint( 8 ) unsigned NOT NULL default '0',
PRIMARY KEY ( `ID_GROUP` , `ID_MEMBER` )
)

MySQL said: 
#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '{$db_prefix}groupmods (
`ID_GROUP` smallint(5) unsigned NOT NULL default '0',
' at line 1


And I have no idea regarding the syntax :-(.
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 04, 2009, 12:31:09 PM
I thought I had figured it out when I saw that

db_prefix

should probably be replaced with my own database prefix so I changed it as below but I still get the same error message as before.

CREATE TABLE IF NOT EXISTS {$smf1_}groupmods (
`ID_GROUP` smallint(5) unsigned NOT NULL default '0',
`ID_MEMBER` mediumint(8) unsigned NOT NULL default '0',
PRIMARY KEY ( `ID_GROUP` , `ID_MEMBER` )
)
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 04, 2009, 12:35:57 PM
now it worked! :-). I finally figured out to change the code like this :-)

CREATE TABLE IF NOT EXISTS smf1_groupmods (
`ID_GROUP` smallint(5) unsigned NOT NULL default '0',
`ID_MEMBER` mediumint(8) unsigned NOT NULL default '0',
PRIMARY KEY ( `ID_GROUP` , `ID_MEMBER` )
)
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 04, 2009, 01:20:32 PM
Now it is up and running and seems to work well except for one thing. It works to add a group moderator but after the moderator is added there is no way for the administrator to see who are group moderators and for which groups as far as I can see? And as a result I can find no way to remove someone from being a group moderator.
Title: Re: Group Moderators 1.4
Post by: Dannii on November 05, 2009, 03:38:45 AM
Anything in your error logs?
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 05, 2009, 06:31:23 AM
You mean the error log for the SMF forum? If there are any errors generated when I add someone as a group moderator? If that's what you mean no such errors are reported. I haven't noted any other errors either doing the manual installation. How is it supposed to work to see who are group moderators as well as how to remove them? What is the user interface?
Title: Re: Group Moderators 1.4
Post by: Dannii on November 05, 2009, 08:07:07 AM
The text box should have a list of the moderators, and if want more you just add an extra name to the list.
Title: Re: Group Moderators 1.4
Post by: s_m_f_forumuser on November 05, 2009, 12:42:14 PM
The text box is empty. But I can make a list of users in it if I click on several users when adding moderators so I see what you mean how it should look like when I go into the modify section of the member group. However when I go into the group the text box is empty even though there is still a moderator for the group. I also tried to click on the save button with the Group moderators text box empty as a way to remove the group moderator but the group moderator does not disappear. And if I enter another group moderator in the text box the old one does not disappear even though when I click save there is only the new group moderator in the text box. I suppose that would be the way to remove as well as change group moderators if it worked as it should?

Can you give me any hint of where to look for the problem?  Where is the code that loads the users into that text box when you go into the modify part?

Thank you very much for your help! I really do appreciate it.
Title: Re: Group Moderators 1.4
Post by: Dannii on November 05, 2009, 08:34:00 PM
Are you sure you made the changes to ManageMembergroups.php correctly? That is the file.
Title: Re: Group Moderators 1.4
Post by: smp420 on December 14, 2009, 06:46:41 PM
Any chance this will be made for 2.0 rc2
Title: Re: Group Moderators 1.4
Post by: Acans on December 15, 2009, 12:24:53 AM
Quote from: smp420 on December 14, 2009, 06:46:41 PM
Any chance this will be made for 2.0 rc2

Group Moderators is a default feature for 2.0
Title: Re: Group Moderators 1.4
Post by: smp420 on December 15, 2009, 12:31:53 AM
oh really I didnt know that.
Title: Re: Group Moderators 1.4
Post by: hcfwesker on March 05, 2011, 08:45:51 PM
Quote from: ѕησω on December 15, 2009, 12:24:53 AM
Quote from: smp420 on December 14, 2009, 06:46:41 PM
Any chance this will be made for 2.0 rc2

Group Moderators is a default feature for 2.0

Really?  How do you do it so they can add/remove members to a specific membergroup?
Title: Re: Group Moderators 1.4
Post by: hcfwesker on June 26, 2011, 09:10:45 PM
bump.  can anyone explain my question above, please.  Or is that specific part not a feature in SMF 2.0
Title: Re: Group Moderators 1.4
Post by: IP_Board_Rules on April 18, 2023, 02:58:09 PM
I have the same question please
Title: Re: Group Moderators 1.4
Post by: Arantor on April 18, 2023, 03:03:24 PM
Please don't bump old topics, it's kind of annoying.

Group moderators have been a feature since 2.0 - you make the group, go into edit it once created and it's literally right there. Right under group name and description. It is obviously not an option for the board moderator 'group' or post count groups.
Title: Re: Group Moderators 1.4
Post by: Steve on April 19, 2023, 06:38:42 AM
@atanua - This is at least the second time this week you've brought up a very old post that you haven't given a good reason to bring up. Don't do this again.
Title: Re: Group Moderators 1.4
Post by: IP_Board_Rules on April 19, 2023, 07:00:33 PM
Quote from: Steve on April 19, 2023, 06:38:42 AM@atanua - This is at least the second time this week you've brought up a very old post that you haven't given a good reason to bring up. Don't do this again.

okay. i will stop posting. obviously the search function is placed here in error and people are not to ask questions.

bye bye and off to message board system that is not making people go away
Title: Re: Group Moderators 1.4
Post by: Arantor on April 19, 2023, 07:02:06 PM
No, it's just that you're finding topics that are years out of date - better to ask a fresh topic where you could just ask how to do this in 2.1 and we'd tell you :)
Title: Re: Group Moderators 1.4
Post by: Diego Andrés on April 19, 2023, 09:20:40 PM
He wants to do it on SMF 2.0.x though, this mod is for SMF 1.1.x
Title: Re: Group Moderators 1.4
Post by: Arantor on April 20, 2023, 03:16:55 AM
Functionality is still there in 2.0 as far as I remember...