News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

Group Moderators 1.4

Started by Dannii, July 25, 2005, 04:24:08 PM

Previous topic - Next topic

Dannii

#40
Here's a bandaid fix. Sorry it's so late coming, but I've been busy. I'll work on an updated version of the mod soon.

find this in Groups.php
while ($row = mysql_fetch_assoc($request))
{
// Verify that they are not already a member - and add them to our array.
if ($row['ID_GROUP'] != $_REQUEST['id'] && !in_array($_REQUEST['id'], explode(',', $row['additionalGroups'])))
$memberQuery[$row['ID_GROUP'] == 0 ? 'main_group' : 'additional'][] = $row['ID_MEMBER'];
}
mysql_free_result($request);

replace with
while ($row = mysql_fetch_assoc($request))
{
// Verify that they are not already a member - and add them to our array.
if ($row['ID_GROUP'] != $_REQUEST['id'] && !in_array($_REQUEST['id'], explode(',', $row['additionalGroups'])))
$memberQuery['additional'][] = $row['ID_MEMBER'];
}
mysql_free_result($request);


This will force all new members added to a group using the groups function (admin is unaffected) to be added as a secondary group only. If you want it to be their primary group you will have to use the admin panel sorry, until the next version when I'll include more options.
"Never imagine yourself not to be otherwise than what it might appear to others that what you were or might have been was not otherwise than what you had been would have appeared to them to be otherwise."

e2p2

Is there a time frame on when this mod will be updated to support RC1?  Also can you add a button, maybe on the home page (for those with Group Mod Permissions), to access the group mod page.

Dannii

A permission will be added in the next version, but it will be up to everyone else to make buttons. RC1... maybe after I download it.
"Never imagine yourself not to be otherwise than what it might appear to others that what you were or might have been was not otherwise than what you had been would have appeared to them to be otherwise."

zwilson

I'm having problems with the settings saving.  I've installed the package, and when I have action=groups? the box and everything comes up, so I know it's installed.  However, my problem comes when I try to add moderators for the groups.  I'm in the "Manage Membergroups" area and when I modify a group I get two boxes with "Group Moderator(s)" where I have added my moderators and have pressed save.  But nothing happens.  When I return the group moderators aren't there and when I try the "action="groups?" there is no change.  Is it not recording the changes?  Do I need to change some settings or permissions somewhere?  Please help.

Harelin

Quote from: zwilson on September 26, 2005, 01:24:18 AM
I'm having problems with the settings saving.  I've installed the package, and when I have action=groups? the box and everything comes up, so I know it's installed.  However, my problem comes when I try to add moderators for the groups.  I'm in the "Manage Membergroups" area and when I modify a group I get two boxes with "Group Moderator(s)" where I have added my moderators and have pressed save.  But nothing happens.  When I return the group moderators aren't there and when I try the "action="groups?" there is no change.  Is it not recording the changes?  Do I need to change some settings or permissions somewhere?  Please help.

What exactly are you typing in the field?  It is fairly sensitive; mistype a moderator's name and you will not receive an error message.  Likewise, if you're inputting several moderators per group and don't separate the names with commas (i.e. moderator1 moderator2 moderator3 as opposed to moderator1,moderator2,moderator3), it will have the exact result you're reporting.  Consider for a second whether your input could be flawed in any way.

zwilson

Hey, well I kind of got it working.  The input wasn't flawed.  I just had to enter in the moderators name in the bottom field instead of the upper field.  This makes me believe it might have been installed twice, and the upper field was just reminiscent of the previous install - and because of the second install it rendered it defective?  If that's the case it was my fault.  Anyway - I think I got it going - thanks for the help!  Great mod!

Dannii

Hmm :S There should only be one field.

For input, its done exactly how its done for entering moderators for a board. Prehaps I should make it better.. Anyways, if you're not sure, use the search tool and add them that way, with a comma between each. The search tool will always return the proper username
"Never imagine yourself not to be otherwise than what it might appear to others that what you were or might have been was not otherwise than what you had been would have appeared to them to be otherwise."

Harelin

I think the input is fine, unless other people are reporting problems.  That was just a suggestion to troubleshoot.  A note to separate names with commas would be a nice touch, but not necessary.

^Raven^

I just want to be sure I understand this properly.  I could create a group called like Overlords.  Then add members to that group.  The Overlords group could then be assigned as mods to certain boards on my forum.  That would allow everyone in the Overlords group to have moderator control of those certain boards.  Is this correct?
Jon Reinhart

Owner, CWF GameCast

Public Relations Coordinator, Battlestar Galactica Wiki

Dannii

No, although I am possibly going to add the possibility of setting a group as a mod over a board in the future.

This mod allows you to set individuals who can add and delete members to their group. This can be used instead of the manage-membergroups permission if you don't want them to have access to every group in your forum.

Example.
Person A is an admin
Person B leads a private group of the forum
Person C wants to be a member of that group
Person D leads another private group
In the old system B and C would have to ask A to add C to the group, or else A could give B permissions over everygroup, but then person D wouldn't be very happy.

In my mod person B can add C him/herself. A and D don't even have to know. This will be very useful for large forums where the admin previously would have to be adding 20 people a day to various groups.
"Never imagine yourself not to be otherwise than what it might appear to others that what you were or might have been was not otherwise than what you had been would have appeared to them to be otherwise."

^Raven^

Oh I get it now.  Not really useful for my forum.  But, when you add the feature, which will allow the group to be a mod over a board or multiple boards it'll be very useful.  I believe I installed the mod ages ago thinking it would allow the group to moderate boards with me (the owner/admin) placing members in the group.

Any idea when you'll be doing that?
Jon Reinhart

Owner, CWF GameCast

Public Relations Coordinator, Battlestar Galactica Wiki

Dannii

Actually I'm thinking now it would be better suited as a separate mod, because they are independant. I would make this mod integrate with it though.

However it's not even needed, if you use local permissions for the board any group can be moderator.
"Never imagine yourself not to be otherwise than what it might appear to others that what you were or might have been was not otherwise than what you had been would have appeared to them to be otherwise."

^Raven^

Not sure I understand how to do that.  Of course, I've been told by David to avoid local permissions because they help people make mistakes and owners tend to forget about them especially on forums my size or larger.
Jon Reinhart

Owner, CWF GameCast

Public Relations Coordinator, Battlestar Galactica Wiki

BlueGoku

Any idea when a new version of this is released so it's compatible with 1.1 RC1?

Dannii

zwackelmann has alerted me to a very serious security threat. Please immediately uninstall this mod until I can release a fixed version. Sorry :'(
"Never imagine yourself not to be otherwise than what it might appear to others that what you were or might have been was not otherwise than what you had been would have appeared to them to be otherwise."

Harelin

#55
ETA?  I hope this won't require a huge amount of re-coding on your part.  This mod is the backbone of my forum.

Dannii

I know the problem so as soon as I can fix it I will release. Hopefully later today. RC1 and new features will still have to wait till after my exams.
"Never imagine yourself not to be otherwise than what it might appear to others that what you were or might have been was not otherwise than what you had been would have appeared to them to be otherwise."

Harelin

No complaints about RC1... I'm still on 1.0.5 myself :)

Thanks for all your work - this mod has been of great use.

Dannii

Version 1.1 has been released
el_groupmods_11.tar.gz
changelog.txt

The security flaw has been fixed. In addition, the permissions 'band-aid' fix has been incorporated.
"Never imagine yourself not to be otherwise than what it might appear to others that what you were or might have been was not otherwise than what you had been would have appeared to them to be otherwise."

Dannii

Version 1.1b has been released
el_groupmods_11b.tar.gz
changelog.txt

This should now work for 1.1 RC1. Please tell me if it doesn't.
"Never imagine yourself not to be otherwise than what it might appear to others that what you were or might have been was not otherwise than what you had been would have appeared to them to be otherwise."

Advertisement: