Simple Machines Community Forum

Hi, I thought I would share this small mod.  I noticed my board was getting cluttered by signatures if someone posts ten times in a topic you see their signature 10 times.

So I wrote a quick mod that displays each signature only once per page, the second page of the topic will have the sig again but I wasn't really too concerned abou that and don't think it's worth the effort. 

This was actually really easy to do.  In Display.template.php

find
//Show the member's signature?

Before this line add

// Show signature only once
               $IDAlreadyDisplayed = 0;
               if (!empty($MemberIDList)) {
                 if (in_array($message['member']['id'], $MemberIDList))
                    $IDAlreadyDisplayed = 1;
               }


Then change
if (!empty($message['member']['signature']) && empty($options['show_no_signatures']))
echo '
                                                        <hr width="100%" size="1" class="hrcolor" />
                                                        <div style="overflow: auto; width: 100%; padding-bottom: 3px;" class="signature">', $message['member']['signature'], '</div>';


to the following:

if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && !$IDAlreadyDisplayed) {
                        echo '
                                                        <hr width="100%" size="1" class="hrcolor" />
                                                        <div style="overflow: auto; width: 100%; padding-bottom: 3px;" class="signature">', $message['member']['signature'], '</div>';
                $MemberIDList[] = $message['member']['id'];
                } // endif I added the brackets


That is all enjoy!  ;D

works great, thanks for sharing :)

in 1.1rc1 i had to search for

      if (!empty($message['member']['signature']) && empty($options['show_no_signatures']))
echo '
<hr width="100%" size="1" class="hrcolor" />
<div class="signature">', $message['member']['signature'], '</div>';

very clever idea.. thanks for sharing this.

-mouser
www.donationcoder.com

 :) Sounds perfect. So where's this option located in the cp?

it's not an "option"...hence all the code.

Zitat von: Tippmaster in November 08, 2005, 05:07:27 NACHMITTAGS
it's not an "option"...hence all the code.

I can't find anything relating to signatures, aside from creating one.  Are the existing posts affected, or just the new ones after the code is modded? ???

No there is no administration for this.  Its just a simple change that will do it automatically.  No way to turn it on off install uninstall.  All it does is that instead of displayin you sig everytime you make a reply to a topic it just displays it in your first post or fist page of the topic.

OK, tnx...

I was asked to change this a little so I did  :P

The text repeating isn't as much of a concern as images repeating, so I have edited my code to show the signatures more than once but the second time on it only shows the text and not the images.


// Show signature only once
               $IDAlreadyDisplayed = 0;
               if (!empty($MemberIDList)) {
                 if (in_array($message['member']['id'], $MemberIDList))
                    $IDAlreadyDisplayed = 1;
               }
                // Show the member's signature?
                if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && !$IDAlreadyDisplayed) {
                        echo '
                                                        <hr width="100%" size="1" class="hrcolor" />
                                                        <div style="overflow: auto; width: 100%; padding-bottom: 3px;" class="signature">', $message['member']['signature'], '</div>';

                                                        $MemberIDList[] = $message['member']['id'];
                } elseif(!empty($message['member']['signature']) && $IDAlreadyDisplayed && empty($options['show_no_signatures'])) {
                                                        $Sig = $message['member']['signature'];
                                                        $tags_to_strip = Array("img");
                                                        foreach ($tags_to_strip as $tag) {
                                                           $Sig = preg_replace("/<\/?" . $tag . "(.|\s)*?>/","",$Sig);
                                                        }
                        echo '
                                                        <hr width="100%" size="1" class="hrcolor" />
                                                        <div style="overflow: auto; width: 100%; padding-bottom: 3px;" class="signature">', $Sig, '</div>';


                }// endif I added the brackets


Its work on RC2. I am using SAFGrey theme.
Thank You :)

This is totally wonderful.  I too concur that it works very nicely with RC2.  Thank you again!   ;)

Hi,
this is an AWESOME modification, it really cleans up the pages.

A single question, is there a way to modify it to display only one the member location, text, and age?
Is there a way to show only once the title if it's not changed by a user?

best,
Carla

Sure anything is "possible".  The thing is you don't want to do too many of these "enhancements" as it will begin to slow down your load times on the pages, you'll also start to suck up memory if you start sorting and checking everything upon display.

Should be built in feature ;)
*hint*hint*

Zitat von: wing in März 21, 2006, 11:47:01 VORMITTAG
Sure anything is "possible".  The thing is you don't want to do too many of these "enhancements" as it will begin to slow down your load times on the pages, you'll also start to suck up memory if you start sorting and checking everything upon display.

Do you have any idea of how much?
I'd like to delete the avatars and all the user info, if the user posted more than once too.
best,
Carla

No idea, but if you know a little php and html you can copy my code and add the avatar stuff as well.

this code is great, thanks! ;)

Zitat von: wing in Januar 26, 2006, 07:07:35 NACHMITTAGS
I was asked to change this a little so I did  :P

The text repeating isn't as much of a concern as images repeating, so I have edited my code to show the signatures more than once but the second time on it only shows the text and not the images.

Code Auswählen Erweitern


// Show signature only once
               $IDAlreadyDisplayed = 0;
               if (!empty($MemberIDList)) {
                 if (in_array($message['member']['id'], $MemberIDList))
                    $IDAlreadyDisplayed = 1;
               }
                // Show the member's signature?
                if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && !$IDAlreadyDisplayed) {
                        echo '
                                                        <hr width="100%" size="1" class="hrcolor" />
                                                        <div style="overflow: auto; width: 100%; padding-bottom: 3px;" class="signature">', $message['member']['signature'], '</div>';

                                                        $MemberIDList[] = $message['member']['id'];
                } elseif(!empty($message['member']['signature']) && $IDAlreadyDisplayed && empty($options['show_no_signatures'])) {
                                                        $Sig = $message['member']['signature'];
                                                        $tags_to_strip = Array("img");
                                                        foreach ($tags_to_strip as $tag) {
                                                           $Sig = preg_replace("/<\/?" . $tag . "(.|\s)*?>/","",$Sig);
                                                        }
                        echo '
                                                        <hr width="100%" size="1" class="hrcolor" />
                                                        <div style="overflow: auto; width: 100%; padding-bottom: 3px;" class="signature">', $Sig, '</div>';


                }// endif I added the brackets


Works perfect on smf 1.0.7

Thanks a lot!

If I understand the code correctly, it sets the signature to only display in the first post by that member, on that page.

Could it be modified to only show the signature on the LAST post by that member, on that page?

Ouch that would be tough.....  ???  I don't think so...

If you are using SMF 1.1 Final the changes are fairly minor, but sicne there are some, just find
// Show the member's signature?
if (!empty($message['member']['signature']) && empty($options['show_no_signatures']))
echo '
<hr width="100%" size="1" class="hrcolor" />
<div class="signature">', $message['member']['signature'], '</div>';

And change it to:
// Show the member's signature?
if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && !$IDAlreadyDisplayed) {
                        echo '
                                                        <hr width="100%" size="1" class="hrcolor" />
                                                        <div class="signature">', $message['member']['signature'], '</div>';
                $MemberIDList[] = $message['member']['id'];
                } // endif I added the brackets

I'd still LOVE to be able to ahve this altered to only show the display on the FINAL occurence of that poster on the page, not the first....

I don't know if this would be of any help to anyone... I don't understand most of this coding stuff... but we had a hack on a Proboard forum that did this (showed the sig. once per user per page, on that users FINAL post in the page.

I know the coding is all different... but wondered if maybe posting the hack that worked for Proboards might twig someones mind into a way for it to work for SMF?

The hack for Proboards is:

<script type="text/javascript">
<!--
/* only show last occurance of a signature on each page - ross*/
if(location.href.match(/ion=(display|gotopost)/)) {
var td = document.getElementsByTagName('td');
var us = [];
for(i=td.length-1; i>4; i--) {
if(td.item(i).colSpan == '3' && td.item(i).vAlign == 'bottom') {
var username = td.item(i).parentNode.parentNode.parentNode.parentNode.parentNode.getElementsByTagName('a').item(1).href.split(/user=/)[1];
if(us[username])
td.item(i).lastChild.style.display = 'none';
us[username] = 'true';
}
}
}
//-->
</script>

I can think of a few ways to do this.

1) Determine # of posts per page from variable.  Then Scan through that many posts and count up each user.  Then on X post from that user only put their signature (slow but saves memory)

2) Follow the same way SMF does it now, which is output one post at a time in a loop except instead of actually outputting to the screen put it into a variable, and do not output to screen.  Once the page is ready to go, go back through your stored arrays and clean up the signatures. (memory hog but might be slightly faster since you do not have to read the database more than once).

Both are not the best solutions, maybe someone has another idea.

Any more ideas on this?  (modifying to display the signature in the users *last* post on the page)

Hopefully this isn't changing the direction of the thread since it has morphed into a request for the sig to show on the last post.....but as with many I am new to SMF and have a question on the original code change.

I have no issue putting this into the default view, but what is the procedure if you don't have a display.template.php for a certain theme you have chosen as a default for your board?  I have used the BlackRain theme as a starter, which doesn't contain a Display.Template.php file in the theme, although I do see one in the default theme.  Changing this doesn't affect the theme until I copy it into the BlackRain theme folder, but then all the button and layout settings are changed to those of the default (as I would expect).

Am I missing something or where to look to see where to apply this for all themes, or for one that doesn't have the needed template file?  I am hoping not to have to create a template for the theme settings as I do like the layout on this one and would hate to have to recreate it from scratch.

Thanks in advance for your patience

my apologies for jumping the gun and posting on this one.  I found the display.template.phpo in the classic theme was driving the display and have copied it into the theme I use, making the modification there.

nice Mod, it' s really useful to clean up things in topic

Thanks much for this mod - and for the update for 1.1.1 - works perfectly!!  VERY glad I didn't have to give this one up when I upgraded!

 8) Tnx. Works great!

I can't find //Show the member's signature?
that line in the file..
and if it helps, I'm using a template named black22

Thank a lot

 Thanks for this code...very useful!

It seems to me that it deserves to be used rather more often and thus to be a packaged mod...seeing as wing has been good enough to do all the coding the least I can do is to do the packaging of it...herewith both versions...the original that removes the signature text and the later one that removes the images...

http://www.mediafire.com/?2z2ayndfjhi (http://www.mediafire.com/?2z2ayndfjhi) SMF_Display_Images_In_Signatures_Only_Once_Per_Page_v1.1.zip

http://www.mediafire.com/?2jdn5gde2od (http://www.mediafire.com/?2jdn5gde2od) SMF_Display_Signatures_Only_Once_Per_Page_v1.1.zip

Perhaps wing might consider adding one or other or both to the mods list...or give permission for them to be added.

This really should be a built-in option heh.

 One person's must have can be another person's clutter...so long as it's readily available as a mod I don't see that we have to worry too much.

BTW the packages are for SMF 1.1.1 and 1.1.2

Well, options are often a great thing, and having it as a mod is truly enough for me. ;)

Hi I tried the code changes suggested in this topic and for some reason it just doesn't work :(  I've applied the changes to the main and only theme Display.template.php as well as the default Display.template.php and it is not taking effect (images appearing more than once on a page)

I tried the packages and it returns a installation error when I try to install them.

I am running 1.1.2 SMF.

Thanks

Perhaps you would quote the installation error and any error log item relevant to the mod...the information you've given isn't enough to work out what the problem might be.

Okay sorry, i presume its a standard error you recieve when a package reports installation errors

Error in Package Installation
At least one error was encountered during a test installation of this package. It is strongly recommended that you do not continue with installation unless you know what you are doing, and have made a backup very recently. This error may be caused by a conflict between the package you're trying to install and another package you have already installed, an error in the package, a package which requires another package that you don't have installed yet, or a package designed for another version of SMF.

Installing this package will perform the following actions:
Type Action Description
1. Execute Modification ./Themes/default/Display.template.php Test failed


It throws no php errors but at the same time it doesn't actually have any effect.

LOL this isn't a problem with the mod at all! You need to do a manual install as some other mod appears to have already altered the files this mod seeks to alter. Do a search for manual install if you need details on how to do it.

http://docs.simplemachines.org/index.php?topic=402
Manual installation of mods

http://sleepycode.com/index.php?action=modparser
SMF Package Parser

Thanks Blackmage, I actually did this before my previous post, but tried again for good measure.  Even after applying it manually (twice) it still doesn't work.  Oh well I'll keep looking into it perhaps I'll turn something up.

works great with 1.1.2 8)

thank you
work fine in MSF 1.1.2

Thank you so much! :D I had this mod on my phpBB forum and was hoping to get it here, too. It works perfectly! :D

Thanks so much! I always wanted to find a mod to do this.  Works perfectly.

Anyone know if this works in 1.1.3 yet?  :D

1.1.3 did not alter any of the template files. it should work just the same as it did on 1.1.2

Zitat von: Mommy in Juni 28, 2007, 03:46:55 NACHMITTAGS
Anyone know if this works in 1.1.3 yet?  :D

Well, I had already added this to my forum when I installed the upgrade, and there've been no trouble. So, I'm guessing it'd be fine.

I had to install manually but it went well  :D  Thanks so much!!!

I started using this when the mod wasn't around yet. ;)

probably can just add ;version_emulate=1.1.2 to your package manager address in the URL bar after clicking packages to get this to install.

Like i said, there were no template changes.

Updated packages as follows:

http://www.mediafire.com/?elzwie9lmzz (http://www.mediafire.com/?elzwie9lmzz)

SMF_Display_Images_In_Signatures_Only_Once_Per_Page_v1.1

http://www.mediafire.com/?0ezyjfeemzh (http://www.mediafire.com/?0ezyjfeemzh)

SMF_Display_Signatures_Only_Once_Per_Page_v1.1


To anyone in the SMF Official Team: May I have permission to submit these as official mods? I've waited quite a while so as to allow the code author ample opportunity to object?

TrueSatan,

Any particular reason why your mod code is bigger and more elaborate than the code presented in the first posts and updated by me to 1.1 Final?

Bigger and more elaborate? It's the same as the original code with the only additions I made being a line at the start and end to aid readability of the file post edit. So minor a change as to be hardly worth mentioning.

I tried your updated code and had problems with it whereas the original code worked perfectly for me so I stuck with that. It seems that there have been no problems reported so I saw no reason to further alter the code.

I merely changed a part that was slightly different in 1.1 Final, not that much, and now that I looked the code of the modification more carefully you re right, it is the same. I hope they allow you to submit the mod to the customization part of the site. :)

Thanks...and I appreciate you taking the trouble to post back with that confirmation and support.

TrueSanta, :)

I'll bring this to the teams attention and see what they have to say.

Thanks ItchBind

Codes from the first post works fine with SMF 1.1.3. Thanks.

I have problem downloading the compressed file from your link TrueSatan. Something to do with cookies not turned on or something.

It seems to be OK TrueSatan. If the author doesn't respond tips and tricks are allowed to be made into a mod. I would also ask that you point to this topic in your mod description and give a little credit to the author.

Firstly thank you IchBin for your help in this matter...it's much appreciated. I will, indeed give accreditation and a link to this topic in the mods...altered to do so now.

@JohnyB

Alternative download links:

http://rapidshare.com/files/41113029/SMF_Display_Images_In_Signatures_Only_Once_Per_Page_v1.1.zip.html]http://rapidshare.com/files/41113029/SMF_Display_Images_In_Signatures_Only_Once_Per_Page_v1.1.zip.html]http://rapidshare.com/files/41113029/SMF_Display_Images_In_Signatures_Only_Once_Per_Page_v1.1.zip.html]http://rapidshare.com/files/41113029/SMF_Display_Images_In_Signatures_Only_Once_Per_Page_v1.1.zip.html]http://rapidshare.com/files/41113029/SMF_Display_Images_In_Signatures_Only_Once_Per_Page_v1.1.zip.html]http://rapidshare.com/files/41113029/SMF_Display_Images_In_Signatures_Only_Once_Per_Page_v1.1.zip.html]http://rapidshare.com/files/41113029/SMF_Display_Images_In_Signatures_Only_Once_Per_Page_v1.1.zip.html (http://rapidshare.com/files/41113029/SMF_Display_Images_In_Signatures_Only_Once_Per_Page_v1.1.zip.html)

http://rapidshare.com/files/41113446/SMF_Display_Signatures_Only_Once_Per_Page_v1.1.zip.html (http://rapidshare.com/files/41113446/SMF_Display_Signatures_Only_Once_Per_Page_v1.1.zip.html)

To note,

Until the mod is approved and placed on our Mod Site (http://custom.simplemachines.org/mods), i would reccommend caution in its install until that time.  Nothing against anyone, just looking out for everyone.

I realize the mod is a small change, but it can be risky to install unapproved mods.

Just be careful :)

Thanks metallica48423...no arguments from me.

Can anyone tell me where this file would be for aa new damage?

pirat3,

mods only install to the default theme.  For use on custom themes, you'd have to manually install it or contact the theme author or mod author and ask how they can be installed on a custom theme.

You could also do it your self,

Manual Installation of Mods (http://docs.simplemachines.org/index.php?topic=402)

test

Hey all!!  Sorry, I didn't check my posts here for a long time, should have PM'ed me ;)  I've been busy coding and writing and such.

Anyways, everyone is welcome to use this of course, otherwise I would have kept it to myself ;)

Does anyone "want" to code this trick to SMF 2.0?

Supports 2.0 RC1-1 isn't it?
http://custom.simplemachines.org/mods/index.php?mod=1958

Oh, I didn't saw it turn into a mod... Thanks, Bulakbol!

I made some corrections and managed to make this mod suitable for SMF 2.0 GOLD
But for some reason I am not allowed to attach the file here (Maybe I have to create a new topic...)

OK... that is my mistake...
I am sorry disturbing that topic.
There is an other topic with the same title here (http://www.simplemachines.org/community/index.php?topic=323140) for a mod that achieves the same thing.
That mod was the basis where I made corrections.
The file I created for SMF 2.0 GOLD is attached on this message (http://www.simplemachines.org/community/index.php?topic=323140.msg3136240#msg3136240)