News:

SMF 2.1.4 has been released! Take it for a spin! Read more.

Main Menu

AJAX Instant Quick Reply

Started by SlammedDime, May 29, 2008, 06:59:11 PM

Previous topic - Next topic

_Anthony_


Filipina

awesome MOD SlammedDime. Installed on my default theme with 25 MODS no problems :)

I just wondered one thing. I used quick reply and the post appeared instantly. Then I did a regular reply in the same thread and it said that warning someone else posted before me. Well that someone was me :)

I am not the brightest bulb on the tree so maybe it means nothing just thought I would mention it.  I saw a "warning" post a few pages back but it appearded to mention something else. Thanks again


SlammedDime

I've put in the javascript to update the 'numreplies' form field, and it should work.  I'd need to see a link with a test account to take a look at it to see whats going on.  Have you done a hard refresh (ctrl - f5) on your site to refresh the javascript so your browser doesn't used an old cache'd version?

btw: great to hear it worked on a site with so many mods.  :)
SlammedDime
Former Lead Customizer
BitBucket Projects
GeekStorage.com Hosting
                      My Mods
SimpleSEF
Ajax Quick Reply
Sitemap
more...
                     

Harvest

#83
I have a problem :/
I installed this great mod, with Opera it works like a charm. But while using Firefox after posting a reply the page must be manually refreshed. The bug tracker in FF outputs:

XMLDoc.getElementsByTagName is not a function
[Break on this error] var post = XMLDoc.getElementsByTagName('post')[0];

Edit
Ok, after applying the Pretty URLs patch, the page refreshes, but looks like without the mod still :/ The whole page refreshes. I've checked the apache logs, and according to them with Opera after adding a reply there is only one POST and one GET action, while just seconds later but with Mozilla, after replying i get requests for all the whole page.  Any ideas? Same thing with IE 7

Eliana Tamerin

Did you do a Hard refresh (Ctrl+F5)?
Do NOT PM me for support.

SimplePortal 2.3.6 is OUT!
SimplePortal Project Manager
Download | Docs
SimplePortal: Power of Simplicity!

Harvest

Sure, deleted cache in FF  nothing seems to help :/

L.G.S

I tried the fix in the first post but the function wasn't even in the JS file.

For some reason now, the new posts on.gif icon on the forum index won't turn off after you've gone in the forum and viewed the posts. It's kinda annoying.
FREE and LIVE World Cup + Premier League football streams:

www.gamesandgoals.com


isara

SlammedDime - Thank you for this great mod. It's a great addition to SMF.

It seems to be functioning just fine. There's only one (possible) bug I wanted to bring up. After making a Quick Reply the "Quick Edit" button in the new post is gone. This could be because I placed the code in the wrong place in the Display.template.php . I'll check it out and edit this post if so.

Thanks again for the great mod. ;D

SlammedDime

#88
The quick edit button is in fact there, its style is just set to 'display:none'.  Unfortunately its due to the way the javascript is setup in SMF.  I'll make a change in the next release to fix this.

L.G.S. - The fix in the first post of the topic should take care of the issue your experiencing.  If the function isn't in the JS file, then the mod did not install properly and you should go through manually and ensure that every change was made correctly.

Harvest - I'd need a link and a test account to look at it and see what's going on.  The error your experiencing normally means that the javascript function isn't returning the proper xml formatted document.  Using firebug, can you take a look at what is being returned from the xml request?
SlammedDime
Former Lead Customizer
BitBucket Projects
GeekStorage.com Hosting
                      My Mods
SimpleSEF
Ajax Quick Reply
Sitemap
more...
                     

_Anthony_

They should install this mod here :)

SlammedDime

#90
Not a bad idea.  It would reduce server load (i think).

Edit: It would actually reduce server load quite a bit.   Rather than two loads of the SMF script, one to post, and one to display the updated topic (which has to reload every post on the page, plus the new one), it only calls the SMF script once, and only has to load up one new post.  It would thus reduce database queries drastically, more than two fold.
SlammedDime
Former Lead Customizer
BitBucket Projects
GeekStorage.com Hosting
                      My Mods
SimpleSEF
Ajax Quick Reply
Sitemap
more...
                     

Harvest

#91
Whoops, sorry problem solved :/ Stupid me, had a typo in template_ajax_reply() :/ sorry for bothering U. That's a great mod, thx a lot ;) 

Removed.

SlammedDime

#92
The mod package is correct, please do not change it, and I'd ask that you please remove that from your post as to not create confusion.  Thanks :)
Although I will add a comment to the install file and in the code as to how to manually install it.
SlammedDime
Former Lead Customizer
BitBucket Projects
GeekStorage.com Hosting
                      My Mods
SimpleSEF
Ajax Quick Reply
Sitemap
more...
                     

Nathaniel

#93
For SMF 2 Beta 3.1

I just noticed a bug with the mod which you may wish to fix, when you post a quick reply and then leave the thread which you posted the reply in, the quick reply post is marked as unread. This seems like something which you may wish to fix.

Edit: This may be a bug with SMF 2 Beta itself, it appears that the image for new posts for that board in the forum index is showing that there are new posts, but when I click on it to see the new posts, I cannot see any.  This is very odd!  :o
SMF Friend (Former Support Specialist) | SimplePortal Developer
My SMF Mods | SimplePortal

"Quis custodiet ipsos custodes?" - Who will Guard the Guards?

Please don't send me ANY support related PMs. I will just delete them.

Eliana Tamerin

This is the fix:

Quote from: SlammedDime on May 30, 2008, 07:19:10 PM
Bah... fix for 1.1.5 or B3.1:
Open xml_topic.js
Code (Find) Select
function ajax_reply()
{
var i, x = new Array();
x[x.length] = 'topic=' + parseInt(document.forms.postmodify.elements['topic'].value);
x[x.length] = 'subject=' + escape(textToEntities(document.forms.postmodify['subject'].value.replace(/&#/g, "&#"))).replace(/\+/g, "%2B");


Code (Replace) Select
function ajax_reply()
{
var i, x = new Array();
x[x.length] = 'topic=' + parseInt(document.forms.postmodify.elements['topic'].value);
x[x.length] = 'goback=' + parseInt(document.forms.postmodify.elements['goback'].value);
x[x.length] = 'subject=' + escape(textToEntities(document.forms.postmodify['subject'].value.replace(/&#/g, "&#"))).replace(/\+/g, "%2B");


Sorry.
Do NOT PM me for support.

SimplePortal 2.3.6 is OUT!
SimplePortal Project Manager
Download | Docs
SimplePortal: Power of Simplicity!

уιℓмαz

Quote from: Harvest on May 31, 2008, 05:31:51 PM
Ok, after applying the Pretty URLs patch, the page refreshes, but looks like without the mod still :/ The whole page refreshes. I've checked the apache logs, and according to them with Opera after adding a reply there is only one POST and one GET action, while just seconds later but with Mozilla, after replying i get requests for all the whole page.  Any ideas? Same thing with IE 7

I have this problem too,

and there is an error in error logs:

http://www.tamforum.gen.tr/index.php?pretty;board=admin-duyurulari;topic=(forum-kurallari).0
8: Undefined index: require_verification
File: /var/www/vhosts/tamforum.gen.tr/httpdocs/Themes/tamforum/Display.template.php (main sub template - eval?)
Line: 810


line 810:
if($context['can_reply_approved'] && !$context['require_verification'] && ($context['page_info']['current_page'] == $context['page_info']['num_pages'] || isset($_REQUEST['all'])))

SlammedDime

Quote from: уιℓмαz on June 01, 2008, 11:51:37 AM
Quote from: Harvest on May 31, 2008, 05:31:51 PM
Ok, after applying the Pretty URLs patch, the page refreshes, but looks like without the mod still :/ The whole page refreshes. I've checked the apache logs, and according to them with Opera after adding a reply there is only one POST and one GET action, while just seconds later but with Mozilla, after replying i get requests for all the whole page.  Any ideas? Same thing with IE 7

I have this problem too,

and there is an error in error logs:

http://www.tamforum.gen.tr/index.php?pretty;board=admin-duyurulari;topic=(forum-kurallari).0
8: Undefined index: require_verification
File: /var/www/vhosts/tamforum.gen.tr/httpdocs/Themes/tamforum/Display.template.php (main sub template - eval?)
Line: 810


line 810:
if($context['can_reply_approved'] && !$context['require_verification'] && ($context['page_info']['current_page'] == $context['page_info']['num_pages'] || isset($_REQUEST['all'])))
Did you manually install the mod?  In any case, make sure that in /Sources/Display.php that all of the changes from the install file were made.
SlammedDime
Former Lead Customizer
BitBucket Projects
GeekStorage.com Hosting
                      My Mods
SimpleSEF
Ajax Quick Reply
Sitemap
more...
                     

уιℓмαz

Hmm yes i fixed it :)

and

Quote from: Harvest on May 31, 2008, 05:31:51 PM
Ok, after applying the Pretty URLs patch, the page refreshes, but looks like without the mod still :/ The whole page refreshes. I've checked the apache logs, and according to them with Opera after adding a reply there is only one POST and one GET action, while just seconds later but with Mozilla, after replying i get requests for all the whole page.  Any ideas? Same thing with IE 7

what do you think about this? any fix?

dannbass

#98
I have trouble making it work in my custom template, can I send you the file instead of posting it here? In the default works perfect, but my theme is quite custom.

Great modification! Looking forward to use it! Thanks!


Now is working thanks to the big help of SlammedDime!

SlammedDime

SlammedDime
Former Lead Customizer
BitBucket Projects
GeekStorage.com Hosting
                      My Mods
SimpleSEF
Ajax Quick Reply
Sitemap
more...
                     

Advertisement: