Does a real skin exists ?

Started by Roman2K, June 21, 2005, 12:33:28 PM

Previous topic - Next topic

Roman2K

Hi everybody.
I really don't understand why the persons who create skins continue to give the style with :

Quote
<div style="border: solid 3px red" etc...>My Life</div>

It is XHTML/CSS valid but this is not good at all ! When we want to modify a thing, we must open the template file and spend minutes to try to find the stuff we want to change.

Why not writing :

Quote
<div id="mydiv">My Life</div>

And in the style.css :

Quote
#mydiv
{
  border: solid 3px red;
}

Like this, it is not boring, so easier to read and simple to modify the style as we want !

What do you think ? Will you do like this now ? (it is not aggressive at all, and not an order of course)

Aaron

Well, in my opinion things as they are now are fine.

As I imagine, it's much easier for a design developer to write direct style-parameters into the code than maintaining a stylesheet and remembering which classes refer to which sections... So I guess that's logical.

Regards,
Aaron.

forsakenlad

What the hell? Most of the div styles are already defined in the CSS, Are you sure you are talking about SMF here?
Eren "forsakenlad" Yaşarkurt
SMF Friend & Former Team Member

morph

It would be ok to do that if you have many things repeating over and over again so all you have to do is add the class. But in somecases its easier to edit directly in the file. Its all the designers preferance. So don't be biased and say that there are no 'real' skins. We have great designers here. If you want to "clean it up" by adding classes go right ahead. But no need to critisize other people.

Coming soon!

codenaught

Almost all of it does use CSS.

Only a few small things are hardcoded in. 
Dev Consultant
Former SMF Doc Coordinator

A.M.A

Sometime you have to balance the repetition and size/load .. i.e. if you use <div style="border: solid 3px red" etc...>My Life</div> in only one place there is no need to make it a class and fetched every time a page loads without needing it.
Really sorry .. real life is demanding my full attention .. will be back soon hopefully :)

bloc

Quote from: Roman2K on June 21, 2005, 12:33:28 PM
Hi everybody.
I really don't understand why the persons who create skins continue to give the style with :

Quote
<div style="border: solid 3px red" etc...>My Life</div>

It is XHTML/CSS valid but this is not good at all ! When we want to modify a thing, we must open the template file and spend minutes to try to find the stuff we want to change.

Why not writing :

Quote
<div id="mydiv">My Life</div>

And in the style.css :

Quote
#mydiv
{
  border: solid 3px red;
}

Like this, it is not boring, so easier to read and simple to modify the style as we want !

What do you think ? Will you do like this now ? (it is not aggressive at all, and not an order of course)

Why do you need to adjust a theme in all possible aspects? If I needed to change a theme that much in detail, I would probably be better off writing my own from scratch.

When there is good chance the user wants to change a style, classes are used. Else, its what works best.

Roman2K

Ok I understand now. Thank you for the answers :D.

Advertisement: