Installs fine, fail on uninstall, no changes?

[PoLlama]

SMF Version: SMF 1.1.3
What could be going on if a package installs fine, but on the uninstall one of the files fail. Guaranteed no changes happened inbetween uninstalled and installed.

[greyknight17]

Something changed....either by you or perhaps something related to the server (a hiccup maybe?).

[PoLlama]

Can hiccups happen literally 30 times, for every install/uninstall?

I am certain the file had not changed in that time. And I double checked 29 times in my testing.

[metallica48423]

which mod are we talking?

Are the permissions on the files being edited such that SMF can write to it?  in most server setups, smf/php is NOT the same user you login to with SSH or FTP.  they get  caught in the read only sector of the permissions.

[PoLlama]

Yes. The mod worked, so it did install correctly.

Well, I did a rewrite on that part of the mod and it fixed it, but as this may be a problem with SMF i'll post the old code here.

Its kinda long.

Code Select Expand


<file name="$themedir/MessageIndex.template.php">

///////////////////
// TOPIC SUBJECT //
//////////////////

<operation>
<search position="after"><![CDATA[
<td class="catbg3"><a href="', $scripturl, '?board=', $context['current_board'], '.', $context['start'], ';sort=subject', $context['sort_by'] == 'subject' && $context['sort_direction'] == 'up' ? ';desc' : '', '">', $txt[70], $context['sort_by'] == 'subject' ? ' <img src="' . $settings['images_url'] . '/sort_' . $context['sort_direction'] . '.gif" alt="" />' : '', '</a></td>
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
if ($context['show_title'])
{
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation><operation>
<search position="before"><![CDATA[
<td class="catbg3"><a href="', $scripturl, '?board=', $context['current_board'], '.', $context['start'], ';sort=subject', $context['sort_by'] == 'subject' && $context['sort_direction'] == 'up' ? ';desc' : '', '">', $txt[70], $context['sort_by'] == 'subject' ? ' <img src="' . $settings['images_url'] . '/sort_' . $context['sort_direction'] . '.gif" alt="" />' : '', '</a></td>
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
}
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation>
<operation>
<search position="after"><![CDATA[
<td class="windowbg' , !empty($settings['seperate_sticky_lock']) && $topic['is_sticky'] ? '3' : '' , '" valign="middle" ', (!empty($topic['quick_mod']['remove']) ? 'id="topic_' . $topic['first_post']['id'] . '" onmouseout="mouse_on_div = 0;" onmouseover="mouse_on_div = 1;" ondblclick="modify_topic(\'' . $topic['id'] . '\', \'' . $topic['first_post']['id'] . '\', \'' . $context['session_id'] . '\');"' : ''), '>';
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
if ($context['show_title'])
{
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation><operation>
<search position="before"><![CDATA[
<small id="pages' . $topic['first_post']['id'] . '">', $topic['pages'], '</small>
</td>
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
}
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation>

///////////////////
// TOPIC STARTER //
//////////////////

<operation>
<search position="after"><![CDATA[
<td class="catbg3" width="11%"><a href="', $scripturl, '?board=', $context['current_board'], '.', $context['start'], ';sort=starter', $context['sort_by'] == 'starter' && $context['sort_direction'] == 'up' ? ';desc' : '', '">', $txt[109], $context['sort_by'] == 'starter' ? ' <img src="' . $settings['images_url'] . '/sort_' . $context['sort_direction'] . '.gif" alt="" />' : '', '</a></td>
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
if ($context['show_name'])
{
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation><operation>
<search position="before"><![CDATA[
<td class="catbg3" width="11%"><a href="', $scripturl, '?board=', $context['current_board'], '.', $context['start'], ';sort=starter', $context['sort_by'] == 'starter' && $context['sort_direction'] == 'up' ? ';desc' : '', '">', $txt[109], $context['sort_by'] == 'starter' ? ' <img src="' . $settings['images_url'] . '/sort_' . $context['sort_direction'] . '.gif" alt="" />' : '', '</a></td>
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
}
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation>
<operation>
<search position="after"><![CDATA[
<td class="windowbg2" valign="middle" width="14%">
', $topic['first_post']['member']['link'], '
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
if ($context['show_name'])
{
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation><operation>
<search position="before"><![CDATA[
', $topic['first_post']['member']['link'], '
</td>
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
}
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation>

///////////////////
// TOPIC VIEWS  //
//////////////////

<operation>
<search position="after"><![CDATA[
<td class="catbg3" width="4%" align="center"><a href="', $scripturl, '?board=', $context['current_board'], '.', $context['start'], ';sort=replies', $context['sort_by'] == 'replies' && $context['sort_direction'] == 'up' ? ';desc' : '', '">', $txt[110], $context['sort_by'] == 'replies' ? ' <img src="' . $settings['images_url'] . '/sort_' . $context['sort_direction'] . '.gif" alt="" />' : '', '</a></td>
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
if ($context['show_views'])
{
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation><operation>
<search position="before"><![CDATA[
<td class="catbg3" width="4%" align="center"><a href="', $scripturl, '?board=', $context['current_board'], '.', $context['start'], ';sort=replies', $context['sort_by'] == 'replies' && $context['sort_direction'] == 'up' ? ';desc' : '', '">', $txt[110], $context['sort_by'] == 'replies' ? ' <img src="' . $settings['images_url'] . '/sort_' . $context['sort_direction'] . '.gif" alt="" />' : '', '</a></td>
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
}
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation>
<operation>
<search position="after"><![CDATA[
<td class="windowbg' , $topic['is_sticky'] ? '3' : '' , '" valign="middle" width="4%" align="center">
', $topic['replies'], '
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
if ($context['show_views'])
{
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation><operation>
<search position="before"><![CDATA[
', $topic['replies'], '
</td>
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
}
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation>

///////////////////
// TOPIC REPLIES //
//////////////////

<operation>
<search position="after"><![CDATA[
<td class="catbg3" width="4%" align="center"><a href="', $scripturl, '?board=', $context['current_board'], '.', $context['start'], ';sort=views', $context['sort_by'] == 'views' && $context['sort_direction'] == 'up' ? ';desc' : '', '">', $txt[301], $context['sort_by'] == 'views' ? ' <img src="' . $settings['images_url'] . '/sort_' . $context['sort_direction'] . '.gif" alt="" />' : '', '</a></td>
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
if ($context['show_replies'])
{
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation><operation>
<search position="before"><![CDATA[
<td class="catbg3" width="4%" align="center"><a href="', $scripturl, '?board=', $context['current_board'], '.', $context['start'], ';sort=views', $context['sort_by'] == 'views' && $context['sort_direction'] == 'up' ? ';desc' : '', '">', $txt[301], $context['sort_by'] == 'views' ? ' <img src="' . $settings['images_url'] . '/sort_' . $context['sort_direction'] . '.gif" alt="" />' : '', '</a></td>
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
}
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation>
<operation>
<search position="after"><![CDATA[
<td class="windowbg' , $topic['is_sticky'] ? '3' : '' , '" valign="middle" width="4%" align="center">
', $topic['views'], '
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
if ($context['show_replies'])
{
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation><operation>
<search position="before"><![CDATA[
', $topic['views'], '
</td>
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
}
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation>


///////////////////
// TOPIC LAST    //
//////////////////

<operation>
<search position="after"><![CDATA[
<td class="catbg3" width="22%"><a href="', $scripturl, '?board=', $context['current_board'], '.', $context['start'], ';sort=last_post', $context['sort_by'] == 'last_post' && $context['sort_direction'] == 'up' ? ';desc' : '', '">', $txt[111], $context['sort_by'] == 'last_post' ? ' <img src="' . $settings['images_url'] . '/sort_' . $context['sort_direction'] . '.gif" alt="" />' : '', '</a></td>';
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
if ($context['show_last'])
{
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation><operation>
<search position="before"><![CDATA[
<td class="catbg3" width="22%"><a href="', $scripturl, '?board=', $context['current_board'], '.', $context['start'], ';sort=last_post', $context['sort_by'] == 'last_post' && $context['sort_direction'] == 'up' ? ';desc' : '', '">', $txt[111], $context['sort_by'] == 'last_post' ? ' <img src="' . $settings['images_url'] . '/sort_' . $context['sort_direction'] . '.gif" alt="" />' : '', '</a></td>';
]]></search>
<add><![CDATA[
// Custom Boards Mod START
}
// Custom Boards Mod END
]]></add>
</operation>
<operation>
<search position="after"><![CDATA[
<td class="windowbg2" valign="middle" width="22%">
<a href="', $topic['last_post']['href'], '"><img src="', $settings['images_url'], '/icons/last_post.gif" alt="', $txt[111], '" title="', $txt[111], '" style="float: right;" /></a>
]]></search>
<add><![CDATA[
<!-- Custom Boards Mod START -->
';
if ($context['show_last'])
{
echo '
<!-- Custom Boards Mod END -->
]]></add>
</operation><operation>
<search position="before"><![CDATA[
', $txt[525], ' ', $topic['last_post']['member']['link'], '
</span>
</td>';
]]></search>
<add><![CDATA[
// Custom Boards Mod START
}
// Custom Boards Mod END
]]></add>
</operation>

</file>

[metallica48423]

but was it the uninstaller you modified (it appears it is)?

which mod was it (so we can verify the uninstaller works or does not work)

[PoLlama]

A mod I was working on, it works now. No I didn't touch the uninstaller.

http://www.simplemachines.org/community/index.php?topic=181152.0