[3085][RC1 bug] The link in the ACP - Support info - more detailed

Started by feline, February 07, 2009, 04:01:34 PM

Previous topic - Next topic

feline

The link points not to the correct position ..

Points to: ?action=admin;area=maintain;sa=version

Must points to: action=admin;area=maintain;sa=routine;activity=version

Fel

metallica48423

I haven't been able to reproduce, using the SVN version from this morning.

action=admin;area=maintain;sa=routine;activity=version is the link it goes to for me.

Does whatever theme you're using, if not default, have it's own Admin.template.php?
Justin O'Leary
Ex-Project Manager
Ex-Lead Support Specialist

QuoteMicrosoft wants us to "Imagine life without walls"...
I say, "If there are no walls, who needs Windows?"


Useful Links:
Online Manual!
How to Help us Help you
Search
Settings Repair Tool

aldo

I am running SMF 2.0 RC1 and my URL in the ACP is this:
action=admin;area=maintain;sa=routine;activity=version

You might just be having a bit of an issue. Try refreshing or something. For some reason when I upgraded the ;u=ID_MEMBER wasn't kept in the URL of the Profile, but now it is...

feline

Quote from: metallica48423 on February 07, 2009, 04:14:57 PM
action=admin;area=maintain;sa=routine;activity=version is the link it goes to for me.
Does whatever theme you're using, if not default, have it's own Admin.template.php?

I dont known what you have on SVN .. I have follow  code in the Admin.template.php from the RC1 public default templates:
// Show the user version information from their server.
echo '
<td valign="top" style="width: 40%;">
<table width="100%" cellpadding="5" cellspacing="1" border="0" class="bordercolor" id="supportVersionsTable">
<tr>
<td class="catbg"><a href="', $scripturl, '?action=admin;area=credits">', $txt['support_title'], '</a></td>
</tr><tr>
<td class="windowbg2" valign="top" style="height: 18ex;">
<b>', $txt['support_versions'], ':</b><br />
', $txt['support_versions_forum'], ':
<i id="yourVersion" style="white-space: nowrap;">', $context['forum_version'], '</i><br />
', $txt['support_versions_current'], ':
<i id="smfVersion" style="white-space: nowrap;">??</i><br />
', $context['can_admin'] ? '<a href="' . $scripturl . '?action=admin;area=maintain;sa=version">' . $txt['version_check_more'] . '</a>' : '', '<br />';


Fel

karlbenson

Indeed Feline is correct.  This is caused by the new sections/tabs in forum maintenance.  The link needs altering to reflect this.

Affects RC1 and SVN version.

http://dev.simplemachines.org/mantis/view.php?id=3085
I've attached a diff to correct it to.

Thx Feline.

metallica48423

I don't get it... i'm using an SVN from yesterday and the link is right -- unless perhaps i'm using the wrong link?  Hey it's possible lol
Justin O'Leary
Ex-Project Manager
Ex-Lead Support Specialist

QuoteMicrosoft wants us to "Imagine life without walls"...
I say, "If there are no walls, who needs Windows?"


Useful Links:
Online Manual!
How to Help us Help you
Search
Settings Repair Tool

karlbenson

There are two occurances in that file metallica, one was correct, the other was not.

Anyway, the good news is that this has already been fixed in the svn by Grudge. So will defo be included for RC2.
*marked the topic with a tick ;)

metallica48423

ahh, so i was clicking the wrong link.

Apologies for the confusion :D
Justin O'Leary
Ex-Project Manager
Ex-Lead Support Specialist

QuoteMicrosoft wants us to "Imagine life without walls"...
I say, "If there are no walls, who needs Windows?"


Useful Links:
Online Manual!
How to Help us Help you
Search
Settings Repair Tool

karlbenson

Don't worry Metallica, I had to take two glances at the file to spot it. ;)

feline


Advertisement: