Quick Modify Freezing

[Selmo]

Well, when I make a person a member of the "moderator" group, then THAT person can quick edit their posts..  but regular users still can't. 


David

Same here. If I allow Moderate board the members, they can use qe, but  replying to locked topics, changing the poll expire time and viewing poll also works.

[dlomneck]

Yeah, can only hope that somebody is working on it.

David

[IchBin™]

You guys have a place and test account I can try this on? I can't reproduce this at all. On my local test sites its working just fine.

[Selmo]

The main forum is unaccesable in non hungarian, but the test forum not. I simulated the same: install 1.1.2 & upgraded 1.1.3. hxxp:selmo.atw.hu/forum [nonactive] test user: teszt pass: hallelujja. But you can register new member to. Oh this is a free host, slooooooow.

[IchBin™]

I bet its one of two things. The ads that are inserted at the top are causing a conflict in the code, or your host has some weird setting causing this. I noticed your URL doesn't change as you browse the forum, and TBH I don't know how SMF handles that stuff.

[greggman]

I have the same problem on 3 different installations, all 1.1.3 forums.

Mods can quickedit, normal users can't. It happens in both IE7 and Firefox 2.0.0.4

You can try here

http://greggman.com/forum/index.php?topic=653.msg3725#new [nofollow]

Register as a new user. Post a reply to that thread. After you've replied go back to the thread and click the quickedit button on the far right of your reply. A green bar "Loading..." should appear and just stay there forever.

I have no mods installed.

[SlammedDime]

I have the same problem on 3 different installations, all 1.1.3 forums.

Mods can quickedit, normal users can't. It happens in both IE7 and Firefox 2.0.0.4

You can try here

http://greggman.com/forum/index.php?topic=653.msg3725#new

Register as a new user. Post a reply to that thread. After you've replied go back to the thread and click the quickedit button on the far right of your reply. A green bar "Loading..." should appear and just stay there forever.

I have no mods installed.

Can you provide a test account for us?

[greggman]

I'm not sure why you couldn't just register but whatever.

name: testaccount
password: password

Post a reply to this thread.

http://greggman.com/forum/index.php?topic=653.msg3725#new [nofollow]

After you've replied go back to the thread and click the quickedit button on the far right of your reply. A green bar "Loading..." should appear and just stay there forever.

[SlammedDime]

What error(s) do you have in your log from the past 5 minutes?

[Rudolf]

I bet its one of two things. The ads that are inserted at the top are causing a conflict in the code, or your host has some weird setting causing this. I noticed your URL doesn't change as you browse the forum, and TBH I don't know how SMF handles that stuff.

The host forces the forum to be in a frame. However he has the same database error as the others. For some reason.

[Rudolf]

It happens only when there are moderators set for that board, because there's an extra ) in the query.

Edit: I'll add the fix later, there's some issues with it

[SlammedDime]

Here's what I think...

SMF 1.1.3 changed this specific mysql query, and I think that change caused another bug...

Original bug... "Quick edit didn't check whether a topic was being locked"

I'm just not sure how to fix it other than changing the query back to what it was in 1.1.2... in which case, edit Post.php, around line 2029..

Code (fix) Select Expand

AND (t.locked = 0' . (empty($moderate_boards) ? '' : ' OR b.ID_BOARD IN (' . implode(', ', $moderate_boards) . ')') . ')') . "


Edit: Rudolf beat me to it, however I think thats the wrong fix.  I *think* a closing ) is simply in the wrong spot... need to test tho...  Also, it happens with or without moderators set for the board...

[Rudolf]

Yeah that's the good one.

Code (Search) Select Expand

AND (t.locked = 0' . (empty($moderate_boards) ? '' : ' OR b.ID_BOARD IN (' . implode(', ', $moderate_boards)) . ')' . ')') . "

Code (Replace) Select Expand

AND (t.locked = 0' . (empty($moderate_boards) ? '' : ' OR b.ID_BOARD IN (' . implode(', ', $moderate_boards)  . ')') . ')') . "

I reported it in the bug tracker.

[Selmo]

Yeah! This solve the problem. THX!

[greggman]

thanks! that fixed it!

[L'AltroWeb]

Thanks!
I have the same problem with smf 1.1.6 (error with IE, works fine with firefox)
Now i've fix

Yeah that's the good one.

Code (Search) Select Expand

AND (t.locked = 0' . (empty($moderate_boards) ? '' : ' OR b.ID_BOARD IN (' . implode(', ', $moderate_boards)) . ')' . ')') . "

Code (Replace) Select Expand

AND (t.locked = 0' . (empty($moderate_boards) ? '' : ' OR b.ID_BOARD IN (' . implode(', ', $moderate_boards)  . ')') . ')') . "

I reported it in the bug tracker.

[SlammedDime]

You shouldn't have had to fix that, as it was done over a year ago in the 1.1.x line.  If it worked in one browser and not another, it was not an SMF coding issue.

[L'AltroWeb]

You shouldn't have had to fix that, as it was done over a year ago in the 1.1.x line.  If it worked in one browser and not another, it was not an SMF coding issue.

But with this fix work also in IE 
My problem: http://www.simplemachines.org/community/index.php?topic=140546.msg1152449#msg1152449
Maybe is a re-bug of 1.1.6???
-
Edit: i've download 1.1.6 pack and fix is already used, maybe in official update-smf-patch (started from 1.1.3) this line isn't updated!

[SlammedDime]

Then it's possible that you're site hasn't been fully upgraded like it should be.  You may want to look at uploading clean files to your site and installing your mods again.

Looking at the 1.1.6 download package, the correct line is in place, so it's not a re-bug...

[L'AltroWeb]

yes and also in 1.1.5 is ok!
Maybe is from really old (1.1.4 or 1.1.3) release and never been upgraded
Thanks for your support!
-
PS: see also my last edit from previous post please