Updating mod to 2.0 help

[KiLLuMiNaTi-7-]

Ok ive already updated the mod to 2.0 but its the first time ive done so and i've been away from SMF for awhile now. So i just wanted someone to take a quick look through it to make sure its all done correctly. (Mainly the Managesettings part). Then i should be able to do the rest of my mods with ease

Cheers.

Solved. File removed.

[sangwe11]

Had a very quick look at just the modsettings bit, and I couldn't see anything majorly wrong.

It was a quick look though, so don't hold me to its all perfect.

[KiLLuMiNaTi-7-]

Had a very quick look at just the modsettings bit, and I couldn't see anything majorly wrong.

It was a quick look though, so don't hold me to its all perfect.

OK. Thanks for looking though

[butchs]

Ok, I will try to get picky.   

I never tried it with out install directives.  IE:

   <!--// Install  //-->
   <install for="2.0 - 2.99.99">
      <readme type="file" parsebbc="true">readme.txt</readme>
      <modification type="file">.xml</modification>
   </install>
   <!--// Uninstall  //-->
   <uninstall for="2.0 - 2.99.99">
      <modification type="file" reverse="true">.xml</modification>
   </uninstall>
   <!--// Upgrade //-->
   <upgrade>
      <readme type="inline">Sorry, but there is no upgrade package from your version. Please uninstall the previous version, and install this version. You won't lose any data.</readme>
   </upgrade>

If it does not load try the above.

In the mod I noticed you used "search position="end"", I usually try to avoid this because it may be difficult to uninstall if another mod did the same thing.

Other than the above minor things it looks good.

[Arantor]

We specifically encourage position="end" for just the opposite reason. It doesn't detect looking for the end of the file, btw, simply the code block it added.

I don't see a for in the <install>, which it should have. <install for="2.0 RC2"> and <uninstall for="2.0 RC2"> for example. Note you can have multiple different install files and multiple versions in the same package; many of my mods have 1.1.10, 2.0 RC1.2 and 2.0 RC2 installations, all with different code, in the same package.

Otherwise looks fine to me.

[KiLLuMiNaTi-7-]

A multiple install sounds better, i'll do that.

Thanks