Very small bug after updating forum name...

[o.o]

This is a very small bug, and i know i sound very picky reporting, but i thought i might as well do it to help you guys out

Well when you edit someone's post, and you get:


« Last Edit: January 1, 2011, 12:00:00 AM by Bob »

at the bottom.

Well if Bob were to change his name to say, Billy, the little editing line doesn't update, when in theory it should. It stays at last edit by bob. See? Just a small bug

[Illori]

does anyone consider this a bug worth tracking?

[Joker™]

The display of the user who modifies the post is stored in the "modified_name" column of "prefix_members" table.

I'm not sure whether it'd be a very optimized way if all the entries related to the member in that column are updated when a member changes his/her display name.

To me it sounds more like a feature than a bug. Sometimes it becomes very hard to distinguish b/w bug and feature .

[emanuele]

The same is true for quotes and /me at least, probably more.

[Joker™]

The same is true for quotes and /me at least, probably more.

So do you see this as bug or feature or none?

[emanuele]

* emanuele is blind.

[Antechinus]

It's been that way since the stone age but does anyone really care? There are quite a few places we'd have to screw around with it, if I'm not mistaken.

[Matthew K.]

I don't think it should be a big deal, but why not eventually put it on the list to optimize how the name is pulled? Rather than storing a name in a separate table (outside of prefix_members) use a type of JOIN to reference the members ID, which is definitely more accurate.

[Joker™]

Using member id can create further issues as what will happen when a member is deleted. In that case there won't be any concerned ID available in members table.

[Joker™]

Forgot to quote labs message. I was basically replying to his thoughts on this topic.

TBH considering the amount of work required is not worth the output in this case, just my opinion .

[Matthew K.]

Oh come on, it wouldn't be very much work, at all. And if the is doesn't exist, you tell it how to react, it's called error handling.

[Joker™]

Oh come on, it wouldn't be very much work, at all. And if the is doesn't exist, you tell it how to react, it's called error handling.

So if the member is deleted, the concerned column values are going to be set to lets say "".

Even with the error handling you are left with 2 options:

1.
« Last Edit: January 1, 2011, 12:00:00 AM by »

- As there is no member name left to display

2. Or show no message at all, which is worst than showing an old display name ( just an opinion)

[Matthew K.]

Or you can say "Previous Member" - "Deleted Member" or as SMF does "Guest" if the name doesn't exist in some locations.

[Joker™]

Well to me it looks more appropriate to show a name rather than showing an unknown sort of text.