Upgrading from 2.0.19 to 2.1.2 has broken avatars and other attachements

[Illori]

I would think that the avatars should have hashed file names, otherwise you will run into conflicts at some point of a trying to use the same file name as someone else.

[Illori]

i did a test. i uploaded an avatar for my admin [account id 1], it was named avatar_1_1666300183.gif. so the name is changed but not in the same way it is changed for attachments.

[Dav999]

I just uploaded an avatar on my forum as well, it shows up in the admin panel as that expected filename:


The link to it is action=dlattach;type=avatar;attach=1480

But in the attachments/ folder, its name is 1480_0f2140af17916e0e87b98206bdfa948e0d09ce1f. Which, renaming it to .gif, is the avatar I just uploaded.

[shawnb61]

2.0 has different behavior depending on whether there is a custom avatar folder specified or not.

If not specified, custom avatars are treated exactly like attachments. 

https://simplemachines.org/community/index.php?topic=197938.0

[Illori]

but this is in the SMF 2.1 board where you have no choice but to use the custom_avatars folder.