Potential code vulnerabilities

Started by Daretary, December 15, 2023, 06:26:45 PM

Previous topic - Next topic

Daretary

I ran the SMF code through the new scanner.

And here's what I've found so far:



The Regular expression Denial of Service attack takes advantage of the fact that most regular expression implementations can reach extreme values that cause them to run very slowly (exponentially with the size of the input data).

Possible risk
An attacker could cause a program using a regular expression (Regex) to enter these extreme conditions and then hang for a very long time. The CVSS severity level of ReDoS is Medium.

https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS


Daretary

I don't think you should open the thread for public review.
If you want, I will continue. Let only moderators see.
I'll wait for the answer.

Aleksi "Lex" Kilpinen

Thank you for reporting your findings. This has been hidden from public until the devs have had a chance to evaluate this.

In the future I would ask that you use the private reporting options either here https://www.simplemachines.org/about/smf/security.php or on Github.
Slava
Ukraini!
"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Sesquipedalian

This warning is bogus. That regular expression is a very simple one. It has no branches, recursion, or any of the other ways that regular expressions can possibly hang. This scanner that you are using appears to be simultaneously dumb and paranoid.
I promise you nothing.

Sesqu... Sesqui... what?
Sesquipedalian, the best word in the English language.

Daretary


m4z

What is the name/origin of "the new scanner"?
"Faith is what you have in things that don't exist."
--Homer Simpson

Es gibt hier im Forum ein deutsches Support-Board!

Advertisement: