Quote open in new window

[Cypher7]

Hey, this isn't a feature request... but more of a though!

At present, when a quote (with author and topic details) is used in a post, the link to that quote opens in the same window. This can be annoying if the quote is from another topic, or even on another page of the same topic. What do you think of having it opening in a new window?

OK, so don't have to click the link to see the quote, but as it is a link/feature, I'm sure it's used sometimes. I just used it there and it was time consuming to go back and forth on the same page.

What do yiz think!?

(sample... link to quote will leave this page...)

We are proud to announce the release of SMF 1.0 Beta 6 to Charter Members this past weekend.  This will be the last release before the upcoming first Release Candidate.  We will not however be releasing this beta beyond our group of Charter Members.  We'd like to once again thank everyone who has helped SMF from its conception to the point it is at today and we look forward to providing you an extremely stable Final release.

[Oldiesmann]

That's actually quite easy to do...

Beta 5 Public:

In Sources/Subs.php

Find:

Code Select Expand

"'<div class=\"quoteheader\"><a href=\"" . $scripturl . "?action=display;\$2\">" . $txt['smf239'] . ": \$1 " . $txt[176] . " ' . timeformat('\$3') . '</a></div><div class=\"quote\">'",

Replace:

Code Select Expand

"'<div class=\"quoteheader\"><a href=\"" . $scripturl . "?action=display;\$2\" target=_blank>" . $txt['smf239'] . ": \$1 " . $txt[176] . " ' . timeformat('\$3') . '</a></div><div class=\"quote\">'",

Beta 6/RC1:

In Sources/Subs.php

Find:

Code Select Expand

'~\[quote author=(.{1,80}?) link=(?:board=\d+;)?(topic=[\dmsg#\./]{1,40}(?:;start=[\dmsg#\./]{1,40})?) date=(\d+)\](?:<br />)?~ei' => '\'<div class="quoteheader"><a href="' . $scripturl . '?$2">' . $txt['smf239'] . ': $1 ' . $txt[176] . ' \' . timeformat(\'$3\') . \'</a></div><div class="quote">\'',

Replace:

Code Select Expand

'~\[quote author=(.{1,80}?) link=(?:board=\d+;)?(topic=[\dmsg#\./]{1,40}(?:;start=[\dmsg#\./]{1,40})?) date=(\d+)\](?:<br />)?~ei' => '\'<div class="quoteheader"><a href="' . $scripturl . '?$2" target=_blank>' . $txt['smf239'] . ': $1 ' . $txt[176] . ' \' . timeformat(\'$3\') . \'</a></div><div class="quote">\'',[/quote][/quote]

[Cypher7]

cheers for the input Oldiesmann...  and yea, it was quite easy!

So what do you think, should that be by design in RC1? I know it's only a small thing... (which is why I didn't post in feature requests!)

[Grudge]

I actually agree with you. I think it should be a new window.

[[Unknown]]

I don't see why it should.  In most cases, you're quoting from the same post.... so a new window would not be what is expected.

It is also a lot harder to open it in the same window if it is set to open in a new window; the reverse is not true.

Generally, links "outside" open in new windows, and inside open in the same.... this is a standard, of sorts.

-[Unknown]

[Cypher7]

I don't see why it should.  In most cases, you're quoting from the same post.... so a new window would not be what is expected.

It is also a lot harder to open it in the same window if it is set to open in a new window; the reverse is not true.

Yea, point taken. I guess case would be that 90% of quotes are from the same topic, and the rest are from other topics (or from other pages in that topic).

Buuuut...! Let's look at it like this,

You're reading through a post, half way through, you see a quote which links to somewhere in that topic (or even a different topic), and you want to see the full post itself. You click, and you leave where you were reading to somewhere else on that page, or even to another page/topic.  Now that you've read it, you have to find your way back to where you were reading. (ok, the browser's back button works... but the less experience user won't think of that.)

If the quote was to open in a new window, you won't have left where you were reading. Just like when a link to another topic is posted.

That's just the way I see it... I personally expected the quote to open in a new window when I clicked first.

[[Unknown]]

And, why can't you right click and open in a new window?

-[Unknown]

[Peter Duggan]

It is also a lot harder to open it in the same window if it is set to open in a new window; the reverse is not true.

New windows have always deprived the end user of choice, but IMHO they're even more irritating when you're trying to organise things logically with tabbed browsing! So I often have several windows full of related tabs open, and all unrequested new windows do is mess up this structure and add clutter...

[Cypher7]

And, why can't you right click and open in a new window?

-[Unknown]

Well *I* can, but I'm sure there are a lot of users out there who don't even know you can do that, let alone think of it first...!

Worse case for this is if you are reading through the topic summary during your reply, and you click on a quoted topic because the post is truncated...

(ps... I just lost my reply because of "Warning - while you were reading a new reply has been posted. You may wish to review your post." ... Thanks Peter

I was typing... then I clicked on a quote in the topic summary, took me to that post, then I clicked Back, I got that message and my reply was gone!? ...just FYI!)

[Ben_S]

New windows are horrible, tell people to use a proper browser and middle click.

It's easy to get a new window if you want one, when the target is set to _blank then it's a pain to open it in the same window, short of dragging it to the address bar. Keep it as it is, if people want it in a new window, let them change it themselves.

[Oldiesmann]

I agree that it should stay like it is for now. I use Mozilla and Firefox quite a bit, so I usually just CTRL-click to open a quote in a new tab that I can close easily. If you don't have the luxury of using a browser that supports tabbed browsing, just hold down the shift key when you click on something to open it in a new window...

[Cypher7]

If you don't have the luxury of using a browser that supports tabbed browsing, just hold down the shift key when you click on something to open it in a new window...

We all know how to do things like that... but the Joe Soapers who browse in and use the forums generally don't. (sorry Joe!)

What I'm getting at is that, it's a link to another post, like a link to another topic. One opens in a new window, one doesn't. It's not like a link to a profile or your PM's, which should obviously open in the same window...    You're looking at a post, you see a quote, you click it just to view it for minute, you leave the post you were looking... you have to go back.    Shift and click is what I do... others may not be aware of that feature. Again, I'm not requesting a feature or posting a bug here... just wanted to put the thought out there...

New windows are horrible, tell people to use a proper browser and middle click.

What do you want me to do, put a sticky up and tell everyone to change to Firefox!!

I don't have the facts, nor the time to search for them, but I'd be willing to assume that the vast majority of internet users use IE as their default browser. I'm not trying to start an IE v Firefox debate here, just saying that lots of people use IE, and will always use it... so no point in saying change your browser to solve a problem...!

[Ben_S]

What do you want me to do, put a sticky up and tell everyone to change to Firefox!!

Well the change you are advocating would mean everyone would have to learn how to open a target blank window in the same window which is a lot more difficult than doing it the other way round.

[Peter Duggan]

I'm not trying to start an IE v Firefox debate here, just saying that lots of people use IE, and will always use it... so no point in saying change your browser to solve a problem...!

While I agree completely with that comment (and realise that some folk have no choice over what browser they're using), I simply can't agree that we should be all be condemned to a plethora of unnecessary new windows in case Joe Bloggs *might* want a new window and not know how to get one! So, FWIW, I'd rather turn the argument on its head and say let's have everything opening in the same window if consistency's what we're looking for.

[Cypher7]

Well the change you are advocating would mean everyone would have to learn how to open a target blank window in the same window which is a lot more difficult than doing it the other way round.

OK, it is harder to open a target blank link in the same window, but... why would you want to do it in *this* case. The main reason you'd be looking at the original post is just for reference, and once you're finished it's back to the post you were reading which you have left. That's what I mean, you have to leave where you were reading, and then go back. (Here's where the shift and click comes in, and again about how many people know it, and we're going around in circles!! but you have to think about how many users know/use it.)

If it was to open in a new window, what you were reading initially is still there in the original one, and you can then close the new window when you're done. It's not going to be left open clogging up your taskbar/tabs.

I simply can't agree that we should be all be condemned to a plethora of unnecessary new windows in case Joe Bloggs *might* want a new window and not know how to get one!

How many times would you use it, I don't think it would be an onslaught of new windows! Once you open it, read the post, you close it as it's not needed anymore... and again, doesn't clog up...

So, FWIW, I'd rather turn the argument on its head and say let's have everything opening in the same window if consistency's what we're looking for.

Now you're just throwing cat's at all the pigeons...!

Even the [url] tags... !?  You're just winding me up... aren't you... aren't you!!

[[Unknown]]

Most people, including me, get annoyed when they open a link, don't notice it happened in a new window for some reason, and then finish at the site and close it.

The old window is still there.

This is very annoying, and when you expect the link to open in the same window, ie. the same site, it should.

-[Unknown]