Stop Forum Spam

[ian]

Hi,

Firstly, thanks for creating this great mod. I would like to report a couple of bugs:

If you use the "Stop Forum Spam" option on a guest post and then click "SUBMIT TO STOP FORUM SPAM", you end up adding yourself to the SFS database! Submitting guest info probably isn't a good idea anyway (the email address hasn't been verified), so rather than try modifying the submission code, I've just disabled the option on guest posts like this:

Code Select Expand

    public static function hook_prepare_display_context(&$output, &$message, $counter): void
    {
        global $smcFunc, $scripturl, $context;

        if ($output['member']['id']) // not a guest
            $output['quickbuttons']['more']['sfs'] = [
                'label' => $smcFunc['classSFS']->txt('sfs_admin_area'),
                'href' => $scripturl . '?action=profile;area=sfs;u=' . $output['member']['id'] . ';msg=' . $output['id'],
                'icon' => 'sfs',
                'show' => $context['can_moderate_forum'],
            ];
    }

The other issue is that the "Guest Verification Sections" and "Member Verification Sections" options cannot be set to empty if they aren't already empty. This actually appears to be an SMF bug (in the saveDBSettings function) affecting all multi-select options, but thought I'd mention it here anyway since it affects this mod.

[live627]

Any documentation on this? The settings seem kinda obtuse or opaque (words are hard). What happens to a member who's registration is caught as spam?

[SleePy]

Words are hard, I'm a software engineer, not an English professor.  I would appreciate it if anyone has better words to clean up the confusion.  Grammarly helps me in posts, but I haven't bothered to add it into my coding process because it generally just gets confused.

During registration, if they are found in the Stop Forum Spam response for checks (like IP, username, email) and above confidence thresholds (for usernames), it will block the registration and present a warning to them that the information provided was found in the Stop Forum Spam database.

No documentation exists yet.  I should work on that.  If I did, I would just wiki it over on the GitHub page. https://github.com/jdarwood007/smfmod_sfs

[live627]

"Words are hard": a reference to me potentially using a wrong word in my post above.

[planetdance]

Request: A way to delete all spammers in one go! The button Check these Members only asks confirmation but then nothing happens.
Thanks.