News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

Stop Parsing Attachments in Display.php

Started by Joshua Dickerson, October 16, 2009, 06:41:20 PM

Previous topic - Next topic

Joshua Dickerson

Link to Mod

There are several bugs that have risen because SMF tries to correct line endings depending on the end-user's operating system. This is good for people that don't know what an editor is. For those of us that work with complex text documents, this causes corrupted files.

This mod removes the functionality in Display.php -> Download().

See the bug report: http://dev.simplemachines.org/mantis/view.php?id=3865
Come work with me at Promenade Group



Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

Sudhakar Arjunan

Hey i could not understand it .

If possible, help me out to learn about this mod using some detailed documents and pics.
Working on New Mods & Themes for SMF... Will update soon... My Blog page
My Smf forum : Discuss ITAcumens :: My SMF Forum

Joshua Dickerson

There's no pics. SMF tries to convert line endings depending on your operating system when a text document is downloaded from an attachment. This mod removes that and sends you the raw attachment.
Come work with me at Promenade Group



Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

aED

Does this bug only affects text document? How about zip files?

Arantor

It only applies to files with the following extensions: 'txt', 'css', 'htm', 'html', 'php', 'xml'

All other files are left alone anyway. This just removes one piece of code that gets run, so all files are treated as binary.
Holder of controversial views, all of which my own.


Advertisement: